GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Make extract_stack resilient to lacking frames. by jhance · Pull Request #563 · MagicStack/uvloop

Conversation

@jhance

@jhance jhance commented Sep 7, 2023

Copy link
Copy Markdown
Contributor

We are using uvloop in conjunction with an implementation of GRPC (not the default one) that is using C++ and Cython instead of native code. This means we try to do things with the loop while not holding a frame, which causes crashes when we enable debug mode on the loop. From reading Cython documentation this seems kinda impossible to adjust to have a frame. But it is fairly easy to just not fail hard here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jhance
Make extract_stack resilient to lacking frames.
06ad898
elprans
elprans approved these changes Oct 7, 2023
View reviewed changes
@elprans
elprans merged commit 0687643 into MagicStack:master Oct 7, 2023
fantix added a commit that referenced this pull request Oct 12, 2023
@fantix
uvloop 0.18.0
400a0c3 
Fixes
=====

* CI fixes (#520, #553)
  (by @altendky in 7783f1c, @dulmandakh in 1dd40f1)

* Make extract_stack resilient to lacking frames. (#563)
  (by @jhance in 0687643 for #563)

* Port uvloop to Python 3.12 (#570)
  (by @1st1, @fantix in 9f82bd7 for #569)
@fantix fantix mentioned this pull request Oct 12, 2023
uvloop 0.18.0 #572
Merged
fantix added a commit that referenced this pull request Oct 13, 2023
@fantix
uvloop 0.18.0
5ddf38b 
Changes
=======

* Port uvloop to Python 3.12 (#570)
  (by @1st1, @fantix in 9f82bd7 for #569)

* Upgrade libuv to v1.46.0 (#571)
  (by @fantix in 2e1978c for #571)

Fixes
=====

* CI fixes (#520, #553)
  (by @altendky in 7783f1c, @dulmandakh in 1dd40f1)

* Make extract_stack resilient to lacking frames. (#563)
  (by @jhance in 0687643 for #563)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elprans elprans elprans approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@jhance @elprans
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.