GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Upgrade libuv to v1.46.0 by fantix · Pull Request #571 · MagicStack/uvloop

Conversation

@fantix

@fantix fantix commented Oct 10, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Fix subprocess/preexec_fn on macOS (darwin: Use posix_spawn to spawn subprocesses in macOS libuv/libuv#3064 changed to use posix_spawn) (CPython discussion bpo-35537)

(CPython code snippet of subprocess.py:)

            if (_USE_POSIX_SPAWN
                    and os.path.dirname(executable)
                    and preexec_fn is None
                    and not close_fds
                    and not pass_fds
                    and cwd is None
                    and (p2cread == -1 or p2cread > 2)
                    and (c2pwrite == -1 or c2pwrite > 2)
                    and (errwrite == -1 or errwrite > 2)
                    and not start_new_session
                    and process_group == -1
                    and gid is None
                    and gids is None
                    and uid is None
                    and umask < 0):
                self._posix_spawn(args, executable, env, restore_signals,
                                  p2cread, p2cwrite,
                                  c2pread, c2pwrite,
                                  errread, errwrite)
                return

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@fantix
Upgrade libuv to v1.46.0
2684057
@fantix
fantix requested a review from 1st1 October 10, 2023 03:09
@fantix
fantix marked this pull request as draft October 10, 2023 04:18
@robd003 robd003 mentioned this pull request Oct 10, 2023
Python 3.12 Support for uvloop #567
Closed
@fantix
Fallback to fork() on macOS if preexec_fn is set
d7b9df7
@fantix
fantix force-pushed the libuv-1.46 branch from b2ec2d5 to d7b9df7 Compare October 11, 2023 23:08
@fantix
fantix marked this pull request as ready for review October 11, 2023 23:29
1st1
1st1 reviewed Oct 12, 2023
View reviewed changes
Comment thread uvloop/handles/process.pyx
# provide explicit API to choose such implementation detail.
# Based on current (libuv 1.46) behavior, setting
# UV_PROCESS_SETUID or UV_PROCESS_SETGID would reliably make
# libuv fallback to use fork, so let's just use it for now.

@1st1 1st1 Oct 12, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we should make a PR to libuv to make it reliably configurable.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

fantix reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
1st1
1st1 approved these changes Oct 12, 2023
View reviewed changes
@fantix
fantix merged commit 2e1978c into master Oct 13, 2023
@fantix
fantix deleted the libuv-1.46 branch October 13, 2023 00:39
@fantix fantix mentioned this pull request Oct 13, 2023
uvloop 0.18.0 #572
Merged
fantix added a commit that referenced this pull request Oct 13, 2023
@fantix
uvloop 0.18.0
5ddf38b
Changes
=======

* Port uvloop to Python 3.12 (#570)
  (by @1st1, @fantix in 9f82bd7 for #569)

* Upgrade libuv to v1.46.0 (#571)
  (by @fantix in 2e1978c for #571)

Fixes
=====

* CI fixes (#520, #553)
  (by @altendky in 7783f1c, @dulmandakh in 1dd40f1)

* Make extract_stack resilient to lacking frames. (#563)
  (by @jhance in 0687643 for #563)
This was referenced Oct 15, 2023
bump libuv to 1.46.0 #554
Closed
Bump libuv to 1.44.2 #499
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 1st1 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@fantix @1st1
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.