GeezerVison is showing github.com — Upgrade libuv to v1.46.0 by fantix · Pull Request #571 · MagicStack/uvloop
Conversation
fantix
commented
Oct 10, 2023
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
(CPython code snippet of subprocess.py:)
if (_USE_POSIX_SPAWN
and os.path.dirname(executable)
and preexec_fn is None
and not close_fds
and not pass_fds
and cwd is None
and (p2cread == -1 or p2cread > 2)
and (c2pwrite == -1 or c2pwrite > 2)
and (errwrite == -1 or errwrite > 2)
and not start_new_session
and process_group == -1
and gid is None
and gids is None
and uid is None
and umask < 0):
self._posix_spawn(args, executable, env, restore_signals,
p2cread, p2cwrite,
c2pread, c2pwrite,
errread, errwrite)
return
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
|
# provide explicit API to choose such implementation detail.
|
|
|
# Based on current (libuv 1.46) behavior, setting
|
|
|
# UV_PROCESS_SETUID or UV_PROCESS_SETGID would reliably make
|
|
|
# libuv fallback to use fork, so let's just use it for now.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we should make a PR to libuv to make it reliably configurable.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
fantix reacted with thumbs up emoji
This was referenced Oct 15, 2023
Reviewers
1st1
1st1 approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|