GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Port uvloop to Python 3.12 by 1st1 · Pull Request #570 · MagicStack/uvloop

Conversation

@1st1

@1st1 1st1 commented Oct 8, 2023

Copy link
Copy Markdown
Member

Fixes #569

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
robd003, yezz123, achimnol, kPsarakis, m5l14i11, graingert, jdavidagudelo, josecsotomorales, AstreaTSS, deliro, and 3 more reacted with heart emoji
All reactions
  • ❤️ 13 reactions
Yury Selivanov added 5 commits October 7, 2023 17:11
Yury Selivanov
Bump Cython to 0.29.36
ee803be
Yury Selivanov
Add missing new API -- timeout param to shutdown_default_executor
f179c5c
Yury Selivanov
Stop using the beloved, but now deprecated, 'IF'
6a37f32 
It's deprecated in 3.0.3
Yury Selivanov
Explicitly qualify void-returning callback functions as noexcept.
77767b9 
This is a pre-requisite for supporting Cython 3.0, but makes sense to
do for 0.29.* just as well.
Yury Selivanov
Fix test_libuv_get_loop_t_ptr to work under Python 3.12
52ff91a
@1st1

1st1 commented Oct 8, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

While working on this I stumbled upon what seems to be an asyncio regression in 3.12. Good news that uvloop doesn't have this regression. Bad news -- our tests that test compliance with asyncio are now failing (we should backport our functional tests to the Python project, they increase test coverage by a lot!)

python/cpython#79033 (comment)
fantix reacted with thumbs up emoji m5l14i11 and rinarakaki reacted with rocket emoji
All reactions
  • 👍 1 reaction
  • 🚀 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@1st1
1st1 requested a review from fantix October 8, 2023 02:05
Yury Selivanov added 3 commits October 7, 2023 19:17
Yury Selivanov
"Fix" the failing asyncio tests by adding a sleep() call
df9576c
Yury Selivanov
Add 3.12 to CI scripts
9a97442
Yury Selivanov
An attempt to force CI to not build a wheel for aiohttp
f23f2ff
@1st1
1st1 force-pushed the 12 branch from 60e0307 to f23f2ff Compare October 8, 2023 02:34
Yury Selivanov added 2 commits October 7, 2023 20:01
Yury Selivanov
A workaround for aiohttp lacking a native 3.12 wheel
247fb17
Yury Selivanov
Seems like setuptools now needs to be installed explicitly for 3.12
eccd451
@1st1
1st1 force-pushed the 12 branch from ebd1448 to eccd451 Compare October 8, 2023 03:02
Yury Selivanov added 3 commits October 7, 2023 20:23
Yury Selivanov
Disable debug build tests on 3.12
4cc4f91 
Seems that we need to update to Cython 3
Yury Selivanov
Stop configuring watchers for asyncio tests under 3.12+
0648d1f
Yury Selivanov
Add the new timeout parameter of shutdown_default_executor to typeshed
178df25
graingert
graingert reviewed Oct 8, 2023
View reviewed changes
Comment thread setup.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@1st1
1st1 marked this pull request as ready for review October 8, 2023 13:27
@1st1
1st1 force-pushed the 12 branch 3 times, most recently from de6fd30 to 2783939 Compare October 8, 2023 16:42
graingert
graingert suggested changes Oct 8, 2023
View reviewed changes
Comment thread README.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@1st1
1st1 force-pushed the 12 branch 5 times, most recently from 69e3e54 to e1c1e69 Compare October 9, 2023 10:48
Yury Selivanov
Implement uvloop.run()
233033b
@1st1
1st1 force-pushed the 12 branch from e1c1e69 to 233033b Compare October 9, 2023 10:59
@fantix
fantix force-pushed the 12 branch 2 times, most recently from dedf200 to c479675 Compare October 9, 2023 17:55
@fantix
Install aiohttp 3.9.0b0 on Python 3.12
b1f2edd 
This partially reverts commit 247fb17.
@fantix
fantix force-pushed the 12 branch from c479675 to b1f2edd Compare October 9, 2023 18:00
@fantix
Add pyproject.toml and update CI
b2c3e4e
fantix
fantix approved these changes Oct 9, 2023
View reviewed changes
@fantix
Merge branch 'master' into 12
e6232d4
@fantix
fantix merged commit 9f82bd7 into master Oct 10, 2023
@fantix
fantix deleted the 12 branch October 10, 2023 00:28
@AntonOfTheWoods

AntonOfTheWoods commented Oct 10, 2023

Copy link
Copy Markdown

Is there an ETA on a release?
applied-mathematician reacted with eyes emoji
All reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nsoranzo nsoranzo mentioned this pull request Oct 10, 2023
Add support for Python 3.12 galaxyproject/galaxy#16796
Merged
2 of 4 tasks
@dalf dalf mentioned this pull request Oct 12, 2023
Add support for Python 3.12 searxng/searxng#2880
Merged
fantix added a commit that referenced this pull request Oct 12, 2023
@fantix
uvloop 0.18.0
400a0c3 
Fixes
=====

* CI fixes (#520, #553)
  (by @altendky in 7783f1c, @dulmandakh in 1dd40f1)

* Make extract_stack resilient to lacking frames. (#563)
  (by @jhance in 0687643 for #563)

* Port uvloop to Python 3.12 (#570)
  (by @1st1, @fantix in 9f82bd7 for #569)
@fantix fantix mentioned this pull request Oct 12, 2023
uvloop 0.18.0 #572
Merged
fantix added a commit that referenced this pull request Oct 13, 2023
@fantix
uvloop 0.18.0
5ddf38b 
Changes
=======

* Port uvloop to Python 3.12 (#570)
  (by @1st1, @fantix in 9f82bd7 for #569)

* Upgrade libuv to v1.46.0 (#571)
  (by @fantix in 2e1978c for #571)

Fixes
=====

* CI fixes (#520, #553)
  (by @altendky in 7783f1c, @dulmandakh in 1dd40f1)

* Make extract_stack resilient to lacking frames. (#563)
  (by @jhance in 0687643 for #563)
@matusvalo matusvalo mentioned this pull request Oct 14, 2023
Mark functions as noexcept to ensure cython 3 compatibility #534
Closed
This was referenced Oct 15, 2023
CI: python 3.12-dev #555
Closed
Run tests on python 3.12 #544
Closed
Add thread timeout for loop.shutdown_default_executor #535
Merged
Add support for Python 3.12 to Uvloop #547
Closed
@danpetry danpetry mentioned this pull request Oct 17, 2023
Update recipe for py312_patch AnacondaRecipes/uvloop-feedstock#5
Open
@No767 No767 mentioned this pull request Apr 30, 2025
Force Uvicorn to use uvloop/winloop UCMercedACM/kanae#51
Merged
4 of 9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fantix fantix fantix approved these changes
+1 more reviewer
@graingert graingert graingert requested changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Can we update cython and make uvloop compatible with python 3.12 please?

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@1st1 @AntonOfTheWoods @graingert @fantix
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.