GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — finish buttons for toolbar by clewis7 · Pull Request #207 · fastplotlib/fastplotlib

Conversation

@clewis7

@clewis7 clewis7 commented May 24, 2023

Copy link
Copy Markdown
Member

finishes #149

added record button, need to make image widget toolbar

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Caitlin Lewis and others added 21 commits May 17, 2023 16:27
Caitlin Lewis
working on toolbar
7869153
Caitlin Lewis
toolbar updates
6a9fa9a
Caitlin Lewis
basic toolbar for plot implemented
4bab1ce
Caitlin Lewis
base logic in notebook for gridplot toolbar
3e916c9
Caitlin Lewis
gp toolbar working when subplots have names & mix names/no names
2fa309b
Caitlin Lewis
initial changes to simple plot toolbar
b985f31
Caitlin Lewis
updates to plot toolbar, still need to refactor into separate file
1702938
Caitlin Lewis
fixed gridplot toolbar, still need to move to separate class
20ef9dd
Caitlin Lewis
add flip button
47612a4
Caitlin Lewis
adding click event handler for gp toolbar dropdown options
14fda3c
Caitlin Lewis
keep new clicked plot up-to-date with toggle button values
5bb9f00
@clewis7
Merge branch 'master' into buttons
7519116
Caitlin Lewis
requested changes
561b4eb
Caitlin Lewis
Merge branch 'buttons' of https://github.com/kushalkolar/fastplotlib …
0eacf45
…into buttons
Caitlin Lewis
adding record button
1fffdf1
Caitlin Lewis
record button
48775c3
@clewis7
Merge branch 'master' into more_buttons
b125530
Caitlin Lewis
silly miss in merge conflict resolve
9e6ed71
Caitlin Lewis
wow I am struggling this am
2b59076
Caitlin Lewis
imagewidget toolbar for single plot iw
9bdd2f7
Caitlin Lewis
toolbar for iw with gridplot
edc1ab3
kushalkolar
kushalkolar requested changes May 25, 2023
View reviewed changes
Comment thread fastplotlib/layouts/_gridplot.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread fastplotlib/layouts/_gridplot.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread fastplotlib/widgets/image.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread fastplotlib/widgets/image.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@kushalkolar

kushalkolar commented May 25, 2023

Copy link
Copy Markdown
Member

what about this for flip: https://fontawesome.com/icons/arrows-up-down?f=sharp&s=light

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Caitlin Lewis
requested changes
3dc010e
@clewis7

clewis7 commented May 25, 2023

Copy link
Copy Markdown
Member Author

got rid of redundant code, iw.show() method might need some work but everything is functional

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Caitlin Lewis added 3 commits May 25, 2023 09:27
Caitlin Lewis
update flip icon
039d142
Caitlin Lewis
toolbar updates
539b45a
Caitlin Lewis
changes to linear selector event handler removal
5778dd5
kushalkolar
kushalkolar reviewed Jun 2, 2023
View reviewed changes
Comment thread fastplotlib/widgets/image.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@kushalkolar
Update fastplotlib/widgets/image.py
0bbe464
@kushalkolar
simplify toolbar stuff in show(), simplify image widget toolbar
480e67f
kushalkolar
kushalkolar approved these changes Jun 2, 2023
View reviewed changes
@kushalkolar
kushalkolar merged commit d2c23c8 into master Jun 2, 2023
@kushalkolar
kushalkolar deleted the more_buttons branch June 2, 2023 19:59
This was referenced Jun 4, 2023
Toolbar #149
Closed
selector garbage collection, use selection feature name, cleanup event handlers #209
Closed
kushalkolar added a commit that referenced this pull request Jun 14, 2023
@clewis7 @kushalkolar
restarted tests, now work from the command line (#179)
a08e84c
* restarted tests, now work from the command line

* more tests

* more tests, still working on iw

* ipywidget can only be tested w/ nbmake

* updated tests

* support numpy fancy indexing for colors and data features (#177)

* type annotation fix for older python versions

* adding fancy indexing implemented in #177

* requested changes

* adding diff storage for CI pipeline usage

* use readthedocs.yaml for doc build (#189)

* tests changes, ready to start CI pipeline

* allow for screenshots to be regenerated via os.environ key

* CI build

* linux-build passes, still working on examples passing

* progress on CI pipeline, still need to figure out test build

* still failing test build, what I have for now

* kwargs for Plot and GridPlot to set canvas star size (#194)

* Update ci.yml

use pygfx before pylinalg refactor

* Update ci.yml

sed to remove pygfx from setup.py

* Update ci.yml

imageio

* Delete requirements_rtd.txt

* Update ci.yml

testing upload screens

* create BaseSelector, heatmap also works with LinearSelector and LinearRegionSelector (#187)

* BaseSelector handles most of the event handling, simplifies a lot of implementation.
* same functionality between Linear and LinearRegion, shift + arrow keys to move
* sync not tested for LinearRegion
* HeatmapGraphic has helpers to add Linear and LinearRegion
* indices getters and get_selected_data() are now based on Graphic type, so line and heatmap are handled differently
* started RectangleRegionSelector, will finish in another PR

* add features section to docs for Graphics

* fix sync bug, arrow key movements are toggleable (#198)

* finishes #107, #119, #192 (#200)

* more selector stuff (#199)

* garbage collection of selectors, not tested yet

* selecors gc progress, not there yet but not broken either

* move events for transparent fill areas

* rectangle region selector basic functionality works

* more rectangle region stuff

* basic recording for Plot (#178)

* basic recording for Plot

* opencv conditional import, reduce fps slightly in recorded vid to compensat, looks fine now

* forgot to add the actual recorder

* record Plot or GridPlot, uses PyAV, works well enough

* comment, organization

* cleaup

* changing linux build to have python versions matrix

* working on toolbar (#195)

* working on toolbar

* toolbar updates

* basic toolbar for plot implemented

* base logic in notebook for gridplot toolbar

* gp toolbar working when subplots have names & mix names/no names

* initial changes to simple plot toolbar

* updates to plot toolbar, still need to refactor into separate file

* fixed gridplot toolbar, still need to move to separate class

* add flip button

* adding click event handler for gp toolbar dropdown options

* keep new clicked plot up-to-date with toggle button values

* requested changes

* catchup with pygfx linalg refactor (#203)

* WIP, mapping to points and selectors not updated

* everything updated for linalg refactor except rectangle selector

* update toolbar w.r.t. linalg refactor

* update examples w.r.t. linalg refactor

* update readme

* image selector and heatmap linalg fixes (#204)

* add selector performance example nb

* Docs build fix (#210)

* Update .readthedocs.yaml, install pygfx from main

* Update .readthedocs.yaml

* Update .readthedocs.yaml

* all feature docs (#212)

* add all feature docs

* Create examples README

* Update README

* Update and rename README to README.md

* finish buttons for toolbar (#207)

* working on toolbar

* toolbar updates

* basic toolbar for plot implemented

* base logic in notebook for gridplot toolbar

* gp toolbar working when subplots have names & mix names/no names

* initial changes to simple plot toolbar

* updates to plot toolbar, still need to refactor into separate file

* fixed gridplot toolbar, still need to move to separate class

* add flip button

* adding click event handler for gp toolbar dropdown options

* keep new clicked plot up-to-date with toggle button values

* requested changes

* adding record button

* record button

* silly miss in merge conflict resolve

* wow I am struggling this am

* imagewidget toolbar for single plot iw

* toolbar for iw with gridplot

* requested changes

* update flip icon

* toolbar updates

* changes to linear selector event handler removal

* Update fastplotlib/widgets/image.py

* simplify toolbar stuff in show(), simplify image widget toolbar

---------

Co-authored-by: Kushal Kolar <[email protected]>

* nbmake tests work

* updating CI file

* all tests passing locally

* trying to get CI to run on ghub

* change screenshots to be stored as png files

* restarted tests, now work from the command line

* more tests

* more tests, still working on iw

* ipywidget can only be tested w/ nbmake

* updated tests

* adding fancy indexing implemented in #177

* requested changes

* adding diff storage for CI pipeline usage

* tests changes, ready to start CI pipeline

* allow for screenshots to be regenerated via os.environ key

* CI build

* linux-build passes, still working on examples passing

* progress on CI pipeline, still need to figure out test build

* still failing test build, what I have for now

* Update ci.yml

use pygfx before pylinalg refactor

* Update ci.yml

sed to remove pygfx from setup.py

* Update ci.yml

imageio

* Update ci.yml

testing upload screens

* changing linux build to have python versions matrix

* nbmake tests work

* updating CI file

* all tests passing locally

* trying to get CI to run on ghub

* change screenshots to be stored as png files

* rebase with master and update CI

* track *.png files using Git LFS

* yml for regenerating screenshots, updating CI yml to not regenerate

* update .gitignore and regen screenshots yml

* hopefully works

* add screenshots

* remove screenshots from git

* add screenshots, yet again

* setup options

* remove type annotation

* change workflow to use setup optiosn

* add pyav to setup for tests

* add scikit-image

* opencv instead of pyav

* add libpng-dev

* try pillow, better work ffs

* bah

* add git-lfs to apt install for github actions

* add interactive again

* install git lfs before checkout repo

* add git lfs fetch pull

* diffs

* diffs path

* update examples for canvas size and autoscale

* remove gpu screenshots

* add screenshot ground truth files from github actions generated screenshots

* remove interactive session stuff

---------

Co-authored-by: Kushal Kolar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kushalkolar kushalkolar kushalkolar approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@clewis7 @kushalkolar
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.