GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: Adding list_validation_references for default and sql registry by amommendes · Pull Request #3436 · feast-dev/feast

Conversation

@amommendes

@amommendes amommendes commented Jan 7, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Signed-off-by: Amom Mendes [email protected]

What this PR does / why we need it:
Adding list_validation_references method which is not implemented on default and sql registry
Which issue(s) this PR fixes:

Fixes #3408

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
amommendes added 4 commits December 31, 2022 20:31
@amommendes
Adding description as a first-class attribute for features/fields
bf98b82 
Signed-off-by: Amom Mendes <[email protected]>
@amommendes
Formatting
85b9251 
Signed-off-by: Amom Mendes <[email protected]>
@amommendes
Merge branch 'feast-dev:master' into master
32bb2f9
@amommendes
Add list validation references
ba4df5c 
Signed-off-by: Amom Mendes <[email protected]>
@feast-ci-bot feast-ci-bot added the size/M label Jan 7, 2023
@amommendes amommendes changed the title Adding list_validation_references for default and sql registry chore: Adding list_validation_references for default and sql registry Jan 7, 2023
@amommendes amommendes changed the title chore: Adding list_validation_references for default and sql registry feat: Adding list_validation_references for default and sql registry Jan 7, 2023
@amommendes

amommendes commented Jan 7, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

@sfc-gh-madkins and @adchia, I'm not sure if we should raise an exception if we don't have any ValidationReference in the project... Considering that _list_objects from sql registry returns an empty list if there are no rows from some table, I think that is not a problem to return an empty list as well ... WDYT?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@amommendes
Format
a4df677 
Signed-off-by: Amom Mendes <[email protected]>
adchia
adchia approved these changes Jan 7, 2023
View reviewed changes

@adchia adchia left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@feast-ci-bot feast-ci-bot assigned adchia Jan 7, 2023
@feast-ci-bot

feast-ci-bot commented Jan 7, 2023

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, amommendes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [adchia]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@feast-ci-bot feast-ci-bot added lgtm approved labels Jan 7, 2023
@amommendes

amommendes commented Jan 7, 2023

Copy link
Copy Markdown
Contributor Author

Hey @adchia, I didn't find commits not signed... Is the merge blocked by this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sfc-gh-madkins
sfc-gh-madkins enabled auto-merge (squash) January 7, 2023 15:56
@feast-ci-bot
feast-ci-bot merged commit 21dd253 into feast-dev:master Jan 8, 2023
kevjumba pushed a commit that referenced this pull request Jan 31, 2023
@feast-ci-bot
chore(release): release 0.29.0
d3b7c06 
# [0.29.0](v0.28.0...v0.29.0) (2023-01-31)

### Bug Fixes

* Add check for bool type in addition to sample ([#3452](#3452)) ([1c7c491](1c7c491))
* Buggy SQL for postgres source ([#3424](#3424)) ([1ea100e](1ea100e))
* Ensure no duplicates in `fv.schema` ([#3460](#3460)) ([08ffa8d](08ffa8d))
* Fix delete sfv twice issue ([#3466](#3466)) ([dfd5eae](dfd5eae))
* Stream feature view UI shows transformation issue ([#3464](#3464)) ([1ef5137](1ef5137))
* Update registry.refresh to have a default arg ([#3450](#3450)) ([2f7c4ed](2f7c4ed))
* Updating the batch field so that you can query create and event date. ([#3411](#3411)) ([01ab462](01ab462)), closes [#3401](#3401)

### Features

* Add data source search ([#3449](#3449)) ([fbbb293](fbbb293))
* Adding list_validation_references for default and sql registry ([#3436](#3436)) ([21dd253](21dd253))
* Make UI accessible behind proxy ([#3428](#3428)) ([753d8db](753d8db))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adchia adchia adchia approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@adchia adchia

Labels

approved lgtm size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SQL Registry + caching is missing the function: list_validation_references(

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@amommendes @feast-ci-bot @adchia
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.