GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: Add check for bool type in addition to sample by beauchbum · Pull Request #3452 · feast-dev/feast

Conversation

@beauchbum

@beauchbum beauchbum commented Jan 19, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Signed-off-by: Ryan Beauchamp [email protected]

What this PR does / why we need it:
The current implementation throws an exception when sample == False as it enters this conditional:

# This block is entered as `False == 0` evaluates to `True`
if sample == 0 or sample == 0.0:

  # However, this fails because `type(False) => bool`
  assert type(sample) in [np.int64, int, np.float64, float]

This PR adds an additional check to bypass this condition when dealing with bool.

Which issue(s) this PR fixes:

Fixes #3451

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Ryan Beauchamp
fix: add check for bool type in addition to sample
5dcd9fb 
Signed-off-by: Ryan Beauchamp <[email protected]>
@feast-ci-bot feast-ci-bot added the size/XS label Jan 19, 2023
@beauchbum beauchbum changed the title fix: add check for bool type in addition to sample fix: Add check for bool type in addition to sample Jan 19, 2023
adchia
adchia approved these changes Jan 20, 2023
View reviewed changes

@adchia adchia left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@feast-ci-bot feast-ci-bot assigned adchia Jan 20, 2023
@feast-ci-bot

feast-ci-bot commented Jan 20, 2023

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, beauchbum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [adchia]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@feast-ci-bot feast-ci-bot added lgtm approved labels Jan 20, 2023
@feast-ci-bot
feast-ci-bot merged commit 1c7c491 into feast-dev:master Jan 20, 2023
kevjumba pushed a commit that referenced this pull request Jan 31, 2023
@feast-ci-bot
chore(release): release 0.29.0
d3b7c06 
# [0.29.0](v0.28.0...v0.29.0) (2023-01-31)

### Bug Fixes

* Add check for bool type in addition to sample ([#3452](#3452)) ([1c7c491](1c7c491))
* Buggy SQL for postgres source ([#3424](#3424)) ([1ea100e](1ea100e))
* Ensure no duplicates in `fv.schema` ([#3460](#3460)) ([08ffa8d](08ffa8d))
* Fix delete sfv twice issue ([#3466](#3466)) ([dfd5eae](dfd5eae))
* Stream feature view UI shows transformation issue ([#3464](#3464)) ([1ef5137](1ef5137))
* Update registry.refresh to have a default arg ([#3450](#3450)) ([2f7c4ed](2f7c4ed))
* Updating the batch field so that you can query create and event date. ([#3411](#3411)) ([01ab462](01ab462)), closes [#3401](#3401)

### Features

* Add data source search ([#3449](#3449)) ([fbbb293](fbbb293))
* Adding list_validation_references for default and sql registry ([#3436](#3436)) ([21dd253](21dd253))
* Make UI accessible behind proxy ([#3428](#3428)) ([753d8db](753d8db))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adchia adchia adchia approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@adchia adchia

Labels

approved lgtm size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

0.28.0 Python SDK: Assertion failure on Boolean types in type_map.py #3443

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@beauchbum @feast-ci-bot @adchia
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.