GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — fix: Updating the batch field so that you can query create and event date. by franciscojavierarceo · Pull Request #3411 · feast-dev/feast

Conversation

franciscojavierarceo commented Dec 23, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

What this PR does / why we need it:

This PR allows users to call get_online_features or get_historical_features with the created or event_timestamp fields in the features function call and return the proper data.

Which issue(s) this PR fixes:

Fixes # #3412

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

feast-ci-bot added do-not-merge/work-in-progress size/M labels

Dec 23, 2022

franciscojavierarceo force-pushed the query-created-date branch from 902ae5b to bfb88c5 Compare

December 23, 2022 20:24

franciscojavierarceo changed the title ~~updating the batch field so that if you want return the created date …~~ fox" updating the batch field so that if you want return the created date …

Dec 23, 2022

franciscojavierarceo changed the title ~~fox" updating the batch field so that if you want return the created date …~~ fix: updating the batch field so that if you want return the created date …

Dec 23, 2022

franciscojavierarceo changed the title ~~fix: updating the batch field so that if you want return the created date …~~ fix: Updating the batch field so that you can query create date.

Dec 23, 2022

franciscojavierarceo mentioned this pull request

Dec 23, 2022

Unable to query created or event_timestamp fields from feature views #3412

Closed

franciscojavierarceo force-pushed the query-created-date branch from c11fcaa to ba2eca4 Compare

December 24, 2022 00:59

franciscojavierarceo marked this pull request as ready for review

December 24, 2022 01:46

feast-ci-bot removed the do-not-merge/work-in-progress label

Dec 24, 2022

franciscojavierarceo force-pushed the query-created-date branch from c42cc51 to fcb821a Compare

December 27, 2022 18:42

franciscojavierarceo changed the title ~~fix: Updating the batch field so that you can query create date.~~ fix: Updating the batch field so that you can query create and event date.

Jan 3, 2023

adchia reviewed

Jan 3, 2023

View reviewed changes

Comment thread

sdk/python/feast/infra/offline_stores/file.py Outdated

adchia Jan 3, 2023

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not fully sure i understand what these duplicate columns are coming from? Can you leave more comments on why?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

franciscojavierarceo Jan 3, 2023

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah i'll update the PR but basically querying for created in get_online_features duplicates the created_timestamp_column. So I could go deeper and try to fix the duplication but I needed a quick fix on my side and it works correctly for us.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

franciscojavierarceo Jan 3, 2023

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adchia updated the comment 👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

adchia approved these changes

Jan 4, 2023

View reviewed changes

adchia left a comment

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

feast-ci-bot assigned adchia

Jan 4, 2023

feast-ci-bot added the lgtm label

Jan 4, 2023

feast-ci-bot commented Jan 4, 2023

Copy link

Copy Markdown

Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, franciscojavierarceo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [adchia]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

feast-ci-bot added the approved label

Jan 4, 2023

kysersozelee and others added 4 commits

January 3, 2023 19:08


          fix: Assertion condition when value is 0 (feast-dev#3401)

cd9dc81

* fix: Add assertion condition when value is 0

Signed-off-by: zlatan.el <[email protected]>

* chore: Add comment about zero value validation

Signed-off-by: zlatan.el <[email protected]>

* chore: Modifiy the comment

Signed-off-by: zlatan.el <[email protected]>

* chore: Add the comment

Signed-off-by: zlatan.el <[email protected]>

Signed-off-by: zlatan.el <[email protected]>
Co-authored-by: zlatan.el <[email protected]>
Signed-off-by: franciscojavierarceo <[email protected]>


          updating the batch field so that if you want return the created date …

a7ce3b7

…of a model you can just add it in the get_online_features feature argument

Signed-off-by: franciscojavierarceo <[email protected]>


          linted

5ea5165

Signed-off-by: franciscojavierarceo <[email protected]>


          adding change to also support querying the event_timestamp

9eba3ea

Signed-off-by: franciscojavierarceo <[email protected]>

franciscojavierarceo force-pushed the query-created-date branch from df1736f to 9eba3ea Compare

January 4, 2023 02:09

feast-ci-bot removed the lgtm label

Jan 4, 2023

franciscojavierarceo commented Jan 4, 2023

Copy link

Copy Markdown

Member Author

sorry @adchia looks like I had to redo the sign off will need another stamp

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

adchia commented Jan 5, 2023

Copy link

Copy Markdown

Collaborator

/lgtm

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

feast-ci-bot added the lgtm label

Jan 5, 2023

feast-ci-bot merged commit 01ab462 into feast-dev:master

Jan 5, 2023

kevjumba pushed a commit that referenced this pull request

Jan 31, 2023


          chore(release): release 0.29.0

d3b7c06

# [0.29.0](v0.28.0...v0.29.0) (2023-01-31)

### Bug Fixes

* Add check for bool type in addition to sample ([#3452](#3452)) ([1c7c491](1c7c491))
* Buggy SQL for postgres source ([#3424](#3424)) ([1ea100e](1ea100e))
* Ensure no duplicates in `fv.schema` ([#3460](#3460)) ([08ffa8d](08ffa8d))
* Fix delete sfv twice issue ([#3466](#3466)) ([dfd5eae](dfd5eae))
* Stream feature view UI shows transformation issue ([#3464](#3464)) ([1ef5137](1ef5137))
* Update registry.refresh to have a default arg ([#3450](#3450)) ([2f7c4ed](2f7c4ed))
* Updating the batch field so that you can query create and event date. ([#3411](#3411)) ([01ab462](01ab462)), closes [#3401](#3401)

### Features

* Add data source search ([#3449](#3449)) ([fbbb293](fbbb293))
* Adding list_validation_references for default and sql registry ([#3436](#3436)) ([21dd253](21dd253))
* Make UI accessible behind proxy ([#3428](#3428)) ([753d8db](753d8db))

Reviewers

adchia

adchia approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

adchia

Labels

approved lgtm size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

franciscojavierarceo commented Dec 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adchia Jan 3, 2023

Choose a reason for hiding this comment

Uh oh!

franciscojavierarceo Jan 3, 2023

Choose a reason for hiding this comment

Uh oh!

franciscojavierarceo Jan 3, 2023

Choose a reason for hiding this comment

Uh oh!

adchia left a comment

Choose a reason for hiding this comment

Uh oh!

feast-ci-bot commented Jan 4, 2023

Uh oh!

franciscojavierarceo commented Jan 4, 2023

Uh oh!

adchia commented Jan 5, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

franciscojavierarceo commented Dec 23, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.