GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: Issue-3771, fix document error as not shortcut -f option in code. by shuchu · Pull Request #3783 · feast-dev/feast

Conversation

@shuchu

@shuchu shuchu commented Oct 9, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:
The code in cli.py (line 75) doest not configure shortcut:
@click.option( "--feature-store-yaml", help="Override the directory where the CLI should look for the feature_store.yaml file.", )

Which issue(s) this PR fixes:

Fixes #3771

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@shuchu shuchu changed the title fix: issue-3771, fix document error as not shortcut -f option in code. fix: Issue-3771, fix document error as not shortcut -f option in code. Oct 9, 2023
achals
achals approved these changes Oct 12, 2023
View reviewed changes

@achals achals left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@achals

achals commented Oct 12, 2023

Copy link
Copy Markdown
Member

@shuchu You need to sign off your commits: https://github.com/feast-dev/feast/pull/3783/checks?check_run_id=17532312440

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@shuchu
fix: issue-3771, fix document error as not shortcut -f option in code.
49da37c
Signed-off-by: Shuchu Han <[email protected]>
@shuchu
shuchu force-pushed the issue-3771 branch from 4484e04 to 49da37c Compare October 13, 2023 01:23
@shuchu

shuchu commented Oct 13, 2023

Copy link
Copy Markdown
Collaborator Author

sorry about this mistake. Have fixed it.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

achals and others added 7 commits October 20, 2023 10:36
@achals
fix: Update jackson and remove unnecessary logging (feast-dev#3809)
018d0ea
Signed-off-by: Achal Shah <[email protected]>
@achals
chore: Add harry to CODEOWNERS (feast-dev#3808)
ea12133
* chore: Add harry to CODEOWNERS

Signed-off-by: Achal Shah <[email protected]>

* add path

Signed-off-by: Achal Shah <[email protected]>

---------

Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah <[email protected]>
@dependabot
chore: Bump golang.org/x/net from 0.7.0 to 0.17.0 (feast-dev#3792)
f7a98e2
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.7.0 to 0.17.0.
- [Commits](golang/net@v0.7.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore: Bump @babel/traverse from 7.17.10 to 7.23.2 in /sdk/python/fea…
98e0ce8
…st/ui (feast-dev#3802)

chore: Bump @babel/traverse in /sdk/python/feast/ui

Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.17.10 to 7.23.2.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse)

---
updated-dependencies:
- dependency-name: "@babel/traverse"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore: Bump avro from 1.10.0 to 1.11.3 in /sdk/python/requirements (f…
f05a6e7
…east-dev#3780)

Bumps [avro](https://github.com/apache/avro) from 1.10.0 to 1.11.3.
- [Release notes](https://github.com/apache/avro/releases)
- [Commits](apache/avro@release-1.10.0...release-1.11.3)

---
updated-dependencies:
- dependency-name: avro
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@sudohainguyen
feat: Support GCS filesystem for bytewax engine (feast-dev#3774)
fb6b807
* fix: Support param timeout when persisting

Signed-off-by: Hai Nguyen <[email protected]>

* fix: fix java integration test

Signed-off-by: Hai Nguyen <[email protected]>

---------

Signed-off-by: Hai Nguyen <[email protected]>
@sudohainguyen
feat: Make bytewax job write as mini-batches (feast-dev#3777)
9b0e5ce
Signed-off-by: Hai Nguyen <[email protected]>
@achals achals added lgtm approved ok-to-test labels Oct 20, 2023
@achals
achals enabled auto-merge (squash) October 20, 2023 22:14
sudohainguyen and others added 13 commits October 20, 2023 15:14
@sudohainguyen
fix: Resolve hbase hotspot issue when materializing (feast-dev#3790)
7376db8
* fix: Resolve hbase hotspot issue when materializing

Signed-off-by: Hai Nguyen <[email protected]>

* chore: Refactor internal table id generator

Signed-off-by: Hai Nguyen <[email protected]>

---------

Signed-off-by: Hai Nguyen <[email protected]>
@BearDimonR
fix: Make generated temp table name escaped (feast-dev#3797)
175d796
* Fix critical issue with saving results in BigQuery

Need to encapsulate table path as tmp table path can contain symbols that can't be process by BigQuery without encapsulation

Signed-off-by: Dmytro Miedviediev <[email protected]>

* update numpy

Signed-off-by: Dmytro Miedviediev <[email protected]>

* revert numpy version

Signed-off-by: Dmytro Miedviediev <[email protected]>

---------

Signed-off-by: Dmytro Miedviediev <[email protected]>
@sudohainguyen
fix: Adopt connection pooling for HBase (feast-dev#3793)
b3852bf
@james-crabtree-sp
fix: Redundant feature materialization and premature incremental mate…
417b16b
…rialization timestamp updates (feast-dev#3789)

* SAASMLOPS-767 wait for jobs to complete

Signed-off-by: James Crabtree <[email protected]>

* SAASMLOPS-805 Stopgap change to fix duplicate materialization of data

Signed-off-by: James Crabtree <[email protected]>

* SAASMLOPS-805 save BYTEWAX_REPLICAS=1

Signed-off-by: James Crabtree <[email protected]>

* SAASMLOPS-809 fix bytewax workers so they only process a single file (feast-dev#6)

* SAASMLOPS-809 fix bytewax workers so they only process a single file

* SAASMLOPS-809 fix newlines

Signed-off-by: James Crabtree <[email protected]>

* SAASMLOPS-833 add configurable job timeout (feast-dev#7)

* SAASMLOPS-833 add configurable job timeout

* SAASMLOPS-833 fix whitespace

Signed-off-by: James Crabtree <[email protected]>

* develop Run large materializations in batches of pods

Signed-off-by: James Crabtree <[email protected]>

* master Set job_batch_size at least equal to max_parallelism

Signed-off-by: James Crabtree <[email protected]>

* master clarity max_parallelism description

Signed-off-by: James Crabtree <[email protected]>

* master resolve bug that causes materialization to continue after job error

Signed-off-by: James Crabtree <[email protected]>

* master resolve bug causing pod logs to not be printed

Signed-off-by: James Crabtree <[email protected]>

---------

Signed-off-by: James Crabtree <[email protected]>
@dependabot
chore: Bump urllib3 from 1.26.16 to 1.26.18 in /sdk/python/requiremen…
0151961
…ts (feast-dev#3803)

Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.26.16 to 1.26.18.
- [Release notes](https://github.com/urllib3/urllib3/releases)
- [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst)
- [Commits](urllib3/urllib3@1.26.16...1.26.18)

---
updated-dependencies:
- dependency-name: urllib3
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@sudohainguyen
feat: Add get online feature rpc to gprc server (feast-dev#3815)
01db8cc
Signed-off-by: Hai Nguyen <[email protected]>
@sudohainguyen
fix: Add async refresh to prevent synchronous refresh in main thread (f…
9583ed6
…east-dev#3812)

fix: Add async refresh to prevent synchronous refresh in main thread for http feature server

Signed-off-by: Hai Nguyen <[email protected]>
@sudohainguyen
fix: Bytewax engine create configmap from object (feast-dev#3821)
25e9775
fix: bytewax engine create configmap from object

Signed-off-by: Hai Nguyen <[email protected]>
@sudohainguyen @achals
fix: Set upper bound for bigquery client due to its breaking changes
2151c39
Signed-off-by: Hai Nguyen <[email protected]>
@sudohainguyen @achals
fix: update dependencies versions due to conflicts
5dc0b24
Signed-off-by: Hai Nguyen <[email protected]>
@sudohainguyen @achals
chore: generate reqs file from up-to-date deps
1f91fc6
Signed-off-by: Hai Nguyen <[email protected]>
@sudohainguyen @achals
feat: Optimize bytewax pod resource with zero-copy
9cf9d96
Signed-off-by: Hai Nguyen <[email protected]>
@sudohainguyen @achals
fix: improve parsing bytewax job status
5983f40
Signed-off-by: Hai Nguyen <[email protected]>
franciscojavierarceo and others added 19 commits January 30, 2024 13:22
@franciscojavierarceo
docs: Updating maintainers.md (feast-dev#3919)
936ecfd
@franciscojavierarceo
docs: Updated development guide to include compiling the protos (feas…
8bce6dc
…t-dev#3896)

* [docs] updated development guide to include compiling the protos

Signed-off-by: franciscojavierarceo <[email protected]>

* adding note on spinning up the docker image

Signed-off-by: franciscojavierarceo <[email protected]>

---------

Signed-off-by: franciscojavierarceo <[email protected]>
@sudohainguyen
fix: Prevent spamming pull busybox from dockerhub (feast-dev#3923)
7153cad
Signed-off-by: Hai Nguyen <[email protected]>
@dependabot
chore: Bump jupyterlab from 4.0.8 to 4.0.11 in /sdk/python/requiremen…
bf026a0
…ts (feast-dev#3895)
@tokoko
fix: Remove unnecessary dependency on mysqlclient (feast-dev#3925)
f494f02
@sudohainguyen
ci: Extend python base version for test cases (feast-dev#3929)
1f3cab8
Signed-off-by: Hai Nguyen <[email protected]>
@tokoko
feat: Add gRPC Registry Server (feast-dev#3924)
373e624
@sudohainguyen
chore: Set upper bound for moto package (feast-dev#3937)
b4aed65
chore: set upper bound for moto package

Signed-off-by: Hai Nguyen <[email protected]>
@Woo-Dong
fix: Trino as an OfflineStore Access Denied when BasicAuthenticaion (f…
49d2988
…east-dev#3898)
@tsisodia10
fix: Typo Correction in Feast UI Readme (feast-dev#3939)
c16e5af
Modify the README to point to correct project list

Signed-off-by: Twinkll Sisodia <[email protected]>
@zseta
docs: Add ScyllaDB as online store alternative (fixed DCO) (feast-dev…
bdce99d
…#3944)
@job-almekinders
fix: Add conn.commit() to Postgresonline_write_batch.online_write_bat…
7d75fc5
…ch (feast-dev#3904)
@tokoko
fix: Transformation server doesn't generate files from proto (feast-d…
d3a2a45
…ev#3902)
@bushwhackr
chore: Bumping fastapi + starlette (feast-dev#3938)
4e450ad
@tokoko
fix: Rewrite Spark materialization engine to use mapInPandas (feast-d…
dbb59ba
…ev#3936)

rewrite spark materilization engine to use mapInPandas

Signed-off-by: tokoko <[email protected]>
@cburroughs
chore: Loosen fsspec requirements to allow recent releases (feast-dev…
5c9f592
…#3922)

* chore: Loosen fsspec requirements to allow recent releases

(I'm not sure the project has a super consistent pattern for when to
specify a maximum version, but was going for the smallest possible
change.)

Signed-off-by: Chris Burroughs <[email protected]>

* drop redundant fsspec now that this is in another extra

Signed-off-by: Chris Burroughs <[email protected]>

* post rebase regen

Signed-off-by: Chris Burroughs <[email protected]>

---------

Signed-off-by: Chris Burroughs <[email protected]>
@shuchu
feat: Update the Pydantic from v1 to v2 (feast-dev#3948)
ec11a7c
@shuchu
fix: issue-3771, fix document error as not shortcut -f option in code.
8d45c93
Signed-off-by: Shuchu Han <[email protected]>
@shuchu
Merge branch 'issue-3771' of github.com:shuchu/feast into issue-3771
4016aa4
@shuchu
shuchu requested review from a team, DvirDukhan, kevjumba, niklasvm, sfc-gh-madkins, sudohainguyen, whoahbot and younggyu-oh as code owners February 16, 2024 22:15
@shuchu shuchu closed this Feb 16, 2024
auto-merge was automatically disabled February 16, 2024 22:19

Pull request was closed

@shuchu shuchu mentioned this pull request Feb 16, 2024
fix: Fix typo as the cli does not support shortcut-f option. #3954
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@achals achals achals approved these changes
@redhatHameed redhatHameed redhatHameed approved these changes
@whoahbot whoahbot Awaiting requested review from whoahbot
@sfc-gh-madkins sfc-gh-madkins Awaiting requested review from sfc-gh-madkins
@DvirDukhan DvirDukhan Awaiting requested review from DvirDukhan
@sudohainguyen sudohainguyen Awaiting requested review from sudohainguyen sudohainguyen is a code owner
@niklasvm niklasvm Awaiting requested review from niklasvm
@kevjumba kevjumba Awaiting requested review from kevjumba
@younggyu-oh younggyu-oh Awaiting requested review from younggyu-oh

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

approved lgtm ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

No such option: -f for feast CLI

Uh oh!

There was an error while loading. Please reload this page.

20 participants

@shuchu @achals @lokeshrangineni @redhatHameed @sudohainguyen @BearDimonR @james-crabtree-sp @snowron @woop @feast-ci-bot @robhowley @j1wonpark @etirelli @JohnLemmonMedely @alex-vinnik-sp @gee-senbong @marti-jorda-roca @franciscojavierarceo @tokoko @Woo-Dong
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.