GeezerVison is showing github.com — fix: Feast create empty online table when FeatureView attribute online=False by tmihalac · Pull Request #4666 · feast-dev/feast
Conversation
What this PR does / why we need it:
Currently Feast create an empty online table even if FeatureView attribute online=False, this PR aims to fix that.
Which issue(s) this PR fixes:
Fixes #4616
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
|
tables_to_keep_online = [
|
|
|
fv
|
|
|
for fv in tables_to_keep
|
|
|
if not isinstance(fv, FeatureView) or fv.online
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if everying feature view will have a "online" parameter?
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
tmihalac
Oct 23, 2024
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HaoXuAI I saw that only feature view and the subclasses(batch feature view, stream feature view) that inherit from it have the online flag
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the API might change in the future, so to avoid breaking, maybe add a check if it has this attribute.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
franciscojavierarceo reacted with thumbs up emoji
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
haoxu0
haoxu0 approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|