GeezerVison is showing github.com — feat: Operator E2E test to validate FeatureStore custom resource using remote registry by lokeshrangineni · Pull Request #4822 · feast-dev/feast
Conversation
We have added the operator E2E test to cover following scenario.
- Deploy the feature store custom resource in one of of the kubernetes namespace.
- Deploy the another feature store custom resource in another namespace but should point to the registry using remote setting which should refer to the registry service created in the previous step.
- Increase the
go test timeout so that github ci will succeed without time out issue. Also added the kind cluster logs when there is a failure of operator e2e test github action so it will help in troubleshooting the issue.
Issue related to 4823
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
abstracted the code to do the featurestore testing.
Signed-off-by: lrangine <[email protected]>
lokeshrangineni
changed the title
Operator E2E test to validate FeatureStore custom resource using remote registry
feat: Operator E2E test to validate FeatureStore custom resource using remote registry
Dec 6, 2024
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
dharmisha
pushed a commit
to nishantgaurav-dev/feast
that referenced
this pull request
Jan 15, 2025
…g remote registry (feast-dev#4822)
* Added new e2e test case to do the remote registry deployment.
abstracted the code to do the featurestore testing.
Signed-off-by: lrangine <[email protected]>
* abstracted the code even further. Now the custom resource CR will execute only once for all the test cases.
Signed-off-by: lrangine <[email protected]>
* fixing the operator e2e test. this was commented before by mistake.
Signed-off-by: lrangine <[email protected]>
* increasing the remote registry deployment timeout to see if it solves the github CI timeout issue.
Signed-off-by: lrangine <[email protected]>
* Trying to increase the timeout and also adding the debugging actions when there is a failure.
Signed-off-by: lrangine <[email protected]>
* increased the go test timeout to 30m to fix the github operator e2e test action.
Signed-off-by: lrangine <[email protected]>
* increased the go test timeout to 30m to fix the github operator e2e test action.
Signed-off-by: lrangine <[email protected]>
* increased the go test timeout to 30m to fix the github operator e2e test action.
Signed-off-by: lrangine <[email protected]>
* incorporating the code review comments.
Signed-off-by: lrangine <[email protected]>
* incorporating the code review comments by using the feastRef.
Signed-off-by: lrangine <[email protected]>
* incorporating the code review comments by marshaling json to the go struct object rather than map.
Signed-off-by: lrangine <[email protected]>
* Fixing the lint error.
Signed-off-by: lrangine <[email protected]>
---------
Signed-off-by: lrangine <[email protected]>
Uh oh!
There was an error while loading. Please reload this page.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|