GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — FCM implementation by tretelny · Pull Request #167 · fullstackreact/react-native-firestack

Conversation

@tretelny

@tretelny tretelny commented Nov 26, 2016

Copy link
Copy Markdown

Most of the FCM implementation, local notifications could be cleaner/need to be tested more. Would be helpful to know how the JS methods want to call and define these things so can know how to better convert to native iOS components i.e. UILocalNotification etc

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
ghuh and others added 30 commits November 7, 2016 17:52
@ghuh
Implement reauthenticateWithCredentialForProvider for Android
ed409a2
@chaitanya-bhagavan
Catch exception thrown by setPersistenceEnabled which was causing the…
972b16d
… rn app to fail
@chaitanya-bhagavan
Parity in response format between ios and android
a4a115f
@chaitanya-bhagavan
Fixed a typo that was causing an error
483e15f
@chaitanya-bhagavan
Parity in response format between ios and android
a85f5fa
@chaitanya-bhagavan
Reverted changes since it was an error from my end
e34988b
@pedro-ribeiro
fixing filter value creation
68396e0
@auser
Merge pull request fullstackreact#122 from pedro-ribeiro/fixing_equalto
635f882
fixing filter value creation
@auser
Merge pull request fullstackreact#119 from chaitanya0bhagvan/master
ea5e10c
Parity of response format between ios and android
@auser
Merge pull request fullstackreact#117 from ghuh/ghuh-android-reauthen…
b55ba69
…ticateWithCredentialForProvider

Implement reauthenticateWithCredentialForProvider for Android
@ghuh
Fix Android listenForAuth method to correctly check for user
c3129fb
@auser
WIP: FirebaseAuth
28644a6
@auser
Added initial handling of android error messages
1111617
@auser
Merge pull request fullstackreact#124 from ghuh/ghuh-android-listenFo…
c811a3a
…rAuth

Fix Android listenForAuth method to correctly check for user
@chaitanya-bhagavan
Parity of response format between ios and android. Added authenticate…
7d09ab4
…d flag to response from getCurrentUser
@auser
Remove RCTConvert to work with react-native-fcm
e525569
@auser
Merge branch 'master' of github.com:fullstackreact/react-native-fires…
9f9525d
…tack

* 'master' of github.com:fullstackreact/react-native-firestack:
  Fix Android listenForAuth method to correctly check for user
@auser
Merge pull request fullstackreact#126 from chaitanya0bhagvan/master
ef52467
Parity of response format between ios and android.
@samer
Filter out undefined filters
8306c45
@pedro-ribeiro
removing trailing comma
487ed30
@auser
Merge pull request fullstackreact#137 from pedro-ribeiro/fixing_trail…
a0a78e5
…ing_comma

Removing undefined's from filter arguments
@auser
Merge pull request fullstackreact#136 from samer/filter-fix
da34c79
Filter out undefined filters
@chaitanya-bhagavan
forEach and map method on the DataSnapshot does not retain key
6ca78a1
@chaitanya-bhagavan
Fixed error calling length of undefined
80133de
@auser
Merge pull request fullstackreact#139 from chaitanya0bhagvan/master
0349b61
forEach and map method on the DataSnapshot does not retain key
@janvogt
Use storage url from .plist file if not setStorageUrl() hasn't been c…
d005ab2
…alled.

- Fix weird error that NSError is not KVC compliant when storage is not configured
JS
- Fixed code seems to exist on several more locations but has not been fixed,
since there are no tests to ensure I don't break anything.
@janvogt
Fix donwloadUrl to use storageUrl from .plist.
dfc0bd1
- Use storageUrl from default config if not set otherwise in JS
- Similar code exists on several other places that are not fixed since
no tests prevent breaking stuff.
@auser
Merge pull request fullstackreact#143 from janvogt/fix-storage-config
e214b6d
Use storage url from .plist file if not setStorageUrl() hasn't been called
@auser
WIP
f4bcfea
@auser
Merge branch 'master' of github.com:fullstackreact/react-native-fires…
29140b6
…tack

* 'master' of github.com:fullstackreact/react-native-firestack:
  Fix donwloadUrl to use storageUrl from .plist.
  Use storage url from .plist file if not setStorageUrl() hasn't been called.
  Fixed error calling length of undefined
  forEach and map method on the DataSnapshot does not retain key
  removing trailing comma
  Filter out undefined filters
  Parity of response format between ios and android. Added authenticated flag to response from getCurrentUser
auser and others added 7 commits November 18, 2016 12:58
@auser
Updated with @Salakar v3
f715d41
@Salakar
Merge pull request fullstackreact#152 from Salakar/master
7774ac1
Update v3 with latest changes
@BlooJeans
Implement firestack.storage.download() for android
98d873f
@BlooJeans
Factor out errorCodes for future constants
f3233ad
@BlooJeans
Remove unused/old database.js
d50e976
 Database.js was factored out into the database/ folder.  This stuck
 around for some reason and the require('modules/database') preferred
 the old version
@Salakar
Merge pull request fullstackreact#154 from devshackio/android-downloa…
f034c1f
…dFile

Implement storage.download() for Android
@tretelny416
FCM implementation
4bb951c
Most of the FCM implementation, local notifications could be cleaner…
@auser

auser commented Nov 28, 2016

Copy link
Copy Markdown
Contributor

I'll check this out this evening!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tansart tansart mentioned this pull request Dec 17, 2016
[v3] – FirestackCloudMessaging.m: expected method body #188
Closed
@Salakar
Salakar force-pushed the v3 branch from 018c0b5 to 9ec08b8 Compare December 29, 2016 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

10 participants

@tretelny @auser @ghuh @chaitanya-bhagavan @pedro-ribeiro @samer @janvogt @Salakar @BlooJeans @tretelny416
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.