GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Remove ttconv backwards-compatibility code by QuLogic · Pull Request #30145 · matplotlib/matplotlib

Conversation

QuLogic commented Jun 5, 2025

Copy link

Copy Markdown

Member

PR summary

When ttconv was replaced by pure Python code, several bits of compatibility code were left in in #18181. This removes those code chunks, as the test images will already be regenerated as part of the larger font work.

As this only affects PDF, and it's only minor rounding/duplicate vertices, the differences are generally only a single pixel for 1 character out of 3 or 4.

PR checklist

[n/a] "closes #0000" is in the body of the PR description to link the related issue
new and changed code is tested
[n/a] Plotting related features are demonstrated in an example
[n/a] New Features and API Changes are noted with a directive and release note
[n/a] Documentation complies with general and docstring guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

QuLogic added this to the v3.11.0 milestone

Jun 5, 2025

QuLogic added this to Font and text overhaul

Jun 5, 2025

github-project-automation Bot moved this to Waiting for other PR in Font and text overhaul

Jun 5, 2025

github-actions Bot added topic: path handling backend: pdf labels

Jun 5, 2025

QuLogic mentioned this pull request

Jun 5, 2025

Update FreeType to 2.13.3 #29816

Merged

5 tasks

oscargus reviewed

Jun 5, 2025

View reviewed changes

Comment thread

lib/matplotlib/backends/backend_pdf.py Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Remove ttconv backwards-compatibility code

8caff88

oscargus approved these changes

Jun 5, 2025

View reviewed changes

oscargus left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor thing that can be skipped to save CI, but other than that seems fine.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

QuLogic force-pushed the remove-ttconv branch from 3062499 to e9ebb41 Compare

June 5, 2025 07:35

QuLogic moved this from Waiting for other PR to Ready for Review in Font and text overhaul

Jun 5, 2025

tacaswell approved these changes

Jun 19, 2025

View reviewed changes

tacaswell commented Jun 19, 2025

Copy link

Copy Markdown

Member

Please drop the last commit and self-merge.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

QuLogic force-pushed the remove-ttconv branch from e9ebb41 to 8caff88 Compare

June 19, 2025 18:47

QuLogic merged commit 7dafe63 into matplotlib:text-overhaul

Jun 19, 2025

github-project-automation Bot moved this from Ready for Review to Done in Font and text overhaul

Jun 19, 2025

QuLogic deleted the remove-ttconv branch

June 19, 2025 18:49

QuLogic commented Jun 19, 2025

Copy link

Copy Markdown

Member Author

Not going to wait for CI, because it's just going to fail, and then run again when merged, and fail there too...

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

wavebyrd pushed a commit to wavebyrd/matplotlib that referenced this pull request

Mar 13, 2026


          Merge pull request matplotlib#30145 from QuLogic/remove-ttconv

1ab578e

Remove ttconv backwards-compatibility code

QuLogic added a commit to QuLogic/matplotlib that referenced this pull request

Apr 10, 2026


          Update test images for font/text overhaul

12d2a4d

This includes images changes for the following pull requests / commits:

* [Fix center of rotation with
  rotation_mode='anchor'](matplotlib#29199)
  (c44db77)
* [Remove ttconv backwards-compatibility
  code](matplotlib#30145)
  (8caff88)
* [Remove kerning_factor from
  tests](matplotlib#29816)
  (7b4d725)
* [Set text hinting to
  defaults](matplotlib#29816)
  (8255ae2)
* [Update FreeType to
  2.13.3](matplotlib#29816)
  (89c054d)
* [Implement text shaping with
  libraqm](matplotlib#30000)
  (b0ded3a,
  9813523)
* [Add language parameter to Text
  objects](matplotlib#29794)
  (7ce8eae)
* [Fix auto-sized glyphs with BaKoMa
  fonts](matplotlib#29936)
  (3ba2c13)
* [pdf: Improve text with characters outside embedded font
  limits](matplotlib#30512)
  (b70fb88,
  6cedcf7)
* [Prepare `CharacterTracker` for advanced font
  features](matplotlib#30608)
  (8274e17,
  70dc388,
  df670cf,
  ed5e074)
* [Add font feature API to
  Text](matplotlib#29695)
  (972a688)
* [Fix spacing in r"$\max
  f$"](matplotlib#30715)
  (4a99a83)
* [Implement libraqm for vector
  outputs](matplotlib#30607)
  (bd17cd4)
* [Drop the FT2Font intermediate
  buffer](matplotlib#30059)
  (9d7d7b4)
* [Rasterize dvi files without
  dvipng](matplotlib#30039)
  (7627118)
* [Update bundled FreeType and HarfBuzz
  libraries](matplotlib#30938)
  (a161658,
  9619bcc)
* [Fix positioning of wide mathtext
  accents](matplotlib#31069)
  (c2fa7ba)
* [Refactor RendererAgg.draw_{mathtext,text,tex} to use same base
  algorithm](matplotlib#31085)
  (931bcf3)
* [Implement TeX's fraction and script
  alignment](matplotlib#31046)
  (94ff452,
  4bfa0f9,
  1cd8510)
* [Fix confusion between text height and ascent in metrics
  calculations](matplotlib#31107)
  (60f2310)
* [mathtext: Fetch quad width & axis height from font
  metrics](matplotlib#31110)
  (692df3f,
  383028b)
* [mathtext: add mathnormal and distinguish between normal and italic
  family](matplotlib#31121)
  (a6913f3)
* [ENH: Ignore empty text for
  tightbbox](matplotlib#31285)
  (d772043)
* [Drop axis_artist tickdir image compat, due to text-overhaul
  merge](matplotlib#31281)
  (2057583)
* [text: Use font metrics to determine line
  heights](matplotlib#31291)
  (3ab6a27,
  d961462,
  97f4943)
* [ps/pdf: Override font height metrics to support AFM
  files](matplotlib#31371)
  (e0913d4)
* [TST: Cleanup back-compat code in tests touched by text
  overhaul](matplotlib#31295)
  (7c33379)
* [TST: Set tests touched by text overhaul to mpl20
  style](matplotlib#31300)
  (41c4d8d)

QuLogic mentioned this pull request

Apr 10, 2026

Font and text overhaul #30161

Merged

4 tasks done

Reviewers

tacaswell

tacaswell approved these changes

oscargus

oscargus approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

backend: pdf topic: path handling

Projects

Font and text overhaul

Status: Done

Milestone

v3.11.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.