GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Drop axis_artist tickdir image compat, due to text-overhaul merge. by anntzer · Pull Request #31281 · matplotlib/matplotlib

Conversation

@anntzer

@anntzer anntzer commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

Baseline image updates for #30369, taking advantage of the text-overhaul regen to squeeze in the changes. See discussion at #30369 (review). Note that I had to rebase the first (feature-implementing) commit as well, because it already touched the tests.

PR summary

AI Disclosure

PR checklist

  • "closes #0000" is in the body of the PR description to link the related issue
  • new and changed code is tested
  • Plotting related features are demonstrated in an example
  • New Features and API Changes are noted with a directive and release note
  • Documentation complies with general and docstring guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@github-actions github-actions Bot added topic: mpl_toolkit Documentation: examples files in galleries/examples Documentation: user guide files in galleries/users_explain or doc/users labels Mar 11, 2026
@anntzer anntzer mentioned this pull request Mar 11, 2026
Support standard tickdir control (in/out/inout) in axisartist. #30369
Merged
5 tasks
@github-actions github-actions Bot added the status: needs rebase label Mar 11, 2026
QuLogic
QuLogic reviewed Mar 11, 2026
View reviewed changes

@QuLogic QuLogic left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can rebase and drop that first commit now; the original PR has been merged to this branch via main.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread lib/mpl_toolkits/axisartist/tests/test_axislines.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@anntzer
anntzer force-pushed the aiot-tests branch from 99957ce to 69700e6 Compare March 11, 2026 21:26
@github-actions github-actions Bot removed Documentation: examples files in galleries/examples Documentation: user guide files in galleries/users_explain or doc/users status: needs rebase labels Mar 11, 2026
@anntzer

anntzer commented Mar 11, 2026

Copy link
Copy Markdown
Contributor Author

Done (including the style clarification).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
QuLogic
QuLogic reviewed Mar 11, 2026
View reviewed changes
Comment thread lib/mpl_toolkits/axisartist/tests/test_axislines.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread lib/mpl_toolkits/axisartist/tests/test_axislines.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread lib/mpl_toolkits/axisartist/tests/test_grid_helper_curvelinear.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@anntzer
Drop axis_artist tickdir image compat, due to text-overhaul merge.
2057583 
Also replace style='default' by style='mpl20'.
@anntzer
anntzer force-pushed the aiot-tests branch from 69700e6 to 2057583 Compare March 12, 2026 09:47
@tacaswell tacaswell added this to the v3.11.0 milestone Mar 12, 2026
QuLogic
QuLogic approved these changes Mar 12, 2026
View reviewed changes

@QuLogic QuLogic left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, when checking the test images locally.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@QuLogic QuLogic added this to Font and text overhaul Mar 13, 2026
@github-project-automation github-project-automation Bot moved this to Waiting for other PR in Font and text overhaul Mar 13, 2026
@QuLogic QuLogic moved this from Waiting for other PR to Ready for Review in Font and text overhaul Mar 13, 2026
ksunden
ksunden approved these changes Mar 13, 2026
View reviewed changes
@QuLogic
QuLogic merged commit f99a345 into matplotlib:text-overhaul Mar 13, 2026
20 of 36 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@github-project-automation github-project-automation Bot moved this from Ready for Review to Done in Font and text overhaul Mar 13, 2026
@anntzer
anntzer deleted the aiot-tests branch March 13, 2026 21:44
QuLogic added a commit to QuLogic/matplotlib that referenced this pull request Apr 10, 2026
@QuLogic
Update test images for font/text overhaul
12d2a4d 
This includes images changes for the following pull requests / commits:

* [Fix center of rotation with
  rotation_mode='anchor'](matplotlib#29199)
  (c44db77)
* [Remove ttconv backwards-compatibility
  code](matplotlib#30145)
  (8caff88)
* [Remove kerning_factor from
  tests](matplotlib#29816)
  (7b4d725)
* [Set text hinting to
  defaults](matplotlib#29816)
  (8255ae2)
* [Update FreeType to
  2.13.3](matplotlib#29816)
  (89c054d)
* [Implement text shaping with
  libraqm](matplotlib#30000)
  (b0ded3a,
  9813523)
* [Add language parameter to Text
  objects](matplotlib#29794)
  (7ce8eae)
* [Fix auto-sized glyphs with BaKoMa
  fonts](matplotlib#29936)
  (3ba2c13)
* [pdf: Improve text with characters outside embedded font
  limits](matplotlib#30512)
  (b70fb88,
  6cedcf7)
* [Prepare `CharacterTracker` for advanced font
  features](matplotlib#30608)
  (8274e17,
  70dc388,
  df670cf,
  ed5e074)
* [Add font feature API to
  Text](matplotlib#29695)
  (972a688)
* [Fix spacing in r"$\max
  f$"](matplotlib#30715)
  (4a99a83)
* [Implement libraqm for vector
  outputs](matplotlib#30607)
  (bd17cd4)
* [Drop the FT2Font intermediate
  buffer](matplotlib#30059)
  (9d7d7b4)
* [Rasterize dvi files without
  dvipng](matplotlib#30039)
  (7627118)
* [Update bundled FreeType and HarfBuzz
  libraries](matplotlib#30938)
  (a161658,
  9619bcc)
* [Fix positioning of wide mathtext
  accents](matplotlib#31069)
  (c2fa7ba)
* [Refactor RendererAgg.draw_{mathtext,text,tex} to use same base
  algorithm](matplotlib#31085)
  (931bcf3)
* [Implement TeX's fraction and script
  alignment](matplotlib#31046)
  (94ff452,
  4bfa0f9,
  1cd8510)
* [Fix confusion between text height and ascent in metrics
  calculations](matplotlib#31107)
  (60f2310)
* [mathtext: Fetch quad width & axis height from font
  metrics](matplotlib#31110)
  (692df3f,
  383028b)
* [mathtext: add mathnormal and distinguish between normal and italic
  family](matplotlib#31121)
  (a6913f3)
* [ENH: Ignore empty text for
  tightbbox](matplotlib#31285)
  (d772043)
* [Drop axis_artist tickdir image compat, due to text-overhaul
  merge](matplotlib#31281)
  (2057583)
* [text: Use font metrics to determine line
  heights](matplotlib#31291)
  (3ab6a27,
  d961462,
  97f4943)
* [ps/pdf: Override font height metrics to support AFM
  files](matplotlib#31371)
  (e0913d4)
* [TST: Cleanup back-compat code in tests touched by text
  overhaul](matplotlib#31295)
  (7c33379)
* [TST: Set tests touched by text overhaul to mpl20
  style](matplotlib#31300)
  (41c4d8d)
@QuLogic QuLogic mentioned this pull request Apr 10, 2026
Font and text overhaul #30161
Merged
4 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuLogic QuLogic QuLogic approved these changes
@ksunden ksunden ksunden approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic: mpl_toolkit

Projects

Font and text overhaul
Status: Done

Milestone

v3.11.0

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@anntzer @QuLogic @ksunden @tacaswell
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.