GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — docs: fix Buffer.allocUnsafeSlow is added in 5.12.0 instead of 5.10.0 by tuananh · Pull Request #15330 · nodejs/node

Conversation

@tuananh

@tuananh tuananh commented Sep 11, 2017

Copy link
Copy Markdown
Contributor

Updating docs: Buffer.allocUnsafeSlow() is added in v5.12.0 instead of 5.10.0

Fixed: #15279

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

None

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@tuananh
docs: fix Buffer.allocUnsafeSlow is added in 5.12.0 instead of 5.10.0
c6e42b1
@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to Node.js documentation. labels Sep 11, 2017
jasnell
jasnell approved these changes Sep 12, 2017
View reviewed changes
richardlau
richardlau approved these changes Sep 12, 2017
View reviewed changes
cjihrig
cjihrig approved these changes Sep 12, 2017
View reviewed changes
lpinca
lpinca approved these changes Sep 12, 2017
View reviewed changes
@vsemozhetbyt vsemozhetbyt mentioned this pull request Sep 13, 2017
doc: fix incorrect api version for Buffer.allocUnsafeSlow #15392
Closed
1 of 4 tasks
vsemozhetbyt pushed a commit that referenced this pull request Sep 13, 2017
@tuananh @vsemozhetbyt
doc: fix "added in" for Buffer.allocUnsafeSlow()
0dad97c
PR-URL: #15330
Fixes: #15279
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@vsemozhetbyt

vsemozhetbyt commented Sep 13, 2017

Copy link
Copy Markdown
Contributor

Basing on this comment in identical PR, landed in 0dad97c

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vsemozhetbyt vsemozhetbyt closed this Sep 13, 2017
@vsemozhetbyt

vsemozhetbyt commented Sep 13, 2017

Copy link
Copy Markdown
Contributor

@tuananh Thank you for the contribution!

tuananh reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

addaleax pushed a commit to addaleax/ayo that referenced this pull request Sep 17, 2017
@tuananh @addaleax
doc: fix "added in" for Buffer.allocUnsafeSlow()
2d2c5d6
PR-URL: nodejs/node#15330
Fixes: nodejs/node#15279
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
jasnell pushed a commit that referenced this pull request Sep 20, 2017
@tuananh @jasnell
doc: fix "added in" for Buffer.allocUnsafeSlow()
b0f5b2a
PR-URL: #15330
Fixes: #15279
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@jasnell jasnell mentioned this pull request Sep 20, 2017
Node.js 8.6.0 Release Proposal #15509
Merged
Qard pushed a commit to Qard/ayo that referenced this pull request Sep 21, 2017
@tuananh Stephen Belanger
doc: fix "added in" for Buffer.allocUnsafeSlow()
e8e1d8f
PR-URL: nodejs/node#15330
Fixes: nodejs/node#15279
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 17, 2017
@tuananh @MylesBorins
doc: fix "added in" for Buffer.allocUnsafeSlow()
bf13007
PR-URL: #15330
Fixes: #15279
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@MylesBorins MylesBorins added the land-on-v6.x label Oct 17, 2017
@MylesBorins MylesBorins mentioned this pull request Oct 17, 2017
v6.12.0 proposal #16263
Merged
MylesBorins pushed a commit that referenced this pull request Oct 25, 2017
@tuananh @MylesBorins
doc: fix "added in" for Buffer.allocUnsafeSlow()
0b2d548
PR-URL: #15330
Fixes: #15279
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 3, 2017
v4.8.6 proposal #16500
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@lpinca lpinca lpinca approved these changes
@cjihrig cjihrig cjihrig approved these changes
@richardlau richardlau richardlau approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@tuananh @vsemozhetbyt @jasnell @lpinca @cjihrig @richardlau @MylesBorins @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.