GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — build: move doc versions JSON file out of out/doc by richardlau · Pull Request #32728 · nodejs/node

Conversation

@richardlau

@richardlau richardlau commented Apr 8, 2020

Copy link
Copy Markdown
Member

Move the generated previous doc versions JSON file out of out/doc to
prevent it being included in the distributed packages.

Fixes: nodejs/build#2276

cc @codebytere

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to Node.js builds or CI infrastructure. label Apr 8, 2020
@richardlau richardlau mentioned this pull request Apr 8, 2020
v12.x LTS expected assets need updating nodejs/build#2276
Closed
@richardlau richardlau added lts-watch-v10.x labels Apr 8, 2020
@nodejs-github-bot

nodejs-github-bot commented Apr 8, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30572/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
codebytere
codebytere approved these changes Apr 8, 2020
View reviewed changes
@codebytere codebytere mentioned this pull request Apr 8, 2020
ansible: add new expected docs asset for v12.x nodejs/build#2277
Closed
@nodejs-github-bot

nodejs-github-bot commented Apr 9, 2020 •
edited by richardlau
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30593/ (✅)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott approved these changes Apr 9, 2020
View reviewed changes
@richardlau richardlau added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Apr 9, 2020
lpinca
lpinca approved these changes Apr 9, 2020
View reviewed changes
gengjiawen
gengjiawen approved these changes Apr 10, 2020
View reviewed changes
@richardlau
richardlau force-pushed the doccache branch from 26601ff to 2cffab9 Compare April 11, 2020 11:04
@richardlau
build: move doc versions JSON file out of out/doc
ce21749 
Move the generated previous doc versions JSON file out of `out/doc` to
prevent it being included in the distributed packages.

Signed-off-by: Richard Lau <[email protected]>

PR-URL: nodejs#32728
Fixes: nodejs/build#2276
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@richardlau
richardlau force-pushed the doccache branch from 2cffab9 to ce21749 Compare April 11, 2020 11:07
@richardlau
richardlau merged commit ce21749 into nodejs:master Apr 11, 2020
@richardlau

richardlau commented Apr 11, 2020

Copy link
Copy Markdown
Member Author

Landed in ce21749.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@richardlau
richardlau deleted the doccache branch April 11, 2020 11:08
@BethGriggs BethGriggs mentioned this pull request Apr 12, 2020
Update expected assets for v10.x and add v14.x nodejs/build#2278
Merged
targos pushed a commit that referenced this pull request Apr 13, 2020
@richardlau @targos
build: move doc versions JSON file out of out/doc
f9a2276 
Move the generated previous doc versions JSON file out of `out/doc` to
prevent it being included in the distributed packages.

Signed-off-by: Richard Lau <[email protected]>

PR-URL: #32728
Fixes: nodejs/build#2276
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@targos targos mentioned this pull request Apr 13, 2020
v13.13.0 release proposal #32813
Merged
BethGriggs pushed a commit that referenced this pull request Apr 14, 2020
@richardlau @BethGriggs
build: move doc versions JSON file out of out/doc
3c4d1f6 
Move the generated previous doc versions JSON file out of `out/doc` to
prevent it being included in the distributed packages.

Signed-off-by: Richard Lau <[email protected]>

PR-URL: #32728
Fixes: nodejs/build#2276
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
richardlau added a commit that referenced this pull request Apr 17, 2020
@richardlau
build: move doc versions JSON file out of out/doc
a85721a 
Move the generated previous doc versions JSON file out of `out/doc` to
prevent it being included in the distributed packages.

Signed-off-by: Richard Lau <[email protected]>

PR-URL: #32728
Fixes: nodejs/build#2276
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
targos pushed a commit that referenced this pull request Apr 22, 2020
@richardlau @targos
build: move doc versions JSON file out of out/doc
c98aa93 
Move the generated previous doc versions JSON file out of `out/doc` to
prevent it being included in the distributed packages.

Signed-off-by: Richard Lau <[email protected]>

PR-URL: #32728
Fixes: nodejs/build#2276
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@targos targos mentioned this pull request Apr 22, 2020
v12.16.3 release proposal #33009
Merged
BethGriggs pushed a commit that referenced this pull request Jun 2, 2020
@richardlau @BethGriggs
build: move doc versions JSON file out of out/doc
145dcc2 
Move the generated previous doc versions JSON file out of `out/doc` to
prevent it being included in the distributed packages.

Signed-off-by: Richard Lau <[email protected]>

PR-URL: #32728
Fixes: nodejs/build#2276
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@richardlau richardlau added backported-to-v12.x and removed lts-watch-v12.x labels Jul 1, 2020
@richardlau richardlau added backported-to-v10.x and removed lts-watch-v10.x labels Jul 1, 2020
@richardlau richardlau mentioned this pull request Jul 2, 2020
v10.22.0 proposal #34170
Merged
2 of 4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@lpinca lpinca lpinca approved these changes
@codebytere codebytere codebytere approved these changes
@gengjiawen gengjiawen gengjiawen approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. build Issues and PRs related to Node.js builds or CI infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

v12.x LTS expected assets need updating

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@richardlau @nodejs-github-bot @Trott @lpinca @codebytere @gengjiawen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.