GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — doc: add note about resource type in async_hooks by tony-go · Pull Request #41797 · nodejs/node

Conversation

tony-go commented Jan 31, 2022

Copy link

Copy Markdown

Member

Hi everyone 👋

During the last Diagnostic WG meeting, the question has been raised of the type argument interface (async_hooks / init hook).

The initial demand was to document more precisely each type. But @bmeck mentions that this list of identifiers described in the documentation could arbitrarily change.

So, this pull request contains a note to explicitly tell users what is the status of these identifiers.

CC @RafaelGSS / @gireeshpunathil

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss reacted with eyes emoji

All reactions

👀 1 reaction

nodejs-github-bot added async_hooks

Issues and PRs related to the async hooks subsystem.

doc Issues and PRs related to Node.js documentation. labels

Jan 31, 2022

Trott commented Feb 1, 2022 •

edited by Mesteery

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Welcome @tony-go and thanks for the pull request. Are you able to edit the first commit message? The first word after doc: should be a verb so perhaps this? doc: add note about resource type

tony-go reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

tony-go added 2 commits

February 1, 2022 11:11


          doc: add note about resource type in async_hooks

385ddae


          doc: lint file

e1aff5c

tony-go force-pushed the async-hooks-doc-type branch from cdbda7b to e1aff5c Compare

February 1, 2022 10:12

tony-go commented Feb 1, 2022

Copy link

Copy Markdown

Member Author

Thanks for the feedback @Trott 🙌.

Let me know if it's good now.

Trott reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

RafaelGSS approved these changes

Feb 1, 2022

View reviewed changes

RafaelGSS left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

tony-go reacted with thumbs up emoji

All reactions

👍 1 reaction

RafaelGSS commented Feb 1, 2022

Copy link

Copy Markdown

Member

cc: @Qard

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Qard approved these changes

Feb 1, 2022

View reviewed changes

Trott changed the title ~~doc: async_hooks - add note about resource type~~ doc: add note about resource type in async_hooks

Feb 1, 2022

Trott reviewed

Feb 1, 2022

View reviewed changes

Comment thread

doc/api/async_hooks.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Trott reviewed

Feb 1, 2022

View reviewed changes

Comment thread

doc/api/async_hooks.md Resolved

Uh oh!

There was an error while loading. Please reload this page.


          doc: fix note about resource type

bac310c

tony-go requested a review from Trott

February 1, 2022 20:50

Trott reviewed

Feb 1, 2022

View reviewed changes

Comment thread

doc/api/async_hooks.md Resolved

Uh oh!

There was an error while loading. Please reload this page.


          doc: delete useless note makrer

b2622ce

Co-authored-by: Rich Trott <[email protected]>

RaisinTen approved these changes

Feb 2, 2022

View reviewed changes

RaisinTen left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

tony-go reacted with thumbs up emoji

All reactions

👍 1 reaction

Trott approved these changes

Feb 2, 2022

View reviewed changes

Trott added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label

Feb 2, 2022

Trott commented Feb 2, 2022

Copy link

Copy Markdown

Member

@nodejs/async_hooks

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Flarna reviewed

Feb 2, 2022

View reviewed changes

Comment thread

doc/api/async_hooks.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Flarna approved these changes

Feb 2, 2022

View reviewed changes

vdeturckheim approved these changes

Feb 2, 2022

View reviewed changes


          doc: add note details

95e1349

Flarna approved these changes

Feb 2, 2022

View reviewed changes

Flarna added commit-queue-squash

PRs the Commit Queue should land as one squashed commit.

commit-queue PRs queued for automated landing through the Commit Queue. labels

Feb 3, 2022

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label

Feb 3, 2022

nodejs-github-bot merged commit 064783c into nodejs:master

Feb 3, 2022

nodejs-github-bot commented Feb 3, 2022

Copy link

Copy Markdown

Collaborator

Landed in 064783c

tony-go reacted with hooray emoji

All reactions

🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ruyadorno pushed a commit that referenced this pull request

Feb 8, 2022


          doc: add note about resource type in async_hooks

4db343b

PR-URL: #41797
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Vladimir de Turckheim <[email protected]>

ruyadorno mentioned this pull request

Feb 8, 2022

v17.5.0 release proposal #41897

Merged

danielleadams pushed a commit that referenced this pull request

Mar 2, 2022


          doc: add note about resource type in async_hooks

f5e4443

PR-URL: #41797
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Vladimir de Turckheim <[email protected]>

danielleadams mentioned this pull request

Mar 3, 2022

v16.14.1 release proposal #42200

Merged

danielleadams pushed a commit that referenced this pull request

Mar 3, 2022


          doc: add note about resource type in async_hooks

e5a6e46

PR-URL: #41797
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Vladimir de Turckheim <[email protected]>

danielleadams pushed a commit that referenced this pull request

Mar 14, 2022


          doc: add note about resource type in async_hooks

44b6927

PR-URL: #41797
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Vladimir de Turckheim <[email protected]>

Reviewers

Qard

Qard approved these changes

Trott

Trott approved these changes

Flarna

Flarna approved these changes

RafaelGSS

RafaelGSS approved these changes

RaisinTen

RaisinTen approved these changes

+1 more reviewer

vdeturckheim

vdeturckheim approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

async_hooks

Issues and PRs related to the async hooks subsystem.

author ready

PRs with CI started, the required approvals, and no outstanding review comments.

commit-queue-squash

PRs the Commit Queue should land as one squashed commit.

doc

Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

tony-go commented Jan 31, 2022

Uh oh!

Trott commented Feb 1, 2022 • edited by Mesteery Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tony-go commented Feb 1, 2022

Uh oh!

RafaelGSS left a comment

Choose a reason for hiding this comment

Uh oh!

RafaelGSS commented Feb 1, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

RaisinTen left a comment

Choose a reason for hiding this comment

Uh oh!

Trott commented Feb 2, 2022

Uh oh!

Uh oh!

nodejs-github-bot commented Feb 3, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Trott commented Feb 1, 2022 •

edited by Mesteery

Loading

Uh oh!

There was an error while loading. Please reload this page.