GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — v17.6.0 release proposal by bengl · Pull Request #42072 · nodejs/node

Conversation

bengl commented Feb 21, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

2022-02-22, Version 17.6.0 (Current), @BethGriggs prepared by @bengl

Notable Changes

[6b88595142] - doc: deprecate notice for process methods (Yash Ladha) #41587
[77462b6083] - stream: revert map spec compliance (Benjamin Gruenbaum) #41931
[b968d89fc9] - build: remove broken x32 arch support (Ben Noordhuis) #41905
[ba639d052b] - (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) #36328
[214d17650b] - (SEMVER-MINOR) fs: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) #41819
[ec0d623bd7] - (SEMVER-MINOR) lib: add FormData global when fetch is enabled (Michaël Zasso) #41956
[3243701997] - (SEMVER-MINOR) readline: bind keystroke ctrl+6 to redo (Ray) #41662
[5796c3a7ea] - process: deprecate multipleResolves (Benjamin Gruenbaum) #41872
- Documentation-only.

Dependency Updates

[d1ef43f2aa] - deps: upgrade npm to 8.5.1 (npm-robot) #42039
[09c17481f6] - deps: update undici to 3e267ece5f (Michaël Zasso) #41955
[0a6f0b416f] - deps: upgrade npm to 8.5.0 (npm-robot) #41925

New Collaborators

[90d90e3868] - doc: add marsonya to collaborators (Akhil Marsonya) #41991
[0de611f53a] - doc: add joesepi to collaborators (Joe Sepi) #41914

Commits

[a93462a719] - build: cancel running CI jobs when a PR is updated (Michaël Zasso) #42017
[0cc1a27636] - build: increase operations and test tag (Michael Dawson) #42038
[f49fe215c4] - build: allow manual run of feature request action (Michael Dawson) #42037
[b57b3056ff] - build: add action to close stale feature requests (Michael Dawson) #41981
[fc649fa289] - build: prevent concurrent CI and CQ workflow runs (Michaël Zasso) #42016
[e2d1eb8e49] - build: use zoslib_include_dir provided by node-gyp (alexcfyung) #41713
[2b329dab2c] - build: move tool updates workflow runtime a day later (Rich Trott) #41982
[b2fc45078e] - build: extend yamllint configuration (Mestery) #41756
[b968d89fc9] - build: remove broken x32 arch support (Ben Noordhuis) #41905
[2b1dabfb16] - build: revert fast-track changes (Filip Skokan) #41892
[182e6b9ee9] - build: improve consistency between workflows (Mestery) #41791
[8af4d31e0f] - build,tools: change the quotes in YAML (Mestery) #41756
[1c404bdb8f] - child_process: kHideConsoleWindows for spawnSync (Raymond Zhao) #41412
[c41e402c06] - cluster: respect listen backlog set by workers (Elad Nava) #41623
[f47a0699a2] - crypto: check result of BIO_new in X509ToObject (Tobias Nießen) #41979
[ce99600782] - crypto: rename X509_NAME_FLAGS (Tobias Nießen) #42001
[88cbceb3ca] - (SEMVER-MINOR) crypto: expose Web Crypto API on the global scope (Antoine du Hamel) #41938
[0fff4d2314] - crypto: do not advertise unsupported algorithms (Brian White) #41864
[e4f0d95ec0] - debugger: add debugger alias for exec(expr) (Xuguang Mei) #41907
[b5fd25b1f6] - debugger: remove duplicate setPauseOnException call (Balakrishna Avulapati) #41838
[811f04bd34] - deps: upgrade npm to 8.5.1 (npm-robot) #42039
[605271ba8c] - deps: update undici to 3e267ece5f (Michaël Zasso) #41955
[0a6f0b416f] - deps: upgrade npm to 8.5.0 (npm-robot) #41925
[0ae2b0e6b0] - doc: fix typo in http2 endAfterHeaders description (Alexandru Comanescu) #42060
[9ab2e217e3] - doc: make minor fixes to contributing guides (T-O-R-U-S) #41966
[7c55d64bb5] - doc: use openpgp.org for keyserver examples (Nick Schonning) #39227
[e2ae5d4d8b] - doc: adjust a/an word usage (Derek Wolpert) #41915
[28cd39edf9] - doc: remove extra <td> (Ray) #42006
[df359a0665] - doc: capitalize valgrind (T•Ø•R•Ü•S) #41986
[87a7b4248f] - doc: fix deprecation number (Antoine du Hamel) #41990
[7c19c7496e] - doc: add marsonya to collaborators (Akhil Marsonya) #41991
[326f54576a] - doc: deprecate notice for process methods (Yash Ladha) #41587
[4c0ad1c630] - doc: fix bug in readable.unshift code example (Xuguang Mei) #41944
[02548adac8] - doc: add missing buffer in the stream/consumers import example (Mestery) #41961
[1b7359d03c] - doc: fix typo in readableStream.locked description (Tobias Nießen) #41923
[529686e540] - doc: fix wrong indent in stream documentation (Xuguang Mei) #41943
[5ec1a20895] - doc: emphasize security warning in vm module doc (Rich Trott) #41916
[4883904ccb] - doc: clarify tls.Server 'connection' event documentation (Austin Cheney) #41917
[63cc999b9c] - doc: improve scrollbar appearance in dark mode (Aaron Xie) #41890
[aa684a78fe] - doc: replace text with paths in toggle SVGs (Brian White) #41885
[fc9d4e96c1] - doc: edit process.config deprecation text (Rich Trott) #41889
[0de611f53a] - doc: add joesepi to collaborators (Joe Sepi) #41914
[ba5cb89134] - doc: remove unneeded ellipsis in header (Rich Trott) #41888
[291fe631dd] - doc: fix webstream close reject state state doc (Benjamin Gruenbaum) #41860
[72cb44b386] - esm: improve fetch_module test coverage and remove hack (Antoine du Hamel) #41947
[010dd4c1bd] - esm: remove erroneous context.parentURL property passed to load hook (Jacob Smith) #41975
[eb2f821030] - esm: fix typo in fetch_module (Michael Scovetta) #41924
[ba639d052b] - (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) #36328
[f6c6d7d0a8] - events: set default handler value (Benjamin Gruenbaum) #41970
[10ca3bb922] - fs: fix default length parameter for fs.read (wbt) #40349
[1e862b3816] - (SEMVER-MINOR) fs: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) #41819
[5fa4455880] - fs: fix cb/sync writev empty array behavior (Benjamin Gruenbaum) #41932
[7b01a371e1] - fs: fix writev empty array error behavior (Benjamin Gruenbaum) #41919
[7fca10ffab] - fs: refactor to use ES2020 syntax (小菜) #41903
[4fbe064ce0] - (SEMVER-MINOR) lib: add FormData global when fetch is enabled (Michaël Zasso) #41956
[53e2e8c835] - lib: stop installing webcrypto if no_browser_globals is true (Mestery) #41971
[ec5b594231] - lib: allow respondWithNewView on byob auto allocated streams (Sean Quinlan) #41887
[8c912ab154] - lib: stop installing fetch if no_browser_globals is true (Darshan Sen) #41969
[7fc68f9a42] - lib: restrict usage of fetch related globals in core internals (Antoine du Hamel) #41957
[5ede4588ec] - lib: move kEnumerableProperty to internal/util (Mestery) #41877
[fa3a9135ad] - lib: add internal genericNodeError() function (Rich Trott) #41879
[3a03e2720e] - meta: update AUTHORS (Node.js GitHub Bot) #42058
[224745c78b] - meta: use plain emojis instead of escape sequences (Mestery) #41989
[25f52c3496] - meta: update AUTHORS and .mailmap (Rich Trott) #41953
[fb750d6402] - perf_hooks: use arrays to store EntryBuffers (Xuguang Mei) #42032
[5796c3a7ea] - process: deprecate multipleResolves (Benjamin Gruenbaum) #41872
[3243701997] - (SEMVER-MINOR) readline: bind keystroke ctrl+6 to redo (Ray) #41662
[c766159e68] - repl: REPL gives wrong autocomplete on literals #41690 REPL gives wrong autocomplete on literals (Xuguang Mei) #41883
[f5f790be1e] - src: merge ToJsSet into ToV8Value (Anna Henningsen) #41757
[eeb3a68a50] - src: remove separate definitions for static constexpr members (Anna Henningsen) #41755
[7395de0078] - src: use const reference instead of pointer in URL::SerializeURL (Anna Henningsen) #41759
[470f870dd0] - src: reserve string allocation space early in URL::SerializeURL (Anna Henningsen) #41759
[554cd2c27b] - src: fix query/fragment serialization in URL::SerializeURL (Anna Henningsen) #41759
[6076291168] - src: don't print interface if sin6_scope_id is 0 (Santiago Gimeno) #41547
[047d4de08b] - src,buffer: evaluate THROW_AND_RETURN_IF_OOB() expression only once (Darshan Sen) #41945
[50a0a22835] - stream: add more forEach tests (Benjamin Gruenbaum) #41937
[6c9a36c7fb] - stream: add more filter tests (Benjamin Gruenbaum) #41936
[abd6967153] - stream: revert map spec compliance (Benjamin Gruenbaum) #41931
[e57267b67d] - stream: avoid usage of deprecated APIs (Mohammed Keyvanzadeh) #41871
[308d31d173] - stream: refactor to use more validators (Mohammed Keyvanzadeh) #41871
[7f69973208] - stream: use standard for loop instead of for..of (Mohammed Keyvanzadeh) #41871
[e412b23800] - test: remove test-stdout-close-catch flaky designation (Rich Trott) #42045
[ce23738279] - test: check that fetch globals are disabled by default (Michaël Zasso) #42015
[0461729120] - test: improve vm test coverage (Yoshiki Kurihara) #41847
[c59dd984a3] - test: run webmessaging/broadcastchannel WPT (Ben Noordhuis) #41962
[dfed49879a] - test: fix names of tests marked flaky on IBM i (Richard Lau) #41984
[f1009ae9f9] - test: fix typographical error (Rich Trott) #41983
[8cf918125c] - test: fix intl tests on small-icu builds (Antoine du Hamel) #41939
[f4304ea941] - test: improve code coverage for streams/duplexify (Erick Wendel) #41862
[dc14bd85ee] - test: remove lint rule for setTimeout() arguments (Rich Trott) #41901
[76f0f1c06d] - test: move test-crypto-engine to addon (Michael Dawson) #41830
[c498a72cff] - tls: avoid throw in onerror for bad TLSSocket obj (Valters Jansons) #41523
[48fa1e5671] - tools: enable es2022 env in ESLint config (Michaël Zasso) #42043
[0f4f2ddfc2] - tools: add console to the list of restricted globals (Antoine du Hamel) #42012
[dcb51b0a48] - tools: lint deprecation codes (Antoine du Hamel) #41992
[98167e884b] - tools: fix bugs in prefer-primordials linter rule (Antoine du Hamel) #42010
[01618c621e] - tools: add timers functions to the list of restricted globals (Antoine du Hamel) #42013
[297d217efc] - tools: reduce list of globals in ESLint config (Rich Trott) #41996
[916cda4afc] - tools: update remark-preset-lint-node to 3.3.1 (Rich Trott) #41999
[7a72aa776a] - tools: update ESLint to 8.9.0 (Luigi Pinca) #41973
[0c4977cf29] - tools: update lint-md-dependencies to [email protected] (Node.js GitHub Bot) #41941
[f30b5e3a6d] - tools: fix typo in prefer-primordials.js (Ikko Ashimine) #41891
[a87fa5b1c7] - tools,lib: remove global and Intl from the list of globals (Antoine du Hamel) #42014
[a4420d379e] - worker: fix typo in debug statement (Antoine du Hamel) #42011

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss, hello-smile6, rayw000, and ErickWendel reacted with thumbs up emoji

bricss, hello-smile6, rayw000, and ErickWendel reacted with heart emoji

bricss and hello-smile6 reacted with rocket emoji

bricss and hello-smile6 reacted with eyes emoji

All reactions

👍 4 reactions
❤️ 4 reactions
🚀 2 reactions
👀 2 reactions

npm-robot and others added 20 commits

February 11, 2022 23:27


          deps: upgrade npm to 8.5.0

0a6f0b4

PR-URL: #41925
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mestery <[email protected]>


          readline: bind keystroke ctrl+6 to redo

1. Any keystroke emits `0x1E` will do redo action.
2. Fix bug of undo/redo.
3. More detailed document.
4. Unit tests.

PR-URL: #41662
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>


          build: improve consistency between workflows

182e6b9

PR-URL: #41791
Reviewed-By: Mary Marchini <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>


          test: move test-crypto-engine to addon

76f0f1c

Fixes: #41633
Fixes: #40958

- move test-crypto-engine so that dummy engine
  is only built if tests are run

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #41830
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>


          crypto: do not advertise unsupported algorithms

0fff4d2

Fixes: #41857

PR-URL: #41864
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>


          process: deprecate multipleResolves

5796c3a

Deprecate the process multipleResolves event to detect when a promise is
resolved more than once because it never really worked.

Fixes: #41554

PR-URL: #41872
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Mestery <[email protected]>


          build: revert fast-track changes

2b1dabf

PR-URL: #41892
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>


          doc: fix webstream close reject state state doc

291fe63

The `closed` promise may reject. Document the states where it rejects
based on the spec.

Fixes: #41858

PR-URL: #41860
Co-Authored-By: Mattias Buelens <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>


          tools: fix typo in prefer-primordials.js

f30b5e3

replacable -> replaceable

PR-URL: #41891
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>


          doc: remove unneeded ellipsis in header

ba5cb89

The ellipsis in `All together` is not needed. I've had it on my list of
"small things to take care of when you get a chance" for a while. The
Microsoft Style Guide says to not use ellipses except in certain cases,
and that reminded me to do it. The day has arrived!

PR-URL: #41888
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>


          lib: add internal genericNodeError() function

fa3a913

There are a few places in lib where `new Error()` is called and then
additional properties are attached in various ways. This creates a
utility function to generate the errors.

PR-URL: #41879
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>


          doc: add joesepi to collaborators

0de611f

Fixes: #41671

PR-URL: #41914
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Richard Lau <[email protected]>


          repl: #41690 REPL gives wrong autocomplete on literals

c766159

Fixes: #41690

PR-URL: #41883
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mestery <[email protected]>


          esm: support https remotely and http locally under flag

ba639d0

Co-authored-by: Jacob Smith <[email protected]>
Co-authored-by: James M Snell <[email protected]>
Co-authored-by: Jordan Harband <[email protected]>
Co-authored-by: James Sumners <[email protected]>
PR-URL: #36328
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>


          doc: edit process.config deprecation text

fc9d4e9

PR-URL: #41889
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>


          doc: replace text with paths in toggle SVGs

aa684a7

Fixes: #41878

PR-URL: #41885
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>


          cluster: respect listen backlog set by workers

c41e402

PR-URL: #41623
Co-authored-by: Ouyang Yadong <[email protected]>
Reviewed-By: Ouyang Yadong <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>


          test: remove lint rule for setTimeout() arguments

dc14bd8

With the introduction of the promises API for setTimeout(), the
requirement that it have two parameters may not be sensible anymore in
tests.

PR-URL: #41901
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>


          build: remove broken x32 arch support

b968d89

I added support for x32 back in 2014 but it's been in a state of
disrepair ever since, not in the least because it was never a fully
supported architecture in upstream V8.

V8 dropped x32 support entirely in or around 2018 so the removal from
Node's build system is long overdue.

Refs: #40576

PR-URL: #41905
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>


          src: don't print interface if sin6_scope_id is 0

An interface with index 0 doesn't make sense and makes
`if_indextoname()` to return `ENXIO` which crashes the process.

Fixes: #41500

PR-URL: #41547
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>

nodejs-github-bot commented Feb 21, 2022

Copy link

Copy Markdown

Collaborator

Review requested:

@nodejs/actions

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot added meta

Issues and PRs related to the general management of the project.

tools

Issues and PRs related to the tools directory.

v17.x labels

Feb 21, 2022

bengl force-pushed the v17.6.0-proposal branch from 9ec97b0 to 536e3ab Compare

February 21, 2022 16:56

bengl added a commit that referenced this pull request

Feb 21, 2022


          2022-02-22, Version 17.6.0 (Current), @bengl

536e3ab

Notable changes:

* [bdbe655] - doc: add marsonya to collaborators (Akhil Marsonya) #41991
* [8fe8dee] - doc: deprecate notice for process methods (Yash Ladha) #41587
* [abd6967] - stream: revert `map` spec compliance (Benjamin Gruenbaum) #41931
* [b968d89] - build: remove broken x32 arch support (Ben Noordhuis) #41905
* [ba639d0] - (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) #36328
* [0de611f] - doc: add joesepi to collaborators (Joe Sepi) #41914
* [5796c3a] - process: deprecate multipleResolves (Benjamin Gruenbaum) #41872

PR-URL: #42072

richardlau reviewed

Feb 21, 2022

View reviewed changes

Comment thread

doc/changelogs/CHANGELOG_V17.md Outdated


		<a id="17.6.0"></a>

		## 2022-02-22, Version 17.6.0 (Current), @bengl

richardlau Feb 21, 2022

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously we've done a @releaser prepared by @potential-new-releaser format, e.g.:
https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V14.md#2020-10-07-version-14131-current-bethgriggs-prepared-by-danielleadams

Suggested change

	## 2022-02-22, Version 17.6.0 (Current), @bengl
	## 2022-02-22, Version 17.6.0 (Current), @BethGriggs prepared by @bengl

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

targos commented Feb 21, 2022

Copy link

Copy Markdown

Member

The commit message should not contain the releaser's handle.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bengl force-pushed the v17.6.0-proposal branch from 536e3ab to 283a61f Compare

February 21, 2022 17:55

targos and others added 3 commits

February 22, 2022 11:38


          tools: enable es2022 env in ESLint config

This adds more globals to the set known by ESLint.

PR-URL: #42043
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>


          perf_hooks: use arrays to store EntryBuffers

391f4e5

Also order entries by startTime when calling getEntriesByType.

Fix: #42004
Fix: #42024

PR-URL: #42032
Fixes: #42004
Fixes: #42024
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>


          tools: update lint-md-dependencies to [email protected]

2cdbf03

PR-URL: #42057
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>

richardlau commented Feb 22, 2022

Copy link

Copy Markdown

Member

Looks like these two tests are consistently crashing the debug builds 😞 : test.parallel/test-domain-error-types test.parallel/test-worker-heap-snapshot

From the #nodejs-release Slack thread it looks like these tests were introduced by #41818. Complicating things is that after nodejs/build#2837 (comment) we're no longer running x64 debug builds on master -- instead we're running debug builds on arm64. There was some allusion to flakiness in #41818 (review) which links through to #41204 which mentions that the crash went away in a V8 update which is not likely to land on v17.x. We probably want to hold off landing #41818 on v17.x-staging for now.

ErickWendel and bricss reacted with thumbs up emoji

All reactions

👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bengl force-pushed the v17.6.0-proposal branch from caadf9d to 39ae944 Compare

February 22, 2022 16:44

bengl added a commit that referenced this pull request

Feb 22, 2022


          2022-02-22, Version 17.6.0 (Current)

39ae944

Notable changes:

- doc: deprecate notice for process methods (Yash Ladha) #41587
- stream: revert `map` spec compliance (Benjamin Gruenbaum) #41931
- build: remove broken x32 arch support (Ben Noordhuis) #41905
- (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) #36328
- (SEMVER-MINOR) fs: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) #41819
- (SEMVER-MINOR) lib: add FormData global when fetch is enabled (Michaël Zasso) #41956
- (SEMVER-MINOR) readline: bind keystroke `ctrl`+`6` to redo (Ray) #41662
- process: deprecate multipleResolves (Benjamin Gruenbaum) #41872
  - Documentation-only.

Dependency updates:

- deps: upgrade npm to 8.5.1 (npm-robot) #42039
- deps: update undici to 3e267ece5f (Michaël Zasso) #41955
- deps: upgrade npm to 8.5.0 (npm-robot) #41925

New collaborators:

- doc: add marsonya to collaborators (Akhil Marsonya) #41991
- doc: add joesepi to collaborators (Joe Sepi) #41914

PR-URL: #42072

bengl commented Feb 22, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member Author

New CI: https://ci.nodejs.org/job/node-test-pull-request/42724/
New V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4527/ ✅
New CITGM: https://ci.nodejs.org/job/citgm-smoker/2858/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bengl mentioned this pull request

Feb 22, 2022

worker: improve code coverage #41818

Merged

This comment was marked as outdated.

nodejs-github-bot commented Feb 22, 2022 •

edited by BethGriggs

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42724/ ✅

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

BethGriggs commented Feb 22, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

~~Release build on 39ae944: https://ci-release.nodejs.org/job/iojs+release/8265~~
~~Release build on 6c7f3040bd: https://ci-release.nodejs.org/job/iojs+release/8266~~
Release build on 972dd0a: https://ci-release.nodejs.org/job/iojs+release/8267/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

BethGriggs approved these changes

Feb 22, 2022

View reviewed changes

richardlau reviewed

Feb 22, 2022

View reviewed changes

Comment thread

doc/changelogs/CHANGELOG_V17.md Outdated

		* \[[`297d217efc`](https://github.com/nodejs/node/commit/297d217efc)] - tools: reduce list of globals in ESLint config (Rich Trott) [#41996](https://github.com/nodejs/node/pull/41996)
		* \[[`916cda4afc`](https://github.com/nodejs/node/commit/916cda4afc)] - tools: update remark-preset-lint-node to 3.3.1 (Rich Trott) [#41999](https://github.com/nodejs/node/pull/41999)
		* \[[`7a72aa776a`](https://github.com/nodejs/node/commit/7a72aa776a)] - tools: update ESLint to 8.9.0 (Luigi Pinca) [#41973](https://github.com/nodejs/node/pull/41973)
		* \[[`0c4977cf29`](https://github.com/nodejs/node/commit/0c4977cf29)] - tools: update lint-md-dependencies to rollup\@2.67.2 (Node.js GitHub Bot) [#41941](https://github.com/nodejs/node/pull/41941)

richardlau Feb 22, 2022

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't checked all of them, but it looks like there's a mismatch to the commit shas on the actual branch, most probably due to one of the rebases.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

BethGriggs reacted with thumbs up emoji

All reactions

👍 1 reaction

bengl Feb 22, 2022

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in latest push.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

BethGriggs reacted with thumbs up emoji

All reactions

👍 1 reaction

bengl force-pushed the v17.6.0-proposal branch from 39ae944 to 6c7f304 Compare

February 22, 2022 21:52

richardlau reviewed

Feb 22, 2022

View reviewed changes

Comment thread

doc/changelogs/CHANGELOG_V17.md Outdated

richardlau Feb 22, 2022

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

	* \[[`326f54576a`](https://github.com/nodejs/node/commit/326f54576a)] - doc: deprecate notice for process methods (Yash Ladha) [#41587](https://github.com/nodejs/node/pull/41587)
	* \[[`6b88595142`](https://github.com/nodejs/node/commit/6b88595142)] - doc: deprecate notice for process methods (Yash Ladha) [#41587](https://github.com/nodejs/node/pull/41587)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

BethGriggs reacted with thumbs up emoji

All reactions

👍 1 reaction

Comment thread

doc/changelogs/CHANGELOG_V17.md Outdated

richardlau Feb 22, 2022

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

	* \[[`abd6967153`](https://github.com/nodejs/node/commit/abd6967153)] - stream: revert `map` spec compliance (Benjamin Gruenbaum) [#41931](https://github.com/nodejs/node/pull/41931)
	* \[[`77462b6083`](https://github.com/nodejs/node/commit/77462b6083)] - stream: revert `map` spec compliance (Benjamin Gruenbaum) [#41931](https://github.com/nodejs/node/pull/41931)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

BethGriggs reacted with thumbs up emoji

All reactions

👍 1 reaction

Comment thread

doc/changelogs/CHANGELOG_V17.md Outdated

richardlau Feb 22, 2022

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

	* \[[`88cbceb3ca`](https://github.com/nodejs/node/commit/88cbceb3ca)] - (SEMVER-MINOR) crypto: expose Web Crypto API on the global scope (Antoine du Hamel) [#41938](https://github.com/nodejs/node/pull/41938)
	* \[[`60682917dd`](https://github.com/nodejs/node/commit/60682917dd)] - (SEMVER-MINOR) crypto: expose Web Crypto API on the global scope (Antoine du Hamel) [#41938](https://github.com/nodejs/node/pull/41938)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

BethGriggs reacted with thumbs up emoji

All reactions

👍 1 reaction

Comment thread

doc/changelogs/CHANGELOG_V17.md Outdated

richardlau Feb 22, 2022

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

	* \[[`1e862b3816`](https://github.com/nodejs/node/commit/1e862b3816)] - (SEMVER-MINOR) fs: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) [#41819](https://github.com/nodejs/node/pull/41819)
	* \[[`214d17650b`](https://github.com/nodejs/node/commit/214d17650b)] - (SEMVER-MINOR) fs: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) [#41819](https://github.com/nodejs/node/pull/41819)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

BethGriggs reacted with thumbs up emoji

All reactions

👍 1 reaction

Comment thread

doc/changelogs/CHANGELOG_V17.md Outdated

richardlau Feb 22, 2022

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

	* \[[`4fbe064ce0`](https://github.com/nodejs/node/commit/4fbe064ce0)] - (SEMVER-MINOR) lib: add FormData global when fetch is enabled (Michaël Zasso) [#41956](https://github.com/nodejs/node/pull/41956)
	* \[[`ec0d623bd7`](https://github.com/nodejs/node/commit/ec0d623bd7)] - (SEMVER-MINOR) lib: add FormData global when fetch is enabled (Michaël Zasso) [#41956](https://github.com/nodejs/node/pull/41956)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

BethGriggs reacted with thumbs up emoji

All reactions

👍 1 reaction

Comment thread

doc/changelogs/CHANGELOG_V17.md Outdated

richardlau Feb 22, 2022

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

	* \[[`811f04bd34`](https://github.com/nodejs/node/commit/811f04bd34)] - deps: upgrade npm to 8.5.1 (npm-robot) [#42039](https://github.com/nodejs/node/pull/42039)
	* \[[`d1ef43f2aa`](https://github.com/nodejs/node/commit/d1ef43f2aa)] - deps: upgrade npm to 8.5.1 (npm-robot) [#42039](https://github.com/nodejs/node/pull/42039)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

BethGriggs reacted with thumbs up emoji

All reactions

👍 1 reaction

Comment thread

doc/changelogs/CHANGELOG_V17.md Outdated

richardlau Feb 22, 2022

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

	* \[[`605271ba8c`](https://github.com/nodejs/node/commit/605271ba8c)] - deps: update undici to 3e267ece5f (Michaël Zasso) [#41955](https://github.com/nodejs/node/pull/41955)
	* \[[`09c17481f6`](https://github.com/nodejs/node/commit/09c17481f6)] - deps: update undici to 3e267ece5f (Michaël Zasso) [#41955](https://github.com/nodejs/node/pull/41955)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

BethGriggs reacted with thumbs up emoji

All reactions

👍 1 reaction

Comment thread

doc/changelogs/CHANGELOG_V17.md Outdated

richardlau Feb 22, 2022

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

	* \[[`7c19c7496e`](https://github.com/nodejs/node/commit/7c19c7496e)] - doc: add marsonya to collaborators (Akhil Marsonya) [#41991](https://github.com/nodejs/node/pull/41991)
	* \[[`90d90e3868`](https://github.com/nodejs/node/commit/90d90e3868)] - doc: add marsonya to collaborators (Akhil Marsonya) [#41991](https://github.com/nodejs/node/pull/41991)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

BethGriggs reacted with thumbs up emoji

All reactions

👍 1 reaction


          2022-02-22, Version 17.6.0 (Current)

972dd0a

Notable changes:

- doc: deprecate notice for process methods (Yash Ladha) #41587
- stream: revert `map` spec compliance (Benjamin Gruenbaum) #41931
- build: remove broken x32 arch support (Ben Noordhuis) #41905
- (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) #36328
- (SEMVER-MINOR) fs: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) #41819
- (SEMVER-MINOR) lib: add FormData global when fetch is enabled (Michaël Zasso) #41956
- (SEMVER-MINOR) readline: bind keystroke `ctrl`+`6` to redo (Ray) #41662
- process: deprecate multipleResolves (Benjamin Gruenbaum) #41872
  - Documentation-only.

Dependency updates:

- deps: upgrade npm to 8.5.1 (npm-robot) #42039
- deps: update undici to 3e267ece5f (Michaël Zasso) #41955
- deps: upgrade npm to 8.5.0 (npm-robot) #41925

New collaborators:

- doc: add marsonya to collaborators (Akhil Marsonya) #41991
- doc: add joesepi to collaborators (Joe Sepi) #41914

PR-URL: #42072

bengl force-pushed the v17.6.0-proposal branch from 6c7f304 to 972dd0a Compare

February 22, 2022 22:19

bengl commented Feb 22, 2022

Copy link

Copy Markdown

Member Author

@richardlau I'm pretty sure I've fixed all of those now, but my work should certainly be checked 😄 .

richardlau reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

richardlau approved these changes

Feb 22, 2022

View reviewed changes

BethGriggs approved these changes

Feb 22, 2022

View reviewed changes

BethGriggs merged commit 972dd0a into v17.x

Feb 22, 2022

BethGriggs added a commit that referenced this pull request

Feb 22, 2022


          Working on v17.6.1

4069ead

PR-URL: #42072

BethGriggs pushed a commit that referenced this pull request

Feb 22, 2022


          2022-02-22, Version 17.6.0 (Current)

a987f7f

Notable changes:

- doc: deprecate notice for process methods (Yash Ladha) #41587
- stream: revert `map` spec compliance (Benjamin Gruenbaum) #41931
- build: remove broken x32 arch support (Ben Noordhuis) #41905
- (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) #36328
- (SEMVER-MINOR) fs: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) #41819
- (SEMVER-MINOR) lib: add FormData global when fetch is enabled (Michaël Zasso) #41956
- (SEMVER-MINOR) readline: bind keystroke `ctrl`+`6` to redo (Ray) #41662
- process: deprecate multipleResolves (Benjamin Gruenbaum) #41872
  - Documentation-only.

Dependency updates:

- deps: upgrade npm to 8.5.1 (npm-robot) #42039
- deps: update undici to 3e267ece5f (Michaël Zasso) #41955
- deps: upgrade npm to 8.5.0 (npm-robot) #41925

New collaborators:

- doc: add marsonya to collaborators (Akhil Marsonya) #41991
- doc: add joesepi to collaborators (Joe Sepi) #41914

PR-URL: #42072

aduh95 deleted the v17.6.0-proposal branch

February 22, 2022 23:56

bengl added a commit to bengl/nodejs.org that referenced this pull request

Feb 23, 2022


          Blog: v17.6.0 release post

03d9f36

Refs: nodejs/node#42072

bengl mentioned this pull request

Feb 23, 2022

Blog: v17.6.0 release post nodejs/nodejs.org#4435

Merged

BethGriggs pushed a commit to nodejs/nodejs.org that referenced this pull request

Feb 23, 2022


          Blog: v17.6.0 release post (#4435)

6c0ed8c

Refs: nodejs/node#42072

Trott pushed a commit that referenced this pull request

Feb 23, 2022


          2022-02-22, Version 17.6.0 (Current)

175638b

Notable changes:

- doc: deprecate notice for process methods (Yash Ladha) #41587
- stream: revert `map` spec compliance (Benjamin Gruenbaum) #41931
- build: remove broken x32 arch support (Ben Noordhuis) #41905
- (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) #36328
- (SEMVER-MINOR) fs: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) #41819
- (SEMVER-MINOR) lib: add FormData global when fetch is enabled (Michaël Zasso) #41956
- (SEMVER-MINOR) readline: bind keystroke `ctrl`+`6` to redo (Ray) #41662
- process: deprecate multipleResolves (Benjamin Gruenbaum) #41872
  - Documentation-only.

Dependency updates:

- deps: upgrade npm to 8.5.1 (npm-robot) #42039
- deps: update undici to 3e267ece5f (Michaël Zasso) #41955
- deps: upgrade npm to 8.5.0 (npm-robot) #41925

New collaborators:

- doc: add marsonya to collaborators (Akhil Marsonya) #41991
- doc: add joesepi to collaborators (Joe Sepi) #41914

PR-URL: #42072

BethGriggs mentioned this pull request

Feb 23, 2022

Onboarding bengl as a releaser nodejs/Release#730

Closed

6 tasks done

Reviewers

richardlau

richardlau approved these changes

BethGriggs

BethGriggs approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

20 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

Conversation

bengl commented Feb 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

2022-02-22, Version 17.6.0 (Current), @BethGriggs prepared by @bengl

Notable Changes

Dependency Updates

New Collaborators

Commits

Uh oh!

nodejs-github-bot commented Feb 21, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

targos commented Feb 21, 2022

Uh oh!

richardlau commented Feb 22, 2022

Uh oh!

bengl commented Feb 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

nodejs-github-bot commented Feb 22, 2022 • edited by BethGriggs Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BethGriggs commented Feb 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bengl commented Feb 22, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

bengl commented Feb 21, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

bengl commented Feb 22, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Feb 22, 2022 •

edited by BethGriggs

Loading

Uh oh!

There was an error while loading. Please reload this page.

BethGriggs commented Feb 22, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.