GeezerVison

Copy link

Copy Markdown

Contributor

bricss reacted with thumbs up emoji

theanarkh force-pushed the trace_threadpoolwork_event branch from 6f35dbf to 245ef10 Compare August 30, 2022 16:35

legendecas reviewed Aug 30, 2022

View reviewed changes

theanarkh force-pushed the trace_threadpoolwork_event branch 2 times, most recently from b87e591 to 39bd5b5 Compare August 30, 2022 17:44

VoltrexKeyva reviewed Aug 31, 2022

View reviewed changes

theanarkh force-pushed the trace_threadpoolwork_event branch from 39bd5b5 to 39f400b Compare August 31, 2022 02:26

legendecas reviewed Aug 31, 2022

View reviewed changes

theanarkh force-pushed the trace_threadpoolwork_event branch from 39f400b to ef94baa Compare August 31, 2022 02:40

legendecas reviewed Aug 31, 2022

View reviewed changes

theanarkh force-pushed the trace_threadpoolwork_event branch 2 times, most recently from 40c49ab to 672d9ad Compare August 31, 2022 13:24

addaleax reviewed Aug 31, 2022

View reviewed changes

theanarkh force-pushed the trace_threadpoolwork_event branch 2 times, most recently from e077266 to 24d32ce Compare September 1, 2022 06:28

RaisinTen reviewed Sep 2, 2022

View reviewed changes

void ThreadPoolWork::ScheduleWork() {
  env_->IncreaseWaitingRequestCounter();

  TRACE_EVENT_NESTABLE_ASYNC_BEGIN0(...);

  int status = uv_queue_work(
      env_->event_loop(),
      &work_req_,
      [](uv_work_t* req) {
        ThreadPoolWork* self = ContainerOf(&ThreadPoolWork::work_req_, req);
        self->DoThreadPoolWork();
      },
      [](uv_work_t* req, int status) {
        ThreadPoolWork* self = ContainerOf(&ThreadPoolWork::work_req_, req);
        self->env_->DecreaseWaitingRequestCounter();

        TRACE_EVENT_NESTABLE_ASYNC_END1(...);

        self->AfterThreadPoolWork(status);
      });
  CHECK_EQ(status, 0);
}

void ThreadPoolWork::ScheduleWork() {
  env_->IncreaseWaitingRequestCounter();

  TRACE_EVENT_NESTABLE_ASYNC_BEGIN0(...);

  int status = uv_queue_work(
      env_->event_loop(),
      &work_req_,
      [](uv_work_t* req) {
        ThreadPoolWork* self = ContainerOf(&ThreadPoolWork::work_req_, req);
        TRACE_EVENT_BEGIN(...);
        self->DoThreadPoolWork();
        TRACE_EVENT_END(...);
      },
      [](uv_work_t* req, int status) {
        ThreadPoolWork* self = ContainerOf(&ThreadPoolWork::work_req_, req);
        self->env_->DecreaseWaitingRequestCounter();

        TRACE_EVENT_NESTABLE_ASYNC_END1(...);

        self->AfterThreadPoolWork(status);
      });
  CHECK_EQ(status, 0);
}

theanarkh force-pushed the trace_threadpoolwork_event branch 2 times, most recently from 1703fd4 to 05cbb9c Compare September 14, 2022 16:26

theanarkh force-pushed the trace_threadpoolwork_event branch 3 times, most recently from a8b5f8f to b1128a1 Compare October 26, 2022 00:38

theanarkh force-pushed the trace_threadpoolwork_event branch from b1128a1 to 1f402fc Compare October 26, 2022 01:30

When the process exits, there may be tasks in the thread pool
that need to access data in the platform, such as trace agent.
So make sure the thread pool exits first.
see #44458

PR-URL: #45226
Refs: #44458
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>

PR-URL: #44458
Reviewed-By: Chengzhong Wu <[email protected]>

When the process exits, there may be tasks in the thread pool
that need to access data in the platform, such as trace agent.
So make sure the thread pool exits first.
see #44458

PR-URL: #45226
Refs: #44458
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>

PR-URL: #44458
Reviewed-By: Chengzhong Wu <[email protected]>

PR-URL: #45266
Refs: #45092
Refs: #44458
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>

PR-URL: #45266
Refs: #45092
Refs: #44458
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>

When the process exits, there may be tasks in the thread pool
that need to access data in the platform, such as trace agent.
So make sure the thread pool exits first.
see #44458

PR-URL: #45226
Refs: #44458
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>

PR-URL: #44458
Reviewed-By: Chengzhong Wu <[email protected]>

PR-URL: #45266
Refs: #45092
Refs: #44458
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>

When the process exits, there may be tasks in the thread pool
that need to access data in the platform, such as trace agent.
So make sure the thread pool exits first.
see #44458

PR-URL: #45226
Refs: #44458
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>

PR-URL: #44458
Reviewed-By: Chengzhong Wu <[email protected]>

PR-URL: #45266
Refs: #45092
Refs: #44458
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>

PR-URL: #45266
Refs: #45092
Refs: #44458
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>