GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — trace_events: add new categories by theanarkh · Pull Request #45266 · nodejs/node

Conversation

@theanarkh

@theanarkh theanarkh commented Nov 1, 2022

Copy link
Copy Markdown
Contributor

add new categories.

Refs: #45092
Refs: #44458

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Nov 1, 2022
RaisinTen
RaisinTen approved these changes Nov 2, 2022
View reviewed changes
@theanarkh theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 2, 2022
@github-actions github-actions Bot added request-ci-failed Starting CI with the request-ci label failed and requires manual intervention. and removed request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Nov 2, 2022
@github-actions

github-actions Bot commented Nov 2, 2022

Copy link
Copy Markdown
Contributor
Failed to start CI
- Validating Jenkins credentials
✖  Jenkins credentials invalid
https://github.com///actions/runs/3377836998
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@theanarkh theanarkh added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed request-ci-failed Starting CI with the request-ci label failed and requires manual intervention. labels Nov 2, 2022
@github-actions github-actions Bot added request-ci-failed Starting CI with the request-ci label failed and requires manual intervention. and removed request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Nov 2, 2022
@github-actions

github-actions Bot commented Nov 2, 2022

Copy link
Copy Markdown
Contributor
Failed to start CI
- Validating Jenkins credentials
✖  Jenkins credentials invalid
https://github.com///actions/runs/3378861038
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@theanarkh
theanarkh force-pushed the add_new_categories branch from bb948a0 to 116af37 Compare November 3, 2022 13:05
@theanarkh theanarkh added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed request-ci-failed Starting CI with the request-ci label failed and requires manual intervention. labels Nov 3, 2022
@github-actions github-actions Bot added request-ci-failed Starting CI with the request-ci label failed and requires manual intervention. and removed request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Nov 3, 2022
@github-actions

github-actions Bot commented Nov 3, 2022

Copy link
Copy Markdown
Contributor
Failed to start CI
- Validating Jenkins credentials
✖  Jenkins credentials invalid
https://github.com/nodejs/node/actions/runs/3387378766
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@theanarkh theanarkh added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed request-ci-failed Starting CI with the request-ci label failed and requires manual intervention. labels Nov 5, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 5, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 5, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47700/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Nov 5, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47714/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Nov 6, 2022
CI Reliability 2022-11-06 nodejs/reliability#420
Open
18 tasks
@theanarkh theanarkh added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Nov 6, 2022
This was referenced Nov 7, 2022
CI Reliability 2022-11-07 nodejs/reliability#421
Open
CI Reliability 2022-11-08 nodejs/reliability#422
Open
legendecas
legendecas approved these changes Nov 8, 2022
View reviewed changes
Comment thread src/inspector/tracing_agent.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.
@theanarkh
theanarkh force-pushed the add_new_categories branch 2 times, most recently from 13d096d to 2509ae1 Compare November 8, 2022 17:34
@github-actions github-actions Bot mentioned this pull request Nov 12, 2022
CI Reliability 2022-11-12 nodejs/reliability#426
Open
19 tasks
@Trott
Trott force-pushed the main branch from 2d76238 to ca3ed36 Compare November 12, 2022 01:49
@github-actions github-actions Bot mentioned this pull request Nov 13, 2022
CI Reliability 2022-11-13 nodejs/reliability#427
Open
25 tasks
@nodejs-github-bot

nodejs-github-bot commented Nov 13, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47902/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Nov 14, 2022
CI Reliability 2022-11-14 nodejs/reliability#428
Open
25 tasks
@nodejs-github-bot

nodejs-github-bot commented Nov 14, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47923/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Nov 15, 2022
CI Reliability 2022-11-15 nodejs/reliability#429
Open
23 tasks
@nodejs-github-bot

nodejs-github-bot commented Nov 15, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47940/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Nov 16, 2022
CI Reliability 2022-11-16 nodejs/reliability#430
Open
17 tasks
jasnell
jasnell approved these changes Nov 16, 2022
View reviewed changes
This was referenced Nov 17, 2022
CI Reliability 2022-11-17 nodejs/reliability#431
Open
CI Reliability 2022-11-18 nodejs/reliability#432
Open
CI Reliability 2022-11-19 nodejs/reliability#433
Open
@theanarkh theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 19, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 19, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 19, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48015/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@theanarkh theanarkh added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 19, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 19, 2022
@nodejs-github-bot
nodejs-github-bot merged commit bcc704f into nodejs:main Nov 19, 2022
@nodejs-github-bot

nodejs-github-bot commented Nov 19, 2022

Copy link
Copy Markdown
Collaborator

Landed in bcc704f
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Nov 20, 2022
CI Reliability 2022-11-20 nodejs/reliability#434
Open
14 tasks
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@theanarkh @ruyadorno
trace_events: add new categories
f441b04 
PR-URL: #45266
Refs: #45092
Refs: #44458
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Nov 24, 2022
v19.2.0 proposal #45615
Merged
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@theanarkh @danielleadams
trace_events: add new categories
a2256ba 
PR-URL: #45266
Refs: #45092
Refs: #44458
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@theanarkh @danielleadams
trace_events: add new categories
210cbcb 
PR-URL: #45266
Refs: #45092
Refs: #44458
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
@theanarkh @danielleadams
trace_events: add new categories
31d2ce8 
PR-URL: #45266
Refs: #45092
Refs: #44458
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@legendecas legendecas legendecas approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@theanarkh @nodejs-github-bot @jasnell @legendecas @RaisinTen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.