GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — trace_events: fix getCategories by theanarkh · Pull Request #45092 · nodejs/node

Conversation

@theanarkh

@theanarkh theanarkh commented Oct 20, 2022

Copy link
Copy Markdown
Contributor

fix getCategories of trace_events.

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Oct 20, 2022
@theanarkh
theanarkh force-pushed the fix_trace_event_categorys branch from c9aa695 to a072817 Compare October 20, 2022 14:35
F3n67u
F3n67u approved these changes Oct 22, 2022
View reviewed changes
@F3n67u F3n67u added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 22, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 22, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
RaisinTen
RaisinTen reviewed Oct 22, 2022
View reviewed changes
Comment thread src/inspector/tracing_agent.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.
@theanarkh
trace_events: fix getCategories
9d3e05c
@theanarkh
theanarkh force-pushed the fix_trace_event_categorys branch from a072817 to 9d3e05c Compare October 22, 2022 14:35
jasnell
jasnell approved these changes Oct 22, 2022
View reviewed changes
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
anonrig
anonrig approved these changes Oct 22, 2022
View reviewed changes
@anonrig anonrig added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Oct 22, 2022
@github-actions github-actions Bot mentioned this pull request Oct 23, 2022
CI Reliability 2022-10-23 nodejs/reliability#408
Open
13 tasks
@theanarkh theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 23, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 23, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
RaisinTen
RaisinTen approved these changes Oct 23, 2022
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Oct 23, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47418/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Oct 23, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47428/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Oct 24, 2022
CI Reliability 2022-10-24 nodejs/reliability#409
Open
13 tasks
@theanarkh theanarkh added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 24, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 24, 2022
@nodejs-github-bot
nodejs-github-bot merged commit aab9f32 into nodejs:main Oct 24, 2022
@nodejs-github-bot

nodejs-github-bot commented Oct 24, 2022

Copy link
Copy Markdown
Collaborator

Landed in aab9f32
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Oct 25, 2022
CI Reliability 2022-10-25 nodejs/reliability#410
Open
CI Reliability 2022-10-26 nodejs/reliability#411
Open
CI Reliability 2022-10-27 nodejs/reliability#412
Open
CI Reliability 2022-10-28 nodejs/reliability#413
Open
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@theanarkh @RafaelGSS
trace_events: fix getCategories
d5ada0f 
PR-URL: #45092
Reviewed-By: Feng Yu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@theanarkh theanarkh mentioned this pull request Nov 1, 2022
trace_events: add new categories #45266
Merged
4 tasks done
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
v19.1.0 proposal #45269
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@theanarkh @RafaelGSS
trace_events: fix getCategories
732f9a7 
PR-URL: #45092
Reviewed-By: Feng Yu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Nov 19, 2022
@theanarkh
trace_events: add new categories
bcc704f 
PR-URL: #45266
Refs: #45092
Refs: #44458
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@theanarkh @ruyadorno
trace_events: add new categories
f441b04 
PR-URL: #45266
Refs: #45092
Refs: #44458
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
v18.13.0 release proposal #46025
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@theanarkh @danielleadams
trace_events: fix getCategories
9f721e6 
PR-URL: #45092
Reviewed-By: Feng Yu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@theanarkh @danielleadams
trace_events: add new categories
a2256ba 
PR-URL: #45266
Refs: #45092
Refs: #44458
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@theanarkh @danielleadams
trace_events: fix getCategories
20a39a3 
PR-URL: #45092
Reviewed-By: Feng Yu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@theanarkh @danielleadams
trace_events: add new categories
210cbcb 
PR-URL: #45266
Refs: #45092
Refs: #44458
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
@theanarkh @danielleadams
trace_events: add new categories
31d2ce8 
PR-URL: #45266
Refs: #45092
Refs: #44458
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@anonrig anonrig anonrig approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes
+1 more reviewer
@F3n67u F3n67u F3n67u approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@theanarkh @nodejs-github-bot @jasnell @anonrig @F3n67u @RaisinTen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.