GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: debug log for nghttp3 by marco-ippolito · Pull Request #47992 · nodejs/node

Conversation

@marco-ippolito

@marco-ippolito marco-ippolito commented May 13, 2023

Copy link
Copy Markdown
Member

Refs: #47576

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@marco-ippolito
tools: debug log for nghttp3
b415eaa
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label May 13, 2023
@marco-ippolito marco-ippolito mentioned this pull request May 13, 2023
deps: update nghttp3 to 1.0.0 #47576
Closed
@marco-ippolito marco-ippolito added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label May 13, 2023
@github-actions

github-actions Bot commented May 13, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @marco-ippolito. Please 👍 to approve.
anonrig, bricss, juanarbol, and deokjinkim reacted with thumbs up emoji
All reactions
  • 👍 4 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
anonrig
anonrig approved these changes May 13, 2023
View reviewed changes
juanarbol
juanarbol approved these changes May 13, 2023
View reviewed changes
tniessen
tniessen reviewed May 14, 2023
View reviewed changes

@tniessen tniessen left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do GitHub files have stable checksums? If so, it would be good to log the sha256sum or so of the downloaded archive.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@marco-ippolito

marco-ippolito commented May 14, 2023

Copy link
Copy Markdown
Member Author

This is a good idea! It might be something we want to do for all archive we download. Ill look into it
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
deokjinkim
deokjinkim approved these changes May 14, 2023
View reviewed changes
jasnell
jasnell approved these changes May 14, 2023
View reviewed changes
@marco-ippolito marco-ippolito added the commit-queue PRs queued for automated landing through the Commit Queue. label May 14, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 14, 2023
@nodejs-github-bot
nodejs-github-bot merged commit d27301d into nodejs:main May 14, 2023
@nodejs-github-bot

nodejs-github-bot commented May 14, 2023

Copy link
Copy Markdown
Collaborator

Landed in d27301d
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request May 14, 2023
@marco-ippolito @targos
tools: debug log for nghttp3
1a1bc0b 
PR-URL: #47992
Refs: #47576
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request May 15, 2023
@marco-ippolito @targos
tools: debug log for nghttp3
a4e261e 
PR-URL: #47992
Refs: #47576
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request May 15, 2023
v20.2.0 release proposal #48020
Merged
@tniessen tniessen mentioned this pull request May 19, 2023
tools: add debug logs to deps update #48060
Merged
@fasenderos fasenderos mentioned this pull request May 20, 2023
tools: log and check shasum of archive file #48088
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@marco-ippolito @danielleadams
tools: debug log for nghttp3
c992668 
PR-URL: #47992
Refs: #47576
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@marco-ippolito @MoLow
tools: debug log for nghttp3
89e068a 
PR-URL: nodejs#47992
Refs: nodejs#47576
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
v18.17.0 release proposal #48694
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tniessen tniessen tniessen left review comments
@jasnell jasnell jasnell approved these changes
@anonrig anonrig anonrig approved these changes
@deokjinkim deokjinkim deokjinkim approved these changes
@juanarbol juanarbol juanarbol approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

fast-track PRs proposed for a shorter-than-standard waiting period before landing. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@marco-ippolito @nodejs-github-bot @jasnell @anonrig @tniessen @deokjinkim @juanarbol
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.