GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — stream: deprecate asIndexedPairs by atlowChemi · Pull Request #48102 · nodejs/node

Conversation

@atlowChemi

@atlowChemi atlowChemi commented May 21, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Refs: https://github.com/tc39/proposal-iterator-helpers, tc39/proposal-iterator-helpers@63567bb, tc39/proposal-iterator-helpers@bdb4883, tc39/proposal-iterator-helpers#211

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot

nodejs-github-bot commented May 21, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/streams
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label May 21, 2023
benjamingr
benjamingr approved these changes May 21, 2023
View reviewed changes
@atlowChemi
atlowChemi marked this pull request as ready for review May 21, 2023 11:09
@atlowChemi
atlowChemi force-pushed the runtime-deprecate-asIndexedPairs branch from a63bb8a to 217c203 Compare May 21, 2023 11:17
@aduh95

aduh95 commented May 21, 2023

Copy link
Copy Markdown
Contributor

It think this should ref tc39/proposal-iterator-helpers@63567bb.
atlowChemi reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@benjamingr benjamingr added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 21, 2023
@benjamingr

benjamingr commented May 21, 2023

Copy link
Copy Markdown
Member

@aduh95 there was a future change removing it entirely rather than renaming it

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 21, 2023
@nodejs-github-bot

nodejs-github-bot commented May 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51900/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 reviewed May 21, 2023
View reviewed changes
Comment thread doc/api/deprecations.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 reviewed May 21, 2023
View reviewed changes

@aduh95 aduh95 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t think we have a precedent for deprecating an experimental feature – and I don’t think we should set one. What I suggest we do instead is to add a runtime warning (and possibly backport it on all non-EOL release lines), then remove it entirely in a follow up PR with the dont-land-on-20.x label.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@atlowChemi

atlowChemi commented May 21, 2023

Copy link
Copy Markdown
Member Author

I don’t think we have a precedent for deprecating an experimental feature – and I don’t think we should set one. What I suggest we do instead is to add a runtime warning (and possibly backport it on all non-EOL release lines), then remove it entirely in a follow up PR with the dont-land-on-20.x label.

I think #47740 which added DEP0173 had deprecated an experimental feature https://github.com/nodejs/node/pull/47740/files#diff-a1dd65347b3a99f8969799e35dc0c324dfaa28865a0706671183aca7aeebea97R231
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
atlowChemi
atlowChemi commented May 21, 2023
View reviewed changes
Comment thread lib/internal/streams/operators.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@atlowChemi
atlowChemi force-pushed the runtime-deprecate-asIndexedPairs branch from 217c203 to bbbdff5 Compare May 21, 2023 16:35
@aduh95

aduh95 commented May 21, 2023

Copy link
Copy Markdown
Contributor

I think #47740 which added DEP0173 had deprecated an experimental feature

I still think it's a wrong move (it's too bad I missed #47740), using the deprecation cycle for an experimental feature gives the wrong message, there should be no guarantee for experimental features. I won't block this if others feel differently, count ma as -0.5.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@benjamingr

benjamingr commented May 21, 2023

Copy link
Copy Markdown
Member

@aduh95 how would you like this removal to look, ideally?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95

aduh95 commented May 21, 2023

Copy link
Copy Markdown
Contributor

What I've written in #48102 (review):

What I suggest we do instead is to add a runtime warning (and possibly backport it on all non-EOL release lines), then remove it entirely in a follow up PR with the dont-land-on-20.x label.
benjamingr and MoLow reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mcollina
mcollina reviewed May 22, 2023
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I concur with @aduh95

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@benjamingr

benjamingr commented May 22, 2023

Copy link
Copy Markdown
Member

@atlowChemi @aduh95 's suggestion seems reasonable to me, WDYT?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@benjamingr benjamingr added the blocked PRs that are blocked by other issues or PRs. label May 22, 2023
@benjamingr

benjamingr commented May 22, 2023

Copy link
Copy Markdown
Member

Added "blocked" since this has a green review (by me) but we're still discussing how this removal should happen
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@atlowChemi

atlowChemi commented May 23, 2023

Copy link
Copy Markdown
Member Author

@atlowChemi @aduh95 's suggestion seems reasonable to me, WDYT?

Yeah, makes sense 🙂
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
atlowChemi added 2 commits May 23, 2023 07:57
@atlowChemi
stream: deprecate asIndexedPairs
f5e17ea
@atlowChemi
CR
90c4cc6
@atlowChemi
atlowChemi force-pushed the runtime-deprecate-asIndexedPairs branch from bbbdff5 to 90c4cc6 Compare May 23, 2023 04:58
@atlowChemi
atlowChemi requested review from aduh95 and benjamingr May 23, 2023 05:00
aduh95
aduh95 reviewed May 23, 2023
View reviewed changes
Comment thread doc/api/stream.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 reviewed May 23, 2023
View reviewed changes
Comment thread doc/api/stream.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented May 23, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51944/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request May 24, 2023
CI Reliability 2023-05-24 nodejs/reliability#575
Open
19 tasks
JungMinu
JungMinu approved these changes May 24, 2023
View reviewed changes
@aduh95 aduh95 added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels May 24, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 24, 2023
@nodejs-github-bot
nodejs-github-bot merged commit c462147 into nodejs:main May 24, 2023
@nodejs-github-bot

nodejs-github-bot commented May 24, 2023

Copy link
Copy Markdown
Collaborator

Landed in c462147
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@atlowChemi
atlowChemi deleted the runtime-deprecate-asIndexedPairs branch May 24, 2023 08:22
@atlowChemi atlowChemi mentioned this pull request May 24, 2023
stream: remove asIndexedPairs #48150
Merged
This was referenced May 25, 2023
CI Reliability 2023-05-25 nodejs/reliability#576
Open
CI Reliability 2023-05-26 nodejs/reliability#577
Open
CI Reliability 2023-05-27 nodejs/reliability#578
Open
CI Reliability 2023-05-28 nodejs/reliability#579
Open
CI Reliability 2023-05-29 nodejs/reliability#580
Open
CI Reliability 2023-05-30 nodejs/reliability#581
Open
targos pushed a commit that referenced this pull request May 30, 2023
@atlowChemi @targos
stream: deprecate asIndexedPairs
9e2b13d 
PR-URL: #48102
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
@github-actions github-actions Bot mentioned this pull request May 31, 2023
CI Reliability 2023-05-31 nodejs/reliability#582
Open
22 tasks
@targos targos mentioned this pull request Jun 4, 2023
v20.3.0 release proposal #48332
Merged
targos added a commit that referenced this pull request Jun 5, 2023
@targos
2023-06-05, Version 20.3.0 (Current)
6d770b5 
Notable changes:

deps:
  * upgrade to libuv 1.45.0, including significant performance
    improvements to file system operations on Linux (Santiago Gimeno) #48078
doc:
  * add Ruy Adorno to list of TSC members (Michael Dawson) #48172
  * mark Node.js 14 as End-of-Life (Richard Lau) #48023
lib:
  * (SEMVER-MINOR) implement AbortSignal.any() (Chemi Atlow) #47821
module:
  * change default resolver to not throw on unknown scheme (Gil Tayar) #47824
node-api:
  * (SEMVER-MINOR) define version 9 (Chengzhong Wu) #48151
stream:
  * deprecate asIndexedPairs (Chemi Atlow) #48102

PR-URL: #48332
RafaelGSS pushed a commit that referenced this pull request Jun 7, 2023
@targos @RafaelGSS
2023-06-08, Version 20.3.0 (Current)
57679e1 
Notable changes:

deps:
  * upgrade to libuv 1.45.0, including significant performance
    improvements to file system operations on Linux (Santiago Gimeno) #48078
doc:
  * add Ruy Adorno to list of TSC members (Michael Dawson) #48172
  * mark Node.js 14 as End-of-Life (Richard Lau) #48023
lib:
  * (SEMVER-MINOR) implement AbortSignal.any() (Chemi Atlow) #47821
module:
  * change default resolver to not throw on unknown scheme (Gil Tayar) #47824
node-api:
  * (SEMVER-MINOR) define version 9 (Chengzhong Wu) #48151
stream:
  * deprecate asIndexedPairs (Chemi Atlow) #48102

PR-URL: #48332
RafaelGSS pushed a commit that referenced this pull request Jun 8, 2023
@targos @RafaelGSS
2023-06-08, Version 20.3.0 (Current)
5a58972 
Notable changes:

deps:
  * upgrade to libuv 1.45.0, including significant performance
    improvements to file system operations on Linux (Santiago Gimeno) #48078
doc:
  * add Ruy Adorno to list of TSC members (Michael Dawson) #48172
  * mark Node.js 14 as End-of-Life (Richard Lau) #48023
lib:
  * (SEMVER-MINOR) implement AbortSignal.any() (Chemi Atlow) #47821
module:
  * change default resolver to not throw on unknown scheme (Gil Tayar) #47824
node-api:
  * (SEMVER-MINOR) define version 9 (Chengzhong Wu) #48151
stream:
  * deprecate asIndexedPairs (Chemi Atlow) #48102

PR-URL: #48332
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@atlowChemi @danielleadams
stream: deprecate asIndexedPairs
6509d4e 
PR-URL: #48102
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@atlowChemi @MoLow
stream: deprecate asIndexedPairs
585d628 
PR-URL: nodejs#48102
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
v18.17.0 release proposal #48694
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@atlowChemi @Ceres6
stream: deprecate asIndexedPairs
6a29340 
PR-URL: nodejs#48102
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@targos @Ceres6
2023-06-08, Version 20.3.0 (Current)
ad26015 
Notable changes:

deps:
  * upgrade to libuv 1.45.0, including significant performance
    improvements to file system operations on Linux (Santiago Gimeno) nodejs#48078
doc:
  * add Ruy Adorno to list of TSC members (Michael Dawson) nodejs#48172
  * mark Node.js 14 as End-of-Life (Richard Lau) nodejs#48023
lib:
  * (SEMVER-MINOR) implement AbortSignal.any() (Chemi Atlow) nodejs#47821
module:
  * change default resolver to not throw on unknown scheme (Gil Tayar) nodejs#47824
node-api:
  * (SEMVER-MINOR) define version 9 (Chengzhong Wu) nodejs#48151
stream:
  * deprecate asIndexedPairs (Chemi Atlow) nodejs#48102

PR-URL: nodejs#48332
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@atlowChemi @Ceres6
stream: deprecate asIndexedPairs
60c58a4 
PR-URL: nodejs#48102
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@targos @Ceres6
2023-06-08, Version 20.3.0 (Current)
902f572 
Notable changes:

deps:
  * upgrade to libuv 1.45.0, including significant performance
    improvements to file system operations on Linux (Santiago Gimeno) nodejs#48078
doc:
  * add Ruy Adorno to list of TSC members (Michael Dawson) nodejs#48172
  * mark Node.js 14 as End-of-Life (Richard Lau) nodejs#48023
lib:
  * (SEMVER-MINOR) implement AbortSignal.any() (Chemi Atlow) nodejs#47821
module:
  * change default resolver to not throw on unknown scheme (Gil Tayar) nodejs#47824
node-api:
  * (SEMVER-MINOR) define version 9 (Chengzhong Wu) nodejs#48151
stream:
  * deprecate asIndexedPairs (Chemi Atlow) nodejs#48102

PR-URL: nodejs#48332
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina left review comments
@JungMinu JungMinu JungMinu approved these changes
@aduh95 aduh95 aduh95 approved these changes
@benjamingr benjamingr Awaiting requested review from benjamingr

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@atlowChemi @nodejs-github-bot @aduh95 @benjamingr @mcollina @JungMinu
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.