GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — module: reduce url invocations in esm/load.js by anonrig · Pull Request #48337 · nodejs/node

Conversation

anonrig commented Jun 5, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Reduces unnecessary new URL call, and removes unnecessary invokes to url.protocol

Ref: nodejs/performance#92

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss and styfle reacted with thumbs up emoji

All reactions

👍 2 reactions

nodejs-github-bot commented Jun 5, 2023

Copy link

Copy Markdown

Collaborator

Review requested:

@nodejs/loaders
@nodejs/modules

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot added esm

Issues and PRs related to the ECMAScript Modules implementation.

needs-ci PRs that need a full CI run. labels

Jun 5, 2023

anonrig force-pushed the improve-esm-loadjs branch from cadc77b to 724ee2e Compare

June 5, 2023 01:13


          module: reduce url invocations in esm/load.js

bd035a6

anonrig force-pushed the improve-esm-loadjs branch from 724ee2e to bd035a6 Compare

June 5, 2023 01:31

Qard approved these changes

Jun 5, 2023

View reviewed changes

aduh95 approved these changes

Jun 5, 2023

View reviewed changes

Comment thread

lib/internal/modules/esm/load.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

lib/internal/modules/esm/load.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

lib/internal/modules/esm/load.js Resolved

Uh oh!

There was an error while loading. Please reload this page.


          fixup! module: reduce url invocations in esm/load.js

41d5cfa

anonrig added author ready

PRs with CI started, the required approvals, and no outstanding review comments.

commit-queue

PRs queued for automated landing through the Commit Queue.

request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels

Jun 5, 2023

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Jun 5, 2023

nodejs-github-bot commented Jun 5, 2023

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52115/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

GeoffreyBooth approved these changes

Jun 5, 2023

View reviewed changes

Comment thread

lib/internal/modules/esm/load.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

lpinca approved these changes

Jun 6, 2023

View reviewed changes

JakobJingleheimer approved these changes

Jun 6, 2023

View reviewed changes

JakobJingleheimer left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we had talked about something similar previously, where I suggested the load hook be passed a URL instance (which we already have internally), but for some reason that I don't recall that was not good.

I think whatever that reason (something about mutability?) was, it doesn't apply here because this is internal.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label

Jun 7, 2023

nodejs-github-bot merged commit 9d936fa into nodejs:main

Jun 7, 2023

nodejs-github-bot commented Jun 7, 2023

Copy link

Copy Markdown

Collaborator

Landed in 9d936fa

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

RafaelGSS pushed a commit that referenced this pull request

Jul 3, 2023


          module: reduce url invocations in esm/load.js

4ec2d92

PR-URL: #48337
Refs: nodejs/performance#92
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>

RafaelGSS mentioned this pull request

Jul 3, 2023

v20.4.0 proposal #48643

Merged

Ceres6 pushed a commit to Ceres6/node that referenced this pull request

Aug 14, 2023


          module: reduce url invocations in esm/load.js

cb3c3af

PR-URL: nodejs#48337
Refs: nodejs/performance#92
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>

Ceres6 pushed a commit to Ceres6/node that referenced this pull request

Aug 14, 2023


          module: reduce url invocations in esm/load.js

7673e40

PR-URL: nodejs#48337
Refs: nodejs/performance#92
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>

ruyadorno pushed a commit that referenced this pull request

Aug 29, 2023


          module: reduce url invocations in esm/load.js

bf1525c

PR-URL: #48337
Refs: nodejs/performance#92
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>

ruyadorno mentioned this pull request

Aug 29, 2023

v18.18.0 proposal #49220

Merged

codebytere added a commit to electron/electron that referenced this pull request

Sep 19, 2023


          module: reduce url invocations in esm/load.js

2e19f7f

nodejs/node#48337

codebytere added a commit to electron/electron that referenced this pull request

Sep 19, 2023


          module: reduce url invocations in esm/load.js

c89b97f

nodejs/node#48337

codebytere added a commit to electron/electron that referenced this pull request

Sep 20, 2023


          module: reduce url invocations in esm/load.js

5c52801

nodejs/node#48337

codebytere added a commit to electron/electron that referenced this pull request

Sep 20, 2023


          module: reduce url invocations in esm/load.js

f81d844

nodejs/node#48337

codebytere added a commit to electron/electron that referenced this pull request

Sep 20, 2023


          module: reduce url invocations in esm/load.js

7c478f5

nodejs/node#48337

jkleinsc pushed a commit to electron/electron that referenced this pull request

Sep 20, 2023


          chore: bump node to v18.18.0 (main) (#39915)

* chore: bump node in DEPS to v18.18.0

* child_process: harden against prototype pollution

nodejs/node#48726

* deps: upgrade to libuv 1.46.0

nodejs/node#49591

* module: reduce url invocations in esm/load.js

nodejs/node#48337

* Revert "test: remove test-crypto-keygen flaky designation"

nodejs/node#48652

* fix: FTBTFS in ada dep

ada-url/ada#464
ada-url/idna#31

* fix: force_colors snapshot line number

* chore: fixup patch indices

* chore: update filenames.json

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <[email protected]>

MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request

Dec 11, 2023


          chore: bump node to v18.18.0 (main) (electron#39915)

a848ba1

* chore: bump node in DEPS to v18.18.0

* child_process: harden against prototype pollution

nodejs/node#48726

* deps: upgrade to libuv 1.46.0

nodejs/node#49591

* module: reduce url invocations in esm/load.js

nodejs/node#48337

* Revert "test: remove test-crypto-keygen flaky designation"

nodejs/node#48652

* fix: FTBTFS in ada dep

ada-url/ada#464
ada-url/idna#31

* fix: force_colors snapshot line number

* chore: fixup patch indices

* chore: update filenames.json

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <[email protected]>

Reviewers

Qard

Qard approved these changes

GeoffreyBooth

GeoffreyBooth approved these changes

lpinca

lpinca approved these changes

JakobJingleheimer

JakobJingleheimer approved these changes

aduh95

aduh95 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready

PRs with CI started, the required approvals, and no outstanding review comments.

esm

Issues and PRs related to the ECMAScript Modules implementation.

needs-ci

PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

anonrig commented Jun 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Jun 5, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Jun 5, 2023

Uh oh!

Uh oh!

JakobJingleheimer left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Jun 7, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

anonrig commented Jun 5, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.