GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [v18.x backport] deps: upgrade to libuv 1.46.0 #48618 by arsnyder16 · Pull Request #49591 · nodejs/node

Conversation

@arsnyder16

@arsnyder16 arsnyder16 commented Sep 10, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Backport-PR-URL: #48078
Backport-PR-URL: #48618
Backport-PR-URL:#48429
Backport-PR-URL:#49410

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
santigimeno added 2 commits September 10, 2023 10:08
@santigimeno @arsnyder16
deps: upgrade to libuv 1.45.0
1230522 
- linux: introduce io_uring support libuv/libuv#3952
- src: add new metrics APIs libuv/libuv#3749
- unix,win: give thread pool threads an 8 MB stack libuv/libuv#3787
- win,unix: change execution order of timers libuv/libuv#3927

Fixes: nodejs#43931
Fixes: nodejs#42496
Fixes: nodejs#47715
Fixes: nodejs#47259
Fixes: nodejs#47241
PR-URL: nodejs#48078
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@santigimeno @arsnyder16
deps: upgrade to libuv 1.46.0
0c99404 
Notable changes
- fs: use WTF-8 on Windows: libuv/libuv#2970
- linux: add some more iouring backed fs ops: libuv/libuv#4012

Important bugs fixed
- linux: work around io_uring IORING_OP_CLOSE bug: libuv/libuv#4059
- src: don't run timers if loop is stopped/unref'd: libuv/libuv#4048

PR-URL: nodejs#48618
Fixes: nodejs#48512
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
@nodejs-github-bot nodejs-github-bot added libuv Issues and PRs related to the libuv dependency or the uv binding. needs-ci PRs that need a full CI run. v18.x labels Sep 10, 2023
@arsnyder16 arsnyder16 mentioned this pull request Sep 10, 2023
v18.18.0 proposal #49220
Merged
gengjiawen and others added 2 commits September 10, 2023 13:55
@gengjiawen @arsnyder16
build: sync libuv header change
497bf4a 
PR-URL: nodejs#48429
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
@santigimeno @arsnyder16
deps: add missing thread-common.c in uv.gyp
b46620a 
PR-URL: nodejs#49410
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@nodejs-github-bot

nodejs-github-bot commented Sep 11, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53876/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@richardlau richardlau mentioned this pull request Sep 11, 2023
deps: upgrade to libuv 1.46.0 #48618
Merged
@ruyadorno ruyadorno mentioned this pull request Sep 11, 2023
[v18.x backport] deps: upgrade to libuv 1.45.0 #49589
Closed
santigimeno
santigimeno approved these changes Sep 11, 2023
View reviewed changes

@santigimeno santigimeno left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good call on adding all four commits for the release. Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ruyadorno reacted with heart emoji
All reactions
  • ❤️ 1 reaction
ruyadorno pushed a commit that referenced this pull request Sep 11, 2023
@santigimeno @ruyadorno
deps: upgrade to libuv 1.45.0
0aad358 
- linux: introduce io_uring support libuv/libuv#3952
- src: add new metrics APIs libuv/libuv#3749
- unix,win: give thread pool threads an 8 MB stack libuv/libuv#3787
- win,unix: change execution order of timers libuv/libuv#3927

Fixes: #43931
Fixes: #42496
Fixes: #47715
Fixes: #47259
Fixes: #47241
PR-URL: #48078
Backport-PR-URL: #49591
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 11, 2023
@santigimeno @ruyadorno
deps: upgrade to libuv 1.46.0
8af0d8c 
Notable changes
- fs: use WTF-8 on Windows: libuv/libuv#2970
- linux: add some more iouring backed fs ops: libuv/libuv#4012

Important bugs fixed
- linux: work around io_uring IORING_OP_CLOSE bug: libuv/libuv#4059
- src: don't run timers if loop is stopped/unref'd: libuv/libuv#4048

PR-URL: #48618
Backport-PR-URL: #49591
Fixes: #48512
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
PR-URL: #48078
ruyadorno pushed a commit that referenced this pull request Sep 11, 2023
@gengjiawen @ruyadorno
build: sync libuv header change
e03aa5f 
PR-URL: #48429
Backport-PR-URL: #49591
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
PR-URL: #48078
ruyadorno pushed a commit that referenced this pull request Sep 11, 2023
@santigimeno @ruyadorno
deps: add missing thread-common.c in uv.gyp
7b72655 
PR-URL: #49410
Backport-PR-URL: #49591
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
PR-URL: #48078
@ruyadorno

ruyadorno commented Sep 11, 2023

Copy link
Copy Markdown
Member

Landed in 6747721...7b72655
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ruyadorno ruyadorno closed this Sep 11, 2023
@ruyadorno

ruyadorno commented Sep 11, 2023

Copy link
Copy Markdown
Member

Thank you @arsnyder16 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
@santigimeno @ruyadorno
deps: upgrade to libuv 1.45.0
4ee7f44 
- linux: introduce io_uring support libuv/libuv#3952
- src: add new metrics APIs libuv/libuv#3749
- unix,win: give thread pool threads an 8 MB stack libuv/libuv#3787
- win,unix: change execution order of timers libuv/libuv#3927

Fixes: #43931
Fixes: #42496
Fixes: #47715
Fixes: #47259
Fixes: #47241
PR-URL: #48078
Backport-PR-URL: #49591
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
@santigimeno @ruyadorno
deps: upgrade to libuv 1.46.0
0ed29c0 
Notable changes
- fs: use WTF-8 on Windows: libuv/libuv#2970
- linux: add some more iouring backed fs ops: libuv/libuv#4012

Important bugs fixed
- linux: work around io_uring IORING_OP_CLOSE bug: libuv/libuv#4059
- src: don't run timers if loop is stopped/unref'd: libuv/libuv#4048

PR-URL: #48618
Backport-PR-URL: #49591
Fixes: #48512
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
PR-URL: #48078
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
@gengjiawen @ruyadorno
build: sync libuv header change
4b0c098 
PR-URL: #48429
Backport-PR-URL: #49591
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
PR-URL: #48078
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
@santigimeno @ruyadorno
deps: add missing thread-common.c in uv.gyp
34a9a3c 
PR-URL: #49410
Backport-PR-URL: #49591
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
PR-URL: #48078
ruyadorno pushed a commit that referenced this pull request Sep 17, 2023
@santigimeno @ruyadorno
deps: upgrade to libuv 1.45.0
fb2b80f 
- linux: introduce io_uring support libuv/libuv#3952
- src: add new metrics APIs libuv/libuv#3749
- unix,win: give thread pool threads an 8 MB stack libuv/libuv#3787
- win,unix: change execution order of timers libuv/libuv#3927

Fixes: #43931
Fixes: #42496
Fixes: #47715
Fixes: #47259
Fixes: #47241
PR-URL: #48078
Backport-PR-URL: #49591
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 17, 2023
@santigimeno @ruyadorno
deps: upgrade to libuv 1.46.0
88855e0 
Notable changes
- fs: use WTF-8 on Windows: libuv/libuv#2970
- linux: add some more iouring backed fs ops: libuv/libuv#4012

Important bugs fixed
- linux: work around io_uring IORING_OP_CLOSE bug: libuv/libuv#4059
- src: don't run timers if loop is stopped/unref'd: libuv/libuv#4048

PR-URL: #48618
Backport-PR-URL: #49591
Fixes: #48512
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
PR-URL: #48078
ruyadorno pushed a commit that referenced this pull request Sep 17, 2023
@gengjiawen @ruyadorno
build: sync libuv header change
7dc731d 
PR-URL: #48429
Backport-PR-URL: #49591
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
PR-URL: #48078
ruyadorno pushed a commit that referenced this pull request Sep 17, 2023
@santigimeno @ruyadorno
deps: add missing thread-common.c in uv.gyp
ea23870 
PR-URL: #49410
Backport-PR-URL: #49591
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
PR-URL: #48078
codebytere added a commit to electron/electron that referenced this pull request Sep 19, 2023
@codebytere
deps: upgrade to libuv 1.46.0
81ce588 
nodejs/node#49591
codebytere added a commit to electron/electron that referenced this pull request Sep 19, 2023
@codebytere
deps: upgrade to libuv 1.46.0
96bfc64 
nodejs/node#49591
codebytere added a commit to electron/electron that referenced this pull request Sep 20, 2023
@codebytere
deps: upgrade to libuv 1.46.0
b942ff9 
nodejs/node#49591
codebytere added a commit to electron/electron that referenced this pull request Sep 20, 2023
@codebytere
deps: upgrade to libuv 1.46.0
d26a7dd 
nodejs/node#49591
codebytere added a commit to electron/electron that referenced this pull request Sep 20, 2023
@codebytere
deps: upgrade to libuv 1.46.0
eb95686 
nodejs/node#49591
jkleinsc pushed a commit to electron/electron that referenced this pull request Sep 20, 2023
@electron-roller @codebytere
chore: bump node to v18.18.0 (main) (#39915)
1766511 
* chore: bump node in DEPS to v18.18.0

* child_process: harden against prototype pollution

nodejs/node#48726

* deps: upgrade to libuv 1.46.0

nodejs/node#49591

* module: reduce url invocations in esm/load.js

nodejs/node#48337

* Revert "test: remove test-crypto-keygen flaky designation"

nodejs/node#48652

* fix: FTBTFS in ada dep

ada-url/ada#464
ada-url/idna#31

* fix: force_colors snapshot line number

* chore: fixup patch indices

* chore: update filenames.json

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <[email protected]>
@ruyadorno

ruyadorno commented Oct 4, 2023

Copy link
Copy Markdown
Member

FYI: #50036
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@electron-roller @codebytere MrHuangJser
chore: bump node to v18.18.0 (main) (electron#39915)
a848ba1 
* chore: bump node in DEPS to v18.18.0

* child_process: harden against prototype pollution

nodejs/node#48726

* deps: upgrade to libuv 1.46.0

nodejs/node#49591

* module: reduce url invocations in esm/load.js

nodejs/node#48337

* Revert "test: remove test-crypto-keygen flaky designation"

nodejs/node#48652

* fix: FTBTFS in ada dep

ada-url/ada#464
ada-url/idna#31

* fix: force_colors snapshot line number

* chore: fixup patch indices

* chore: update filenames.json

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@santigimeno santigimeno santigimeno approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

libuv Issues and PRs related to the libuv dependency or the uv binding. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@arsnyder16 @nodejs-github-bot @ruyadorno @santigimeno @gengjiawen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.