GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test_runner: run global after() hook earlier by cjihrig · Pull Request #49059 · nodejs/node

Conversation

@cjihrig

@cjihrig cjihrig commented Aug 7, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This commit moves the global after() hook execution from the 'beforeExit' event to the point where all tests have finished running. This gives the global after() a chance to clean up handles that would otherwise prevent the 'beforeExit' event from being emitted.

Fixes: #49056

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mcollina and atlowChemi reacted with heart emoji
All reactions
  • ❤️ 2 reactions
@nodejs-github-bot

nodejs-github-bot commented Aug 7, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cjihrig
cjihrig requested a review from mcollina August 7, 2023 22:03
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Aug 7, 2023
@MoLow

MoLow commented Aug 10, 2023

Copy link
Copy Markdown
Member

can you please also add this test? https://github.com/MoLow/node/blob/test-runner-only/test/fixtures/test-runner/output/async-test-scheduling.mjs
cjihrig reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
MoLow
MoLow reviewed Aug 10, 2023
View reviewed changes
Comment thread lib/internal/test_runner/harness.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
MoLow
MoLow reviewed Aug 10, 2023
View reviewed changes
Comment thread lib/internal/test_runner/test.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@cjihrig
cjihrig force-pushed the after-handles branch from 9b60785 to 60c0edc Compare August 10, 2023 22:56
@cjihrig
cjihrig marked this pull request as ready for review August 10, 2023 22:56
@nodejs-github-bot

nodejs-github-bot commented Aug 10, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53154/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Aug 11, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53159/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Aug 11, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53164/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Aug 11, 2023 •
edited by cjihrig
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53165/ 🟡
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cjihrig cjihrig added commit-queue-squash PRs the Commit Queue should land as one squashed commit. and removed needs-ci PRs that need a full CI run. labels Aug 11, 2023
atlowChemi
atlowChemi reviewed Aug 11, 2023
View reviewed changes
Comment thread test/parallel/test-runner-root-after-with-refed-handles.js Outdated

@atlowChemi atlowChemi Aug 11, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cjihrig would it be worth ensuring the after hook also waits for cb?

Suggested change
server.close();
server.close(common.mustCall());

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@cjihrig cjihrig Aug 11, 2023

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not a bad idea. Honestly though, the CI was a pain to get passing yesterday and I would prefer not to start over for that change.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
atlowChemi reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
atlowChemi
atlowChemi approved these changes Aug 11, 2023
View reviewed changes
MoLow
MoLow approved these changes Aug 11, 2023
View reviewed changes
mcollina
mcollina approved these changes Aug 11, 2023
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
benjamingr
benjamingr approved these changes Aug 11, 2023
View reviewed changes
@cjihrig cjihrig added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 11, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 11, 2023
@nodejs-github-bot

nodejs-github-bot commented Aug 11, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/49059
✔  Done loading data for nodejs/node/pull/49059
----------------------------------- PR info ------------------------------------
Title      test_runner: run global after() hook earlier (#49059)
Author     Colin Ihrig  (@cjihrig)
Branch     cjihrig:after-handles -> nodejs:main
Labels     commit-queue-squash, test_runner
Commits    3
 - test_runner: run global after() hook earlier
 - test and feedback
 - other test
Committers 1
 - cjihrig 
PR-URL: https://github.com/nodejs/node/pull/49059
Fixes: https://github.com/nodejs/node/issues/49056
Reviewed-By: Chemi Atlow 
Reviewed-By: Moshe Atlow 
Reviewed-By: Matteo Collina 
Reviewed-By: Benjamin Gruenbaum 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49059
Fixes: https://github.com/nodejs/node/issues/49056
Reviewed-By: Chemi Atlow 
Reviewed-By: Moshe Atlow 
Reviewed-By: Matteo Collina 
Reviewed-By: Benjamin Gruenbaum 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 07 Aug 2023 22:03:17 GMT
   ✔  Approvals: 4
   ✔  - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/49059#pullrequestreview-1573038132
   ✔  - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/49059#pullrequestreview-1573061500
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/49059#pullrequestreview-1573130592
   ✔  - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/49059#pullrequestreview-1573170558
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2023-08-11T03:28:19Z: https://ci.nodejs.org/job/node-test-pull-request/53165/
- Querying data for job/node-test-pull-request/53165/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/5832906334
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cjihrig
test_runner: run global after() hook earlier
6346bdc 
This commit moves the global after() hook execution from the
'beforeExit' event to the point where all tests have finished
running. This gives the global after() a chance to clean up
handles that would otherwise prevent the 'beforeExit' event
from being emitted.

PR-URL: nodejs#49059
Fixes: nodejs#49056
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@cjihrig
cjihrig force-pushed the after-handles branch from 60c0edc to 6346bdc Compare August 11, 2023 13:17
@cjihrig
cjihrig merged commit 6346bdc into nodejs:main Aug 11, 2023
@cjihrig
cjihrig deleted the after-handles branch August 11, 2023 13:17
@cjihrig

cjihrig commented Aug 11, 2023

Copy link
Copy Markdown
Contributor Author

Landed in 6346bdc.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joyeecheung

joyeecheung commented Aug 11, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Not sure why but I am now constantly failing test-runner-output.mjs locally after pulling in this change. It passed again if I revert this commit.

See stack trace 
▶ test runner output
  ✔ test-runner/output/abort.js (1080.035875ms)
  ✔ test-runner/output/abort_suite.js (1100.539375ms)
  ✔ test-runner/output/abort_hooks.js (170.884375ms)
  ✔ test-runner/output/describe_it.js (725.507334ms)
  ✔ test-runner/output/describe_nested.js (119.515875ms)
  ✔ test-runner/output/hooks.js (177.523667ms)
  ✔ test-runner/output/timeout_in_before_each_should_not_affect_further_tests.js (1320.205417ms)
  ✔ test-runner/output/hooks-with-no-global-test.js (168.12325ms)
  ✔ test-runner/output/before-and-after-each-too-many-listeners.js (164.051292ms)
  ✔ test-runner/output/before-and-after-each-with-timeout-too-many-listeners.js (165.916292ms)
  ✖ test-runner/output/global_after_should_fail_the_test.js (171.50075ms)
    AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
    + actual - expected ... Lines skipped

      'this is a test\n' +
        'TAP version 13\n' +
    ...
        '  ---\n' +
        '  duration_ms: *\n' +
    -   '  ...\n' +
    -   'not ok 2 - /test/fixtures/test-runner/output/global_after_should_fail_the_test.js\n' +
    -   '  ---\n' +
    -   '  duration_ms: *\n' +
    -   "  location: '/test/fixtures/test-runner/output/global_after_should_fail_the_test.js:(LINE):1'\n" +
    -   "  failureType: 'hookFailed'\n" +
    -   "  error: 'this should fail the test'\n" +
    -   "  code: 'ERR_TEST_FAILURE'\n" +
    -   '  stack: |-\n' +
    -   '    *\n' +
    -   '    *\n' +
    -   '    *\n' +
    -   '    *\n' +
    -   '    *\n' +
    -   '    *\n' +
    -   '    *\n' +
    -   '    *\n' +
    -   '    *\n' +
        '  ...\n' +
    ...
        '# skipped 0\n' +
        '# todo 0\n' +
        '# duration_ms *\n'
        at assertSnapshot (/Users/joyee/projects/node/test/common/assertSnapshot.js:52:12)
        at async Module.spawnAndAssert (/Users/joyee/projects/node/test/common/assertSnapshot.js:80:3)
        at async TestContext.<anonymous> (file:///Users/joyee/projects/node/test/parallel/test-runner-output.mjs:95:5)
        at async Test.run (node:internal/test_runner/test:632:9)
        at async Promise.all (index 10)
        at async Suite.run (node:internal/test_runner/test:948:7)
        at async startSubtest (node:internal/test_runner/harness:208:3) {
      generatedMessage: true,
      code: 'ERR_ASSERTION',
      actual: 'this is a test\nTAP version 13\n# Subtest: this is a test\nok 1 - this is a test\n  ---\n  duration_ms: *\n  ...\n1..1\n# tests 1\n# suites 0\n...',
      expected: 'this is a test\nTAP version 13\n# Subtest: this is a test\nok 1 - this is a test\n  ---\n  duration_ms: *\n  ...\nnot ok 2 - /test/fixtures/test-runner/output/global_after_should_fail_the_test.js\n  ---\n  duration_ms: *\n...',
      operator: 'strictEqual'
    }

  ✔ test-runner/output/no_refs.js (149.993708ms)
  ✔ test-runner/output/no_tests.js (154.464834ms)
  ✔ test-runner/output/only_tests.js (169.572709ms)
  ✔ test-runner/output/dot_reporter.js (620.084375ms)
  ✔ test-runner/output/spec_reporter_successful.js (159.8035ms)
  ✔ test-runner/output/spec_reporter.js (625.975708ms)
  ✔ test-runner/output/spec_reporter_cli.js (663.377458ms)
  ✔ test-runner/output/output.js (541.202459ms)
  ✔ test-runner/output/output_cli.js (620.8815ms)
  ✔ test-runner/output/name_pattern.js (121.049417ms)
  ✔ test-runner/output/name_pattern_with_only.js (148.999583ms)
  ✔ test-runner/output/unresolved_promise.js (154.180542ms)
  ✔ test-runner/output/default_output.js (201.822875ms)
  ✔ test-runner/output/arbitrary-output.js (182.5105ms)
  ✔ test-runner/output/async-test-scheduling.mjs (156.54525ms)
  ✔ test-runner/output/arbitrary-output-colored.js (342.718166ms)
  ✔ test-runner/output/dot_output_custom_columns.js (207.744791ms)
  ✔ test-runner/output/tap_escape.js (130.406458ms)
▶ test runner output (1326.1695ms)

ℹ tests 29
ℹ suites 1
ℹ pass 28
ℹ fail 1
ℹ cancelled 0
ℹ skipped 0
ℹ todo 0
ℹ duration_ms 1328.780583

✖ failing tests:

test at file:/Users/joyee/projects/node/test/parallel/test-runner-output.mjs:101:5
✖ test-runner/output/global_after_should_fail_the_test.js (171.50075ms)
  AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
  + actual - expected ... Lines skipped

    'this is a test\n' +
      'TAP version 13\n' +
  ...
      '  ---\n' +
      '  duration_ms: *\n' +
  -   '  ...\n' +
  -   'not ok 2 - /test/fixtures/test-runner/output/global_after_should_fail_the_test.js\n' +
  -   '  ---\n' +
  -   '  duration_ms: *\n' +
  -   "  location: '/test/fixtures/test-runner/output/global_after_should_fail_the_test.js:(LINE):1'\n" +
  -   "  failureType: 'hookFailed'\n" +
  -   "  error: 'this should fail the test'\n" +
  -   "  code: 'ERR_TEST_FAILURE'\n" +
  -   '  stack: |-\n' +
  -   '    *\n' +
  -   '    *\n' +
  -   '    *\n' +
  -   '    *\n' +
  -   '    *\n' +
  -   '    *\n' +
  -   '    *\n' +
  -   '    *\n' +
  -   '    *\n' +
      '  ...\n' +
  ...
      '# skipped 0\n' +
      '# todo 0\n' +
      '# duration_ms *\n'
      at assertSnapshot (/Users/joyee/projects/node/test/common/assertSnapshot.js:52:12)
      at async Module.spawnAndAssert (/Users/joyee/projects/node/test/common/assertSnapshot.js:80:3)
      at async TestContext.<anonymous> (file:///Users/joyee/projects/node/test/parallel/test-runner-output.mjs:95:5)
      at async Test.run (node:internal/test_runner/test:632:9)
      at async Promise.all (index 10)
      at async Suite.run (node:internal/test_runner/test:948:7)
      at async startSubtest (node:internal/test_runner/harness:208:3) {
    generatedMessage: true,
    code: 'ERR_ASSERTION',
    actual: 'this is a test\nTAP version 13\n# Subtest: this is a test\nok 1 - this is a test\n  ---\n  duration_ms: *\n  ...\n1..1\n# tests 1\n# suites 0\n...',
    expected: 'this is a test\nTAP version 13\n# Subtest: this is a test\nok 1 - this is a test\n  ---\n  duration_ms: *\n  ...\nnot ok 2 - /test/fixtures/test-runner/output/global_after_should_fail_the_test.js\n  ---\n  duration_ms: *\n...',
    operator: 'strictEqual'
  }

I am on Apple M2 Max with macOS 13.4 though not sure how relevant that is.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joyeecheung joyeecheung mentioned this pull request Aug 11, 2023
Revert "test_runner: run global after() hook earlier" #49110
Merged
@richardlau richardlau mentioned this pull request Aug 11, 2023
build: fix typo libray -> library (configure.py) #49106
Merged
@cjihrig

cjihrig commented Aug 11, 2023

Copy link
Copy Markdown
Contributor Author

FWIW, here is the fix before the revert:

diff --git a/lib/internal/test_runner/test.js b/lib/internal/test_runner/test.js
index f8c9087f6c..975ad4ac08 100644
--- a/lib/internal/test_runner/test.js
+++ b/lib/internal/test_runner/test.js
@@ -662,7 +662,7 @@ class Test extends AsyncResource {
       }
     }
 
-    if (this.parent !== null) {
+    if (this.parent !== null || typeof this.hookType === 'string') {
       // Clean up the test. Then, try to report the results and execute any
       // tests that were pending due to available concurrency.
       //
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cjihrig added a commit to cjihrig/node that referenced this pull request Aug 12, 2023
@cjihrig
test_runner: reland run global after() hook earlier
6796570 
This commit reverts the revert in
bb52656. It also includes the
fix for the issue that required the revert
(nodejs#49059 (comment))
and an additional common.mustCall() in the added test.

Refs: nodejs#49059
Refs: nodejs#49110
@cjihrig cjihrig mentioned this pull request Aug 12, 2023
test_runner: reland run global after() hook earlier #49116
Merged
@atlowChemi atlowChemi mentioned this pull request Aug 12, 2023
stream: improve WebStreams creation performance #49089
Merged
@github-actions github-actions Bot mentioned this pull request Aug 13, 2023
CI Reliability 2023-08-13 nodejs/reliability#635
Open
29 tasks
nodejs-github-bot pushed a commit that referenced this pull request Aug 14, 2023
@cjihrig
test_runner: reland run global after() hook earlier
b574075 
This commit reverts the revert in
bb52656. It also includes the
fix for the issue that required the revert
(#49059 (comment))
and an additional common.mustCall() in the added test.

Refs: #49059
Refs: #49110
PR-URL: #49116
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@cjihrig @Ceres6
test_runner: run global after() hook earlier
7e81628 
This commit moves the global after() hook execution from the
'beforeExit' event to the point where all tests have finished
running. This gives the global after() a chance to clean up
handles that would otherwise prevent the 'beforeExit' event
from being emitted.

PR-URL: nodejs#49059
Fixes: nodejs#49056
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@cjihrig @Ceres6
test_runner: run global after() hook earlier
489984c 
This commit moves the global after() hook execution from the
'beforeExit' event to the point where all tests have finished
running. This gives the global after() a chance to clean up
handles that would otherwise prevent the 'beforeExit' event
from being emitted.

PR-URL: nodejs#49059
Fixes: nodejs#49056
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@cjihrig @Ceres6
test_runner: reland run global after() hook earlier
1373b69 
This commit reverts the revert in
bb52656. It also includes the
fix for the issue that required the revert
(nodejs#49059 (comment))
and an additional common.mustCall() in the added test.

Refs: nodejs#49059
Refs: nodejs#49110
PR-URL: nodejs#49116
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
@cjihrig @RafaelGSS
test_runner: run global after() hook earlier
b58688b 
This commit moves the global after() hook execution from the
'beforeExit' event to the point where all tests have finished
running. This gives the global after() a chance to clean up
handles that would otherwise prevent the 'beforeExit' event
from being emitted.

PR-URL: #49059
Fixes: #49056
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
@cjihrig @RafaelGSS
test_runner: reland run global after() hook earlier
adab698 
This commit reverts the revert in
bb52656. It also includes the
fix for the issue that required the revert
(#49059 (comment))
and an additional common.mustCall() in the added test.

Refs: #49059
Refs: #49110
PR-URL: #49116
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Aug 15, 2023
v20.6.0 proposal #49185
Merged
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Aug 15, 2023
@cjihrig @RafaelGSS
test_runner: run global after() hook earlier
280b735 
This commit moves the global after() hook execution from the
'beforeExit' event to the point where all tests have finished
running. This gives the global after() a chance to clean up
handles that would otherwise prevent the 'beforeExit' event
from being emitted.

PR-URL: nodejs#49059
Fixes: nodejs#49056
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Aug 15, 2023
@cjihrig @RafaelGSS
test_runner: reland run global after() hook earlier
b9407ff 
This commit reverts the revert in
bb52656. It also includes the
fix for the issue that required the revert
(nodejs#49059 (comment))
and an additional common.mustCall() in the added test.

Refs: nodejs#49059
Refs: nodejs#49110
PR-URL: nodejs#49116
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@aduh95 aduh95 added dont-land-on-v16.x labels Aug 16, 2023
RafaelGSS pushed a commit that referenced this pull request Aug 16, 2023
@cjihrig @RafaelGSS
test_runner: reland run global after() hook earlier
324c8a1 
This commit reverts the revert in
bb52656. It also includes the
fix for the issue that required the revert
(#49059 (comment))
and an additional common.mustCall() in the added test.

Refs: #49059
Refs: #49110
PR-URL: #49116
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
rluvaton pushed a commit to rluvaton/node that referenced this pull request Sep 4, 2023
@cjihrig @rluvaton
test_runner: reland run global after() hook earlier
2ad1bbc 
This commit reverts the revert in
bb52656. It also includes the
fix for the issue that required the revert
(nodejs#49059 (comment))
and an additional common.mustCall() in the added test.

Refs: nodejs#49059
Refs: nodejs#49110
PR-URL: nodejs#49116
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
@cjihrig @UlisesGascon
test_runner: reland run global after() hook earlier
546ad5f 
This commit reverts the revert in
bb52656. It also includes the
fix for the issue that required the revert
(#49059 (comment))
and an additional common.mustCall() in the added test.

Refs: #49059
Refs: #49110
PR-URL: #49116
Backport-PR-URL: #49225
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Oct 9, 2023
2023-10-17, Version 21.0.0 (Current) #49870
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
@cjihrig @targos
test_runner: reland run global after() hook earlier
d839640 
This commit reverts the revert in
bb52656. It also includes the
fix for the issue that required the revert
(#49059 (comment))
and an additional common.mustCall() in the added test.

Refs: #49059
Refs: #49110
PR-URL: #49116
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test_runner: reland run global after() hook earlier
7b5134a 
This commit reverts the revert in
bb52656. It also includes the
fix for the issue that required the revert
(nodejs/node#49059 (comment))
and an additional common.mustCall() in the added test.

Refs: nodejs/node#49059
Refs: nodejs/node#49110
PR-URL: nodejs/node#49116
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test_runner: reland run global after() hook earlier
b4224c7 
This commit reverts the revert in
bb52656. It also includes the
fix for the issue that required the revert
(nodejs/node#49059 (comment))
and an additional common.mustCall() in the added test.

Refs: nodejs/node#49059
Refs: nodejs/node#49110
PR-URL: nodejs/node#49116
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes
@benjamingr benjamingr benjamingr approved these changes
@MoLow MoLow MoLow approved these changes
@atlowChemi atlowChemi atlowChemi approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. commit-queue-squash PRs the Commit Queue should land as one squashed commit. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test_runner: global after not run if handles are open

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@cjihrig @nodejs-github-bot @MoLow @joyeecheung @mcollina @benjamingr @atlowChemi @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.