GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — test_runner: reland run global after() hook earlier by cjihrig · Pull Request #49116 · nodejs/node

Conversation

cjihrig commented Aug 12, 2023

Copy link

Copy Markdown

Contributor

This commit reverts the revert in
bb52656. It also includes the fix for the issue that required the revert
(#49059 (comment)) and an additional common.mustCall() in the added test.

Refs: #49059
Refs: #49110

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss reacted with thumbs up emoji

All reactions

👍 1 reaction


          test_runner: reland run global after() hook earlier

This commit reverts the revert in
bb52656. It also includes the
fix for the issue that required the revert
(nodejs#49059 (comment))
and an additional common.mustCall() in the added test.

Refs: nodejs#49059
Refs: nodejs#49110

cjihrig requested review from MoLow, atlowChemi, benjamingr and mcollina

August 12, 2023 14:18

nodejs-github-bot commented Aug 12, 2023

Copy link

Copy Markdown

Collaborator

Review requested:

@nodejs/test_runner

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot added needs-ci

PRs that need a full CI run.

test_runner Issues and PRs related to the test runner subsystem. labels

Aug 12, 2023

mcollina approved these changes

Aug 12, 2023

View reviewed changes

mcollina left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

atlowChemi approved these changes

Aug 12, 2023

View reviewed changes

atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Aug 12, 2023

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Aug 12, 2023

nodejs-github-bot commented Aug 12, 2023

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53242/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

atlowChemi added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label

Aug 12, 2023

nodejs-github-bot commented Aug 12, 2023

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53243/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

MoLow approved these changes

Aug 12, 2023

View reviewed changes

nodejs-github-bot commented Aug 12, 2023

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53248/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Aug 12, 2023 •

edited by cjihrig

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53250/ 🟡

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot mentioned this pull request

Aug 13, 2023

CI Reliability 2023-08-13 nodejs/reliability#635

Open

29 tasks

cjihrig removed the needs-ci PRs that need a full CI run. label

Aug 13, 2023

benjamingr approved these changes

Aug 13, 2023

View reviewed changes

atlowChemi added the commit-queue PRs queued for automated landing through the Commit Queue. label

Aug 13, 2023

rluvaton reviewed

Aug 13, 2023

View reviewed changes

Comment thread

lib/internal/test_runner/harness.js

		const exitHandler = async () => {
		await root.run(new ERR_TEST_FAILURE(
		const exitHandler = () => {
		root.postRun(new ERR_TEST_FAILURE(

rluvaton Aug 13, 2023

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not await?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

atlowChemi Aug 13, 2023

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rluvaton postRun returns void (and not a Promise)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

rluvaton Aug 13, 2023

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I changed that (or I'm thinking of another function there) 😅

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

github-actions Bot mentioned this pull request

Aug 14, 2023

CI Reliability 2023-08-14 nodejs/reliability#636

Open

25 tasks

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label

Aug 14, 2023

nodejs-github-bot merged commit b574075 into nodejs:main

Aug 14, 2023

nodejs-github-bot commented Aug 14, 2023

Copy link

Copy Markdown

Collaborator

Landed in b574075

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Ceres6 pushed a commit to Ceres6/node that referenced this pull request

Aug 14, 2023


          test_runner: reland run global after() hook earlier

1373b69

This commit reverts the revert in
bb52656. It also includes the
fix for the issue that required the revert
(nodejs#49059 (comment))
and an additional common.mustCall() in the added test.

Refs: nodejs#49059
Refs: nodejs#49110
PR-URL: nodejs#49116
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>

github-actions Bot mentioned this pull request

Aug 15, 2023

CI Reliability 2023-08-15 nodejs/reliability#637

Open

22 tasks

RafaelGSS pushed a commit that referenced this pull request

Aug 15, 2023


          test_runner: reland run global after() hook earlier

adab698

This commit reverts the revert in
bb52656. It also includes the
fix for the issue that required the revert
(#49059 (comment))
and an additional common.mustCall() in the added test.

Refs: #49059
Refs: #49110
PR-URL: #49116
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>

UlisesGascon mentioned this pull request

Aug 15, 2023

v20.6.0 proposal #49185

Merged

RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request

Aug 15, 2023


          test_runner: reland run global after() hook earlier

b9407ff

This commit reverts the revert in
bb52656. It also includes the
fix for the issue that required the revert
(nodejs#49059 (comment))
and an additional common.mustCall() in the added test.

Refs: nodejs#49059
Refs: nodejs#49110
PR-URL: nodejs#49116
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>

RafaelGSS pushed a commit that referenced this pull request

Aug 16, 2023


          test_runner: reland run global after() hook earlier

324c8a1

This commit reverts the revert in
bb52656. It also includes the
fix for the issue that required the revert
(#49059 (comment))
and an additional common.mustCall() in the added test.

Refs: #49059
Refs: #49110
PR-URL: #49116
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>

cjihrig deleted the reland branch

August 17, 2023 16:52

RafaelGSS added the backport-requested-v20.x label

Aug 17, 2023

RafaelGSS commented Aug 17, 2023

Copy link

Copy Markdown

Member

Due to fact, #48877 didn't land cleanly on v20.x-staging. This PR somehow, depends on it. So we'll need a manual backport.

Reference: https://github.com/nodejs/node/blob/main/doc/contributing/backporting-to-release-lines.md

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

rluvaton mentioned this pull request

Aug 18, 2023

[v20.x backport] backport multiple test runner related prs #49225

Closed

rluvaton added backport-open-v20.x and removed backport-requested-v20.x labels

Aug 18, 2023

rluvaton commented Aug 18, 2023

Copy link

Copy Markdown

Member

Backport PR:

[v20.x backport] backport multiple test runner related prs #49225

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

rluvaton pushed a commit to rluvaton/node that referenced this pull request

Sep 4, 2023


          test_runner: reland run global after() hook earlier

2ad1bbc

This commit reverts the revert in
bb52656. It also includes the
fix for the issue that required the revert
(nodejs#49059 (comment))
and an additional common.mustCall() in the added test.

Refs: nodejs#49059
Refs: nodejs#49110
PR-URL: nodejs#49116
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>

UlisesGascon pushed a commit that referenced this pull request

Sep 10, 2023


          test_runner: reland run global after() hook earlier

546ad5f

This commit reverts the revert in
bb52656. It also includes the
fix for the issue that required the revert
(#49059 (comment))
and an additional common.mustCall() in the added test.

Refs: #49059
Refs: #49110
PR-URL: #49116
Backport-PR-URL: #49225
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>

UlisesGascon mentioned this pull request

Sep 10, 2023

v20.7.0 proposal #49592

Merged

targos added backported-to-v20.x and removed backport-open-v20.x labels

Nov 12, 2023

targos pushed a commit that referenced this pull request

Nov 27, 2023


          test_runner: reland run global after() hook earlier

d839640

This commit reverts the revert in
bb52656. It also includes the
fix for the issue that required the revert
(#49059 (comment))
and an additional common.mustCall() in the added test.

Refs: #49059
Refs: #49110
PR-URL: #49116
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>

targos mentioned this pull request

Nov 28, 2023

v18.19.0 release proposal #50953

Merged

sercher added a commit to sercher/graaljs that referenced this pull request

Apr 25, 2024


          test_runner: reland run global after() hook earlier

7b5134a

This commit reverts the revert in
bb52656. It also includes the
fix for the issue that required the revert
(nodejs/node#49059 (comment))
and an additional common.mustCall() in the added test.

Refs: nodejs/node#49059
Refs: nodejs/node#49110
PR-URL: nodejs/node#49116
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>

sercher added a commit to sercher/graaljs that referenced this pull request

Apr 25, 2024


          test_runner: reland run global after() hook earlier

b4224c7

This commit reverts the revert in
bb52656. It also includes the
fix for the issue that required the revert
(nodejs/node#49059 (comment))
and an additional common.mustCall() in the added test.

Refs: nodejs/node#49059
Refs: nodejs/node#49110
PR-URL: nodejs/node#49116
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>

Reviewers

rluvaton

rluvaton left review comments

atlowChemi

atlowChemi approved these changes

mcollina

mcollina approved these changes

benjamingr

benjamingr approved these changes

MoLow

MoLow approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready

PRs with CI started, the required approvals, and no outstanding review comments.

test_runner

Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

cjihrig commented Aug 12, 2023

Uh oh!

nodejs-github-bot commented Aug 12, 2023

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Aug 12, 2023

Uh oh!

nodejs-github-bot commented Aug 12, 2023

Uh oh!

nodejs-github-bot commented Aug 12, 2023

Uh oh!

nodejs-github-bot commented Aug 12, 2023 • edited by cjihrig Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rluvaton Aug 13, 2023

Choose a reason for hiding this comment

Uh oh!

atlowChemi Aug 13, 2023

Choose a reason for hiding this comment

Uh oh!

rluvaton Aug 13, 2023

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Aug 14, 2023

Uh oh!

RafaelGSS commented Aug 17, 2023

Uh oh!

rluvaton commented Aug 18, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

nodejs-github-bot commented Aug 12, 2023 •

edited by cjihrig

Loading

Uh oh!

There was an error while loading. Please reload this page.