GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — esm: require braces for modules code by GeoffreyBooth · Pull Request #49657 · nodejs/node

Conversation

GeoffreyBooth commented Sep 14, 2023

Copy link

Copy Markdown

Member

Split out from #49523 per #49523 (comment).

This PR adds a lint rule to formalize our informal rule for modules code, where we try to always use braces to enclose blocks (so no implicit blocks after things like if conditions).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss reacted with thumbs up emoji

All reactions

👍 1 reaction

GeoffreyBooth added esm

Issues and PRs related to the ECMAScript Modules implementation.

fast-track PRs proposed for a shorter-than-standard waiting period before landing. labels

Sep 14, 2023

GeoffreyBooth requested a review from aduh95

September 14, 2023 22:08

nodejs-github-bot commented Sep 14, 2023

Copy link

Copy Markdown

Collaborator

Review requested:

@nodejs/loaders

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot commented Sep 14, 2023

Copy link

Copy Markdown

Contributor

Fast-track has been requested by @GeoffreyBooth. Please 👍 to approve.

bricss, aduh95, JakobJingleheimer, and surajshende247 reacted with thumbs up emoji

All reactions

👍 4 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot added lib / src

Issues and PRs involving general changes in the lib/ or src/ directories.

needs-ci PRs that need a full CI run. labels

Sep 14, 2023

ljharb approved these changes

Sep 14, 2023

View reviewed changes

aduh95 approved these changes

Sep 14, 2023

View reviewed changes

Comment thread

lib/internal/modules/cjs/loader.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

GeoffreyBooth force-pushed the modules-code-add-braces branch from 9a8027e to 83342a5 Compare

September 15, 2023 04:59

GeoffreyBooth mentioned this pull request

Sep 15, 2023

test: fix edge snapshot stack traces #49659

Merged

GeoffreyBooth force-pushed the modules-code-add-braces branch from 83342a5 to 6557d26 Compare

September 15, 2023 05:09

aduh95 reviewed

Sep 15, 2023

There was an error while loading. Please reload this page.

GeoffreyBooth and others added 5 commits

September 15, 2023 10:10


          esm: require braces for modules code

0a1b3ee


          Add missing braces

024a2c1


          Apply suggestions from code review

a9a976e


          fix lint

17b4d98


          fix tests

9e3e794

aduh95 force-pushed the modules-code-add-braces branch from 3be8276 to 9e3e794 Compare

September 15, 2023 08:14

aduh95 added author ready

PRs with CI started, the required approvals, and no outstanding review comments.

request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels

Sep 15, 2023

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Sep 15, 2023

nodejs-github-bot commented Sep 15, 2023

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53959/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Sep 15, 2023

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53960/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

JakobJingleheimer approved these changes

Sep 15, 2023

View reviewed changes

nodejs-github-bot commented Sep 15, 2023

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53969/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label

Sep 15, 2023

GeoffreyBooth added the commit-queue-squash PRs the Commit Queue should land as one squashed commit. label

Sep 15, 2023

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label

Sep 15, 2023

nodejs-github-bot merged commit f42a103 into nodejs:main

Sep 15, 2023

This was referenced Sep 17, 2023

CI Reliability 2023-09-17 nodejs/reliability#668

Open

CI Reliability 2023-09-18 nodejs/reliability#669

Open

CI Reliability 2023-09-19 nodejs/reliability#670

Open

ruyadorno commented Sep 28, 2023

Copy link

Copy Markdown

Member

This commit does not land cleanly on v20.x-staging and will need manual backport in case we want it in v20.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ruyadorno added the backport-requested-v20.x label

Sep 28, 2023

RafaelGSS mentioned this pull request

Oct 9, 2023

2023-10-17, Version 21.0.0 (Current) #49870

Merged

GeoffreyBooth mentioned this pull request

Oct 19, 2023

[v20.x backport] backport: esm: require braces for modules code #50268

Closed

GeoffreyBooth added backport-open-v20.x and removed backport-requested-v20.x labels

Oct 19, 2023

GeoffreyBooth added a commit to GeoffreyBooth/node that referenced this pull request

Oct 19, 2023


          esm: require braces for modules code

83e582a

PR-URL: nodejs#49657
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>

targos mentioned this pull request

Nov 11, 2023

[v18.x] Backport most ESM and customization hook changes #50669

Closed

targos added backported-to-v20.x and removed backport-open-v20.x labels

Nov 11, 2023

targos pushed a commit that referenced this pull request

Nov 11, 2023


          esm: require braces for modules code

PR-URL: #49657
Backport-PR-URL: #50268
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>

targos pushed a commit to targos/node that referenced this pull request

Nov 11, 2023


          esm: require braces for modules code

c262d3b

PR-URL: nodejs#49657
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>

targos mentioned this pull request

Nov 12, 2023

v20.10.0 release proposal #50682

Merged

targos added the backported-to-v18.x label

Nov 23, 2023

targos pushed a commit that referenced this pull request

Nov 23, 2023


          esm: require braces for modules code

957725f

PR-URL: #49657
Backport-PR-URL: #50669
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>

targos mentioned this pull request

Nov 28, 2023

v18.19.0 release proposal #50953

Merged

juanarbol mentioned this pull request

Dec 6, 2023

2023-12-06, N|Solid v5.0.1 Iron Release nodesource/nsolid#41

Merged

ckerr added a commit to electron/electron that referenced this pull request

Dec 7, 2023


          chore: update pass_all_globals_through_require.patch

2d3c55f

no manual changes; patch applied with fuzz

Xref: nodejs/node#49657

ckerr added a commit to electron/electron that referenced this pull request

Dec 7, 2023


          update fix_expose_the_built-in_electron_module_via_the_esm_loader.patch

d44b426

Xref: nodejs/node#50096
Xref: nodejs/node#50314
in lib/internal/modules/esm/load.js, update the code that checks for
`format === 'electron'`. I'd like 👀 on this

Xref: nodejs/node#49657
add braces in lib/internal/modules/esm/translators.js to sync with upstream

codebytere pushed a commit to electron/electron that referenced this pull request

Dec 8, 2023


          chore: update pass_all_globals_through_require.patch

9e47ee7

no manual changes; patch applied with fuzz

Xref: nodejs/node#49657

codebytere pushed a commit to electron/electron that referenced this pull request

Dec 8, 2023


          update fix_expose_the_built-in_electron_module_via_the_esm_loader.patch

077c8e4

Xref: nodejs/node#50096
Xref: nodejs/node#50314
in lib/internal/modules/esm/load.js, update the code that checks for
`format === 'electron'`. I'd like 👀 on this

Xref: nodejs/node#49657
add braces in lib/internal/modules/esm/translators.js to sync with upstream

codebytere added a commit to electron/electron that referenced this pull request

Dec 11, 2023


          chore: bump node to v20.10.0 (main) (#40675)

890a557

* chore: bump node in DEPS to v20.10.0

* chore: update feat_initialize_asar_support.patch

no code changes; patch just needed an update due to nearby upstream changes

Xref: nodejs/node#49986

* chore: update pass_all_globals_through_require.patch

no manual changes; patch applied with fuzz

Xref: nodejs/node#49657

* chore: update refactor_allow_embedder_overriding_of_internal_fs_calls

Xref: nodejs/node#49912

no code changes; patch just needed an update due to nearby upstream changes

* chore: update chore_allow_the_node_entrypoint_to_be_a_builtin_module.patch

Xref: nodejs/node#49986

minor manual changes needed to sync with upstream change

* update fix_expose_the_built-in_electron_module_via_the_esm_loader.patch

Xref: nodejs/node#50096
Xref: nodejs/node#50314
in lib/internal/modules/esm/load.js, update the code that checks for
`format === 'electron'`. I'd like 👀 on this

Xref: nodejs/node#49657
add braces in lib/internal/modules/esm/translators.js to sync with upstream

* fix: lazyload fs in esm loaders to apply asar patches

* nodejs/node#50127
* nodejs/node#50096

* esm: jsdoc for modules code

nodejs/node#49523

* test: set test-cli-node-options as flaky

nodejs/node#50296

* deps: update c-ares to 1.20.1

nodejs/node#50082

* esm: bypass CommonJS loader under --default-type=module

nodejs/node#49986

* deps: update uvwasi to 0.0.19

nodejs/node#49908

* lib,test: do not hardcode Buffer.kMaxLength

nodejs/node#49876

* crypto: account for disabled SharedArrayBuffer

nodejs/node#50034

* test: fix edge snapshot stack traces

nodejs/node#49659

* src: generate snapshot with --predictable

nodejs/node#48749

* chore: fixup patch indices

* fs: throw errors from sync branches instead of separate implementations

nodejs/node#49913

* crypto: ensure valid point on elliptic curve in SubtleCrypto.importKey

nodejs/node#50234

* esm: detect ESM syntax in ambiguous JavaScrip

nodejs/node#50096

* fixup! test: fix edge snapshot stack traces

* esm: unflag extensionless ES module JavaScript and Wasm in module scope

nodejs/node#49974

* [tagged-ptr] Arrowify objects

https://chromium-review.googlesource.com/c/v8/v8/+/4705331

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <[email protected]>
Co-authored-by: Shelley Vohr <[email protected]>

sercher added a commit to sercher/graaljs that referenced this pull request

Apr 25, 2024


          esm: require braces for modules code

009f613

PR-URL: nodejs/node#49657
Backport-PR-URL: nodejs/node#50669
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>

sercher added a commit to sercher/graaljs that referenced this pull request

Apr 25, 2024


          esm: require braces for modules code

4dc712f

PR-URL: nodejs/node#49657
Backport-PR-URL: nodejs/node#50669
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>

Reviewers

aduh95

aduh95 approved these changes

ljharb

ljharb approved these changes

JakobJingleheimer

JakobJingleheimer approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready

PRs with CI started, the required approvals, and no outstanding review comments.

commit-queue-squash

PRs the Commit Queue should land as one squashed commit.

esm

Issues and PRs related to the ECMAScript Modules implementation.

fast-track

PRs proposed for a shorter-than-standard waiting period before landing.

lib / src

Issues and PRs involving general changes in the lib/ or src/ directories.

needs-ci

PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.