GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — esm: detect ESM syntax in ambiguous JavaScript by GeoffreyBooth · Pull Request #50096 · nodejs/node

Conversation

GeoffreyBooth commented Oct 9, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Implements #50064. This PR aims to allow Node.js to allow ES module syntax input by default, without the user needing to opt in by using a non-.js extension, a package.json "type" field or a command-line flag. The goal is to make this enabled by default, unflagged, once we consider it stable.

For the following “ambiguous” inputs:

Files with a .js extension or no extension; and either no controlling package.json or one that lacks a type field; and --experimental-default-type is not specified
String input (--eval or STDIN) when neither --input-type nor --experimental-default-type are specified

Node will do the following:

For ambiguous main entry point, either file or string input, the new containsModuleSyntax function from esm: improve check for ESM syntax #50127 is used to determine whether the CommonJS or ESM loader should handle the main entry. (The ESM loader is used if the main entry contains module syntax.)
When the ESM loader is handling modules, within the load hook, once the source is loaded it will be passed to containsModuleSyntax to determine whether the format should be module or commonjs (again, only for the ambiguous inputs specified above).

This behavior applies to ambiguous files within node_modules. This is to prevent the hazard where a package author writes a library relying on this detection behavior but consumers of the package would fail to load it if they didn’t also have the detection behavior. (Such a hazard will still exist for consumers running old versions of Node, but at least it’s avoided moving forward.)

This behavior applies to the main entry point and to files referenced via import. It would not apply to files referenced via require, because require cannot load ES modules.

This behavior does not apply to modules with any marker of explicitness: an .mjs or .cjs extension, a package.json with a type field, specified --input-type or --experimental-default-type flags.

This behavior does not apply to --print input, as --print does not support ESM syntax.

When enabled, detection should have no impact on all-CommonJS apps (either written that way or transpiled into CommonJS) since detection isn’t run on files that are referenced via require; such apps would incur only a single double parse for the entry point (and therefore never opt into the ESM loader). The largest impact would be for ESM apps with CommonJS dependencies that lack type fields.

Before unflagging this we need to confirm that when enabled, this doesn’t affect any apps that run without erroring today. Or inversely it should have no effect on anything that already runs successfully, and therefore is not a breaking change.

cc @nodejs/performance @nodejs/loaders @nodejs/tsc

Notable change

The new flag --experimental-detect-module can be used to automatically run ES modules when their syntax can be detected. For “ambiguous” files, which are .js or extensionless files with no package.json with a type field, Node.js will parse the file to detect ES module syntax; if found, it will run the file as an ES module, otherwise it will run the file as a CommonJS module. The same applies to string input via --eval or STDIN.

We hope to make detection enabled by default in a future version of Node.js. Detection increases startup time, so we encourage everyone—especially package authors—to add a type field to package.json, even for the default "type": "commonjs". The presence of a type field, or explicit extensions such as .mjs or .cjs, will opt out of detection.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

meyfa, silverwind, bricss, danielbayley, H4ad, styfle, karlhorky, MurzNN, nickserv, lin72h, and 17 more reacted with heart emoji

All reactions

❤️ 27 reactions

GeoffreyBooth added module

Issues and PRs related to the module subsystem.

cli

Issues and PRs related to the Node.js command-line interface.

esm Issues and PRs related to the ECMAScript Modules implementation. labels

Oct 9, 2023

nodejs-github-bot commented Oct 9, 2023

Copy link

Copy Markdown

Collaborator

Review requested:

@nodejs/loaders

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot added lib / src

Issues and PRs involving general changes in the lib/ or src/ directories.

needs-ci PRs that need a full CI run. labels

Oct 9, 2023

ljharb reviewed

Oct 9, 2023

View reviewed changes

Comment thread

lib/internal/modules/esm/translators.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

lib/internal/modules/esm/translators.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

lib/internal/modules/helpers.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

GeoffreyBooth force-pushed the ambiguous-detection branch from dc43188 to 3a37bc3 Compare

October 9, 2023 05:50

This was referenced Oct 9, 2023

Node.js Loaders Team Meeting 2023-10-10 nodejs/loaders#165

Closed

When to make --default-type=module the Node.js default nodejs/TSC#1445

Closed

MoLow reviewed

Oct 9, 2023

View reviewed changes

Comment thread

doc/api/esm.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

GeoffreyBooth commented Oct 9, 2023

Copy link

Copy Markdown

Member Author

There are tests failing because of the change in this PR where I move the attempted CommonJS module load out of the ModuleWrap callback to just before that callback is defined, because I need it earlier so that we can retry as ESM. (https://github.com/nodejs/node/pull/50096/files#diff-b1de5e9ce1e9b411001c63d11a5092dbba32e1586269a20dc11408375eb2f16cR309-R318.) The failing tests are ones that compare error messages and stacks, and I suspect that some of these are legitimate errors because of some special handling that happens to errors thrown within the ModuleWrap callback. If someone who knows C++ and/or ModuleWrap can help me figure out how to preserve the prior error handling behavior, I could use the assistance.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mcollina commented Oct 9, 2023

Copy link

Copy Markdown

Member

I think @jasnell did some analysis on related topics using perf_hooks.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

GeoffreyBooth commented Oct 9, 2023

Copy link

Copy Markdown

Member Author

Looking at the first broken test, it’s for the debugger pausing on caught exceptions. The PR as currently written puts the “module load” within a try/catch, where inside the catch I check if we should do the “try again as ESM” logic, else rethrow the error. This new try/catch changes the error that the “debugger catches caught exceptions” test is asserting against.

To fix the test, I can move the “should we retry” condition outside of the try/catch, so it’s like “if we’re in detect/retry mode, try/catch and retry; else just module load.” But the issue there is that the test will pass now while there’s a flag, but once the flag is removed and we’re in detect/retry mode by default, I’ll be back to the broken test so long as the test case remains ambiguous code.

Which leads to the bigger question, is that should Node adding a try/catch around module loading be considered a breaking change? If not, then I can just update the test accordingly and move on. I have a feeling that many of the other broken tests will be things like this, where the tests are checking very specific things in Node’s internals (like particular stack traces, or async resources created) that change in this branch, even for CommonJS code that executes successfully. We can always mark this as semver-major, and go into detail in the release notes of the edge cases that are affected; most real-world code should run unaffected. Or if the things that change as a result of this are internals that we don’t consider part of the public API, then the changes shouldn’t be considered breaking.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joyeecheung reviewed

Oct 10, 2023

View reviewed changes

Comment thread

lib/internal/modules/esm/translators.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

lib/internal/modules/run_main.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

GeoffreyBooth force-pushed the ambiguous-detection branch 3 times, most recently from 34f7a35 to 6c1c2f5 Compare

October 10, 2023 06:07

targos commented Oct 10, 2023

Copy link

Copy Markdown

Member

I'd like to see some tests that verify we don't catch runtime exceptions. For example, this should throw in CommonJS and not trigger the ESM re-evaluation.

eval('import "something";');

GeoffreyBooth, Qard, and lin72h reacted with thumbs up emoji

All reactions

👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

GeoffreyBooth mentioned this pull request

Oct 10, 2023

esm: improve check for ESM syntax #50127

Merged

GeoffreyBooth marked this pull request as draft

October 11, 2023 22:36

GeoffreyBooth commented Oct 11, 2023

Copy link

Copy Markdown

Member Author

I’m going to redo this to use #50127 once that lands.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

GeoffreyBooth force-pushed the ambiguous-detection branch from 6c1c2f5 to a45e219 Compare

October 15, 2023 02:23

GeoffreyBooth commented Oct 15, 2023

Copy link

Copy Markdown

Member Author

I’ve updated this to build on #50127. You can see the differences that this PR adds at https://github.com/GeoffreyBooth/node/compare/better-esm-check…GeoffreyBooth:node:ambiguous-detection

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

GeoffreyBooth marked this pull request as ready for review

October 15, 2023 02:36

GeoffreyBooth force-pushed the ambiguous-detection branch from a45e219 to 063aec0 Compare

October 15, 2023 05:14

anonrig reviewed

Oct 15, 2023

View reviewed changes

Comment thread

lib/internal/modules/run_main.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

GeoffreyBooth force-pushed the ambiguous-detection branch 3 times, most recently from c086c61 to c3ed61c Compare

October 17, 2023 03:08

GeoffreyBooth mentioned this pull request

Nov 17, 2023

Node.js module changes npm/cli#6855

Closed

wraithgar commented Nov 17, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

What do we do with all of the packages that exist today? They're idempotent and can't change.

I would humbly suggest this is a mistake. If I were to pick the number one lesson learned in the last 14 years of npm's history it would be: "Do not try to guess user intent". You have a clear way for folks to indicate module type, and over a decade of history for what that type is if this new feature is not being indicated. Why are we slowing down every package that exists for an implementation of guessing what the user wants?

ljharb, nickserv, joshuajaco, and gmarinov reacted with thumbs up emoji

ljharb reacted with heart emoji

ljharb reacted with rocket emoji

All reactions

👍 4 reactions
❤️ 1 reaction
🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

GeoffreyBooth commented Nov 17, 2023

Copy link

Copy Markdown

Member Author

@wraithgar That was considered; see the referenced issues. There are use cases that just can't be solved, such as ESM syntax in loose extensionless files, without either a breaking change or detection. Adding detection is the least bad option. We spent months considering other options.

It's been a strong recommendation for years in the Node docs that every package author include the type field. Once this feature becomes enabled by default, such packages will still work, they'll just increase the overall app startup time slightly. Runtime performance is unaffected. We felt that this is an acceptable trade-off for finally supporting the remaining use cases and to support ESM syntax by default without requiring an opt in.

If you'd like to discuss further please open a new issue.

karlhorky and cray0000 reacted with thumbs up emoji

All reactions

👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ljharb commented Nov 17, 2023

Copy link

Copy Markdown

Member

I've proposed a solution multiple times (including during the modules WG discussions) that doesn't require either one of those, but you keep ignoring it. An extensions map would be a superior nonbreaking replacement for type that would cover extensionless files.

nickserv reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

targos added a commit that referenced this pull request

Nov 21, 2023


          2023-11-22, Version 20.10.0 'Iron' (LTS)

a220664

Notable changes:

deps:
  * (SEMVER-MINOR) update uvwasi to 0.0.19 (Node.js GitHub Bot) #49908
doc:
  * add H4ad to collaborators (Vinícius Lourenço) #50217
esm:
  * (SEMVER-MINOR) detect ESM syntax in ambiguous JavaScript (Geoffrey Booth) #50096
  * use import attributes instead of import assertions (Antoine du Hamel) #50140
  * --experimental-default-type flag to flip module defaults (Geoffrey Booth) #49869
fs:
  * (SEMVER-MINOR) add flush option to appendFile() functions (Colin Ihrig) #50095
  * add flush option to writeFile() functions (Colin Ihrig) #50009
lib:
  * (SEMVER-MINOR) add WebSocket client (Matthew Aitken) #49830
stream:
  * (SEMVER-MINOR) allow pass stream class to `stream.compose` (Alex Yang) #50187
  * call helper function from push and unshift (Raz Luvaton) #50173
  * optimize Writable (Robert Nagy) #50012
test_runner, cli:
  * (SEMVER-MINOR) add --test-concurrency flag (Colin Ihrig) #49996
vm:
  * (SEMVER-MINOR) use import attributes instead of import assertions (Antoine du Hamel) #50141
  * use default HDO when importModuleDynamically is not set (Joyee Cheung) #49950
wasi:

PR-URL: #50682

targos added a commit that referenced this pull request

Nov 22, 2023


          2023-11-22, Version 20.10.0 'Iron' (LTS)

a9bd735

Notable changes:

deps:
  * (SEMVER-MINOR) update uvwasi to 0.0.19 (Node.js GitHub Bot) #49908
doc:
  * add H4ad to collaborators (Vinícius Lourenço) #50217
esm:
  * (SEMVER-MINOR) detect ESM syntax in ambiguous JavaScript (Geoffrey Booth) #50096
  * use import attributes instead of import assertions (Antoine du Hamel) #50140
  * --experimental-default-type flag to flip module defaults (Geoffrey Booth) #49869
fs:
  * (SEMVER-MINOR) add flush option to appendFile() functions (Colin Ihrig) #50095
  * add flush option to writeFile() functions (Colin Ihrig) #50009
lib:
  * (SEMVER-MINOR) add WebSocket client (Matthew Aitken) #49830
stream:
  * (SEMVER-MINOR) allow pass stream class to `stream.compose` (Alex Yang) #50187
  * call helper function from push and unshift (Raz Luvaton) #50173
  * optimize Writable (Robert Nagy) #50012
test_runner, cli:
  * (SEMVER-MINOR) add --test-concurrency flag (Colin Ihrig) #49996
vm:
  * (SEMVER-MINOR) use import attributes instead of import assertions (Antoine du Hamel) #50141
  * use default HDO when importModuleDynamically is not set (Joyee Cheung) #49950
wasi:

PR-URL: #50682

lucshi pushed a commit to lucshi/node that referenced this pull request

Nov 27, 2023


          2023-11-22, Version 20.10.0 'Iron' (LTS)

e36ce82

Notable changes:

deps:
  * (SEMVER-MINOR) update uvwasi to 0.0.19 (Node.js GitHub Bot) nodejs#49908
doc:
  * add H4ad to collaborators (Vinícius Lourenço) nodejs#50217
esm:
  * (SEMVER-MINOR) detect ESM syntax in ambiguous JavaScript (Geoffrey Booth) nodejs#50096
  * use import attributes instead of import assertions (Antoine du Hamel) nodejs#50140
  * --experimental-default-type flag to flip module defaults (Geoffrey Booth) nodejs#49869
fs:
  * (SEMVER-MINOR) add flush option to appendFile() functions (Colin Ihrig) nodejs#50095
  * add flush option to writeFile() functions (Colin Ihrig) nodejs#50009
lib:
  * (SEMVER-MINOR) add WebSocket client (Matthew Aitken) nodejs#49830
stream:
  * (SEMVER-MINOR) allow pass stream class to `stream.compose` (Alex Yang) nodejs#50187
  * call helper function from push and unshift (Raz Luvaton) nodejs#50173
  * optimize Writable (Robert Nagy) nodejs#50012
test_runner, cli:
  * (SEMVER-MINOR) add --test-concurrency flag (Colin Ihrig) nodejs#49996
vm:
  * (SEMVER-MINOR) use import attributes instead of import assertions (Antoine du Hamel) nodejs#50141
  * use default HDO when importModuleDynamically is not set (Joyee Cheung) nodejs#49950
wasi:

PR-URL: nodejs#50682

meyfa mentioned this pull request

Dec 5, 2023

Node can't recognize static import of ES module when theres's not explicit marker #51057

Closed

andrewbranch mentioned this pull request

Dec 5, 2023

Design Meeting Notes, 12/1/2023 microsoft/TypeScript#56641

Closed

andrewbranch commented Dec 5, 2023

Copy link

Copy Markdown

This will have some unfortunate implications for TypeScript if it becomes enabled by default in the future. I wrote up an explanation on our issue tracker: microsoft/TypeScript#56678

ljharb reacted with eyes emoji

All reactions

👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

juanarbol mentioned this pull request

Dec 6, 2023

2023-12-06, N|Solid v5.0.1 Iron Release nodesource/nsolid#41

Merged

ckerr added a commit to electron/electron that referenced this pull request

Dec 7, 2023


          update fix_expose_the_built-in_electron_module_via_the_esm_loader.patch

d44b426

Xref: nodejs/node#50096
Xref: nodejs/node#50314
in lib/internal/modules/esm/load.js, update the code that checks for
`format === 'electron'`. I'd like 👀 on this

Xref: nodejs/node#49657
add braces in lib/internal/modules/esm/translators.js to sync with upstream

codebytere pushed a commit to electron/electron that referenced this pull request

Dec 8, 2023


          update fix_expose_the_built-in_electron_module_via_the_esm_loader.patch

077c8e4

Xref: nodejs/node#50096
Xref: nodejs/node#50314
in lib/internal/modules/esm/load.js, update the code that checks for
`format === 'electron'`. I'd like 👀 on this

Xref: nodejs/node#49657
add braces in lib/internal/modules/esm/translators.js to sync with upstream

codebytere added a commit to electron/electron that referenced this pull request

Dec 8, 2023


          fix: lazyload fs in esm loaders to apply asar patches

f0bf3ef

* nodejs/node#50127
* nodejs/node#50096

codebytere added a commit to electron/electron that referenced this pull request

Dec 10, 2023


          esm: detect ESM syntax in ambiguous JavaScrip

bb9a171

nodejs/node#50096

codebytere added a commit to electron/electron that referenced this pull request

Dec 11, 2023


          chore: bump node to v20.10.0 (main) (#40675)

890a557

* chore: bump node in DEPS to v20.10.0

* chore: update feat_initialize_asar_support.patch

no code changes; patch just needed an update due to nearby upstream changes

Xref: nodejs/node#49986

* chore: update pass_all_globals_through_require.patch

no manual changes; patch applied with fuzz

Xref: nodejs/node#49657

* chore: update refactor_allow_embedder_overriding_of_internal_fs_calls

Xref: nodejs/node#49912

no code changes; patch just needed an update due to nearby upstream changes

* chore: update chore_allow_the_node_entrypoint_to_be_a_builtin_module.patch

Xref: nodejs/node#49986

minor manual changes needed to sync with upstream change

* update fix_expose_the_built-in_electron_module_via_the_esm_loader.patch

Xref: nodejs/node#50096
Xref: nodejs/node#50314
in lib/internal/modules/esm/load.js, update the code that checks for
`format === 'electron'`. I'd like 👀 on this

Xref: nodejs/node#49657
add braces in lib/internal/modules/esm/translators.js to sync with upstream

* fix: lazyload fs in esm loaders to apply asar patches

* nodejs/node#50127
* nodejs/node#50096

* esm: jsdoc for modules code

nodejs/node#49523

* test: set test-cli-node-options as flaky

nodejs/node#50296

* deps: update c-ares to 1.20.1

nodejs/node#50082

* esm: bypass CommonJS loader under --default-type=module

nodejs/node#49986

* deps: update uvwasi to 0.0.19

nodejs/node#49908

* lib,test: do not hardcode Buffer.kMaxLength

nodejs/node#49876

* crypto: account for disabled SharedArrayBuffer

nodejs/node#50034

* test: fix edge snapshot stack traces

nodejs/node#49659

* src: generate snapshot with --predictable

nodejs/node#48749

* chore: fixup patch indices

* fs: throw errors from sync branches instead of separate implementations

nodejs/node#49913

* crypto: ensure valid point on elliptic curve in SubtleCrypto.importKey

nodejs/node#50234

* esm: detect ESM syntax in ambiguous JavaScrip

nodejs/node#50096

* fixup! test: fix edge snapshot stack traces

* esm: unflag extensionless ES module JavaScript and Wasm in module scope

nodejs/node#49974

* [tagged-ptr] Arrowify objects

https://chromium-review.googlesource.com/c/v8/v8/+/4705331

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <[email protected]>
Co-authored-by: Shelley Vohr <[email protected]>

mash-graz mentioned this pull request

Mar 11, 2024

Consider unstable flag to make cjs files be treated as esm denoland/deno#22818

Closed

elovin mentioned this pull request

Mar 29, 2024

ESM support nestjs/nest#13319

Closed

1 task done

aduh95 mentioned this pull request

Sep 16, 2024

Worker eval as ES Module #30682

Closed

vlakoff mentioned this pull request

Apr 4, 2025

Add .mjs extension to the "web script" file associations notepad-plus-plus/notepad-plus-plus#14689

Closed

GereonV mentioned this pull request

May 14, 2025

ESM syntax detection ignores certain top-level awaits #58331

Closed

joyeecheung mentioned this pull request

Mar 10, 2026

[25.x] module: fix extensionless CJS files in type:module packages #62083

Merged

coderabbitai Bot mentioned this pull request

Mar 23, 2026

feat: complete phase 8 runtime schema freeze flyingrobots/echo#306

Merged

coderabbitai Bot mentioned this pull request

Jun 25, 2026

Initialize CodeM8 project b4prog/CodeM8#1

Merged

colinhacks mentioned this pull request

Jul 10, 2026

feat(runtime): backport --experimental-detect-module for ambiguous ESM .js nubjs/nub#400

Closed

This was referenced Aug 4, 2026

feat(feature-discovery): add multi-agent roadmap discovery plugin rube-de/cc-skills#236

Merged

feat(#115): cold-installed public role matrix (owner README gate remaining) Akagilnc/ak-pi-workflow-roles#175

Merged

This was referenced Aug 21, 2026

Certify complete tracker reads for TODO import and export unbraind/pm-todos#55

Merged

ONM-20: Enforce fixer prompt guardrails against test assertion mutation escidmost/orca-no-mistakes#18

Merged

Reviewers

ljharb

ljharb left review comments

joyeecheung

joyeecheung left review comments

MoLow

MoLow left review comments

aduh95

aduh95 left review comments

guybedford

guybedford approved these changes

benjamingr

benjamingr approved these changes

anonrig

anonrig approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready

PRs with CI started, the required approvals, and no outstanding review comments.

cli

Issues and PRs related to the Node.js command-line interface.

commit-queue-squash

PRs the Commit Queue should land as one squashed commit.

esm

Issues and PRs related to the ECMAScript Modules implementation.

lib / src

Issues and PRs involving general changes in the lib/ or src/ directories.

module

Issues and PRs related to the module subsystem.

needs-ci

PRs that need a full CI run.

notable-change

PRs with changes that should be highlighted in changelogs.

semver-minor

PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

17 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

GeoffreyBooth commented Oct 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Notable change

Uh oh!

nodejs-github-bot commented Oct 9, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

GeoffreyBooth commented Oct 9, 2023

Uh oh!

mcollina commented Oct 9, 2023

Uh oh!

GeoffreyBooth commented Oct 9, 2023

Uh oh!

Uh oh!

Uh oh!

targos commented Oct 10, 2023

Uh oh!

GeoffreyBooth commented Oct 11, 2023

Uh oh!

GeoffreyBooth commented Oct 15, 2023

Uh oh!

Uh oh!

wraithgar commented Nov 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GeoffreyBooth commented Nov 17, 2023

Uh oh!

ljharb commented Nov 17, 2023

Uh oh!

andrewbranch commented Dec 5, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

GeoffreyBooth commented Oct 9, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

wraithgar commented Nov 17, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.