GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — crypto: account for disabled `SharedArrayBuffer` by codebytere · Pull Request #50034 · nodejs/node

Conversation

codebytere commented Oct 4, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Xref electron/electron#40070

It's possible for SharedArrayBuffers to be disabled with --no-harmony-sharedarraybuffer. If they are disabled and a user goes to use for example webcrypto.subtle.importKey, they will see the following error:

Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'prototype')
    at isSharedArrayBuffer (node:internal/crypto/webidl:187:57)
    at Object.BufferSource (node:internal/crypto/webidl:208:9)
    at SubtleCrypto.importKey (node:internal/crypto/webcrypto:585:36)
    at worker.js:6:18

This handles that case similarly to how it's handled elsewhere in the codebase.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss reacted with thumbs up emoji

All reactions

👍 1 reaction

nodejs-github-bot commented Oct 4, 2023

Copy link

Copy Markdown

Collaborator

Review requested:

@nodejs/crypto

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot added crypto

Issues and PRs related to the crypto subsystem.

needs-ci PRs that need a full CI run. labels

Oct 4, 2023

panva added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Oct 4, 2023

panva approved these changes

Oct 4, 2023

View reviewed changes

panva added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label

Oct 4, 2023

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Oct 4, 2023

nodejs-github-bot commented Oct 4, 2023

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54519/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Oct 4, 2023

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54521/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

H4ad reviewed

Oct 4, 2023

View reviewed changes

Comment thread

lib/internal/crypto/webidl.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

codebytere force-pushed the maybe-sab-undefined branch from 1feae12 to a39227d Compare

October 4, 2023 14:27


          crypto: account for disabled SharedArrayBuffer

ef45d7f

codebytere force-pushed the maybe-sab-undefined branch from a39227d to ef45d7f Compare

October 4, 2023 14:29

H4ad approved these changes

Oct 4, 2023

View reviewed changes

panva added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Oct 4, 2023

panva approved these changes

Oct 4, 2023

View reviewed changes

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Oct 4, 2023

nodejs-github-bot commented Oct 4, 2023

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54532/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

KhafraDev approved these changes

Oct 4, 2023

View reviewed changes

tniessen approved these changes

Oct 4, 2023

View reviewed changes

richardlau approved these changes

Oct 4, 2023

View reviewed changes

anonrig approved these changes

Oct 4, 2023

View reviewed changes

github-actions Bot mentioned this pull request

Oct 5, 2023

CI Reliability 2023-10-05 nodejs/reliability#684

Open

13 tasks

panva added the commit-queue PRs queued for automated landing through the Commit Queue. label

Oct 5, 2023

lpinca approved these changes

Oct 5, 2023

View reviewed changes

github-actions Bot mentioned this pull request

Oct 6, 2023

CI Reliability 2023-10-06 nodejs/reliability#685

Open

10 tasks

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label

Oct 6, 2023

nodejs-github-bot merged commit 136a967 into nodejs:main

Oct 6, 2023

nodejs-github-bot commented Oct 6, 2023

Copy link

Copy Markdown

Collaborator

Landed in 136a967

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot mentioned this pull request

Oct 7, 2023

CI Reliability 2023-10-07 nodejs/reliability#686

Open

19 tasks

github-actions Bot mentioned this pull request

Oct 8, 2023

CI Reliability 2023-10-08 nodejs/reliability#687

Open

19 tasks

RafaelGSS mentioned this pull request

Oct 9, 2023

2023-10-17, Version 21.0.0 (Current) #49870

Merged

targos pushed a commit that referenced this pull request

Nov 11, 2023


          crypto: account for disabled SharedArrayBuffer

3f98c06

PR-URL: #50034
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>

targos mentioned this pull request

Nov 12, 2023

v20.10.0 release proposal #50682

Merged

juanarbol mentioned this pull request

Dec 6, 2023

2023-12-06, N|Solid v5.0.1 Iron Release nodesource/nsolid#41

Merged

codebytere added a commit to electron/electron that referenced this pull request

Dec 8, 2023


          crypto: account for disabled SharedArrayBuffer

a5ccb7e

nodejs/node#50034

codebytere added a commit to electron/electron that referenced this pull request

Dec 8, 2023


          crypto: account for disabled SharedArrayBuffer

8ea24d4

nodejs/node#50034

codebytere added a commit to electron/electron that referenced this pull request

Dec 11, 2023


          chore: bump node to v20.10.0 (main) (#40675)

890a557

* chore: bump node in DEPS to v20.10.0

* chore: update feat_initialize_asar_support.patch

no code changes; patch just needed an update due to nearby upstream changes

Xref: nodejs/node#49986

* chore: update pass_all_globals_through_require.patch

no manual changes; patch applied with fuzz

Xref: nodejs/node#49657

* chore: update refactor_allow_embedder_overriding_of_internal_fs_calls

Xref: nodejs/node#49912

no code changes; patch just needed an update due to nearby upstream changes

* chore: update chore_allow_the_node_entrypoint_to_be_a_builtin_module.patch

Xref: nodejs/node#49986

minor manual changes needed to sync with upstream change

* update fix_expose_the_built-in_electron_module_via_the_esm_loader.patch

Xref: nodejs/node#50096
Xref: nodejs/node#50314
in lib/internal/modules/esm/load.js, update the code that checks for
`format === 'electron'`. I'd like 👀 on this

Xref: nodejs/node#49657
add braces in lib/internal/modules/esm/translators.js to sync with upstream

* fix: lazyload fs in esm loaders to apply asar patches

* nodejs/node#50127
* nodejs/node#50096

* esm: jsdoc for modules code

nodejs/node#49523

* test: set test-cli-node-options as flaky

nodejs/node#50296

* deps: update c-ares to 1.20.1

nodejs/node#50082

* esm: bypass CommonJS loader under --default-type=module

nodejs/node#49986

* deps: update uvwasi to 0.0.19

nodejs/node#49908

* lib,test: do not hardcode Buffer.kMaxLength

nodejs/node#49876

* crypto: account for disabled SharedArrayBuffer

nodejs/node#50034

* test: fix edge snapshot stack traces

nodejs/node#49659

* src: generate snapshot with --predictable

nodejs/node#48749

* chore: fixup patch indices

* fs: throw errors from sync branches instead of separate implementations

nodejs/node#49913

* crypto: ensure valid point on elliptic curve in SubtleCrypto.importKey

nodejs/node#50234

* esm: detect ESM syntax in ambiguous JavaScrip

nodejs/node#50096

* fixup! test: fix edge snapshot stack traces

* esm: unflag extensionless ES module JavaScript and Wasm in module scope

nodejs/node#49974

* [tagged-ptr] Arrowify objects

https://chromium-review.googlesource.com/c/v8/v8/+/4705331

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <[email protected]>
Co-authored-by: Shelley Vohr <[email protected]>

debadree25 pushed a commit to debadree25/node that referenced this pull request

Apr 15, 2024


          crypto: account for disabled SharedArrayBuffer

b8b8724

PR-URL: nodejs#50034
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>

Reviewers

panva

panva approved these changes

lpinca

lpinca approved these changes

anonrig

anonrig approved these changes

tniessen

tniessen approved these changes

richardlau

richardlau approved these changes

H4ad

H4ad approved these changes

KhafraDev

KhafraDev approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready

PRs with CI started, the required approvals, and no outstanding review comments.

crypto

Issues and PRs related to the crypto subsystem.

needs-ci

PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

codebytere commented Oct 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Oct 4, 2023

Uh oh!

nodejs-github-bot commented Oct 4, 2023

Uh oh!

nodejs-github-bot commented Oct 4, 2023

Uh oh!

Uh oh!

nodejs-github-bot commented Oct 4, 2023

Uh oh!

nodejs-github-bot commented Oct 6, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

codebytere commented Oct 4, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.