GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: clarify behaviour of node-api adjust function by mhdawson · Pull Request #57463 · nodejs/node

Conversation

@mhdawson

@mhdawson mhdawson commented Mar 14, 2025

Copy link
Copy Markdown
Member

Refs: #57351

  • based on recent request to update one of the tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@mhdawson
doc: clarify behaviour of node-api adjust function
e998236
Refs: nodejs#57351
- based on recent request to update one of the tests

Signed-off-by: Michael Dawson <[email protected]>
@nodejs-github-bot

nodejs-github-bot commented Mar 14, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/node-api
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. node-api Issues and PRs related to Node-API. labels Mar 14, 2025
@github-project-automation github-project-automation Bot added this to Node-API Team Project Mar 14, 2025
@github-project-automation github-project-automation Bot moved this to Need Triage in Node-API Team Project Mar 14, 2025
NickNaso
NickNaso approved these changes Mar 15, 2025
View reviewed changes
lpinca
lpinca approved these changes Mar 15, 2025
View reviewed changes
Comment thread doc/api/n-api.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread doc/api/n-api.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

legendecas
legendecas requested changes Mar 17, 2025
View reviewed changes
Comment thread doc/api/n-api.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@legendecas legendecas mentioned this pull request Mar 17, 2025
test: increase change_in_bytes for napi_adjust_external_memory test #57351
Closed
mhdawson and others added 3 commits March 17, 2025 11:05
@mhdawson @lpinca
Update doc/api/n-api.md
0fcc85e
Co-authored-by: Luigi Pinca <[email protected]>
@mhdawson @lpinca
Update doc/api/n-api.md
53d4bf0
Co-authored-by: Luigi Pinca <[email protected]>
@mhdawson
squash: address comments
f982c65
mhdawson
mhdawson commented Mar 17, 2025
View reviewed changes
Comment thread doc/api/n-api.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@mhdawson
Update doc/api/n-api.md
2425f8e
mhdawson
mhdawson commented Mar 17, 2025
View reviewed changes
Comment thread doc/api/n-api.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@mhdawson
Update doc/api/n-api.md
3ca64c0
vmoroz
vmoroz approved these changes Mar 17, 2025
View reviewed changes

@vmoroz vmoroz left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@mhdawson
squash: make linter happy
d4da3bf
Signed-off-by: Michael Dawson <[email protected]>
legendecas
legendecas reviewed Mar 17, 2025
View reviewed changes
Comment thread doc/api/n-api.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

legendecas
legendecas reviewed Mar 19, 2025
View reviewed changes
Comment thread doc/api/n-api.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread doc/api/n-api.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread doc/api/n-api.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

mhdawson and others added 2 commits March 20, 2025 16:20
@mhdawson @legendecas
Update doc/api/n-api.md
d7aec7a
Co-authored-by: Chengzhong Wu <[email protected]>
@mhdawson @legendecas
Update doc/api/n-api.md
0e3379e
Co-authored-by: Chengzhong Wu <[email protected]>
mhdawson
mhdawson commented Mar 20, 2025
View reviewed changes
Comment thread doc/api/n-api.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@mhdawson
Update doc/api/n-api.md
d8cdc40
@mhdawson

mhdawson commented Mar 20, 2025

Copy link
Copy Markdown
Member Author

@legendecas accepted your suggestions and then tweaked again.

I am still wondering if we should include the comment about calling with -512 if you called with +512 before. If its ok to call +512 twice and then -1024 later I'm not sure we want to include that.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

legendecas
legendecas approved these changes Mar 20, 2025
View reviewed changes
Comment thread doc/api/n-api.md Outdated
often than it would otherwise.

This function is expected to be invoked symmetrically. If it is invoked with +512KB,
it is expected to be invoked -512KB in sum at a later time.

@legendecas legendecas Mar 20, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am still wondering if we should include the comment about calling with -512 if you called with +512 before. If its ok to call +512 twice and then -1024 later I'm not sure we want to include that.

"in sum" should address the concern? I think this sentence now is saying the value should be in symmetry.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@mhdawson
squash: make linter happy again
3753184
Signed-off-by: Michael Dawson <[email protected]>
mhdawson
mhdawson commented Mar 21, 2025
View reviewed changes
Comment thread doc/api/n-api.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

mhdawson
mhdawson commented Mar 21, 2025
View reviewed changes
Comment thread doc/api/n-api.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

legendecas
legendecas approved these changes Mar 22, 2025
View reviewed changes
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Mar 28, 2025
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Mar 28, 2025
@nodejs-github-bot

nodejs-github-bot commented Mar 28, 2025

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/57463
✔  Done loading data for nodejs/node/pull/57463
----------------------------------- PR info ------------------------------------
Title      doc: clarify behaviour of node-api adjust function (#57463)
Author     Michael Dawson <[email protected]> (@mhdawson)
Branch     mhdawson:node-api-adjust-doc -> nodejs:main
Labels     doc, node-api, author ready
Commits    14
 - doc: clarify behaviour of node-api adjust function
 - Update doc/api/n-api.md
 - Update doc/api/n-api.md
 - squash: address comments
 - Update doc/api/n-api.md
 - Update doc/api/n-api.md
 - squash: make linter happy
 - Update doc/api/n-api.md
 - Update doc/api/n-api.md
 - Update doc/api/n-api.md
 - squash: make linter happy again
 - Update doc/api/n-api.md
 - Update doc/api/n-api.md
 - Update doc/api/n-api.md
Committers 2
 - Michael Dawson <[email protected]>
 - GitHub <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/57463
Refs: https://github.com/nodejs/node/pull/57351
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Vladimir Morozov <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/57463
Refs: https://github.com/nodejs/node/pull/57351
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Vladimir Morozov <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 14 Mar 2025 16:33:21 GMT
   ✔  Approvals: 3
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/57463#pullrequestreview-2688093622
   ✔  - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/57463#pullrequestreview-2708009128
   ✔  - Vladimir Morozov (@vmoroz): https://github.com/nodejs/node/pull/57463#pullrequestreview-2692160164
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 57463
From https://github.com/nodejs/node
 * branch                  refs/pull/57463/merge -> FETCH_HEAD
✔  Fetched commits as af75d04a76f1..0792c648255b
--------------------------------------------------------------------------------
[main 445d937f04] doc: clarify behaviour of node-api adjust function
 Author: Michael Dawson <[email protected]>
 Date: Fri Mar 14 16:31:39 2025 +0000
 1 file changed, 9 insertions(+), 5 deletions(-)
[main 309b4a8d5c] Update doc/api/n-api.md
 Author: Michael Dawson <[email protected]>
 Date: Mon Mar 17 11:05:35 2025 -0400
 1 file changed, 1 insertion(+), 1 deletion(-)
[main d26bae84e3] Update doc/api/n-api.md
 Author: Michael Dawson <[email protected]>
 Date: Mon Mar 17 11:07:01 2025 -0400
 1 file changed, 1 insertion(+), 1 deletion(-)
[main f25b0c9b60] squash: address comments
 Author: Michael Dawson <[email protected]>
 Date: Mon Mar 17 17:31:08 2025 -0400
 1 file changed, 4 insertions(+), 4 deletions(-)
[main d37760a389] Update doc/api/n-api.md
 Author: Michael Dawson <[email protected]>
 Date: Mon Mar 17 17:31:54 2025 -0400
 1 file changed, 1 insertion(+), 1 deletion(-)
[main a07cb6213b] Update doc/api/n-api.md
 Author: Michael Dawson <[email protected]>
 Date: Mon Mar 17 17:33:06 2025 -0400
 1 file changed, 1 insertion(+), 1 deletion(-)
[main 39ace7aa08] squash: make linter happy
 Author: Michael Dawson <[email protected]>
 Date: Mon Mar 17 21:59:59 2025 +0000
 1 file changed, 1 insertion(+), 1 deletion(-)
[main 9cb313079e] Update doc/api/n-api.md
 Author: Michael Dawson <[email protected]>
 Date: Thu Mar 20 16:20:28 2025 -0400
 1 file changed, 5 insertions(+), 4 deletions(-)
[main 40a46af5be] Update doc/api/n-api.md
 Author: Michael Dawson <[email protected]>
 Date: Thu Mar 20 16:20:40 2025 -0400
 1 file changed, 3 insertions(+)
[main 8cb12f5c27] Update doc/api/n-api.md
 Author: Michael Dawson <[email protected]>
 Date: Thu Mar 20 16:24:43 2025 -0400
 1 file changed, 3 insertions(+), 3 deletions(-)
[main 6dbbbe56d8] squash: make linter happy again
 Author: Michael Dawson <[email protected]>
 Date: Fri Mar 21 13:07:38 2025 +0000
 1 file changed, 3 insertions(+), 3 deletions(-)
[main 2a1f4efa75] Update doc/api/n-api.md
 Author: Michael Dawson <[email protected]>
 Date: Fri Mar 21 11:28:34 2025 -0400
 1 file changed, 3 insertions(+), 1 deletion(-)
[main 92379c52fb] Update doc/api/n-api.md
 Author: Michael Dawson <[email protected]>
 Date: Fri Mar 21 11:28:57 2025 -0400
 1 file changed, 1 deletion(-)
[main c81ea08ffb] Update doc/api/n-api.md
 Author: Michael Dawson <[email protected]>
 Date: Fri Mar 21 11:29:12 2025 -0400
 1 file changed, 3 insertions(+), 3 deletions(-)
   ✔  Patches applied
There are 14 commits in the PR. Attempting autorebase.
Rebasing (2/28)
Executing: git node land --amend --yes
   ⚠  Found Refs: https://github.com/nodejs/node/pull/57351, skipping..
--------------------------------- New Message ----------------------------------
doc: clarify behaviour of node-api adjust function

Refs: #57351

  • based on recent request to update one of the tests

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #57463
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Vladimir Morozov <[email protected]>

[detached HEAD 2c91b74144] doc: clarify behaviour of node-api adjust function
Author: Michael Dawson <[email protected]>
Date: Fri Mar 14 16:31:39 2025 +0000
1 file changed, 9 insertions(+), 5 deletions(-)
Rebasing (3/28)
Rebasing (4/28)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update doc/api/n-api.md

Co-authored-by: Luigi Pinca <[email protected]>
PR-URL: #57463
Refs: #57351
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Vladimir Morozov <[email protected]>

[detached HEAD 4518344fce] Update doc/api/n-api.md
Author: Michael Dawson <[email protected]>
Date: Mon Mar 17 11:05:35 2025 -0400
1 file changed, 1 insertion(+), 1 deletion(-)
Rebasing (5/28)
Rebasing (6/28)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update doc/api/n-api.md

Co-authored-by: Luigi Pinca <[email protected]>
PR-URL: #57463
Refs: #57351
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Vladimir Morozov <[email protected]>

[detached HEAD f14f767de0] Update doc/api/n-api.md
Author: Michael Dawson <[email protected]>
Date: Mon Mar 17 11:07:01 2025 -0400
1 file changed, 1 insertion(+), 1 deletion(-)
Rebasing (7/28)
Rebasing (8/28)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
squash: address comments

PR-URL: #57463
Refs: #57351
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Vladimir Morozov <[email protected]>

[detached HEAD 5c7a313b1a] squash: address comments
Author: Michael Dawson <[email protected]>
Date: Mon Mar 17 17:31:08 2025 -0400
1 file changed, 4 insertions(+), 4 deletions(-)
Rebasing (9/28)
Rebasing (10/28)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update doc/api/n-api.md

PR-URL: #57463
Refs: #57351
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Vladimir Morozov <[email protected]>

[detached HEAD 5581ec6461] Update doc/api/n-api.md
Author: Michael Dawson <[email protected]>
Date: Mon Mar 17 17:31:54 2025 -0400
1 file changed, 1 insertion(+), 1 deletion(-)
Rebasing (11/28)
Rebasing (12/28)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update doc/api/n-api.md

PR-URL: #57463
Refs: #57351
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Vladimir Morozov <[email protected]>

[detached HEAD 86149ae09a] Update doc/api/n-api.md
Author: Michael Dawson <[email protected]>
Date: Mon Mar 17 17:33:06 2025 -0400
1 file changed, 1 insertion(+), 1 deletion(-)
Rebasing (13/28)
Rebasing (14/28)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
squash: make linter happy

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #57463
Refs: #57351
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Vladimir Morozov <[email protected]>

[detached HEAD 99cc30fe3d] squash: make linter happy
Author: Michael Dawson <[email protected]>
Date: Mon Mar 17 21:59:59 2025 +0000
1 file changed, 1 insertion(+), 1 deletion(-)
Rebasing (15/28)
Rebasing (16/28)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update doc/api/n-api.md

Co-authored-by: Chengzhong Wu <[email protected]>
PR-URL: #57463
Refs: #57351
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Vladimir Morozov <[email protected]>

[detached HEAD 548a6d2759] Update doc/api/n-api.md
Author: Michael Dawson <[email protected]>
Date: Thu Mar 20 16:20:28 2025 -0400
1 file changed, 5 insertions(+), 4 deletions(-)
Rebasing (17/28)
Rebasing (18/28)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update doc/api/n-api.md

Co-authored-by: Chengzhong Wu <[email protected]>
PR-URL: #57463
Refs: #57351
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Vladimir Morozov <[email protected]>

[detached HEAD c31e1a8485] Update doc/api/n-api.md
Author: Michael Dawson <[email protected]>
Date: Thu Mar 20 16:20:40 2025 -0400
1 file changed, 3 insertions(+)
Rebasing (19/28)
Rebasing (20/28)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update doc/api/n-api.md

PR-URL: #57463
Refs: #57351
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Vladimir Morozov <[email protected]>

[detached HEAD 3f3c0ce114] Update doc/api/n-api.md
Author: Michael Dawson <[email protected]>
Date: Thu Mar 20 16:24:43 2025 -0400
1 file changed, 3 insertions(+), 3 deletions(-)
Rebasing (21/28)
Rebasing (22/28)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
squash: make linter happy again

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #57463
Refs: #57351
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Vladimir Morozov <[email protected]>

[detached HEAD 2bd96c12c5] squash: make linter happy again
Author: Michael Dawson <[email protected]>
Date: Fri Mar 21 13:07:38 2025 +0000
1 file changed, 3 insertions(+), 3 deletions(-)
Rebasing (23/28)
Rebasing (24/28)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update doc/api/n-api.md

PR-URL: #57463
Refs: #57351
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Vladimir Morozov <[email protected]>

[detached HEAD 8391dd7080] Update doc/api/n-api.md
Author: Michael Dawson <[email protected]>
Date: Fri Mar 21 11:28:34 2025 -0400
1 file changed, 3 insertions(+), 1 deletion(-)
Rebasing (25/28)
Rebasing (26/28)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update doc/api/n-api.md

PR-URL: #57463
Refs: #57351
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Vladimir Morozov <[email protected]>

[detached HEAD 5ffe41d35d] Update doc/api/n-api.md
Author: Michael Dawson <[email protected]>
Date: Fri Mar 21 11:28:57 2025 -0400
1 file changed, 1 deletion(-)
Rebasing (27/28)
Rebasing (28/28)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update doc/api/n-api.md

PR-URL: #57463
Refs: #57351
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Vladimir Morozov <[email protected]>

[detached HEAD 5e221cd453] Update doc/api/n-api.md
Author: Michael Dawson <[email protected]>
Date: Fri Mar 21 11:29:12 2025 -0400
1 file changed, 3 insertions(+), 3 deletions(-)
Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/14132066355

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@aduh95 aduh95 added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Mar 28, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Mar 28, 2025
@nodejs-github-bot
nodejs-github-bot merged commit ca74d64 into nodejs:main Mar 28, 2025
@nodejs-github-bot

nodejs-github-bot commented Mar 28, 2025

Copy link
Copy Markdown
Collaborator

Landed in ca74d64

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-project-automation github-project-automation Bot moved this from Need Triage to Done in Node-API Team Project Mar 28, 2025
aduh95 pushed a commit that referenced this pull request Mar 28, 2025
@mhdawson @aduh95
doc: clarify behaviour of node-api adjust function
4ed1a09
Refs: #57351
- based on recent request to update one of the tests

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #57463
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Vladimir Morozov <[email protected]>
@github-actions github-actions Bot mentioned this pull request Mar 30, 2025
2025-04-01, Version 23.11.0 (Current) #57694
Merged
@RafaelGSS RafaelGSS mentioned this pull request Apr 8, 2025
v22.x-staging cherry-pick status #57799
Closed
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Apr 8, 2025
@mhdawson @RafaelGSS
doc: clarify behaviour of node-api adjust function
0ad3694
Refs: nodejs#57351
- based on recent request to update one of the tests

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: nodejs#57463
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Vladimir Morozov <[email protected]>
@aduh95 aduh95 mentioned this pull request Apr 11, 2025
2025-04-23, Version 22.15.0 'Jod' (LTS), @UlisesGascon prepared by @RafaelGSS #57840
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 14, 2025
@mhdawson @RafaelGSS
doc: clarify behaviour of node-api adjust function
6f6f8a0
Refs: #57351
- based on recent request to update one of the tests

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #57463
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Vladimir Morozov <[email protected]>
aduh95 pushed a commit that referenced this pull request Apr 14, 2025
@mhdawson @aduh95
doc: clarify behaviour of node-api adjust function
d8575e1
Refs: #57351
- based on recent request to update one of the tests

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #57463
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Vladimir Morozov <[email protected]>
aduh95 pushed a commit that referenced this pull request Apr 15, 2025
@mhdawson @aduh95
doc: clarify behaviour of node-api adjust function
9544a63
Refs: #57351
- based on recent request to update one of the tests

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #57463
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Vladimir Morozov <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Apr 16, 2025
@mhdawson @RafaelGSS
doc: clarify behaviour of node-api adjust function
3b7551e
Refs: #57351
- based on recent request to update one of the tests

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #57463
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Vladimir Morozov <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Apr 17, 2025
@mhdawson @RafaelGSS
doc: clarify behaviour of node-api adjust function
b7ac0bd
Refs: #57351
- based on recent request to update one of the tests

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #57463
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Vladimir Morozov <[email protected]>
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Apr 20, 2025
ECG Bot @tmeijn
build(deps): update node to v23.11.0
e073dc8
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [node](https://nodejs.org) ([source](https://github.com/nodejs/node)) | minor | `23.10.0` -> `23.11.0` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>nodejs/node (node)</summary>

### [`v23.11.0`](https://github.com/nodejs/node/releases/tag/v23.11.0): 2025-04-01, Version 23.11.0 (Current), @&#8203;aduh95

[Compare Source](nodejs/node@v23.10.0...v23.11.0)

##### Notable Changes

-   \[[`64b086740a`](nodejs/node@64b086740a)] - **(SEMVER-MINOR)** **assert**: implement partial error comparison (Ruben Bridgewater) [#&#8203;57370](nodejs/node#57370)
-   \[[`053cef70e0`](nodejs/node@053cef70e0)] - **(SEMVER-MINOR)** **crypto**: add optional callback to `crypto.diffieHellman` (Filip Skokan) [#&#8203;57274](nodejs/node#57274)
-   \[[`f8aff90235`](nodejs/node@f8aff90235)] - **(SEMVER-MINOR)** **process**: add `execve` (Paolo Insogna) [#&#8203;56496](nodejs/node#56496)
-   \[[`4b04c92d7d`](nodejs/node@4b04c92d7d)] - **(SEMVER-MINOR)** **sqlite**: add `StatementSync.prototype.columns()` (Colin Ihrig) [#&#8203;57490](nodejs/node#57490)
-   \[[`1b8d1d3a3a`](nodejs/node@1b8d1d3a3a)] - **(SEMVER-MINOR)** **util**: expose diff function used by the assertion errors (Giovanni Bucci) [#&#8203;57462](nodejs/node#57462)

##### Commits

-   \[[`7b72396c8b`](nodejs/node@7b72396c8b)] - **assert**: improve partialDeepStrictEqual performance (Ruben Bridgewater) [#&#8203;57509](nodejs/node#57509)
-   \[[`64b086740a`](nodejs/node@64b086740a)] - **(SEMVER-MINOR)** **assert**: implement partial error comparison (Ruben Bridgewater) [#&#8203;57370](nodejs/node#57370)
-   \[[`f694d7de0e`](nodejs/node@f694d7de0e)] - **(SEMVER-MINOR)** **assert**: improve partialDeepStrictEqual (Ruben Bridgewater) [#&#8203;57370](nodejs/node#57370)
-   \[[`80d9d5653f`](nodejs/node@80d9d5653f)] - **(SEMVER-MINOR)** **assert,util**: improve performance (Ruben Bridgewater) [#&#8203;57370](nodejs/node#57370)
-   \[[`d52a71f832`](nodejs/node@d52a71f832)] - **(SEMVER-MINOR)** **benchmark**: adjust assert runtimes (Ruben Bridgewater) [#&#8203;57370](nodejs/node#57370)
-   \[[`7592cf4cd7`](nodejs/node@7592cf4cd7)] - **(SEMVER-MINOR)** **benchmark**: skip running some assert benchmarks by default (Ruben Bridgewater) [#&#8203;57370](nodejs/node#57370)
-   \[[`e4cc54a746`](nodejs/node@e4cc54a746)] - **(SEMVER-MINOR)** **benchmark**: add assert partialDeepStrictEqual benchmark (Ruben Bridgewater) [#&#8203;57370](nodejs/node#57370)
-   \[[`de48407011`](nodejs/node@de48407011)] - **build**: fix update-wpt workflow (Jonas) [#&#8203;57468](nodejs/node#57468)
-   \[[`52cd0954f9`](nodejs/node@52cd0954f9)] - **cli**: clarify --cpu-prof-name allowed values (Eugenio Ceschia) [#&#8203;57433](nodejs/node#57433)
-   \[[`7611fc14de`](nodejs/node@7611fc14de)] - **crypto**: fix output of privateDecrypt with zero-length data (Filip Skokan) [#&#8203;57575](nodejs/node#57575)
-   \[[`cc42ee8fc7`](nodejs/node@cc42ee8fc7)] - **crypto**: ensure expected JWK alg in SubtleCrypto.importKey RSA imports (Filip Skokan) [#&#8203;57450](nodejs/node#57450)
-   \[[`053cef70e0`](nodejs/node@053cef70e0)] - **(SEMVER-MINOR)** **crypto**: add optional callback to crypto.diffieHellman (Filip Skokan) [#&#8203;57274](nodejs/node#57274)
-   \[[`1f08864fd7`](nodejs/node@1f08864fd7)] - **debugger**: fix behavior of plain object exec in debugger repl (Dario Piotrowicz) [#&#8203;57498](nodejs/node#57498)
-   \[[`162b2828eb`](nodejs/node@162b2828eb)] - **deps**: update undici to 6.21.2 (Matteo Collina) [#&#8203;57442](nodejs/node#57442)
-   \[[`43bea6bb80`](nodejs/node@43bea6bb80)] - **deps**: V8: cherry-pick [`c172ffc`](nodejs/node@c172ffc5bf54) (Choongwoo Han) [#&#8203;57437](nodejs/node#57437)
-   \[[`99f93afb9d`](nodejs/node@99f93afb9d)] - **deps**: update ada to v3.2.1 (Yagiz Nizipli) [#&#8203;57429](nodejs/node#57429)
-   \[[`30e5658f12`](nodejs/node@30e5658f12)] - **deps**: update googletest to [`0bdccf4`](nodejs/node@0bdccf4) (Node.js GitHub Bot) [#&#8203;57380](nodejs/node#57380)
-   \[[`573467c070`](nodejs/node@573467c070)] - **deps**: update acorn to 8.14.1 (Node.js GitHub Bot) [#&#8203;57382](nodejs/node#57382)
-   \[[`affeaac0c7`](nodejs/node@affeaac0c7)] - **doc**: add gurgunday as triager (Gürgün Dayıoğlu) [#&#8203;57594](nodejs/node#57594)
-   \[[`4ed1a098f5`](nodejs/node@4ed1a098f5)] - **doc**: clarify behaviour of node-api adjust function (Michael Dawson) [#&#8203;57463](nodejs/node#57463)
-   \[[`921041b284`](nodejs/node@921041b284)] - **doc**: remove Corepack documentation (Antoine du Hamel) [#&#8203;57635](nodejs/node#57635)
-   \[[`99dbd8b391`](nodejs/node@99dbd8b391)] - **doc**: remove mention of `--require` not supporting ES modules (Huáng Jùnliàng) [#&#8203;57620](nodejs/node#57620)
-   \[[`8c76b2949e`](nodejs/node@8c76b2949e)] - **doc**: mention reports should align with Node.js CoC (Rafael Gonzaga) [#&#8203;57607](nodejs/node#57607)
-   \[[`ee1c78a7a3`](nodejs/node@ee1c78a7a3)] - **doc**: add section stating that very stale MRs should be closed (Dario Piotrowicz) [#&#8203;57541](nodejs/node#57541)
-   \[[`595e9e5ad6`](nodejs/node@595e9e5ad6)] - **doc**: add bjohansebas as triager (Sebastian Beltran) [#&#8203;57564](nodejs/node#57564)
-   \[[`3742d2a198`](nodejs/node@3742d2a198)] - **doc**: update support channels (Claudio W.) [#&#8203;57538](nodejs/node#57538)
-   \[[`717c44dead`](nodejs/node@717c44dead)] - **doc**: make stability labels more consistent (Antoine du Hamel) [#&#8203;57516](nodejs/node#57516)
-   \[[`b4576a6f57`](nodejs/node@b4576a6f57)] - **doc**: remove cryptoStream API reference (Jonas) [#&#8203;57579](nodejs/node#57579)
-   \[[`2c4f894036`](nodejs/node@2c4f894036)] - **doc**: module resolution pseudocode corrections (Marcel Laverdet) [#&#8203;57080](nodejs/node#57080)
-   \[[`c45894f90c`](nodejs/node@c45894f90c)] - **doc**: add history entry for DEP0190 in `child_process.md` (Antoine du Hamel) [#&#8203;57544](nodejs/node#57544)
-   \[[`c21068b696`](nodejs/node@c21068b696)] - **doc**: remove deprecated pattern in `child_process.md` (Antoine du Hamel) [#&#8203;57568](nodejs/node#57568)
-   \[[`87e0dda352`](nodejs/node@87e0dda352)] - **doc**: mark multiple experimental APIS as stable (James M Snell) [#&#8203;57510](nodejs/node#57510)
-   \[[`d637763e4e`](nodejs/node@d637763e4e)] - **doc**: remove mertcanaltin from Triagers (Mert Can Altin) [#&#8203;57531](nodejs/node#57531)
-   \[[`ee6025495d`](nodejs/node@ee6025495d)] - **doc**: recommend watching the collaborators repo in the onboarding doc (Darshan Sen) [#&#8203;57527](nodejs/node#57527)
-   \[[`706b64638b`](nodejs/node@706b64638b)] - **doc**: remove mention of visa fees from onboarding doc (Darshan Sen) [#&#8203;57526](nodejs/node#57526)
-   \[[`176d951bd0`](nodejs/node@176d951bd0)] - **doc**: deprecate passing `args` to `spawn` and `execFile` (Antoine du Hamel) [#&#8203;57389](nodejs/node#57389)
-   \[[`5c05ba119b`](nodejs/node@5c05ba119b)] - **doc**: remove some inconsistencies in `deprecations.md` (Antoine du Hamel) [#&#8203;57512](nodejs/node#57512)
-   \[[`9d5be4bb8c`](nodejs/node@9d5be4bb8c)] - **doc**: run license-builder (github-actions\[bot]) [#&#8203;57511](nodejs/node#57511)
-   \[[`273607edb4`](nodejs/node@273607edb4)] - **doc**: add new writing-docs contributing md (Dario Piotrowicz) [#&#8203;57502](nodejs/node#57502)
-   \[[`e28c723f24`](nodejs/node@e28c723f24)] - **doc**: add node.js streams references to Web Streams doc (Dario Piotrowicz) [#&#8203;57393](nodejs/node#57393)
-   \[[`47296492ba`](nodejs/node@47296492ba)] - **doc**: replace NOTEs that do not render properly (Colin Ihrig) [#&#8203;57484](nodejs/node#57484)
-   \[[`db9c37f792`](nodejs/node@db9c37f792)] - **doc**: prefer to sign commits under nodejs repository (Rafael Gonzaga) [#&#8203;57311](nodejs/node#57311)
-   \[[`e5e3987ae7`](nodejs/node@e5e3987ae7)] - **doc**: fixed the incorrect splitting of multiple words (letianpailove) [#&#8203;57454](nodejs/node#57454)
-   \[[`91a824e43b`](nodejs/node@91a824e43b)] - **doc**: add review guidelines for collaborator nominations (Antoine du Hamel) [#&#8203;57449](nodejs/node#57449)
-   \[[`2a5fcb2172`](nodejs/node@2a5fcb2172)] - **doc**: fix typo in `url.md` (Allon Murienik) [#&#8203;57467](nodejs/node#57467)
-   \[[`17ccf9282f`](nodejs/node@17ccf9282f)] - **doc**: add history info for --use-system-ca (Darshan Sen) [#&#8203;57432](nodejs/node#57432)
-   \[[`9adaaeb965`](nodejs/node@9adaaeb965)] - **doc**: remove typo YAML snippet from tls.getCACertificates doc (Darshan Sen) [#&#8203;57459](nodejs/node#57459)
-   \[[`ee4e855f8e`](nodejs/node@ee4e855f8e)] - **doc**: fix typo in sqlite.md (Tobias Nießen) [#&#8203;57473](nodejs/node#57473)
-   \[[`8cb3441443`](nodejs/node@8cb3441443)] - **doc**: explicit mention arbitrary code execution as a vuln (Rafael Gonzaga) [#&#8203;57426](nodejs/node#57426)
-   \[[`27f183ad03`](nodejs/node@27f183ad03)] - **doc**: update maintaining-openssl.md for openssl (Richard Lau) [#&#8203;57413](nodejs/node#57413)
-   \[[`ca67145d60`](nodejs/node@ca67145d60)] - **doc**: add missing `deprecated` badges in `fs.md` (Yukihiro Hasegawa) [#&#8203;57384](nodejs/node#57384)
-   \[[`3687390510`](nodejs/node@3687390510)] - **doc**: fix small typo in `process.md` (Felix Rieseberg) [#&#8203;57333](nodejs/node#57333)
-   \[[`097d9926e3`](nodejs/node@097d9926e3)] - **doc**: add note about sync nodejs-private branches (Rafael Gonzaga) [#&#8203;57404](nodejs/node#57404)
-   \[[`5006627969`](nodejs/node@5006627969)] - **fs**: apply exclude function to root path (Rich Trott) [#&#8203;57420](nodejs/node#57420)
-   \[[`0583c3db92`](nodejs/node@0583c3db92)] - **http**: coerce content-length to number (Marco Ippolito) [#&#8203;57458](nodejs/node#57458)
-   \[[`2a580b9332`](nodejs/node@2a580b9332)] - **lib**: add warning when binding inspector to public IP (Demian Parkhomenko) [#&#8203;55736](nodejs/node#55736)
-   \[[`fda56b9837`](nodejs/node@fda56b9837)] - **lib**: limit split function calls to prevent excessive array length (Gürgün Dayıoğlu) [#&#8203;57501](nodejs/node#57501)
-   \[[`d5a26f6525`](nodejs/node@d5a26f6525)] - **lib**: make getCallSites sourceMap option truly optional (James M Snell) [#&#8203;57388](nodejs/node#57388)
-   \[[`00a5b18043`](nodejs/node@00a5b18043)] - **meta**: add some clarification to the nomination process (James M Snell) [#&#8203;57503](nodejs/node#57503)
-   \[[`d0c96c463c`](nodejs/node@d0c96c463c)] - **meta**: remove collaborator self-nomination (Rich Trott) [#&#8203;57537](nodejs/node#57537)
-   \[[`a9a93f31ee`](nodejs/node@a9a93f31ee)] - **meta**: edit collaborator nomination process (Antoine du Hamel) [#&#8203;57483](nodejs/node#57483)
-   \[[`0ca362f5f2`](nodejs/node@0ca362f5f2)] - **meta**: move ovflowd to emeritus (Claudio W.) [#&#8203;57443](nodejs/node#57443)
-   \[[`f8aff90235`](nodejs/node@f8aff90235)] - **(SEMVER-MINOR)** **process**: add execve (Paolo Insogna) [#&#8203;56496](nodejs/node#56496)
-   \[[`e8d4a31d4b`](nodejs/node@e8d4a31d4b)] - **sqlite**: add support for unknown named parameters (Colin Ihrig) [#&#8203;57552](nodejs/node#57552)
-   \[[`5652da642d`](nodejs/node@5652da642d)] - **sqlite**: add DatabaseSync.prototype.isOpen (Colin Ihrig) [#&#8203;57522](nodejs/node#57522)
-   \[[`5c976f16cd`](nodejs/node@5c976f16cd)] - **sqlite**: add DatabaseSync.prototype\[Symbol.dispose]\() (Colin Ihrig) [#&#8203;57506](nodejs/node#57506)
-   \[[`4b04c92d7d`](nodejs/node@4b04c92d7d)] - **(SEMVER-MINOR)** **sqlite**: add StatementSync.prototype.columns() (Colin Ihrig) [#&#8203;57490](nodejs/node#57490)
-   \[[`7f5e31645c`](nodejs/node@7f5e31645c)] - **src**: ensure primordials are initialized exactly once (Chengzhong Wu) [#&#8203;57519](nodejs/node#57519)
-   \[[`9611980f58`](nodejs/node@9611980f58)] - **src**: improve error handling in multiple files (James M Snell) [#&#8203;57507](nodejs/node#57507)
-   \[[`3ddc5cd875`](nodejs/node@3ddc5cd875)] - **src**: cache urlpattern properties (JonasBa) [#&#8203;57465](nodejs/node#57465)
-   \[[`b9d9ee4da2`](nodejs/node@b9d9ee4da2)] - **src**: make minor cleanups in encoding_binding.cc (James M Snell) [#&#8203;57448](nodejs/node#57448)
-   \[[`f8acf2dd2a`](nodejs/node@f8acf2dd2a)] - **src**: make minor cleanups in compile_cache.cc (James M Snell) [#&#8203;57448](nodejs/node#57448)
-   \[[`6ee15c6509`](nodejs/node@6ee15c6509)] - **src**: define urlpattern components using a macro (JonasBa) [#&#8203;57452](nodejs/node#57452)
-   \[[`4ab3c1690a`](nodejs/node@4ab3c1690a)] - **src**: cleanup crypto more (James M Snell) [#&#8203;57323](nodejs/node#57323)
-   \[[`5be80b1748`](nodejs/node@5be80b1748)] - **src**: refine ncrypto more (James M Snell) [#&#8203;57300](nodejs/node#57300)
-   \[[`6a13319a6e`](nodejs/node@6a13319a6e)] - **src**: cleanup aliased_buffer.h (Mohammed Keyvanzadeh) [#&#8203;57395](nodejs/node#57395)
-   \[[`3cff7f80bb`](nodejs/node@3cff7f80bb)] - **src**: suggest --use-system-ca when a certificate error occurs (Aditi) [#&#8203;57362](nodejs/node#57362)
-   \[[`3d372ad9f3`](nodejs/node@3d372ad9f3)] - **test**: update WPT for urlpattern to [`6ceca69`](nodejs/node@6ceca69d26) (Node.js GitHub Bot) [#&#8203;57486](nodejs/node#57486)
-   \[[`481ea665af`](nodejs/node@481ea665af)] - **test**: add more number cases for buffer.indexOf (Meghan Denny) [#&#8203;57200](nodejs/node#57200)
-   \[[`27b01ed4e7`](nodejs/node@27b01ed4e7)] - **test**: update parallel/test-tls-dhe for OpenSSL 3.5 (Richard Lau) [#&#8203;57477](nodejs/node#57477)
-   \[[`8f7debcf41`](nodejs/node@8f7debcf41)] - **timers**: optimize timer functions with improved argument handling (Gürgün Dayıoğlu) [#&#8203;57072](nodejs/node#57072)
-   \[[`d4abd9d3fb`](nodejs/node@d4abd9d3fb)] - **timers**: remove unnecessary allocation of \_onTimeout (Gürgün Dayıoğlu) [#&#8203;57497](nodejs/node#57497)
-   \[[`f8f81c8ba2`](nodejs/node@f8f81c8ba2)] - **timers**: remove unused parameter from insertGuarded (Gürgün Dayıoğlu) [#&#8203;57251](nodejs/node#57251)
-   \[[`c4fdb27b51`](nodejs/node@c4fdb27b51)] - **tls**: remove unnecessary type check on normalize (Yagiz Nizipli) [#&#8203;57336](nodejs/node#57336)
-   \[[`ad5dcc5798`](nodejs/node@ad5dcc5798)] - **tools**: fix WPT update cron string (Antoine du Hamel) [#&#8203;57665](nodejs/node#57665)
-   \[[`7faa482588`](nodejs/node@7faa482588)] - **tools**: remove stalled label on unstalled issues and MRs (Rich Trott) [#&#8203;57630](nodejs/node#57630)
-   \[[`e3bb26da2b`](nodejs/node@e3bb26da2b)] - **tools**: update sccache to support GH cache changes (Michaël Zasso) [#&#8203;57573](nodejs/node#57573)
-   \[[`f0c9f505d9`](nodejs/node@f0c9f505d9)] - **tools**: bump [@&#8203;babel/helpers](https://github.com/babel/helpers) from 7.26.9 to 7.26.10 in /tools/eslint (dependabot\[bot]) [#&#8203;57444](nodejs/node#57444)
-   \[[`a40ff1f646`](nodejs/node@a40ff1f646)] - **url**: fix constructor error message for URLPattern (jakecastelli) [#&#8203;57482](nodejs/node#57482)
-   \[[`f36bee4b89`](nodejs/node@f36bee4b89)] - **util**: avoid run debug when enabled is false (fengmk2) [#&#8203;57494](nodejs/node#57494)
-   \[[`1b8d1d3a3a`](nodejs/node@1b8d1d3a3a)] - **(SEMVER-MINOR)** **util**: expose diff function used by the assertion errors (Giovanni Bucci) [#&#8203;57462](nodejs/node#57462)
-   \[[`1f7b08a317`](nodejs/node@1f7b08a317)] - **win,test**: disable test case failing with ClangCL (Stefan Stojanovic) [#&#8203;57397](nodejs/node#57397)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4yMzAuMiIsInVwZGF0ZWRJblZlciI6IjM5LjIzMC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
@Firas2515 Firas2515 mentioned this pull request Apr 21, 2025
```suggestion actions/runner#3818
Closed
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@mhdawson @RafaelGSS
doc: clarify behaviour of node-api adjust function
5eebbaa
Refs: #57351
- based on recent request to update one of the tests

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #57463
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Vladimir Morozov <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@mhdawson @RafaelGSS
doc: clarify behaviour of node-api adjust function
0c66220
Refs: #57351
- based on recent request to update one of the tests

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #57463
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Vladimir Morozov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vmoroz vmoroz vmoroz approved these changes
@lpinca lpinca lpinca approved these changes
@legendecas legendecas legendecas approved these changes
+1 more reviewer
@NickNaso NickNaso NickNaso approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. doc Issues and PRs related to Node.js documentation. node-api Issues and PRs related to Node-API.

Projects

Node-API Team Project
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@mhdawson @nodejs-github-bot @NickNaso @vmoroz @lpinca @legendecas @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.