GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — sqlite: create authorization api by araujogui · Pull Request #59928 · nodejs/node

Conversation

@araujogui

@araujogui araujogui commented Sep 18, 2025

Copy link
Copy Markdown
Member

Fixes #59916

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

louwers, addaleax, bricss, ovflowd, and TheOneTheOnlyJJ reacted with thumbs up emoji
All reactions
  • 👍 5 reactions
araujogui added 6 commits September 18, 2025 11:33
@araujogui
sqlite: create authz method
6bf9173
@araujogui
sqlite: improve error handling
bf0fc42
@araujogui
doc: create setauthorizer method doc
41717ac
@araujogui
doc: lint
60ad323
@araujogui
doc: update doc link
19cdadf
@araujogui
sqlite: remove duplicated proto init
e25f0ce
@nodejs-github-bot

nodejs-github-bot commented Sep 18, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/sqlite
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Sep 18, 2025
araujogui added 2 commits September 18, 2025 14:29
@araujogui
sqlite: break long lines
e7288f3
@araujogui
sqlite: format code
3662e71
geeksilva97
geeksilva97 reviewed Sep 18, 2025
View reviewed changes
Comment thread src/node_sqlite.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.

@codecov

codecov Bot commented Sep 18, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.07339% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.46%. Comparing base (97e55f8) to head (0f4816f).
⚠️ Report is 72 commits behind head on main.

Files with missing lines Patch % Lines
src/node_sqlite.cc 88.07% 8 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #59928      +/-   ##
==========================================
+ Coverage   88.27%   88.46%   +0.18%     
==========================================
  Files         703      703              
  Lines      207333   207653     +320     
  Branches    39875    40031     +156     
==========================================
+ Hits       183028   183691     +663     
+ Misses      16263    15942     -321     
+ Partials     8042     8020      -22     
Files with missing lines Coverage Δ
src/node_sqlite.h 80.39% <ø> (ø)
src/node_sqlite.cc 80.15% <88.07%> (+0.54%) ⬆️

... and 79 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

addaleax
addaleax requested changes Sep 18, 2025
View reviewed changes
Comment thread src/node_sqlite.h Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/node_sqlite.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/node_sqlite.h Resolved

Uh oh!

There was an error while loading. Please reload this page.

araujogui added 2 commits September 22, 2025 20:56
@araujogui
sqlite: store callback in internal field
f63cba7
@araujogui
sqlite: restrict valid authz code
2714896
addaleax
addaleax approved these changes Sep 23, 2025
View reviewed changes
Comment thread src/node_sqlite.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/node_sqlite.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/node_sqlite.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.

@araujogui
sqlite: improve authorizer error handling
e66a64c
addaleax
addaleax reviewed Sep 24, 2025
View reviewed changes
Comment thread src/node_sqlite.h Resolved

Uh oh!

There was an error while loading. Please reload this page.

@araujogui
sqlite: store authz error in internal object
9e96632
@araujogui
araujogui force-pushed the feat/sqlite-authz branch from fef384f to 9e96632 Compare September 24, 2025 17:40
geeksilva97
geeksilva97 reviewed Sep 24, 2025
View reviewed changes
Comment thread src/node_sqlite.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.

@araujogui
sqlite: refactor authz code validation logic
a1553ef
@araujogui
araujogui force-pushed the feat/sqlite-authz branch from f592978 to a1553ef Compare September 24, 2025 21:58
geeksilva97
geeksilva97 reviewed Sep 25, 2025
View reviewed changes
Comment thread src/node_sqlite.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.

geeksilva97
geeksilva97 reviewed Sep 25, 2025
View reviewed changes
Comment thread src/node_sqlite.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.

araujogui added 3 commits September 25, 2025 14:58
@araujogui
sqlite: refactor ToLocalChecked usage
e6ab93d
@araujogui
sqlite: create constants doc
254680d
@araujogui
sqlite: create sqlite_ignore test cases
b51043c
@nodejs-github-bot

nodejs-github-bot commented Sep 25, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69378/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

addaleax
addaleax approved these changes Sep 26, 2025
View reviewed changes
@geeksilva97 geeksilva97 added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 26, 2025
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 26, 2025
@nodejs-github-bot

nodejs-github-bot commented Sep 26, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69387/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

addaleax
addaleax reviewed Sep 26, 2025
View reviewed changes
Comment thread src/node_sqlite.h Resolved

Uh oh!

There was an error while loading. Please reload this page.

araujogui added 2 commits September 26, 2025 17:25
@araujogui
sqlite: refactor authz error handling
526216d
@araujogui
sqlite: fix format
0f4816f
@araujogui

araujogui commented Sep 30, 2025

Copy link
Copy Markdown
Member Author

@addaleax @geeksilva97 are we good to merge?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

geeksilva97
geeksilva97 approved these changes Sep 30, 2025
View reviewed changes
@geeksilva97 geeksilva97 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Sep 30, 2025
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 30, 2025
@nodejs-github-bot

nodejs-github-bot commented Sep 30, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69472/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@addaleax addaleax added the semver-minor PRs that contain new features and should be released in the next minor version. label Oct 1, 2025
@addaleax

addaleax commented Oct 1, 2025

Copy link
Copy Markdown
Member

Landed in b217051

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

addaleax pushed a commit that referenced this pull request Oct 1, 2025
@araujogui @addaleax
sqlite: create authorization api
b217051
PR-URL: #59928
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Edy Silva <[email protected]>
@addaleax addaleax closed this Oct 1, 2025
@cjihrig cjihrig mentioned this pull request Oct 1, 2025
sqlite: expose authorization API #59916
Closed
targos pushed a commit that referenced this pull request Oct 6, 2025
@araujogui @targos
sqlite: create authorization api
18c79d9
PR-URL: #59928
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Edy Silva <[email protected]>
@github-actions github-actions Bot mentioned this pull request Oct 7, 2025
2025-10-08, Version 24.10.0 (Current) #60136
Merged
nodejs-github-bot added a commit that referenced this pull request Oct 7, 2025
@nodejs-github-bot
2025-10-07, Version 24.10.0 (Current)
6e0ed65
Notable changes:

console:
  * (SEMVER-MINOR) allow per-stream `inspectOptions` option (Anna Henningsen) #60082
lib:
  * (SEMVER-MINOR) remove util.getCallSite (Rafael Gonzaga) #59980
sqlite:
  * (SEMVER-MINOR) create authorization api (Guilherme Araújo) #59928

PR-URL: #60136
RafaelGSS pushed a commit that referenced this pull request Oct 8, 2025
@nodejs-github-bot @RafaelGSS
2025-10-08, Version 24.10.0 (Current)
9b72b88
Notable changes:

console:
  * (SEMVER-MINOR) allow per-stream `inspectOptions` option (Anna Henningsen) #60082
lib:
  * (SEMVER-MINOR) remove util.getCallSite (Rafael Gonzaga) #59980
sqlite:
  * (SEMVER-MINOR) create authorization api (Guilherme Araújo) #59928

PR-URL: #60136
Signed-off-by: RafaelGSS <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Oct 8, 2025
@nodejs-github-bot @RafaelGSS
2025-10-08, Version 24.10.0 (Current)
642a7c0
Notable changes:

console:
  * (SEMVER-MINOR) allow per-stream `inspectOptions` option (Anna Henningsen) #60082
lib:
  * (SEMVER-MINOR) remove util.getCallSite (Rafael Gonzaga) #59980
sqlite:
  * (SEMVER-MINOR) create authorization api (Guilherme Araújo) #59928

PR-URL: #60136
Signed-off-by: RafaelGSS <[email protected]>
@github-actions github-actions Bot mentioned this pull request Jan 3, 2026
chore(nix): update flake.lock (act, actionlint, awscli2 +25 more) i9wa4/dotfiles#79
Closed
juanarbol pushed a commit to juanarbol/node that referenced this pull request Jul 16, 2026
@araujogui @juanarbol
sqlite: create authorization api
a899991
PR-URL: nodejs#59928
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Edy Silva <[email protected]>
juanarbol added a commit that referenced this pull request Jul 16, 2026
@juanarbol
2026-07-21, Version 22.24.0 'Jod' (LTS)
d48d663
Notable changes:

async_hooks:
  * (SEMVER-MINOR) add trackPromises option to createHook() (Joyee Cheung) #61415
buffer:
  * (SEMVER-MINOR) increase Buffer.poolSize default to 64 KiB (Matteo Collina) #63597
cli:
  * (SEMVER-MINOR) add --max-heap-size option (tannal) #58708
console:
  * (SEMVER-MINOR) allow per-stream `inspectOptions` option (Anna Henningsen) #60082
crypto:
  * update root certificates to NSS 3.123.1 (Node.js GitHub Bot) #63527
debugger:
  * (SEMVER-MINOR) add edit-free runtime expression probes to `node inspect` (Joyee Cheung) #62713
fs:
  * (SEMVER-MINOR) add signal option to fs.stat() (Mert Can Altin) #57775
  * (SEMVER-MINOR) expose frsize field in statfs (Jinho Jang) #62277
  * (SEMVER-MINOR) add `throwIfNoEntry` option for fs.stat and fs.promises.stat (Juan José) #61178
  * (SEMVER-MINOR) add ignore option to fs.watch (Matteo Collina) #61433
http:
  * (SEMVER-MINOR) add writeInformation to send arbitrary 1xx status codes (Tim Perry) #63155
  * (SEMVER-MINOR) add req.signal to IncomingMessage (Akshat) #62541
lib:
  * (SEMVER-MINOR) remove util.getCallSite (Rafael Gonzaga) #59980
net:
  * (SEMVER-MINOR) add `setTOS` and `getTOS` to `Socket` (Amol Yadav) #61503
node-api:
  * (SEMVER-MINOR) support SharedArrayBuffer in napi_create_dataview (Kevin Eady) #60473
  * (SEMVER-MINOR) add napi_create_object_with_properties (Miguel Marcondes Filho) #59953
perf_hooks:
  * (SEMVER-MINOR) move non-standard performance properties to perf_hooks (Chengzhong Wu) #60370
sqlite:
  * (SEMVER-MINOR) add sqlite prepare options args (Guilherme Araújo) #61311
  * (SEMVER-MINOR) create authorization api (Guilherme Araújo) #59928
src:
  * (CVE-2026-21712) handle url crash on different url formats (RafaelGSS) nodejs-private/node-private#816
src,permission:
  * (SEMVER-MINOR) add --allow-inspector ability (Rafael Gonzaga) #59711
stream:
  * (SEMVER-MINOR) add bytes() method to stream/consumers (wantaek) #60426
  * (SEMVER-MINOR) do not pass `readable.compose()` output via `Readable.from()` (René) #60907
test_runner:
  * (SEMVER-MINOR) align mock timeout api (sangwook) #62820

PR-URL: TODO
@juanarbol juanarbol mentioned this pull request Jul 16, 2026
V22.24.0 proposal #64533
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes
@cjihrig cjihrig cjihrig left review comments
@Renegade334 Renegade334 Renegade334 left review comments
@geeksilva97 geeksilva97 geeksilva97 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version. sqlite Issues and PRs related to the SQLite subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

sqlite: expose authorization API

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@araujogui @nodejs-github-bot @addaleax @cjihrig @Renegade334 @geeksilva97
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.