GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — lib: remove util.getCallSite by RafaelGSS · Pull Request #59980 · nodejs/node

Conversation

@RafaelGSS

@RafaelGSS RafaelGSS commented Sep 22, 2025

Copy link
Copy Markdown
Member

This API has been replaced by util.getCallSites().

It was previously experimental with a warning about its usage and its removal in a semver-minor PR. Here it is.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@RafaelGSS
lib: remove util.getCallSite
1586e3b
This API has been replaced by util.getCallSites().

It was previously experimental with a warning about
its usage and its removal in a semver-minor PR. Here it
is.
@RafaelGSS RafaelGSS added the semver-minor PRs that contain new features and should be released in the next minor version. label Sep 22, 2025
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels Sep 22, 2025
@RafaelGSS
RafaelGSS requested a review from legendecas September 22, 2025 23:14
legendecas
legendecas approved these changes Sep 22, 2025
View reviewed changes
@codecov

codecov Bot commented Sep 23, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.45%. Comparing base (54c4567) to head (0cc017a).
⚠️ Report is 116 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #59980      +/-   ##
==========================================
+ Coverage   88.43%   88.45%   +0.01%     
==========================================
  Files         703      703              
  Lines      207359   207524     +165     
  Branches    39985    40011      +26     
==========================================
+ Hits       183386   183572     +186     
+ Misses      15984    15938      -46     
- Partials     7989     8014      +25     
Files with missing lines Coverage Δ
lib/util.js 97.95% <ø> (-0.02%) ⬇️

... and 44 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jasnell
jasnell approved these changes Sep 23, 2025
View reviewed changes
@RafaelGSS
fixup! lib: remove util.getCallSite
0cc017a
@legendecas legendecas added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Sep 25, 2025
@nodejs-github-bot

nodejs-github-bot commented Sep 25, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69370/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented Sep 29, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69444/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented Oct 6, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69582/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@RafaelGSS RafaelGSS added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 6, 2025
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 6, 2025
@nodejs-github-bot

nodejs-github-bot commented Oct 6, 2025

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/59980
✔  Done loading data for nodejs/node/pull/59980
----------------------------------- PR info ------------------------------------
Title      lib: remove util.getCallSite (#59980)
Author     Rafael Gonzaga <[email protected]> (@RafaelGSS)
Branch     RafaelGSS:drop-get-call-site-api -> nodejs:main
Labels     util, semver-minor, author ready, needs-ci
Commits    2
 - lib: remove util.getCallSite
 - fixup! lib: remove util.getCallSite
Committers 1
 - RafaelGSS <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/59980
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/59980
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - lib: remove util.getCallSite
   ⚠  - fixup! lib: remove util.getCallSite
   ℹ  This PR was created on Mon, 22 Sep 2025 23:11:16 GMT
   ✔  Approvals: 2
   ✔  - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/59980#pullrequestreview-3255563043
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/59980#pullrequestreview-3258095389
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2025-10-06T13:52:51Z: https://ci.nodejs.org/job/node-test-pull-request/69582/
- Querying data for job/node-test-pull-request/69582/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/18288699054
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@RafaelGSS RafaelGSS removed the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label Oct 6, 2025
@RafaelGSS

RafaelGSS commented Oct 6, 2025

Copy link
Copy Markdown
Member Author

Please, approve again after the fixup.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

legendecas
legendecas approved these changes Oct 6, 2025
View reviewed changes
@legendecas legendecas added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 6, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 6, 2025
@nodejs-github-bot
nodejs-github-bot merged commit b757a8f into nodejs:main Oct 6, 2025
6 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented Oct 6, 2025

Copy link
Copy Markdown
Collaborator

Landed in b757a8f

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

RafaelGSS added a commit that referenced this pull request Oct 7, 2025
@RafaelGSS
lib: remove util.getCallSite
3b92be2
This API has been replaced by util.getCallSites().

It was previously experimental with a warning about
its usage and its removal in a semver-minor PR. Here it
is.

PR-URL: #59980
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@github-actions github-actions Bot mentioned this pull request Oct 7, 2025
2025-10-08, Version 24.10.0 (Current) #60136
Merged
nodejs-github-bot added a commit that referenced this pull request Oct 7, 2025
@nodejs-github-bot
2025-10-07, Version 24.10.0 (Current)
6e0ed65
Notable changes:

console:
  * (SEMVER-MINOR) allow per-stream `inspectOptions` option (Anna Henningsen) #60082
lib:
  * (SEMVER-MINOR) remove util.getCallSite (Rafael Gonzaga) #59980
sqlite:
  * (SEMVER-MINOR) create authorization api (Guilherme Araújo) #59928

PR-URL: #60136
RafaelGSS pushed a commit that referenced this pull request Oct 8, 2025
@nodejs-github-bot @RafaelGSS
2025-10-08, Version 24.10.0 (Current)
9b72b88
Notable changes:

console:
  * (SEMVER-MINOR) allow per-stream `inspectOptions` option (Anna Henningsen) #60082
lib:
  * (SEMVER-MINOR) remove util.getCallSite (Rafael Gonzaga) #59980
sqlite:
  * (SEMVER-MINOR) create authorization api (Guilherme Araújo) #59928

PR-URL: #60136
Signed-off-by: RafaelGSS <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Oct 8, 2025
@nodejs-github-bot @RafaelGSS
2025-10-08, Version 24.10.0 (Current)
642a7c0
Notable changes:

console:
  * (SEMVER-MINOR) allow per-stream `inspectOptions` option (Anna Henningsen) #60082
lib:
  * (SEMVER-MINOR) remove util.getCallSite (Rafael Gonzaga) #59980
sqlite:
  * (SEMVER-MINOR) create authorization api (Guilherme Araújo) #59928

PR-URL: #60136
Signed-off-by: RafaelGSS <[email protected]>
@claude claude Bot mentioned this pull request Nov 11, 2025
Update dependency @types/node to v24.19.2 harusame0616/bingo-bang-online#94
Open
1 task
@github-actions github-actions Bot mentioned this pull request Jan 3, 2026
chore(nix): update flake.lock (act, actionlint, awscli2 +25 more) i9wa4/dotfiles#79
Closed
juanarbol pushed a commit to juanarbol/node that referenced this pull request Jul 16, 2026
@RafaelGSS @juanarbol
lib: remove util.getCallSite
6384766
This API has been replaced by util.getCallSites().

It was previously experimental with a warning about
its usage and its removal in a semver-minor PR. Here it
is.

PR-URL: nodejs#59980
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
juanarbol added a commit that referenced this pull request Jul 16, 2026
@juanarbol
2026-07-21, Version 22.24.0 'Jod' (LTS)
d48d663
Notable changes:

async_hooks:
  * (SEMVER-MINOR) add trackPromises option to createHook() (Joyee Cheung) #61415
buffer:
  * (SEMVER-MINOR) increase Buffer.poolSize default to 64 KiB (Matteo Collina) #63597
cli:
  * (SEMVER-MINOR) add --max-heap-size option (tannal) #58708
console:
  * (SEMVER-MINOR) allow per-stream `inspectOptions` option (Anna Henningsen) #60082
crypto:
  * update root certificates to NSS 3.123.1 (Node.js GitHub Bot) #63527
debugger:
  * (SEMVER-MINOR) add edit-free runtime expression probes to `node inspect` (Joyee Cheung) #62713
fs:
  * (SEMVER-MINOR) add signal option to fs.stat() (Mert Can Altin) #57775
  * (SEMVER-MINOR) expose frsize field in statfs (Jinho Jang) #62277
  * (SEMVER-MINOR) add `throwIfNoEntry` option for fs.stat and fs.promises.stat (Juan José) #61178
  * (SEMVER-MINOR) add ignore option to fs.watch (Matteo Collina) #61433
http:
  * (SEMVER-MINOR) add writeInformation to send arbitrary 1xx status codes (Tim Perry) #63155
  * (SEMVER-MINOR) add req.signal to IncomingMessage (Akshat) #62541
lib:
  * (SEMVER-MINOR) remove util.getCallSite (Rafael Gonzaga) #59980
net:
  * (SEMVER-MINOR) add `setTOS` and `getTOS` to `Socket` (Amol Yadav) #61503
node-api:
  * (SEMVER-MINOR) support SharedArrayBuffer in napi_create_dataview (Kevin Eady) #60473
  * (SEMVER-MINOR) add napi_create_object_with_properties (Miguel Marcondes Filho) #59953
perf_hooks:
  * (SEMVER-MINOR) move non-standard performance properties to perf_hooks (Chengzhong Wu) #60370
sqlite:
  * (SEMVER-MINOR) add sqlite prepare options args (Guilherme Araújo) #61311
  * (SEMVER-MINOR) create authorization api (Guilherme Araújo) #59928
src:
  * (CVE-2026-21712) handle url crash on different url formats (RafaelGSS) nodejs-private/node-private#816
src,permission:
  * (SEMVER-MINOR) add --allow-inspector ability (Rafael Gonzaga) #59711
stream:
  * (SEMVER-MINOR) add bytes() method to stream/consumers (wantaek) #60426
  * (SEMVER-MINOR) do not pass `readable.compose()` output via `Readable.from()` (René) #60907
test_runner:
  * (SEMVER-MINOR) align mock timeout api (sangwook) #62820

PR-URL: TODO
@juanarbol juanarbol mentioned this pull request Jul 16, 2026
V22.24.0 proposal #64533
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@legendecas legendecas legendecas approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version. util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@RafaelGSS @nodejs-github-bot @jasnell @legendecas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.