GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||
GeezerVison is showing github.com — lib: remove util.getCallSite by RafaelGSS · Pull Request #59980 · nodejs/node Conversation
Member
This API has been replaced by util.getCallSites(). It was previously experimental with a warning about its usage and its removal in a semver-minor PR. Here it is.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsThis API has been replaced by util.getCallSites(). It was previously experimental with a warning about its usage and its removal in a semver-minor PR. Here it is.
legendecas
approved these changes
|
There was an error while loading. Please reload this page.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## main #59980 +/- ## ========================================== + Coverage 88.43% 88.45% +0.01% ========================================== Files 703 703 Lines 207359 207524 +165 Branches 39985 40011 +26 ========================================== + Hits 183386 183572 +186 + Misses 15984 15938 -46 - Partials 7989 8014 +25
🚀 New features to boost your workflow:
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Commit Queue failed- Loading data for nodejs/node/pull/59980 ✔ Done loading data for nodejs/node/pull/59980 ----------------------------------- PR info ------------------------------------ Title lib: remove util.getCallSite (#59980) Author Rafael Gonzaga <[email protected]> (@RafaelGSS) Branch RafaelGSS:drop-get-call-site-api -> nodejs:main Labels util, semver-minor, author ready, needs-ci Commits 2 - lib: remove util.getCallSite - fixup! lib: remove util.getCallSite Committers 1 - RafaelGSS <[email protected]> PR-URL: https://github.com/nodejs/node/pull/59980 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: James M Snell <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/59980 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: James M Snell <[email protected]> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - lib: remove util.getCallSite ⚠ - fixup! lib: remove util.getCallSite ℹ This PR was created on Mon, 22 Sep 2025 23:11:16 GMT ✔ Approvals: 2 ✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/59980#pullrequestreview-3255563043 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/59980#pullrequestreview-3258095389 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-10-06T13:52:51Z: https://ci.nodejs.org/job/node-test-pull-request/69582/ - Querying data for job/node-test-pull-request/69582/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/18288699054 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Please, approve again after the fixup. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Landed in b757a8f |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
This API has been replaced by util.getCallSites(). It was previously experimental with a warning about its usage and its removal in a semver-minor PR. Here it is. PR-URL: #59980 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: James M Snell <[email protected]>
Notable changes: console: * (SEMVER-MINOR) allow per-stream `inspectOptions` option (Anna Henningsen) #60082 lib: * (SEMVER-MINOR) remove util.getCallSite (Rafael Gonzaga) #59980 sqlite: * (SEMVER-MINOR) create authorization api (Guilherme Araújo) #59928 PR-URL: #60136 Signed-off-by: RafaelGSS <[email protected]>
Notable changes: console: * (SEMVER-MINOR) allow per-stream `inspectOptions` option (Anna Henningsen) #60082 lib: * (SEMVER-MINOR) remove util.getCallSite (Rafael Gonzaga) #59980 sqlite: * (SEMVER-MINOR) create authorization api (Guilherme Araújo) #59928 PR-URL: #60136 Signed-off-by: RafaelGSS <[email protected]>
This API has been replaced by util.getCallSites(). It was previously experimental with a warning about its usage and its removal in a semver-minor PR. Here it is. PR-URL: nodejs#59980 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: James M Snell <[email protected]>
Notable changes: async_hooks: * (SEMVER-MINOR) add trackPromises option to createHook() (Joyee Cheung) #61415 buffer: * (SEMVER-MINOR) increase Buffer.poolSize default to 64 KiB (Matteo Collina) #63597 cli: * (SEMVER-MINOR) add --max-heap-size option (tannal) #58708 console: * (SEMVER-MINOR) allow per-stream `inspectOptions` option (Anna Henningsen) #60082 crypto: * update root certificates to NSS 3.123.1 (Node.js GitHub Bot) #63527 debugger: * (SEMVER-MINOR) add edit-free runtime expression probes to `node inspect` (Joyee Cheung) #62713 fs: * (SEMVER-MINOR) add signal option to fs.stat() (Mert Can Altin) #57775 * (SEMVER-MINOR) expose frsize field in statfs (Jinho Jang) #62277 * (SEMVER-MINOR) add `throwIfNoEntry` option for fs.stat and fs.promises.stat (Juan José) #61178 * (SEMVER-MINOR) add ignore option to fs.watch (Matteo Collina) #61433 http: * (SEMVER-MINOR) add writeInformation to send arbitrary 1xx status codes (Tim Perry) #63155 * (SEMVER-MINOR) add req.signal to IncomingMessage (Akshat) #62541 lib: * (SEMVER-MINOR) remove util.getCallSite (Rafael Gonzaga) #59980 net: * (SEMVER-MINOR) add `setTOS` and `getTOS` to `Socket` (Amol Yadav) #61503 node-api: * (SEMVER-MINOR) support SharedArrayBuffer in napi_create_dataview (Kevin Eady) #60473 * (SEMVER-MINOR) add napi_create_object_with_properties (Miguel Marcondes Filho) #59953 perf_hooks: * (SEMVER-MINOR) move non-standard performance properties to perf_hooks (Chengzhong Wu) #60370 sqlite: * (SEMVER-MINOR) add sqlite prepare options args (Guilherme Araújo) #61311 * (SEMVER-MINOR) create authorization api (Guilherme Araújo) #59928 src: * (CVE-2026-21712) handle url crash on different url formats (RafaelGSS) nodejs-private/node-private#816 src,permission: * (SEMVER-MINOR) add --allow-inspector ability (Rafael Gonzaga) #59711 stream: * (SEMVER-MINOR) add bytes() method to stream/consumers (wantaek) #60426 * (SEMVER-MINOR) do not pass `readable.compose()` output via `Readable.from()` (René) #60907 test_runner: * (SEMVER-MINOR) align mock timeout api (sangwook) #62820 PR-URL: TODO
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.