GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — async_hooks: add trackPromises option to createHook() by joyeecheung · Pull Request #61415 · nodejs/node

Conversation

@joyeecheung

@joyeecheung joyeecheung commented Jan 17, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This adds a trackPromises option that allows users to completely opt out of the promise hooks that are installed whenever an async hook is added. For those who do not need to track promises, this avoids the excessive hook invocation and the heavy overhead from it.

This option was previously already implemented internally to skip the noise from promise hooks when debugging async operations via the V8 inspector. This patch just exposes it.

Refs: #57148

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. needs-ci PRs that need a full CI run. labels Jan 17, 2026
@joyeecheung
async_hooks: add trackPromises option to createHook()
2241850
This adds a trackPromises option that allows users to completely opt
out of the promise hooks that are installed whenever an async hook is
added. For those who do not need to track promises, this avoids
the excessive hook invocation and the heavy overhead from it.

This option was previously already implemented internally to skip the
noise from promise hooks when debugging async operations via the
V8 inspector. This patch just exposes it.
@joyeecheung
joyeecheung force-pushed the track-promises branch from f31931b to 2241850 Compare January 17, 2026 22:41
@codecov

codecov Bot commented Jan 17, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.54%. Comparing base (1bd7f62) to head (3759c9e).
⚠️ Report is 145 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #61415      +/-   ##
==========================================
+ Coverage   88.51%   88.54%   +0.02%     
==========================================
  Files         704      704              
  Lines      208739   208897     +158     
  Branches    40274    40332      +58     
==========================================
+ Hits       184770   184964     +194     
+ Misses      15968    15936      -32     
+ Partials     8001     7997       -4     
Files with missing lines Coverage Δ
lib/async_hooks.js 100.00% <100.00%> (ø)
lib/internal/inspector_async_hook.js 100.00% <100.00%> (ø)

... and 77 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Flarna Flarna added the semver-minor PRs that contain new features and should be released in the next minor version. label Jan 18, 2026
Flarna
Flarna reviewed Jan 18, 2026
View reviewed changes
Comment thread doc/api/async_hooks.md
will not have the `before` and `after` callbacks fired on them. For more details
see the details of the V8 [PromiseHooks][] API.
### Disabling promise execution tracking

@Flarna Flarna Jan 18, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW promise tracking might still be enabled because some other async_hooks instance is using it (e.g. domain, ALS in older node.js versions or if --no-async-context-frame is set).

not sure if it is worth to mention this somewhere here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@joyeecheung joyeecheung Jan 19, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an option and the default (tracking it by default) has not been changed - even when it is changed, the internal call sites can just specify it to be true explicitly, so I think it probably doesn't need documentation changes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Flarna
Flarna approved these changes Jan 18, 2026
View reviewed changes
@joyeecheung joyeecheung added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Jan 19, 2026
@Flarna Flarna added the commit-queue-squash PRs the Commit Queue should land as one squashed commit. label Jan 19, 2026
Flarna
Flarna approved these changes Jan 19, 2026
View reviewed changes
avivkeller
avivkeller reviewed Jan 19, 2026
View reviewed changes
Comment thread tools/gdbinit Resolved

Uh oh!

There was an error while loading. Please reload this page.

@joyeecheung
fixup! async_hooks: add trackPromises option to createHook()
3759c9e
@joyeecheung
joyeecheung force-pushed the track-promises branch from 57550f3 to 3759c9e Compare January 19, 2026 23:23
@joyeecheung

joyeecheung commented Jan 27, 2026

Copy link
Copy Markdown
Member Author

Updated to remove the accidentally checked in script @Flarna can you take a look again?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Flarna
Flarna approved these changes Jan 27, 2026
View reviewed changes
@Flarna Flarna added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jan 27, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jan 27, 2026
@nodejs-github-bot

nodejs-github-bot commented Jan 27, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71073/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented Jan 27, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71077/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@joyeecheung joyeecheung added the commit-queue PRs queued for automated landing through the Commit Queue. label Jan 28, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jan 28, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 8c380de into nodejs:main Jan 28, 2026
66 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented Jan 28, 2026

Copy link
Copy Markdown
Collaborator

Landed in 8c380de

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

aduh95 pushed a commit that referenced this pull request Jan 28, 2026
@joyeecheung @aduh95
async_hooks: add trackPromises option to createHook()
796ff46
This adds a trackPromises option that allows users to completely opt
out of the promise hooks that are installed whenever an async hook is
added. For those who do not need to track promises, this avoids
the excessive hook invocation and the heavy overhead from it.

This option was previously already implemented internally to skip the
noise from promise hooks when debugging async operations via the
V8 inspector. This patch just exposes it.

PR-URL: #61415
Refs: #57148
Reviewed-By: Gerhard Stöbich <[email protected]>
@github-actions github-actions Bot mentioned this pull request Feb 2, 2026
2026-02-03, Version 25.6.0 (Current) #61635
Merged
nodejs-github-bot added a commit that referenced this pull request Feb 2, 2026
@nodejs-github-bot
2026-02-03, Version 25.6.0 (Current)
9e5f1c1
Notable changes:

async_hooks:
  * (SEMVER-MINOR) add trackPromises option to createHook() (Joyee Cheung) #61415
src:
  * improve textEncoder encode performance with simdutf (Mert Can Altin) #61496
stream:
  * (SEMVER-MINOR) add bytes() method to stream/consumers (wantaek) #60426
test_runner:
  * (SEMVER-MINOR) add env option to run function (Ethan Arrowood) #61367
url:
  * update ada to v3.4.2 and support unicode 17 (Yagiz Nizipli) #61593

PR-URL: #61635
aduh95
aduh95 reviewed Feb 2, 2026
View reviewed changes
Comment thread doc/api/async_hooks.md
## `async_hooks.createHook(options)`

<!-- YAML
added: v8.1.0

@aduh95 aduh95 Feb 2, 2026

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would have been nice to have a history entry to track this change

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@abelinagomez274-code abelinagomez274-code Feb 3, 2026

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
aduh95 added a commit that referenced this pull request Feb 2, 2026
@aduh95
2026-02-03, Version 25.6.0 (Current)
f8a81d1
Notable changes:

async_hooks:
  * (SEMVER-MINOR) add `trackPromises` option to `createHook()` (Joyee Cheung) #61415
net:
  * (SEMVER-MINOR) add `setTOS` and `getTOS` to `Socket` (Amol Yadav) #61503
src:
  * (SEMVER-MINOR) add initial support for ESM in embedder API (Joyee Cheung) #61548
  * improve `TextEncoder` encode performance with `simdutf` (Mert Can Altin) #61496
stream:
  * (SEMVER-MINOR) add `bytes()` method to `node:stream/consumers` (wantaek) #60426
test_runner:
  * (SEMVER-MINOR) add `env` option to `run` function (Ethan Arrowood) #61367
url:
  * update Ada to v3.4.2 and support Unicode 17 (Yagiz Nizipli) #61593

PR-URL: #61635
aduh95 added a commit that referenced this pull request Feb 3, 2026
@aduh95
2026-02-03, Version 25.6.0 (Current)
1818bb7
Notable changes:

async_hooks:
  * (SEMVER-MINOR) add `trackPromises` option to `createHook()` (Joyee Cheung) #61415
net:
  * (SEMVER-MINOR) add `setTOS` and `getTOS` to `Socket` (Amol Yadav) #61503
src:
  * (SEMVER-MINOR) add initial support for ESM in embedder API (Joyee Cheung) #61548
  * improve `TextEncoder` encode performance with `simdutf` (Mert Can Altin) #61496
stream:
  * (SEMVER-MINOR) add `bytes()` method to `node:stream/consumers` (wantaek) #60426
test_runner:
  * (SEMVER-MINOR) add `env` option to `run` function (Ethan Arrowood) #61367
url:
  * update Ada to v3.4.2 and support Unicode 17 (Yagiz Nizipli) #61593

PR-URL: #61635
aduh95 pushed a commit that referenced this pull request Feb 10, 2026
@joyeecheung @aduh95
async_hooks: add trackPromises option to createHook()
feedfd5
This adds a trackPromises option that allows users to completely opt
out of the promise hooks that are installed whenever an async hook is
added. For those who do not need to track promises, this avoids
the excessive hook invocation and the heavy overhead from it.

This option was previously already implemented internally to skip the
noise from promise hooks when debugging async operations via the
V8 inspector. This patch just exposes it.

PR-URL: #61415
Refs: #57148
Reviewed-By: Gerhard Stöbich <[email protected]>
@github-actions github-actions Bot mentioned this pull request Feb 22, 2026
2026-02-24, Version 24.14.0 'Krypton' (LTS) #61924
Merged
nodejs-github-bot added a commit that referenced this pull request Feb 22, 2026
@nodejs-github-bot
2026-02-24, Version 24.14.0 'Krypton' (LTS)
8a522ec
Notable changes:

async_hooks:
  * (SEMVER-MINOR) add trackPromises option to createHook() (Joyee Cheung) #61415
build,deps:
  * replace cjs-module-lexer with merve (Yagiz Nizipli) #61456
deps:
  * (SEMVER-MINOR) add LIEF as a dependency (Joyee Cheung) #61167
  * (SEMVER-MINOR) add tools and scripts to pull LIEF as a dependency (Joyee Cheung) #61167
events:
  * (SEMVER-MINOR) repurpose `events.listenerCount()` to accept EventTargets (René) #60214
fs:
  * (SEMVER-MINOR) add ignore option to fs.watch (Matteo Collina) #61433
http:
  * (SEMVER-MINOR) add http.setGlobalProxyFromEnv() (Joyee Cheung) #60953
module:
  * (SEMVER-MINOR) allow subpath imports that start with `#/` (Jan Martin) #60864
process:
  * (SEMVER-MINOR) preserve AsyncLocalStorage in queueMicrotask only when needed (Gürgün Dayıoğlu) #60913
sea:
  * (SEMVER-MINOR) split sea binary manipulation code (Joyee Cheung) #61167
sqlite:
  * (SEMVER-MINOR) enable defensive mode by default (Bart Louwers) #61266
  * (SEMVER-MINOR) add sqlite prepare options args (Guilherme Araújo) #61311
src:
  * (SEMVER-MINOR) add initial support for ESM in embedder API (Joyee Cheung) #61548
stream:
  * (SEMVER-MINOR) add bytes() method to stream/consumers (wantaek) #60426
  * (SEMVER-MINOR) do not pass `readable.compose()` output via `Readable.from()` (René) #60907
test:
  * (SEMVER-MINOR) use fixture directories for sea tests (Joyee Cheung) #61167
test_runner:
  * (SEMVER-MINOR) add env option to run function (Ethan Arrowood) #61367
  * (SEMVER-MINOR) support expecting a test-case to fail (Jacob Smith) #60669
util:
  * (SEMVER-MINOR) add convertProcessSignalToExitCode utility (Erick Wendel) #60963

PR-URL: #61924
aduh95 pushed a commit that referenced this pull request Feb 22, 2026
@joyeecheung @aduh95
async_hooks: add trackPromises option to createHook()
8b6d31d
This adds a trackPromises option that allows users to completely opt
out of the promise hooks that are installed whenever an async hook is
added. For those who do not need to track promises, this avoids
the excessive hook invocation and the heavy overhead from it.

This option was previously already implemented internally to skip the
noise from promise hooks when debugging async operations via the
V8 inspector. This patch just exposes it.

PR-URL: #61415
Refs: #57148
Reviewed-By: Gerhard Stöbich <[email protected]>
aduh95 added a commit that referenced this pull request Feb 22, 2026
@aduh95
2026-02-24, Version 24.14.0 'Krypton' (LTS)
9ec7093
Notable changes:

async_hooks:
  * (SEMVER-MINOR) add `trackPromises` option to `createHook()` (Joyee Cheung) #61415
build,deps:
  * replace cjs-module-lexer with merve (Yagiz Nizipli) #61456
deps:
  * (SEMVER-MINOR) add LIEF as a dependency (Joyee Cheung) #61167
events:
  * (SEMVER-MINOR) repurpose `events.listenerCount()` to accept `EventTarget`s (René) #60214
fs:
  * (SEMVER-MINOR) add `ignore` option to `fs.watch` (Matteo Collina) #61433
http:
  * (SEMVER-MINOR) add `http.setGlobalProxyFromEnv()` (Joyee Cheung) #60953
module:
  * (SEMVER-MINOR) allow subpath imports that start with `#/` (Jan Martin) #60864
process:
  * (SEMVER-MINOR) preserve `AsyncLocalStorage` in `queueMicrotask` only when needed (Gürgün Dayıoğlu) #60913
sea:
  * (SEMVER-MINOR) split sea binary manipulation code (Joyee Cheung) #61167
sqlite:
  * (SEMVER-MINOR) enable defensive mode by default (Bart Louwers) #61266
  * (SEMVER-MINOR) add sqlite prepare options args (Guilherme Araújo) #61311
src:
  * (SEMVER-MINOR) add initial support for ESM in embedder API (Joyee Cheung) #61548
stream:
  * (SEMVER-MINOR) add `bytes()` method to `node:stream/consumers` (wantaek) #60426
  * (SEMVER-MINOR) do not pass `readable.compose()` output via `Readable.from()` (René) #60907
test:
  * (SEMVER-MINOR) use fixture directories for sea tests (Joyee Cheung) #61167
test_runner:
  * (SEMVER-MINOR) add `env` option to `run` function (Ethan Arrowood) #61367
  * (SEMVER-MINOR) support expecting a test-case to fail (Jacob Smith) #60669
util:
  * (SEMVER-MINOR) add `convertProcessSignalToExitCode` utility (Erick Wendel) #60963

PR-URL: #61924
aduh95 added a commit that referenced this pull request Feb 23, 2026
@aduh95
2026-02-24, Version 24.14.0 'Krypton' (LTS)
f657bb8
Notable changes:

async_hooks:
  * (SEMVER-MINOR) add `trackPromises` option to `createHook()` (Joyee Cheung) #61415
build,deps:
  * replace cjs-module-lexer with merve (Yagiz Nizipli) #61456
deps:
  * (SEMVER-MINOR) add LIEF as a dependency (Joyee Cheung) #61167
events:
  * (SEMVER-MINOR) repurpose `events.listenerCount()` to accept `EventTarget`s (René) #60214
fs:
  * (SEMVER-MINOR) add `ignore` option to `fs.watch` (Matteo Collina) #61433
http:
  * (SEMVER-MINOR) add `http.setGlobalProxyFromEnv()` (Joyee Cheung) #60953
module:
  * (SEMVER-MINOR) allow subpath imports that start with `#/` (Jan Martin) #60864
process:
  * (SEMVER-MINOR) preserve `AsyncLocalStorage` in `queueMicrotask` only when needed (Gürgün Dayıoğlu) #60913
sea:
  * (SEMVER-MINOR) split sea binary manipulation code (Joyee Cheung) #61167
sqlite:
  * (SEMVER-MINOR) enable defensive mode by default (Bart Louwers) #61266
  * (SEMVER-MINOR) add sqlite prepare options args (Guilherme Araújo) #61311
src:
  * (SEMVER-MINOR) add initial support for ESM in embedder API (Joyee Cheung) #61548
stream:
  * (SEMVER-MINOR) add `bytes()` method to `node:stream/consumers` (wantaek) #60426
  * (SEMVER-MINOR) do not pass `readable.compose()` output via `Readable.from()` (René) #60907
test:
  * (SEMVER-MINOR) use fixture directories for sea tests (Joyee Cheung) #61167
test_runner:
  * (SEMVER-MINOR) add `env` option to `run` function (Ethan Arrowood) #61367
  * (SEMVER-MINOR) support expecting a test-case to fail (Jacob Smith) #60669
util:
  * (SEMVER-MINOR) add `convertProcessSignalToExitCode` utility (Erick Wendel) #60963

PR-URL: #61924
ruyadorno pushed a commit that referenced this pull request Feb 24, 2026
@aduh95 @ruyadorno
2026-02-24, Version 24.14.0 'Krypton' (LTS)
001d5d4
Notable changes:

async_hooks:
  * (SEMVER-MINOR) add `trackPromises` option to `createHook()` (Joyee Cheung) #61415
build,deps:
  * replace cjs-module-lexer with merve (Yagiz Nizipli) #61456
deps:
  * (SEMVER-MINOR) add LIEF as a dependency (Joyee Cheung) #61167
events:
  * (SEMVER-MINOR) repurpose `events.listenerCount()` to accept `EventTarget`s (René) #60214
fs:
  * (SEMVER-MINOR) add `ignore` option to `fs.watch` (Matteo Collina) #61433
http:
  * (SEMVER-MINOR) add `http.setGlobalProxyFromEnv()` (Joyee Cheung) #60953
module:
  * (SEMVER-MINOR) allow subpath imports that start with `#/` (Jan Martin) #60864
process:
  * (SEMVER-MINOR) preserve `AsyncLocalStorage` in `queueMicrotask` only when needed (Gürgün Dayıoğlu) #60913
sea:
  * (SEMVER-MINOR) split sea binary manipulation code (Joyee Cheung) #61167
sqlite:
  * (SEMVER-MINOR) enable defensive mode by default (Bart Louwers) #61266
  * (SEMVER-MINOR) add sqlite prepare options args (Guilherme Araújo) #61311
src:
  * (SEMVER-MINOR) add initial support for ESM in embedder API (Joyee Cheung) #61548
stream:
  * (SEMVER-MINOR) add `bytes()` method to `node:stream/consumers` (wantaek) #60426
  * (SEMVER-MINOR) do not pass `readable.compose()` output via `Readable.from()` (René) #60907
test:
  * (SEMVER-MINOR) use fixture directories for sea tests (Joyee Cheung) #61167
test_runner:
  * (SEMVER-MINOR) add `env` option to `run` function (Ethan Arrowood) #61367
  * (SEMVER-MINOR) support expecting a test-case to fail (Jacob Smith) #60669
util:
  * (SEMVER-MINOR) add `convertProcessSignalToExitCode` utility (Erick Wendel) #60963

PR-URL: #61924
@chaiphetwongchaiyatham0-ohmk

This comment has been minimized.

Sign in to view
juanarbol pushed a commit to juanarbol/node that referenced this pull request Jul 16, 2026
@joyeecheung @juanarbol
async_hooks: add trackPromises option to createHook()
4239d07
This adds a trackPromises option that allows users to completely opt
out of the promise hooks that are installed whenever an async hook is
added. For those who do not need to track promises, this avoids
the excessive hook invocation and the heavy overhead from it.

This option was previously already implemented internally to skip the
noise from promise hooks when debugging async operations via the
V8 inspector. This patch just exposes it.

PR-URL: nodejs#61415
Refs: nodejs#57148
Reviewed-By: Gerhard Stöbich <[email protected]>
juanarbol added a commit that referenced this pull request Jul 16, 2026
@juanarbol
2026-07-21, Version 22.24.0 'Jod' (LTS)
d48d663
Notable changes:

async_hooks:
  * (SEMVER-MINOR) add trackPromises option to createHook() (Joyee Cheung) #61415
buffer:
  * (SEMVER-MINOR) increase Buffer.poolSize default to 64 KiB (Matteo Collina) #63597
cli:
  * (SEMVER-MINOR) add --max-heap-size option (tannal) #58708
console:
  * (SEMVER-MINOR) allow per-stream `inspectOptions` option (Anna Henningsen) #60082
crypto:
  * update root certificates to NSS 3.123.1 (Node.js GitHub Bot) #63527
debugger:
  * (SEMVER-MINOR) add edit-free runtime expression probes to `node inspect` (Joyee Cheung) #62713
fs:
  * (SEMVER-MINOR) add signal option to fs.stat() (Mert Can Altin) #57775
  * (SEMVER-MINOR) expose frsize field in statfs (Jinho Jang) #62277
  * (SEMVER-MINOR) add `throwIfNoEntry` option for fs.stat and fs.promises.stat (Juan José) #61178
  * (SEMVER-MINOR) add ignore option to fs.watch (Matteo Collina) #61433
http:
  * (SEMVER-MINOR) add writeInformation to send arbitrary 1xx status codes (Tim Perry) #63155
  * (SEMVER-MINOR) add req.signal to IncomingMessage (Akshat) #62541
lib:
  * (SEMVER-MINOR) remove util.getCallSite (Rafael Gonzaga) #59980
net:
  * (SEMVER-MINOR) add `setTOS` and `getTOS` to `Socket` (Amol Yadav) #61503
node-api:
  * (SEMVER-MINOR) support SharedArrayBuffer in napi_create_dataview (Kevin Eady) #60473
  * (SEMVER-MINOR) add napi_create_object_with_properties (Miguel Marcondes Filho) #59953
perf_hooks:
  * (SEMVER-MINOR) move non-standard performance properties to perf_hooks (Chengzhong Wu) #60370
sqlite:
  * (SEMVER-MINOR) add sqlite prepare options args (Guilherme Araújo) #61311
  * (SEMVER-MINOR) create authorization api (Guilherme Araújo) #59928
src:
  * (CVE-2026-21712) handle url crash on different url formats (RafaelGSS) nodejs-private/node-private#816
src,permission:
  * (SEMVER-MINOR) add --allow-inspector ability (Rafael Gonzaga) #59711
stream:
  * (SEMVER-MINOR) add bytes() method to stream/consumers (wantaek) #60426
  * (SEMVER-MINOR) do not pass `readable.compose()` output via `Readable.from()` (René) #60907
test_runner:
  * (SEMVER-MINOR) align mock timeout api (sangwook) #62820

PR-URL: TODO
@juanarbol juanarbol mentioned this pull request Jul 16, 2026
V22.24.0 proposal #64533
Closed
@soulee-dev soulee-dev mentioned this pull request Jul 25, 2026
async_hooks: use validateBoolean for trackPromises #64731
Merged
nodejs-github-bot pushed a commit that referenced this pull request Jul 29, 2026
@soulee-dev
async_hooks: use validateBoolean for trackPromises
41525ab
The `trackPromises` check duplicated `validateBoolean()` exactly: same
error code, same expected type string, same argument order. Replace it
with the validator, matching how this file already validates `type` and
`fn` via `validateString()`/`validateFunction()`.

`ERR_INVALID_ARG_TYPE` had no other use in this file, so drop the
import. Since `validateBoolean` is wrapped in `hideStackFrames()`, the
thrown error is unchanged from a caller's perspective.

Signed-off-by: Soul Lee <[email protected]>
PR-URL: #64731
Refs: #61415
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Aviv Keller <[email protected]>
aduh95 pushed a commit that referenced this pull request Aug 3, 2026
@soulee-dev @aduh95
async_hooks: use validateBoolean for trackPromises
b3d007c
The `trackPromises` check duplicated `validateBoolean()` exactly: same
error code, same expected type string, same argument order. Replace it
with the validator, matching how this file already validates `type` and
`fn` via `validateString()`/`validateFunction()`.

`ERR_INVALID_ARG_TYPE` had no other use in this file, so drop the
import. Since `validateBoolean` is wrapped in `hideStackFrames()`, the
thrown error is unchanged from a caller's perspective.

Signed-off-by: Soul Lee <[email protected]>
PR-URL: #64731
Refs: #61415
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Aviv Keller <[email protected]>
aduh95 pushed a commit that referenced this pull request Aug 4, 2026
@soulee-dev @aduh95
async_hooks: use validateBoolean for trackPromises
6168067
The `trackPromises` check duplicated `validateBoolean()` exactly: same
error code, same expected type string, same argument order. Replace it
with the validator, matching how this file already validates `type` and
`fn` via `validateString()`/`validateFunction()`.

`ERR_INVALID_ARG_TYPE` had no other use in this file, so drop the
import. Since `validateBoolean` is wrapped in `hideStackFrames()`, the
thrown error is unchanged from a caller's perspective.

Signed-off-by: Soul Lee <[email protected]>
PR-URL: #64731
Refs: #61415
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Aviv Keller <[email protected]>
aduh95 pushed a commit that referenced this pull request Aug 5, 2026
@soulee-dev @aduh95
async_hooks: use validateBoolean for trackPromises
a2d3f89
The `trackPromises` check duplicated `validateBoolean()` exactly: same
error code, same expected type string, same argument order. Replace it
with the validator, matching how this file already validates `type` and
`fn` via `validateString()`/`validateFunction()`.

`ERR_INVALID_ARG_TYPE` had no other use in this file, so drop the
import. Since `validateBoolean` is wrapped in `hideStackFrames()`, the
thrown error is unchanged from a caller's perspective.

Signed-off-by: Soul Lee <[email protected]>
PR-URL: #64731
Refs: #61415
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Aviv Keller <[email protected]>
aduh95 pushed a commit that referenced this pull request Aug 6, 2026
@soulee-dev @aduh95
async_hooks: use validateBoolean for trackPromises
984260b
The `trackPromises` check duplicated `validateBoolean()` exactly: same
error code, same expected type string, same argument order. Replace it
with the validator, matching how this file already validates `type` and
`fn` via `validateString()`/`validateFunction()`.

`ERR_INVALID_ARG_TYPE` had no other use in this file, so drop the
import. Since `validateBoolean` is wrapped in `hideStackFrames()`, the
thrown error is unchanged from a caller's perspective.

Signed-off-by: Soul Lee <[email protected]>
PR-URL: #64731
Refs: #61415
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Aviv Keller <[email protected]>
@outreach-rule

This comment was marked as spam.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95 aduh95 aduh95 left review comments
@avivkeller avivkeller avivkeller left review comments
@Flarna Flarna Flarna approved these changes
+1 more reviewer
@abelinagomez274-code abelinagomez274-code abelinagomez274-code left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

async_hooks Issues and PRs related to the async hooks subsystem. commit-queue-squash PRs the Commit Queue should land as one squashed commit. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@joyeecheung @nodejs-github-bot @chaiphetwongchaiyatham0-ohmk @outreach-rule @aduh95 @Flarna @avivkeller @abelinagomez274-code
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.