GeezerVison is showing github.com — 2025-10-28, Version 25.1.0 (Current) by github-actions[bot] · Pull Request #60436 · nodejs/node
Conversation
github-actions
Bot
commented
Oct 27, 2025
•
edited by aduh95
Loading
Uh oh!
There was an error while loading. Please reload this page.
Notable Changes
- [
4395fe14b9] - (SEMVER-MINOR) http: add optimizeEmptyRequests server option (Rafael Gonzaga) #59778
- [
2e55c6ad04] - (SEMVER-MINOR) sqlite: allow setting defensive flag (Bart Louwers) #60217
- [
f437204491] - (SEMVER-MINOR) src: add watch config namespace (Marco Ippolito) #60178
Commits
- [
bb27766bd5] - benchmark: improve cpu.sh for safety and usability (Nam Yooseong) #60162
- [
e600711c20] - benchmark: add benchmark for leaf source text modules (Joyee Cheung) #60205
- [
1bbcdf9039] - benchmark: add vm.SourceTextModule benchmark (Joyee Cheung) #59396
- [
22fa6bd28b] - build: ibmi follow aix visibility (SRAVANI GUNDEPALLI) #60360
- [
931028400e] - build: use call command when calling python configure (Jacob Nichols) #60098
- [
17fde3f3d1] - build: build v8 with -fvisibility=hidden -fvisibility-inlines-hidden (Joyee Cheung) #56290
- [
04cc7aae5e] - build: remove V8_COMPRESS_POINTERS_IN_ISOLATE_CAGE defs (Joyee Cheung) #60296
- [
8a2053060d] - crypto: update root certificates to NSS 3.116 (Node.js GitHub Bot) #59956
- [
fe91c0f755] - deps: update simdjson to 4.0.7 (Node.js GitHub Bot) #59883
- [
aacfc0d212] - deps: update corepack to 0.34.1 (Node.js GitHub Bot) #60314
- [
8596891a71] - deps: update inspector_protocol to af7f5a8173fdbc29f0835ec94395932e328b (Node.js GitHub Bot) #60312
- [
21bcd0eb2f] - deps: V8: cherry-pick 3d0f462a17ff (Joyee Cheung) #59396
- [
673558501c] - deps: update googletest to 279f847 (Node.js GitHub Bot) #60219
- [
425a1879b1] - doc: mention more codemods in deprecations.md (Augustin Mauroy) #60243
- [
563e1317f3] - doc: remove unnecessary statement of web storage (Deokjin Kim) #60363
- [
064c8c5cfd] - doc: add missing CAA type to dns.resolveAny() & dnsPromises.resolveAny() (Jimmy Leung) #58899
- [
99e357af35] - doc: use any for worker_threads.Worker 'error' event argument err (Jonas Geiler) #60300
- [
8ccff0d934] - doc: update decorator documentation to reflect actual policy (Muhammad Salman Aziz) #60288
- [
bac70c6ef3] - doc: document wildcard supported by tools/test.py (Joyee Cheung) #60265
- [
8492bc6a88] - doc: add --heap-snapshot-on-oom to useful v8 flag (jakecastelli) #60260
- [
0f0d3c0e47] - doc: fix blob.bytes() heading level (XTY) #60252
- [
8c8525cf93] - doc: fix not working code example in vm docs (Artur Gawlik) #60224
- [
8a6de3866c] - doc, assert: correct order of changes entries (Gerhard Stöbich) #60304
- [
6bacb6555a] - doc, module: change async customization hooks to experimental (Gerhard Stöbich) #60302
- [
6f3b16df16] - esm: use index-based resolution callbacks (Joyee Cheung) #59396
- [
95644a432c] - http: lazy allocate cookies array (Robert Nagy) #59734
- [
4395fe14b9] - (SEMVER-MINOR) http: add optimizeEmptyRequests server option (Rafael Gonzaga) #59778
- [
f1aa1eaaf5] - inspector: add network payload buffer size limits (Chengzhong Wu) #60236
- [
64fc625bf9] - inspector: support handshake response for websocket inspection (Shima Ryuhei) #60225
- [
0ecbb806a8] - lib: fix typo in createBlobReaderStream (SeokHun) #60132
- [
ffec5927fd] - meta: fix typo in test-shared workflow name (Ronit Sabhaya) #60321
- [
a02897e157] - meta: move one or more collaborators to emeritus (Node.js GitHub Bot) #60325
- [
59223a7831] - meta: loop userland-migrations in deprecations (Chengzhong Wu) #60299
- [
2d48d17696] - module: refactor and clarify async loader hook customizations (Joyee Cheung) #60278
- [
be1b84fd93] - module: handle null source from async loader hooks in sync hooks (Joyee Cheung) #59929
- [
063fbd87d3] - msi: fix WiX warnings (Stefan Stojanovic) #60251
- [
2e55c6ad04] - (SEMVER-MINOR) sqlite: allow setting defensive flag (Bart Louwers) #60217
- [
dc93d6988a] - src: fix timing of snapshot serialize callback (Joyee Cheung) #60434
- [
267e1b3817] - src: add COUNT_GENERIC_USAGE utility for tests (Joyee Cheung) #60434
- [
4a5d7a4c2a] - src: conditionally disable source phase imports by default (Shelley Vohr) #60364
- [
f437204491] - (SEMVER-MINOR) src: add watch config namespace (Marco Ippolito) #60178
- [
36837fa0f9] - src: use cached primordials_string (Sohyeon Kim) #60255
- [
df8396ad37] - src: replace Environment::GetCurrent with args.GetIsolate (Sohyeon Kim) #60256
- [
5dd670b2b9] - src: initial enablement of IsolateGroups (James M Snell) #60254
- [
afdb362933] - src: use Utf8Value and TwoByteValue instead of V8 helpers (Anna Henningsen) #60244
- [
a40e533e72] - src: add a default branch for module phase (Chengzhong Wu) #60261
- [
42729f07ee] - src: stop using deprecated v8::Context::GetIsolate (Michaël Zasso) #60223
- [
7a6542c205] - test: skip failing test on macOS 15.7+ (Antoine du Hamel) #60419
- [
29a5855a4f] - test: ensure assertions are reachable in test/addons (Antoine du Hamel) #60142
- [
12773d19c4] - test: increase debugger waitFor timeout on macOS (Chengzhong Wu) #60367
- [
0b38de3e9e] - test: put helper in test-runner-output into common (Joyee Cheung) #60330
- [
6de2407c44] - test: fix small compile warning in test_network_requests_buffer.cc (xiaocainiao633) #60281
- [
4b23ac8613] - test: fix status when compiled without inspector (Antoine du Hamel) #60289
- [
a07f32e326] - test: split test-runner-watch-mode-kill-signal (Joyee Cheung) #60298
- [
30451d32d7] - test: fix incorrect calculation in test-perf-hooks.js (Joyee Cheung) #60271
- [
e3c3b48f1c] - test: ignore EPIPE errors in https proxy invalid URL test (Joyee Cheung) #60269
- [
405a9c4c5f] - test: parallelize test-without-async-context-frame correctly (Joyee Cheung) #60273
- [
ffeebebc71] - test: make test-worker-prof more tolerant (Joyee Cheung) #60272
- [
26b01bf170] - test: skip sea tests on x64 macOS (Joyee Cheung) #60250
- [
8caae1a05b] - test: move sea tests into test/sea (Joyee Cheung) #60250
- [
3d183e3e9f] - test,crypto: fix conditional SHA3-* skip on BoringSSL (Filip Skokan) #60379
- [
e83dbcba94] - test,crypto: sha3 algorithms aren't supported with BoringSSL (Shelley Vohr) #60374
- [
3d89331496] - test_runner: use module.registerHooks in module mocks (Joyee Cheung) #60326
- [
377e8ce85a] - tls: avoid external memory leak on invalid protocol versions (Shelley Vohr) #60390
- [
ae4858c1f6] - tools: add an option to generate lighter archives (Antoine du Hamel) #60294
- [
cb615b1a2e] - tools: skip test-shared workflow for draft PRs (Michaël Zasso) #60365
- [
03b034731e] - tools: disable inspector on macOS-shared to reduce flakiness (Antoine du Hamel) #60320
- [
f402b4e1d1] - tools: show diff alongside the error in Nix linter (Antoine du Hamel) #60301
- [
5d5c8483fb] - tools: run CI with shared libs on GHA (Antoine du Hamel) #60121
- [
e8fdd8d2e8] - tools: update gyp-next to 0.20.5 (Node.js GitHub Bot) #60313
- [
6e8b029a21] - tools: limit inspector protocol PR title length (Chengzhong Wu) #60324
- [
a5073086c6] - tools: fix inspector_protocol updater (Chengzhong Wu) #60277
- [
47fa765bff] - tools: optimize wildcard execution in tools/test.py (Joyee Cheung) #60266
- [
11ebb0447d] - tools: add C++ lint rule to avoid using String::Utf8Value (Anna Henningsen) #60244
- [
14f3189670] - tools: add inspector_protocol updater (Chengzhong Wu) #60245
- [
ef4c596fc6] - typings: add missing properties and method in Worker (Woohyun Sung) #60257
- [
09ae6fc065] - typings: add missing properties in HTTPParser (Woohyun Sung) #60257
- [
9ecaf41f8e] - typings: delete undefined property in ConfigBinding (Woohyun Sung) #60257
- [
4a86016e86] - util: use more defensive code when inspecting error objects (Antoine du Hamel) #60139
- [
9e6d6cec59] - util: mark special properties when inspecting them (Ruben Bridgewater) #60131
- [
79b2387fd9] - vm: make vm.Module.evaluate() conditionally synchronous (Joyee Cheung) #60205
- [
e5559f3be3] - win: upgrade Visual Studio workload from 2019 to 2022 (Jiawen Geng) #60318
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
bricss and Saraeutsza reacted with thumbs up emoji
bricss reacted with hooray emoji
bricss reacted with heart emoji
bricss reacted with rocket emoji
All reactions
-
👍
2 reactions
-
🎉
1 reaction
-
❤️
1 reaction
-
🚀
1 reaction
This relaxes the validation in sync hooks so that it accepts
the quirky nullish source returned by the default step of the
async loader when the module being loaded is CommonJS.
When there are no customization hooks registered, a saner
synchronous default load step is used to use a property
instead of a reset nullish source to signify that the module
should go through the CJS monkey patching routes and reduce
excessive reloading from disk.
PR-URL: #59929
Fixes: #59384
Fixes: #57327
Refs: #59666
Refs: https://github.com/dygabo/load_module_test
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Original commit message:
[api] Add index-based module resolution in InstantiateModule()
Add new InstantiateModule() overload that allows embedders to identify
modules requests by index in the module requests array rather than
using specifier and import attributes. When embedders want to fetch
all the modules using information from module->GetModuleRequests()
before calling InstantiateModule() instead of having to do the fetching
inside the InstantiateModule() callback, they could just maintain a simple array of modules indexed by module request positions and
look up the fetched the module by index in the new callback.
Previously this has to be done by mapping from specifier and import
attributes to module objects cached on the embedder side, leading to an overhead to hash the specifier and import attributes for each module request.
Refs: #59396
Bug: 435317398
Change-Id: Ie017d2f3ccc605e0f58aa423504b5fa5fdbcc633
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6804466
Commit-Queue: Joyee Cheung <[email protected]>
Reviewed-by: Camillo Bruni <[email protected]>
Cr-Commit-Position: refs/heads/main@{#102613}
Refs: v8/v8@3d0f462
PR-URL: #59396
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/6804466
Reviewed-By: Chengzhong Wu <[email protected]>
This lays the initial groundwork for enabling the
use of IsolateGroups.
Every isolate in V8 is created within a group. When pointer
compression is enabled, all isolates within a single group
are limited to a 4 GB shared pointer cage. By default, all
isolates in the process share the same group, which means
that when running with pointer compression, the entire
process would be limited to a single 4 GB shared pointer
cage. But, we can create as many IsolateGroups as we want,
limited only by the amount of virtual memory available on
the machine.
PR-URL: #60254
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
It previously re-einvented the pattern matching that's already
supported by test.py, and was running the tests one by one,
which can lead to time out on slower machines.
This move it to sequential and use wildcard
support in test.py to correctly parallelize the tests.
PR-URL: #60273
Fixes: #60268
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
There can be a race from eagerly shutting down the servers and
severing two pipes at the same time but for the purpose of this test,
we only care about whether the requests are initiated from the client
as expected, not how the upstream/proxy servers behave. Ignore EPIPE
errors from them.
PR-URL: #60269
Refs: #59741
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Previously for each matching test, it would execute multiple
`node -p` commands to decide the configurations of the executable.
That means if there are 100 tests matched, it will run the Node.js
executable 4*100 times to retrieve the same configurations repeatedly.
This changes the loop order so that it only execute these commands
once and reuse the results for all matching tests.
PR-URL: #60266
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
- Make sure that the vm.Module.evaluate() method is conditionally
synchronous based on the specification. Previously, the returned
promise is unconditionally pending (even for synthetic modules and
source text modules without top-level await) instead of immediately
fulfilled, making it harder to debug as it deviates from the
specified behavior.
- Clarify the synchronicity of this method in the documentation
- Add more tests for the synchronicity of this method.
PR-URL: #60205
Refs: #59656
Refs: #37648
Reviewed-By: Chengzhong Wu <[email protected]>
The previous cpu.sh script was minimal. This change makes it a more
robust and safe utility for managing CPU governors during benchmarks.
The script now includes:
- Checks to ensure it only runs on Linux with root privileges.
- A `reset` command to restore the CPU governor to a dynamically
detected system default.
- A `get` command to check the current governor for all cores.
- An improved usage guide and clearer feedback messages.
PR-URL: #60162
Reviewed-By: Antoine du Hamel <[email protected]>
nodejs-github-bot
added a commit
that referenced
this pull request
Oct 27, 2025
Notable changes:
http:
* (SEMVER-MINOR) add optimizeEmptyRequests server option (Rafael Gonzaga) #59778
sqlite:
* (SEMVER-MINOR) allow setting defensive flag (Bart Louwers) #60217
src:
* (SEMVER-MINOR) add watch config namespace (Marco Ippolito) #60178
PR-URL: #60436
|
Review requested:
- @nodejs/actions
- @nodejs/build
- @nodejs/gyp
- @nodejs/performance
- @nodejs/security-wg
- @nodejs/tsc
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Previously the addAfterUserSerailizeCallback() wasn't
ready to be used for building the built-in snapshot.
This patch initializes the callbacks at the time
lib/internal/v8/start_snapshot.js is loaded, so that
these callbacks get run correctly when building the
built-in snapshot.
Currently when building the built-in snapshot,
addAfterUserSerializeCallback() is only used by createUnsafeBuffer(),
other usages can only come from user-land snapshots,
which is covered by tests, but what gets run by the
built-in snapshot building process is less visible, and the
path used by createUnsafeBuffer() isn't reliably visible in user
land either. This adds an internal usage counter in debug builds
to verify this path when building the built-in snapshot.
PR-URL: #60434
Fixes: #60423
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Notable changes:
http:
* (SEMVER-MINOR) add optimizeEmptyRequests server option (Rafael Gonzaga) #59778
sqlite:
* (SEMVER-MINOR) allow setting defensive flag (Bart Louwers) #60217
src:
* (SEMVER-MINOR) add watch config namespace (Marco Ippolito) #60178
PR-URL: #60436
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
codecov
Bot
commented
Oct 28, 2025
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|
❌ Patch coverage is 94.40628% with 57 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.58%. Comparing base (0b3a10d) to head (1da054d).
⚠️ Report is 85 commits behind head on v25.x.
Additional details and impacted files
@@ Coverage Diff @@
## v25.x #60436 +/- ##
========================================
Coverage 88.57% 88.58%
========================================
Files 704 704
Lines 208162 207731 -431
Branches 40012 40027 +15
========================================
- Hits 184387 184014 -373
+ Misses 15820 15760 -60
- Partials 7955 7957 +2
... and 99 files with indirect coverage changes
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
#60351 is a fix for a behaviour regression in v25.0.0 – probably not enough time to get it through, but would be ideal if it were doable.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
aduh95
added a commit
that referenced
this pull request
Oct 28, 2025
Notable changes:
http:
* (SEMVER-MINOR) add optimizeEmptyRequests server option (Rafael Gonzaga) #59778
sqlite:
* (SEMVER-MINOR) allow setting defensive flag (Bart Louwers) #60217
src:
* (SEMVER-MINOR) add watch config namespace (Marco Ippolito) #60178
PR-URL: #60436
Uh oh!
There was an error while loading. Please reload this page.
ChALkeR
commented
Oct 28, 2025
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|
I am highly surprised that disabling zero-fill on allocUnsafe is not included in notable changes
#60434 (comment)
It's not even included in the changelog at all
Was that intentional? Could that be amended?
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
aduh95
aduh95 approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Labels
release
Issues and PRs related to Node.js releases.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|