GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-64660: Don't hardcode Argument Clinic return converter result variable name by erlend-aasland · Pull Request #104200 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented May 5, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Issue:

  • Argument Clinic included return converters hard code use of _return_value #64660

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
erlend-aasland added 2 commits May 5, 2023 14:38
@erlend-aasland
pythongh-64660: Don't hard-code '_return_value' in AC return converters
acfdab7
@erlend-aasland
pythongh-64660: Don't hardcode Argument Clinic return converter resul…
de9dc35
…t variable name
@erlend-aasland erlend-aasland added the skip news label May 5, 2023
@erlend-aasland
erlend-aasland requested a review from brettcannon May 5, 2023 13:03
@bedevere-bot bedevere-bot added the awaiting core review label May 5, 2023
@erlend-aasland erlend-aasland mentioned this pull request May 5, 2023
Argument Clinic included return converters hard code use of _return_value #64660
Closed
@erlend-aasland erlend-aasland changed the title clinic dont hardcode return value gh-64660: Don't hardcode Argument Clinic return converter result variable name May 5, 2023
erlend-aasland added 2 commits May 5, 2023 22:57
@erlend-aasland
Pull in main
0fd153e
@erlend-aasland
Pull in main
884f03e
@erlend-aasland

erlend-aasland commented May 6, 2023

Copy link
Copy Markdown
Contributor Author

I'll merge this tomorrow, as a part 1 of fixing the linked issue.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland added 3 commits May 7, 2023 23:26
@erlend-aasland
Pull in main
cf3f060
@erlend-aasland
Naming
548732e
@erlend-aasland
Remove XXX comment
fc2939f
@erlend-aasland
erlend-aasland enabled auto-merge (squash) May 7, 2023 21:31
@erlend-aasland
erlend-aasland merged commit ac02062 into python:main May 7, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label May 7, 2023
jbower-fb pushed a commit to jbower-fb/cpython that referenced this pull request May 8, 2023
@erlend-aasland @jbower-fb
pythongh-64660: Don't hardcode Argument Clinic return converter resul…
67b4b55
…t variable name (python#104200)
carljm added a commit to carljm/cpython that referenced this pull request May 9, 2023
@carljm
Merge branch 'main' into inlinecomp2
76077cd
* main: (47 commits)
  pythongh-97696 Remove unnecessary check for eager_start kwarg (python#104188)
  pythonGH-104308: socket.getnameinfo should release the GIL (python#104307)
  pythongh-104310: Add importlib.util.allowing_all_extensions() (pythongh-104311)
  pythongh-99113: A Per-Interpreter GIL! (pythongh-104210)
  pythonGH-104284: Fix documentation gettext build (python#104296)
  pythongh-89550: Buffer GzipFile.write to reduce execution time by ~15% (python#101251)
  pythongh-104223: Fix issues with inheriting from buffer classes (python#104227)
  pythongh-99108: fix typo in Modules/Setup (python#104293)
  pythonGH-104145: Use fully-qualified cross reference types for the bisect module (python#104172)
  pythongh-103193: Improve `getattr_static` test coverage (python#104286)
  Trim trailing whitespace and test on CI (python#104275)
  pythongh-102500: Remove mention of bytes shorthand (python#104281)
  pythongh-97696: Improve and fix documentation for asyncio eager tasks (python#104256)
  pythongh-99108: Replace SHA3 implementation HACL* version (python#103597)
  pythongh-104273: Remove redundant len() calls in argparse function (python#104274)
  pythongh-64660: Don't hardcode Argument Clinic return converter result variable name (python#104200)
  pythongh-104265 Disallow instantiation of `_csv.Reader` and `_csv.Writer` (python#104266)
  pythonGH-102613: Improve performance of `pathlib.Path.rglob()` (pythonGH-104244)
  pythongh-103650: Fix perf maps address format (python#103651)
  pythonGH-89812: Churn `pathlib.Path` methods (pythonGH-104243)
  ...
@erlend-aasland
erlend-aasland deleted the clinic-dont-hardcode-return-value branch July 4, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon Awaiting requested review from brettcannon

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@erlend-aasland @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.