Description

arhadthedev

opened on May 26, 2022

Issue body actions

Reference: PEP 594 – Removing dead batteries from the standard library.

This issue tracks removal of the following modules:

• Demote from the public API into the test helpers
  • smtpd (gh-93243: Make smtpd private before porting its users #93246)
  • asynchat and asyncore (gh-72719: Remove deprecated asyncore and asynchat modules #96580)
• Port tests onto relevant analogs, step by step
  • smtpd
    • test.test_smtplib
  • asynchat and asyncore
    • test.test_ftplib
    • test.test_logging
    • test.test_poplib
      • try to give priority for gh-74699: test_pop3lib asyncore with asyncio #1864
    • test.test_smtplib
    • test.test_ssl
    • test.libregrtest.save_env
• Remove the remnescants
  • Lib/test/smtpd.py, PCbuild/*
  • Lib/test/support/async(hat|ore).py, PCbuild/*
  • Dead links from What's New and release notes

Related issues:

• Remove asyncore, asynchat and smtpd modules #72719 (created 3 years before PEP 594 was written)
• Update tests from asyncore to asyncio #91171 (I lost authorship there during the porting from the bugs.python.org)

Activity

1. arhadthedev

   added

   type-featureA feature request or enhancementA feature request or enhancement

   on May 26, 2022
2. JelleZijlstra commented on May 26, 2022

   

   JelleZijlstra

   on May 26, 2022

   Member

   More actions

   This requires finishing #1864 (which I need to get back to).

   Reacted by Oleg Iarygin
3. arhadthedev commented on Jul 12, 2022

   

   arhadthedev

   on Jul 12, 2022

   MemberAuthor

   More actions

   Asyncore-based test servers from test_ftp and test_logging cannot be ported to asyncio, the tested clients are blocking. However, instead of writing a server thread class from scratch, it would be nice to reuse test.support.threading_helper.Server from gh-92475.
4. miss-islington

   added a commit that references this issue on Aug 6, 2022

   gh-93243: Make smtpd private before porting its users (GH-93246)

   56d16e8
5. iritkatriel

   added a commit that references this issue on Aug 11, 2022

   pythongh-93243: Make smtpd private before porting its users (pythonGH…

   10dc75f
6. arhadthedev

   added this to Contribution Queueon Feb 5, 2023
7. github-project-automation

   moved this to Todo in Contribution Queueon Feb 5, 2023
8. iritkatriel

   added

   testsTests in the Lib/test dirTests in the Lib/test dir

   on Nov 29, 2023
9. iritkatriel

   changed the title [-]PEP 594: Process "to be removed in 3.12" part of the plan[/-] [+]tests still rely on the removed stdlib modules asyncore/asynchat[/+] on Nov 29, 2023
10. iritkatriel commented on Nov 29, 2023

    

    iritkatriel

    on Nov 29, 2023

    Member

    More actions

    Changing the title to reflect what still needs to be done.
11. vstinner commented on Feb 27, 2025

    

    vstinner

    on Feb 27, 2025

    Member

    More actions

    PEP 594 has been fully implemented: asyncore, asynchat and smtpd have been removed from the stdlib.

    Some tests still use asyncore, asynchat and smtpd: there is now a copy in Lib/test/support/ only for tests. While it would be nice to rewrite these tests using asyncio or threads, it seems like no one is interested to work on that.

    I suggest to close the issue as "not planned". It's ok to leave tests are they are, since tests are now reliable and stable.
12. iritkatriel commented on Feb 27, 2025

    

    iritkatriel

    on Feb 27, 2025

    Member

    More actions

    I agree.

    Reacted by Victor Stinner
13. iritkatriel

    closed this as completedon Feb 27, 2025

Issue actions