GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Document that zipfile's pwd parameter is a bytes object by JustAnotherArchivist · Pull Request #100209 · python/cpython

Conversation

JustAnotherArchivist commented Dec 13, 2022

Copy link

Copy Markdown

Contributor

Trivial docs change for which no issue exists.

This has been a requirement for a very long time (the exception on using non-bytes was added before 2.7; I didn't search beyond that) but was never documented anywhere as far as I can see.

Needs backports to earlier branches.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-bot added the awaiting review label

Dec 13, 2022

netlify Bot commented Dec 13, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

✅ Deploy Preview for python-cpython-preview ready!

Name	Link
🔨 Latest commit	`81b6e1a`
🔍 Latest deploy log	https://app.netlify.com/sites/python-cpython-preview/deploys/6398236f8640a20009af66fd
😎 Deploy Preview	https://deploy-preview-100209--python-cpython-preview.netlify.app/library/zipfile
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot added docs

Documentation in the Doc dir

skip news labels

Dec 13, 2022

hauntsaninja approved these changes

Dec 13, 2022

View reviewed changes

hauntsaninja left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good to me. I confirmed that pwd does seem to need to be bytes and not e.g. bytearray or a buffer.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Doc/library/zipfile.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot added awaiting core review and removed awaiting review labels

Dec 13, 2022


          Document that zipfile's pwd parameter is a bytes object

81b6e1a

JustAnotherArchivist force-pushed the docs-zipfile-pwd-type branch from 139d9ca to 81b6e1a Compare

December 13, 2022 07:02

kumaraditya303 approved these changes

Dec 16, 2022

View reviewed changes

kumaraditya303 left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is checked here:

cpython/Lib/zipfile/__init__.py

Lines 1491 to 1498 in e00266f

	def setpassword(self, pwd):
	"""Set default password for encrypted files."""
	if pwd and not isinstance(pwd, bytes):
	raise TypeError("pwd: expected bytes, got %s" % type(pwd).__name__)
	if pwd:
	self.pwd = pwd
	else:
	self.pwd = None

LGTM thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

JustAnotherArchivist reacted with heart emoji

All reactions

❤️ 1 reaction

bedevere-bot added awaiting merge and removed awaiting core review labels

Dec 16, 2022

kumaraditya303 added the skip issue label

Dec 16, 2022

kumaraditya303 merged commit 5ee7eb9 into python:main

Dec 16, 2022

bedevere-bot removed the awaiting merge label

Dec 16, 2022

carljm added a commit to carljm/cpython that referenced this pull request

Dec 16, 2022


          Merge branch 'main' into fastmock

2260a54

* main:
  Improve stats presentation for calls. (pythonGH-100274)
  Better stats for `LOAD_ATTR` and `STORE_ATTR` (pythonGH-100295)
  pythongh-81057: Move the Cached Parser Dummy Name to _PyRuntimeState (python#100277)
  Document that zipfile's pwd parameter is a `bytes` object (python#100209)
  pythongh-99767: mark `PyTypeObject.tp_watched` as internal use only in table (python#100271)
  Fix typo in introduction.rst (python#100266)
  pythongh-78997: AttributeError if loading fails in LibraryLoader.__getattr__
  pythonGH-100234: Set a default value for random.expovariate() (pythonGH-100235)
  Remove uninformative itertools recipe (pythonGH-100253)
  pythonGH-99767: update PyTypeObject docs for type watchers (pythonGH-99928)
  Move stats for the method cache into the `Py_STAT` machinery (pythonGH-100255)
  pythonGH-100222: fix typo _py_set_opocde -> _py_set_opcode (pythonGH-100259)
  pythonGH-100000: Cleanup and polish various watchers code (pythonGH-99998)
  pythongh-90111: Minor Cleanup for Runtime-Global Objects (pythongh-100254)

JustAnotherArchivist commented Dec 16, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor Author

@kumaraditya303 Thanks for merging! How about backporting it to the other branches (at least the supported ones)? I think this needs some 'needs backport to X' labels.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

kumaraditya303 added needs backport to 3.10 needs backport to 3.11 only security fixes labels

Dec 17, 2022

miss-islington commented Dec 17, 2022

Copy link

Copy Markdown

Contributor

Thanks @JustAnotherArchivist for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington commented Dec 17, 2022

Copy link

Copy Markdown

Contributor

Thanks @JustAnotherArchivist for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot commented Dec 17, 2022

Copy link

Copy Markdown

GH-100309 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.11 only security fixes label

Dec 17, 2022

bedevere-bot commented Dec 17, 2022

Copy link

Copy Markdown

GH-100310 is a backport of this pull request to the 3.10 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.10 label

Dec 17, 2022

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Dec 17, 2022


          Document that zipfile's pwd parameter is a bytes object (pythonGH-1…

bd330a4

…00209)

(cherry picked from commit 5ee7eb9)

Co-authored-by: JustAnotherArchivist <[email protected]>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Dec 17, 2022


          Document that zipfile's pwd parameter is a bytes object (pythonGH-1…

6c5e97a

…00209)

(cherry picked from commit 5ee7eb9)

Co-authored-by: JustAnotherArchivist <[email protected]>

miss-islington added a commit that referenced this pull request

Dec 17, 2022


          Document that zipfile's pwd parameter is a bytes object (GH-100209)

697a07a

(cherry picked from commit 5ee7eb9)

Co-authored-by: JustAnotherArchivist <[email protected]>

miss-islington added a commit that referenced this pull request

Dec 17, 2022


          Document that zipfile's pwd parameter is a bytes object (GH-100209)

e3d8578

(cherry picked from commit 5ee7eb9)

Co-authored-by: JustAnotherArchivist <[email protected]>

shihai1991 added a commit to shihai1991/cpython that referenced this pull request

Dec 18, 2022


          Merge remote-tracking branch 'origin/main' into bpo_34697

* origin/main: (1306 commits)
  Correct CVE-2020-10735 documentation (python#100306)
  pythongh-100272: Fix JSON serialization of OrderedDict (pythonGH-100273)
  pythongh-93649: Split tracemalloc tests from _testcapimodule.c (python#99551)
  Docs: Use `PY_VERSION_HEX` for version comparison (python#100179)
  pythongh-97909: Fix markup for `PyMethodDef` members (python#100089)
  pythongh-99240: Reset pointer to NULL when the pointed memory is freed in argument parsing (python#99890)
  pythongh-99240: Reset pointer to NULL when the pointed memory is freed in argument parsing (python#99890)
  pythonGH-98831: Add DECREF_INPUTS(), expanding to DECREF() each stack input (python#100205)
  pythongh-78707: deprecate passing >1 argument to `PurePath.[is_]relative_to()` (pythonGH-94469)
  pythongh-99540: Constant hash for _PyNone_Type to aid reproducibility (pythonGH-99541)
  pythongh-100039: enhance __signature__ to work with str and callables (pythonGH-100168)
  pythongh-99830: asyncio: Document returns of remove_{reader,writer} (python#100302)
  "Compound statement" docs: Fix with-statement step indexing (python#100286)
  pythonGH-90043: Handle NaNs in COMPARE_OP_FLOAT_JUMP (pythonGH-100278)
  Improve stats presentation for calls. (pythonGH-100274)
  Better stats for `LOAD_ATTR` and `STORE_ATTR` (pythonGH-100295)
  pythongh-81057: Move the Cached Parser Dummy Name to _PyRuntimeState (python#100277)
  Document that zipfile's pwd parameter is a `bytes` object (python#100209)
  pythongh-99767: mark `PyTypeObject.tp_watched` as internal use only in table (python#100271)
  Fix typo in introduction.rst (python#100266)
  ...

Reviewers

hauntsaninja

hauntsaninja approved these changes

kumaraditya303

kumaraditya303 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs

Documentation in the Doc dir

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

JustAnotherArchivist commented Dec 13, 2022

Uh oh!

netlify Bot commented Dec 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for python-cpython-preview ready!

Uh oh!

hauntsaninja left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kumaraditya303 left a comment

Choose a reason for hiding this comment

Uh oh!

JustAnotherArchivist commented Dec 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

miss-islington commented Dec 17, 2022

Uh oh!

miss-islington commented Dec 17, 2022

Uh oh!

bedevere-bot commented Dec 17, 2022

Uh oh!

bedevere-bot commented Dec 17, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

netlify Bot commented Dec 13, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

JustAnotherArchivist commented Dec 16, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.