GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Docs: Fix with-statement step indexing by ferdnyc · Pull Request #100286 · python/cpython

Conversation

@ferdnyc

@ferdnyc ferdnyc commented Dec 16, 2022

Copy link
Copy Markdown
Contributor

Back in commit 226e6e7 (3 years ago!) an item was added to the list, renumbering all the rest of the items, but the forward-reference wasn't updated to match. Apparently I'm the first to notice?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ferdnyc
Fix with-statement step indexing
a2fd1b8
Back in commit 226e6e7
an item was added to the list, renumbering all the rest of the
items, but the forward-reference wasn't updated to match.
@bedevere-bot bedevere-bot added the awaiting review label Dec 16, 2022
@netlify

netlify Bot commented Dec 16, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

✅ Deploy Preview for python-cpython-preview ready!

Name Link
🔨 Latest commit a2fd1b8
🔍 Latest deploy log https://app.netlify.com/sites/python-cpython-preview/deploys/639c02b18c0e1d0008d707b2
😎 Deploy Preview https://deploy-preview-100286--python-cpython-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news labels Dec 16, 2022
@ferdnyc
Merge branch 'main' into patch-1
d4c71bd
@carljm carljm added the skip issue label Dec 16, 2022
carljm
carljm approved these changes Dec 16, 2022
View reviewed changes

@carljm carljm left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently at least you were the first to notice and take the time to submit a patch! Thank you!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ferdnyc reacted with laugh emoji
All reactions
  • 😄 1 reaction
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Dec 16, 2022
@ferdnyc
Merge branch 'main' into patch-1
2585455
@ferdnyc

ferdnyc commented Dec 16, 2022

Copy link
Copy Markdown
Contributor Author

@carljm I even took the time to write a StackOverflow question asking whether anyone has any clever ideas for a Better Way™ to manage that sort of list-item referencing automatically.

(I'm not expecting to have any success with that, but I figured it couldn't hurt to try.)

carljm and AlexWaygood reacted with heart emoji
All reactions
  • ❤️ 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@AlexWaygood AlexWaygood added needs backport to 3.10 needs backport to 3.11 only security fixes labels Dec 16, 2022
AlexWaygood
AlexWaygood approved these changes Dec 16, 2022
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Dec 16, 2022
@AlexWaygood
AlexWaygood merged commit f23236a into python:main Dec 16, 2022
@miss-islington

miss-islington commented Dec 16, 2022

Copy link
Copy Markdown
Contributor

Thanks @ferdnyc for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the awaiting merge label Dec 16, 2022
@bedevere-bot

bedevere-bot commented Dec 16, 2022

Copy link
Copy Markdown

GH-100300 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Dec 16, 2022
@ferdnyc
ferdnyc deleted the patch-1 branch December 16, 2022 18:44
@bedevere-bot

bedevere-bot commented Dec 16, 2022

Copy link
Copy Markdown

GH-100301 is a backport of this pull request to the 3.10 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Dec 16, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 16, 2022
@ferdnyc @miss-islington
"Compound statement" docs: Fix with-statement step indexing (pythonGH…
dd08c4c
…-100286)

Back in commit 226e6e7
an item was added to the list, renumbering all the rest of the
items, but the forward-reference wasn't updated to match.
(cherry picked from commit f23236a)

Co-authored-by: Frank Dana <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 16, 2022
@ferdnyc @miss-islington
"Compound statement" docs: Fix with-statement step indexing (pythonGH…
2ff7d79
…-100286)

Back in commit 226e6e7
an item was added to the list, renumbering all the rest of the
items, but the forward-reference wasn't updated to match.
(cherry picked from commit f23236a)

Co-authored-by: Frank Dana <[email protected]>
miss-islington added a commit that referenced this pull request Dec 16, 2022
@miss-islington @ferdnyc
[3.11] "Compound statement" docs: Fix with-statement step indexing (G…
138c2e6
…H-100286) (GH-100300)

Back in commit 226e6e7
an item was added to the list, renumbering all the rest of the
items, but the forward-reference wasn't updated to match.
(cherry picked from commit f23236a)

Co-authored-by: Frank Dana <[email protected]>
miss-islington added a commit that referenced this pull request Dec 16, 2022
@miss-islington @ferdnyc
"Compound statement" docs: Fix with-statement step indexing (GH-100286)
0f61020
Back in commit 226e6e7
an item was added to the list, renumbering all the rest of the
items, but the forward-reference wasn't updated to match.
(cherry picked from commit f23236a)

Co-authored-by: Frank Dana <[email protected]>
carljm added a commit to carljm/cpython that referenced this pull request Dec 16, 2022
@carljm
Merge branch 'main' into fastmock
1b6241a
* main:
  pythongh-99540: Constant hash for _PyNone_Type to aid reproducibility (pythonGH-99541)
  pythongh-100039: enhance __signature__ to work with str and callables (pythonGH-100168)
  pythongh-99830: asyncio: Document returns of remove_{reader,writer} (python#100302)
  "Compound statement" docs: Fix with-statement step indexing (python#100286)
  pythonGH-90043: Handle NaNs in COMPARE_OP_FLOAT_JUMP (pythonGH-100278)
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Dec 18, 2022
@shihai1991
Merge remote-tracking branch 'origin/main' into bpo_34697
2878571
* origin/main: (1306 commits)
  Correct CVE-2020-10735 documentation (python#100306)
  pythongh-100272: Fix JSON serialization of OrderedDict (pythonGH-100273)
  pythongh-93649: Split tracemalloc tests from _testcapimodule.c (python#99551)
  Docs: Use `PY_VERSION_HEX` for version comparison (python#100179)
  pythongh-97909: Fix markup for `PyMethodDef` members (python#100089)
  pythongh-99240: Reset pointer to NULL when the pointed memory is freed in argument parsing (python#99890)
  pythongh-99240: Reset pointer to NULL when the pointed memory is freed in argument parsing (python#99890)
  pythonGH-98831: Add DECREF_INPUTS(), expanding to DECREF() each stack input (python#100205)
  pythongh-78707: deprecate passing >1 argument to `PurePath.[is_]relative_to()` (pythonGH-94469)
  pythongh-99540: Constant hash for _PyNone_Type to aid reproducibility (pythonGH-99541)
  pythongh-100039: enhance __signature__ to work with str and callables (pythonGH-100168)
  pythongh-99830: asyncio: Document returns of remove_{reader,writer} (python#100302)
  "Compound statement" docs: Fix with-statement step indexing (python#100286)
  pythonGH-90043: Handle NaNs in COMPARE_OP_FLOAT_JUMP (pythonGH-100278)
  Improve stats presentation for calls. (pythonGH-100274)
  Better stats for `LOAD_ATTR` and `STORE_ATTR` (pythonGH-100295)
  pythongh-81057: Move the Cached Parser Dummy Name to _PyRuntimeState (python#100277)
  Document that zipfile's pwd parameter is a `bytes` object (python#100209)
  pythongh-99767: mark `PyTypeObject.tp_watched` as internal use only in table (python#100271)
  Fix typo in introduction.rst (python#100266)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carljm carljm carljm approved these changes
@AlexWaygood AlexWaygood AlexWaygood approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@ferdnyc @miss-islington @bedevere-bot @carljm @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.