GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-99830: asyncio: Document returns of remove_{reader,writer} by bdarnell · Pull Request #100302 · python/cpython

Conversation

@bdarnell

@bdarnell bdarnell commented Dec 16, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fixes #99830

  • Issue: asyncio: Document return values of AbstractEventLoop.remove_{reader,writer} #99830

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bdarnell
pythongh-99830: asyncio: Document returns of remove_{reader,writer}
8842f42
Fixes python#99830
@bdarnell
bdarnell requested review from 1st1, asvetlov, gvanrossum and kumaraditya303 as code owners December 16, 2022 18:56
@bedevere-bot bedevere-bot mentioned this pull request Dec 16, 2022
asyncio: Document return values of AbstractEventLoop.remove_{reader,writer} #99830
Closed
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Dec 16, 2022
@ghost

ghost commented Dec 16, 2022 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

gvanrossum
gvanrossum approved these changes Dec 16, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Dec 16, 2022
@gvanrossum
gvanrossum merged commit 5234e1c into python:main Dec 16, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Dec 16, 2022
@gvanrossum gvanrossum added needs backport to 3.10 needs backport to 3.11 only security fixes labels Dec 16, 2022
@miss-islington

miss-islington commented Dec 16, 2022

Copy link
Copy Markdown
Contributor

Thanks @bdarnell for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington

miss-islington commented Dec 16, 2022

Copy link
Copy Markdown
Contributor

Thanks @bdarnell for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot

bedevere-bot commented Dec 16, 2022

Copy link
Copy Markdown

GH-100303 is a backport of this pull request to the 3.10 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Dec 16, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 16, 2022
@bdarnell @miss-islington
pythongh-99830: asyncio: Document returns of remove_{reader,writer} (p…
9a25bb9
…ythonGH-100302)

(cherry picked from commit 5234e1c)

Co-authored-by: Ben Darnell <[email protected]>
@bedevere-bot

bedevere-bot commented Dec 16, 2022

Copy link
Copy Markdown

GH-100304 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Dec 16, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 16, 2022
@bdarnell @miss-islington
pythongh-99830: asyncio: Document returns of remove_{reader,writer} (p…
fb54e42
…ythonGH-100302)

(cherry picked from commit 5234e1c)

Co-authored-by: Ben Darnell <[email protected]>
miss-islington added a commit that referenced this pull request Dec 16, 2022
@miss-islington @bdarnell
gh-99830: asyncio: Document returns of remove_{reader,writer} (GH-100302
4c810f9
)

(cherry picked from commit 5234e1c)

Co-authored-by: Ben Darnell <[email protected]>
miss-islington added a commit that referenced this pull request Dec 16, 2022
@miss-islington @bdarnell
gh-99830: asyncio: Document returns of remove_{reader,writer} (GH-100302
958be79
)

(cherry picked from commit 5234e1c)

Co-authored-by: Ben Darnell <[email protected]>
carljm added a commit to carljm/cpython that referenced this pull request Dec 16, 2022
@carljm
Merge branch 'main' into fastmock
1b6241a
* main:
  pythongh-99540: Constant hash for _PyNone_Type to aid reproducibility (pythonGH-99541)
  pythongh-100039: enhance __signature__ to work with str and callables (pythonGH-100168)
  pythongh-99830: asyncio: Document returns of remove_{reader,writer} (python#100302)
  "Compound statement" docs: Fix with-statement step indexing (python#100286)
  pythonGH-90043: Handle NaNs in COMPARE_OP_FLOAT_JUMP (pythonGH-100278)
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Dec 18, 2022
@shihai1991
Merge remote-tracking branch 'origin/main' into bpo_34697
2878571
* origin/main: (1306 commits)
  Correct CVE-2020-10735 documentation (python#100306)
  pythongh-100272: Fix JSON serialization of OrderedDict (pythonGH-100273)
  pythongh-93649: Split tracemalloc tests from _testcapimodule.c (python#99551)
  Docs: Use `PY_VERSION_HEX` for version comparison (python#100179)
  pythongh-97909: Fix markup for `PyMethodDef` members (python#100089)
  pythongh-99240: Reset pointer to NULL when the pointed memory is freed in argument parsing (python#99890)
  pythongh-99240: Reset pointer to NULL when the pointed memory is freed in argument parsing (python#99890)
  pythonGH-98831: Add DECREF_INPUTS(), expanding to DECREF() each stack input (python#100205)
  pythongh-78707: deprecate passing >1 argument to `PurePath.[is_]relative_to()` (pythonGH-94469)
  pythongh-99540: Constant hash for _PyNone_Type to aid reproducibility (pythonGH-99541)
  pythongh-100039: enhance __signature__ to work with str and callables (pythonGH-100168)
  pythongh-99830: asyncio: Document returns of remove_{reader,writer} (python#100302)
  "Compound statement" docs: Fix with-statement step indexing (python#100286)
  pythonGH-90043: Handle NaNs in COMPARE_OP_FLOAT_JUMP (pythonGH-100278)
  Improve stats presentation for calls. (pythonGH-100274)
  Better stats for `LOAD_ATTR` and `STORE_ATTR` (pythonGH-100295)
  pythongh-81057: Move the Cached Parser Dummy Name to _PyRuntimeState (python#100277)
  Document that zipfile's pwd parameter is a `bytes` object (python#100209)
  pythongh-99767: mark `PyTypeObject.tp_watched` as internal use only in table (python#100271)
  Fix typo in introduction.rst (python#100266)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

asyncio: Document return values of AbstractEventLoop.remove_{reader,writer}

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@bdarnell @miss-islington @bedevere-bot @gvanrossum
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.