GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-101810: Remove duplicated st_ino calculation by juria90 · Pull Request #101811 · python/cpython

Conversation

@juria90

@juria90 juria90 commented Feb 10, 2023

Copy link
Copy Markdown
Contributor

The deleted status->st_ino = (((uint64_t)info.nFileIndexHigh) << 32) + info.nFileIndexLow; is already calculated and assigned in the function _Py_attribute_data_to_stat(). So removing the duplicated code.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@juria90
Remove duplicated st_ino calculation
844cf87 
The deleted `status->st_ino = (((uint64_t)info.nFileIndexHigh) << 32) + info.nFileIndexLow;` is already calculated and assigned in the function `_Py_attribute_data_to_stat()`.
So removing the duplicated code.
@ghost

ghost commented Feb 10, 2023 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting review label Feb 10, 2023
@bedevere-bot bedevere-bot mentioned this pull request Feb 10, 2023
Duplicated st_ino calculation #101810
Closed
@bedevere-bot

bedevere-bot commented Feb 10, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@juria90

juria90 commented Feb 10, 2023

Copy link
Copy Markdown
Contributor Author

Seems like we don't need a NEWS entry for removing duplicated code, IMO.
zooba reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@eryksun
eryksun requested a review from a team February 11, 2023 02:17
@zooba zooba added the skip news label Feb 13, 2023
@zooba
zooba merged commit 95cbb3d into python:main Feb 13, 2023
@bedevere-bot bedevere-bot removed the awaiting review label Feb 13, 2023
carljm added a commit to carljm/cpython that referenced this pull request Feb 13, 2023
@carljm
Merge branch 'main' into inlinecomp2
ae0bd02 
* main:
  pythongh-101810: Remove duplicated st_ino calculation (pythonGH-101811)
  pythongh-92547: Purge sqlite3_enable_shared_cache() detection from configure (python#101873)
  pythonGH-100987: Refactor `_PyInterpreterFrame` a bit, to assist generator improvement. (pythonGH-100988)
  pythonGH-87849: Simplify stack effect of SEND and specialize it for generators and coroutines. (pythonGH-101788)
  Correct trivial grammar in reset_mock docs (python#101861)
  pythongh-101845: pyspecific: Fix i18n for availability directive (pythonGH-101846)
  pythongh-89792: Limit test_tools freeze test build parallelism based on the number of cores (python#101841)
  pythongh-85984: Utilize new "winsize" functions from termios in pty tests. (python#101831)
  pythongh-89792: Prevent test_tools from copying 1000M of "source" in freeze test (python#101837)
  Fix typo in test_fstring.py (python#101823)
  pythonGH-101797: allocate `PyExpat_CAPI` capsule on heap (python#101798)
  pythongh-101390: Fix docs for `imporlib.util.LazyLoader.factory` to properly call it a class method (pythonGH-101391)
@eryksun

eryksun commented Feb 14, 2023

Copy link
Copy Markdown
Contributor

@zooba, do you plan to backport this fix to 3.10 and 3.11? 3.10.11 is scheduled to be released on 3 April. It's the last bugfix release for 3.10.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zooba

zooba commented Feb 14, 2023

Copy link
Copy Markdown
Member

It's not really a bug fix though, and I didn't go through older versions to make sure it's duplicated there (and the backport PR won't detect it if it's not).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zooba

zooba commented Feb 14, 2023

Copy link
Copy Markdown
Member

Okay, just saw that you checked out the history on the issue.

But I've been told off once this week for backporting perf-only changes, so I think I'll leave this one where it is.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@juria90 @bedevere-bot @eryksun @zooba
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.