GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Correct trivial grammar in reset_mock docs by s-t-e-v-e-n-k · Pull Request #101861 · python/cpython

Conversation

@s-t-e-v-e-n-k

@s-t-e-v-e-n-k s-t-e-v-e-n-k commented Feb 13, 2023

Copy link
Copy Markdown
Contributor

reset_mock under unittest.mock had a singular 'argument' for a list of two, correct it to the plural, and add a - for keyword-only for good measure.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
arhadthedev reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@s-t-e-v-e-n-k
Correct trivial grammar in reset_mock docs
221e658 
reset_mock under unittest.mock had a singular 'argument' for a list of
two, correct it to the plural, and add a - for keyword-only for good
measure.
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Feb 13, 2023
@ghost

ghost commented Feb 13, 2023 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@arhadthedev arhadthedev added the skip issue label Feb 13, 2023
hugovk
hugovk approved these changes Feb 13, 2023
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Feb 13, 2023
@hugovk hugovk added needs backport to 3.10 needs backport to 3.11 only security fixes and removed awaiting merge labels Feb 13, 2023
@hugovk
hugovk merged commit a1f08f5 into python:main Feb 13, 2023
@miss-islington

miss-islington commented Feb 13, 2023

Copy link
Copy Markdown
Contributor

Thanks @s-t-e-v-e-n-k for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Feb 13, 2023

Copy link
Copy Markdown

GH-101869 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Feb 13, 2023
@bedevere-bot

bedevere-bot commented Feb 13, 2023

Copy link
Copy Markdown

GH-101870 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Feb 13, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 13, 2023
@s-t-e-v-e-n-k @miss-islington
Correct trivial grammar in reset_mock docs (pythonGH-101861)
cb2ab98 
(cherry picked from commit a1f08f5)

Co-authored-by: Steve Kowalik <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 13, 2023
@s-t-e-v-e-n-k @miss-islington
Correct trivial grammar in reset_mock docs (pythonGH-101861)
f635a16 
(cherry picked from commit a1f08f5)

Co-authored-by: Steve Kowalik <[email protected]>
miss-islington added a commit that referenced this pull request Feb 13, 2023
@miss-islington @s-t-e-v-e-n-k
Correct trivial grammar in reset_mock docs (GH-101861)
59852bb 
(cherry picked from commit a1f08f5)

Co-authored-by: Steve Kowalik <[email protected]>
miss-islington added a commit that referenced this pull request Feb 13, 2023
@miss-islington @s-t-e-v-e-n-k
Correct trivial grammar in reset_mock docs (GH-101861)
01b21c3 
(cherry picked from commit a1f08f5)

Co-authored-by: Steve Kowalik <[email protected]>
carljm added a commit to carljm/cpython that referenced this pull request Feb 13, 2023
@carljm
Merge branch 'main' into inlinecomp2
ae0bd02 
* main:
  pythongh-101810: Remove duplicated st_ino calculation (pythonGH-101811)
  pythongh-92547: Purge sqlite3_enable_shared_cache() detection from configure (python#101873)
  pythonGH-100987: Refactor `_PyInterpreterFrame` a bit, to assist generator improvement. (pythonGH-100988)
  pythonGH-87849: Simplify stack effect of SEND and specialize it for generators and coroutines. (pythonGH-101788)
  Correct trivial grammar in reset_mock docs (python#101861)
  pythongh-101845: pyspecific: Fix i18n for availability directive (pythonGH-101846)
  pythongh-89792: Limit test_tools freeze test build parallelism based on the number of cores (python#101841)
  pythongh-85984: Utilize new "winsize" functions from termios in pty tests. (python#101831)
  pythongh-89792: Prevent test_tools from copying 1000M of "source" in freeze test (python#101837)
  Fix typo in test_fstring.py (python#101823)
  pythonGH-101797: allocate `PyExpat_CAPI` capsule on heap (python#101798)
  pythongh-101390: Fix docs for `imporlib.util.LazyLoader.factory` to properly call it a class method (pythonGH-101391)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@s-t-e-v-e-n-k @miss-islington @bedevere-bot @hugovk @arhadthedev
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.