GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-102069: Fix `__weakref__` descriptor generation for custom dataclasses by sobolevn · Pull Request #102075 · python/cpython

Conversation

sobolevn commented Feb 20, 2023 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Since we recreate a class, we have a descriptor from a previous type. This is why check_descr fails.

Issue: Unexpected behavior with dataclasses and weakref #102069

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-102069: Fix __weakref__ descriptor generation for custom d…

a388296

…ataclasses

sobolevn requested a review from ericvsmith as a code owner

February 20, 2023 13:50

bedevere-bot added the awaiting review label

Feb 20, 2023

bedevere-bot mentioned this pull request

Feb 20, 2023

Unexpected behavior with dataclasses and weakref #102069

Closed

sobolevn added the needs backport to 3.11 only security fixes label

Feb 20, 2023

sobolevn commented Mar 11, 2023

Copy link

Copy Markdown

Member Author

@carljm maybe you will be interested in this PR as well? :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

carljm requested changes

Mar 13, 2023

View reviewed changes

carljm left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo in the added comment, otherwise this LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Lib/dataclasses.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot added awaiting changes and removed awaiting review labels

Mar 13, 2023

bedevere-bot commented Mar 13, 2023

Copy link

Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Update Lib/dataclasses.py

1d512e6

carljm approved these changes

Mar 13, 2023

View reviewed changes

carljm left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, just remembered that I can make trivial fixes to the PR myself :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

sobolevn and Eclips4 reacted with thumbs up emoji

AlexWaygood reacted with laugh emoji

All reactions

👍 2 reactions
😄 1 reaction

bedevere-bot added awaiting merge and removed awaiting changes labels

Mar 13, 2023

carljm merged commit d97757f into python:main

Mar 13, 2023

miss-islington commented Mar 13, 2023

Copy link

Copy Markdown

Contributor

Thanks @sobolevn for the PR, and @carljm for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the awaiting merge label

Mar 13, 2023

carljm commented Mar 13, 2023

Copy link

Copy Markdown

Member

Thanks for the fix!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Mar 13, 2023


          pythongh-102069: Fix __weakref__ descriptor generation for custom d…

ad32998

…ataclasses (pythonGH-102075)

(cherry picked from commit d97757f)

Co-authored-by: Nikita Sobolev <[email protected]>

bedevere-bot commented Mar 13, 2023

Copy link

Copy Markdown

GH-102662 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.11 only security fixes label

Mar 13, 2023

carljm pushed a commit that referenced this pull request

Mar 13, 2023


          [3.11] gh-102069: Fix __weakref__ descriptor generation for custom …

b0e221c

…dataclasses (GH-102075) (#102662)

gh-102069: Fix `__weakref__` descriptor generation for custom dataclasses (GH-102075)
(cherry picked from commit d97757f)

Co-authored-by: Nikita Sobolev <[email protected]>

carljm added a commit to carljm/cpython that referenced this pull request

Mar 14, 2023


          Merge branch 'main' into inlinecomp2

6c5f269

* main: (50 commits)
  pythongh-102674: Remove _specialization_stats from Lib/opcode.py (python#102685)
  pythongh-102660: Handle m_copy Specially for the sys and builtins Modules (pythongh-102661)
  pythongh-102354: change python3 to python in docs examples (python#102696)
  pythongh-81057: Add a CI Check for New Unsupported C Global Variables (pythongh-102506)
  pythonGH-94851: check unicode consistency of static strings in debug mode (python#102684)
  pythongh-100315: clarification to `__slots__` docs. (python#102621)
  pythonGH-100227: cleanup initialization of global interned dict (python#102682)
  doc: Remove a duplicate 'versionchanged' in library/asyncio-task (pythongh-102677)
  pythongh-102013: Add PyUnstable_GC_VisitObjects (python#102014)
  pythonGH-102670: Use sumprod() to simplify, speed up, and improve accuracy of statistics functions (pythonGH-102649)
  pythongh-102627: Replace address pointing toward malicious web page (python#102630)
  pythongh-98831: Use DECREF_INPUTS() more (python#102409)
  pythongh-101659: Avoid Allocation for Shared Exceptions in the _xxsubinterpreters Module (pythongh-102659)
  pythongh-101524: Fix the ChannelID tp_name (pythongh-102655)
  pythongh-102069: Fix `__weakref__` descriptor generation for custom dataclasses (python#102075)
  pythongh-98169 dataclasses.astuple support DefaultDict (python#98170)
  pythongh-102650: Remove duplicate include directives from multiple source files (python#102651)
  pythonGH-100987: Don't cache references to the names and consts array in `_PyEval_EvalFrameDefault`. (python#102640)
  pythongh-87092: refactor assemble() to a number of separate functions, which do not need the compiler struct (python#102562)
  pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (python#102631)
  ...

Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this pull request

Mar 27, 2023


          pythongh-102069: Fix __weakref__ descriptor generation for custom d…

98b34ba

…ataclasses (python#102075)

warsaw pushed a commit to warsaw/cpython that referenced this pull request

Apr 11, 2023


          pythongh-102069: Fix __weakref__ descriptor generation for custom d…

29f35a9

…ataclasses (python#102075)

Reviewers

carljm

carljm approved these changes

ericvsmith

Awaiting requested review from ericvsmith

ericvsmith is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

sobolevn commented Feb 20, 2023 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sobolevn commented Mar 11, 2023

Uh oh!

carljm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bedevere-bot commented Mar 13, 2023

Uh oh!

carljm left a comment

Choose a reason for hiding this comment

Uh oh!

miss-islington commented Mar 13, 2023

Uh oh!

carljm commented Mar 13, 2023

Uh oh!

bedevere-bot commented Mar 13, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sobolevn commented Feb 20, 2023 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.