GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-98831: Use DECREF_INPUTS() more by gvanrossum · Pull Request #102409 · python/cpython

Conversation

@gvanrossum

@gvanrossum gvanrossum commented Mar 4, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This helped with the tagged refcount project (anything done here doesn't need to be done manually), and might help with future similar projects.

  • Issue: Generate the interpreter #98831

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-bot bedevere-bot added the awaiting core review label Mar 4, 2023
@gvanrossum

gvanrossum commented Mar 4, 2023

Copy link
Copy Markdown
Member Author

Hm, there are refleaks.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@gvanrossum
gvanrossum force-pushed the more-decref-inputs branch from 394f2e0 to dc507f4 Compare March 13, 2023 20:20
@gvanrossum gvanrossum changed the title Use DECREF_INPUTS() more gh-98831: Use DECREF_INPUTS() more Mar 13, 2023
@bedevere-bot bedevere-bot mentioned this pull request Mar 13, 2023
Generate the interpreter #98831
Closed
@gvanrossum gvanrossum added the skip news label Mar 13, 2023
@gvanrossum
gvanrossum requested a review from iritkatriel March 13, 2023 20:22
gvanrossum added 3 commits March 13, 2023 13:23
@gvanrossum
Use DECREF_INPUTS() more
778ca94
Also convert END_FOR (the only macro inst) to a regular inst.
@gvanrossum
Whoops, cannot use DECREF_INPUTS() in some cases
68077f1
@gvanrossum
Don't mess with END_FOR
12e85cf
@gvanrossum
gvanrossum force-pushed the more-decref-inputs branch from dc507f4 to 12e85cf Compare March 13, 2023 20:23
@gvanrossum
gvanrossum marked this pull request as ready for review March 13, 2023 20:23
@gvanrossum gvanrossum added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Mar 13, 2023
@bedevere-bot

bedevere-bot commented Mar 13, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @gvanrossum for commit 12e85cf 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Mar 13, 2023
@gvanrossum

gvanrossum commented Mar 13, 2023

Copy link
Copy Markdown
Member Author

@iritkatriel Even if there is still a refleak it would be nice to have a second pair of eyes on this.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

iritkatriel
iritkatriel approved these changes Mar 13, 2023
View reviewed changes

@iritkatriel iritkatriel left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff in the generated file is quite small, and seems fine.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Mar 13, 2023
@gvanrossum
gvanrossum merged commit 392f2ad into python:main Mar 13, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Mar 13, 2023
@gvanrossum
gvanrossum deleted the more-decref-inputs branch March 13, 2023 22:08
carljm added a commit to carljm/cpython that referenced this pull request Mar 14, 2023
@carljm
Merge branch 'main' into inlinecomp2
6c5f269
* main: (50 commits)
  pythongh-102674: Remove _specialization_stats from Lib/opcode.py (python#102685)
  pythongh-102660: Handle m_copy Specially for the sys and builtins Modules (pythongh-102661)
  pythongh-102354: change python3 to python in docs examples (python#102696)
  pythongh-81057: Add a CI Check for New Unsupported C Global Variables (pythongh-102506)
  pythonGH-94851: check unicode consistency of static strings in debug mode (python#102684)
  pythongh-100315: clarification to `__slots__` docs. (python#102621)
  pythonGH-100227: cleanup initialization of global interned dict (python#102682)
  doc: Remove a duplicate 'versionchanged' in library/asyncio-task (pythongh-102677)
  pythongh-102013: Add PyUnstable_GC_VisitObjects (python#102014)
  pythonGH-102670: Use sumprod() to simplify, speed up, and improve accuracy of statistics functions (pythonGH-102649)
  pythongh-102627: Replace address pointing toward malicious web page (python#102630)
  pythongh-98831: Use DECREF_INPUTS() more (python#102409)
  pythongh-101659: Avoid Allocation for Shared Exceptions in the _xxsubinterpreters Module (pythongh-102659)
  pythongh-101524: Fix the ChannelID tp_name (pythongh-102655)
  pythongh-102069: Fix `__weakref__` descriptor generation for custom dataclasses (python#102075)
  pythongh-98169 dataclasses.astuple support DefaultDict (python#98170)
  pythongh-102650: Remove duplicate include directives from multiple source files (python#102651)
  pythonGH-100987: Don't cache references to the names and consts array in `_PyEval_EvalFrameDefault`. (python#102640)
  pythongh-87092: refactor assemble() to a number of separate functions, which do not need the compiler struct (python#102562)
  pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (python#102631)
  ...
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this pull request Mar 27, 2023
@gvanrossum @Fidget-Spinner
pythongh-98831: Use DECREF_INPUTS() more (python#102409)
b99132d
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@gvanrossum @warsaw
pythongh-98831: Use DECREF_INPUTS() more (python#102409)
9cf44ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@gvanrossum @bedevere-bot @iritkatriel
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.