GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-100315: clarification to `__slots__` docs. by kwsp · Pull Request #102621 · python/cpython

Conversation

@kwsp

@kwsp kwsp commented Mar 12, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

refer to tp_itemsize in discussion on "variable-length" built-in types

#100315

  • Issue: Clarification in the __slots__ documentation #100315

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@kwsp
pythongh-100315: clarification to __slots__ docs.
6f6ba27
refer to tp_itemsize in discussion on "variable-length" built-in types
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news labels Mar 12, 2023
@bedevere-bot bedevere-bot mentioned this pull request Mar 12, 2023
Clarification in the __slots__ documentation #100315
Closed
@bedevere-bot bedevere-bot added the awaiting review label Mar 12, 2023
@kwsp
Merge branch 'main' into slots_docs
89292d8
@AlexWaygood
AlexWaygood self-requested a review March 12, 2023 13:24
AlexWaygood
AlexWaygood reviewed Mar 13, 2023
View reviewed changes
Comment thread Doc/reference/datamodel.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@kwsp
reword
3aca8b5
AlexWaygood
AlexWaygood approved these changes Mar 14, 2023
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Mar 14, 2023
@AlexWaygood AlexWaygood added needs backport to 3.10 needs backport to 3.11 only security fixes labels Mar 14, 2023
@AlexWaygood
AlexWaygood merged commit 88c262c into python:main Mar 14, 2023
@miss-islington

miss-islington commented Mar 14, 2023

Copy link
Copy Markdown
Contributor

Thanks @kwsp for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the awaiting merge label Mar 14, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 14, 2023
@kwsp @miss-islington
pythongh-100315: clarification to __slots__ docs. (pythonGH-102621)
855a80f
refer to tp_itemsize in discussion on "variable-length" built-in types
(cherry picked from commit 88c262c)

Co-authored-by: T <[email protected]>
@bedevere-bot

bedevere-bot commented Mar 14, 2023

Copy link
Copy Markdown

GH-102687 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Mar 14, 2023
@bedevere-bot

bedevere-bot commented Mar 14, 2023

Copy link
Copy Markdown

GH-102688 is a backport of this pull request to the 3.10 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Mar 14, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 14, 2023
@kwsp @miss-islington
pythongh-100315: clarification to __slots__ docs. (pythonGH-102621)
c2d6fa1
refer to tp_itemsize in discussion on "variable-length" built-in types
(cherry picked from commit 88c262c)

Co-authored-by: T <[email protected]>
miss-islington added a commit that referenced this pull request Mar 14, 2023
@miss-islington @kwsp
gh-100315: clarification to __slots__ docs. (GH-102621)
2c015a6
refer to tp_itemsize in discussion on "variable-length" built-in types
(cherry picked from commit 88c262c)

Co-authored-by: T <[email protected]>
miss-islington added a commit that referenced this pull request Mar 14, 2023
@miss-islington @kwsp
gh-100315: clarification to __slots__ docs. (GH-102621)
1f7eb8f
refer to tp_itemsize in discussion on "variable-length" built-in types
(cherry picked from commit 88c262c)

Co-authored-by: T <[email protected]>
carljm added a commit to carljm/cpython that referenced this pull request Mar 14, 2023
@carljm
Merge branch 'main' into inlinecomp2
6c5f269
* main: (50 commits)
  pythongh-102674: Remove _specialization_stats from Lib/opcode.py (python#102685)
  pythongh-102660: Handle m_copy Specially for the sys and builtins Modules (pythongh-102661)
  pythongh-102354: change python3 to python in docs examples (python#102696)
  pythongh-81057: Add a CI Check for New Unsupported C Global Variables (pythongh-102506)
  pythonGH-94851: check unicode consistency of static strings in debug mode (python#102684)
  pythongh-100315: clarification to `__slots__` docs. (python#102621)
  pythonGH-100227: cleanup initialization of global interned dict (python#102682)
  doc: Remove a duplicate 'versionchanged' in library/asyncio-task (pythongh-102677)
  pythongh-102013: Add PyUnstable_GC_VisitObjects (python#102014)
  pythonGH-102670: Use sumprod() to simplify, speed up, and improve accuracy of statistics functions (pythonGH-102649)
  pythongh-102627: Replace address pointing toward malicious web page (python#102630)
  pythongh-98831: Use DECREF_INPUTS() more (python#102409)
  pythongh-101659: Avoid Allocation for Shared Exceptions in the _xxsubinterpreters Module (pythongh-102659)
  pythongh-101524: Fix the ChannelID tp_name (pythongh-102655)
  pythongh-102069: Fix `__weakref__` descriptor generation for custom dataclasses (python#102075)
  pythongh-98169 dataclasses.astuple support DefaultDict (python#98170)
  pythongh-102650: Remove duplicate include directives from multiple source files (python#102651)
  pythonGH-100987: Don't cache references to the names and consts array in `_PyEval_EvalFrameDefault`. (python#102640)
  pythongh-87092: refactor assemble() to a number of separate functions, which do not need the compiler struct (python#102562)
  pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (python#102631)
  ...
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this pull request Mar 27, 2023
@kwsp @Fidget-Spinner
pythongh-100315: clarification to __slots__ docs. (python#102621)
9c61718
refer to tp_itemsize in discussion on "variable-length" built-in types
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@kwsp @warsaw
pythongh-100315: clarification to __slots__ docs. (python#102621)
37736fc
refer to tp_itemsize in discussion on "variable-length" built-in types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@kwsp @miss-islington @bedevere-bot @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.