GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives by iritkatriel · Pull Request #102619 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Mar 12, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Replace Fetch/Restore etc by the new exception APIs #102192

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@iritkatriel
pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient al…
abeb903
…ternatives
@iritkatriel
iritkatriel requested a review from markshannon as a code owner March 12, 2023 11:03
@bedevere-bot bedevere-bot mentioned this pull request Mar 12, 2023
Replace Fetch/Restore etc by the new exception APIs #102192
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Mar 12, 2023
@iritkatriel iritkatriel added skip news interpreter-core (Objects, Python, Grammar, and Parser dirs) and removed awaiting core review labels Mar 12, 2023
barneygale and others added 11 commits March 12, 2023 19:04
@barneygale @kmaork @iritkatriel
pythonGH-80486: Fix handling of NTFS alternate data streams in pathlib (
5f49d2d
pythonGH-102454)

Co-authored-by: Maor Kleinberger <[email protected]>
@XuehaiPan @iritkatriel
pythongh-102578: Optimise setting and deleting mutable attributes on …
b85d003
…non-dataclass subclasses of frozen dataclasses (pythongh-102573)
@sobolevn @iritkatriel
pythongh-102103: add module argument to dataclasses.make_dataclass (
cdf9e3a
python#102104)
@ischurov @iritkatriel
pythongh-88071: Update docstrings of dataclass' astuple and asdict (p…
f8d4afb
…ython#101806)

Update dataclasses.astuple and dataclasses.asdict docstrings to reflect that they deep copy objects in the field values.
@brandtbucher @iritkatriel
pythonGH-90997: Shrink the LOAD_GLOBAL caches (python#102569)
4c8bbe4
@AlexWaygood @carljm @iritkatriel
pythongh-102433: Add tests for how classes with properties interact w…
fde1a99
…ith `isinstance()` checks on `typing.runtime_checkable` protocols (python#102449)

Co-authored-by: Carl Meyer <[email protected]>
@wangxiang-hz @iritkatriel
pythongh-102213: Optimize the performance of __getattr__ (pythonGH-…
fc48167
…102248)

When __getattr__ is defined, python with try to find an attribute using _PyObject_GenericGetAttrWithDict
find nothing is reasonable so we don't need an exception, it will hurt performance.
@tkren @iritkatriel
pythongh-79940: add introspection API for asynchronous generators to …
f9250e4
…`inspect` module (python#11590)
@tkren @iritkatriel
pythongh-79940: skip TestGetAsyncGenState on wasm as it requires wo…
45cc601
…rking sockets (pythonGH-102605)

Skip `TestGetAsyncGenState` and restoring of the default event loop policy in `test_inspect` if platform lacks working socket support.

Fixes python#11590

Automerge-Triggered-By: GH:kumaraditya303
@sobolevn @iritkatriel
pythongh-101821: Test coverage for ast.main function (python#101822)
f955ac9
@iritkatriel
put back the missing None check
69c5afb
@iritkatriel
iritkatriel requested review from AlexWaygood, Fidget-Spinner, JelleZijlstra, barneygale, ericvsmith and gvanrossum as code owners March 12, 2023 19:05
@AlexWaygood

AlexWaygood commented Mar 12, 2023

Copy link
Copy Markdown
Member

Looks like something went wrong with git

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@AlexWaygood
AlexWaygood removed their request for review March 12, 2023 19:10
@iritkatriel

iritkatriel commented Mar 12, 2023

Copy link
Copy Markdown
Member Author

not sure what I did here. Closing.

AlexWaygood reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@iritkatriel iritkatriel closed this Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@barneygale barneygale Awaiting requested review from barneygale
@gvanrossum gvanrossum Awaiting requested review from gvanrossum
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner
@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner
@ericvsmith ericvsmith Awaiting requested review from ericvsmith ericvsmith is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

10 participants

@iritkatriel @AlexWaygood @bedevere-bot @barneygale @XuehaiPan @sobolevn @ischurov @brandtbucher @wangxiang-hz @tkren
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.