GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Add comments to `{typing,_collections_abc}._type_repr` about each other by sobolevn · Pull Request #102752 · python/cpython

Conversation

sobolevn commented Mar 16, 2023

Copy link

Copy Markdown

Member

Refs #102637 (comment)

I don't think we need issue or news for this one.
Btw, I've also ported a change from #102637 (comment) to _collection_abc, because it makes sense here as well.

CC @AlexWaygood

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Add comments to {typing,_collections_abc}._type_repr abouth each other

1a4fd9f

sobolevn requested review from AlexWaygood, Fidget-Spinner, JelleZijlstra, gvanrossum and rhettinger as code owners

March 16, 2023 11:24

bedevere-bot added the awaiting review label

Mar 16, 2023

sobolevn added skip issue skip news labels

Mar 16, 2023

sobolevn mentioned this pull request

Mar 16, 2023

gh-102721: Improve coverage of _collections_abc._CallableGenericAlias #102722

Merged

AlexWaygood reviewed

Mar 16, 2023

View reviewed changes

AlexWaygood left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small nits:

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Lib/_collections_abc.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Lib/typing.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

AlexWaygood commented Mar 16, 2023

Copy link

Copy Markdown

Member

I don't think we need issue or news for this one.

Agreed!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AlexWaygood self-assigned this

Mar 16, 2023


          Address review

1b8faa2

AlexWaygood changed the title ~~Add comments to {typing,_collections_abc}._type_repr abouth each other~~ Add comments to {typing,_collections_abc}._type_repr about each other

Mar 16, 2023

AlexWaygood reviewed

Mar 16, 2023

View reviewed changes

AlexWaygood left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the docstring in _collections_abc already mentions the typing version, I'd just add a note to the end of the docstring instead of adding a comment

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Lib/_collections_abc.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Lib/_collections_abc.py Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Address review

1383fe8

AlexWaygood approved these changes

Mar 16, 2023

View reviewed changes

AlexWaygood left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-bot added awaiting merge and removed awaiting review labels

Mar 16, 2023

AlexWaygood merged commit a297d59 into python:main

Mar 16, 2023

bedevere-bot removed the awaiting merge label

Mar 16, 2023

carljm added a commit to carljm/cpython that referenced this pull request

Mar 17, 2023


          Merge branch 'main' into inlinecomp2

1a8f4a0

* main: (34 commits)
  pythongh-102701: Fix overflow in dictobject.c (pythonGH-102750)
  pythonGH-78530: add support for generators in `asyncio.wait` (python#102761)
  Increase stack reserve size for Windows debug builds to avoid test crashes (pythonGH-102764)
  pythongh-102755: Add PyErr_DisplayException(exc) (python#102756)
  Fix outdated note about 'int' rounding or truncating (python#102736)
  pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (python#102760)
  pythongh-99726: Improves correctness of stat results for Windows, and uses faster API when available (pythonGH-102149)
  pythongh-102192: remove redundant exception fields from ssl module socket (python#102466)
  pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (python#102743)
  pythongh-102737: Un-ignore ceval.c in the CI globals check (pythongh-102745)
  pythonGH-102748: remove legacy support for generator based coroutines from `asyncio.iscoroutine` (python#102749)
  pythongh-102721: Improve coverage of `_collections_abc._CallableGenericAlias` (python#102722)
  pythonGH-102653: Make recipe docstring show the correct distribution (python#102742)
  Add comments to `{typing,_collections_abc}._type_repr` about each other (python#102752)
  pythongh-102594: PyErr_SetObject adds note to exception raised on normalization error (python#102675)
  pythongh-94440: Fix issue of ProcessPoolExecutor shutdown hanging (python#94468)
  pythonGH-100112:  avoid using iterable coroutines in asyncio internally (python#100128)
  pythongh-102690: Use Edge as fallback in webbrowser instead of IE (python#102691)
  pythongh-102660: Fix Refleaks in import.c (python#102744)
  pythongh-102738: remove from cases generator the code related to register instructions (python#102739)
  ...

Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this pull request

Mar 27, 2023


          Add comments to {typing,_collections_abc}._type_repr about each oth…

e3461ea

…er (python#102752)

Remove `if` condition in `_collections_abc._type_repr` that's no longer needed, bringing it in sync with `typing._type_repr`.

warsaw pushed a commit to warsaw/cpython that referenced this pull request

Apr 11, 2023


          Add comments to {typing,_collections_abc}._type_repr about each oth…

939efdc

…er (python#102752)

Remove `if` condition in `_collections_abc._type_repr` that's no longer needed, bringing it in sync with `typing._type_repr`.

Reviewers

AlexWaygood

AlexWaygood approved these changes

gvanrossum

Awaiting requested review from gvanrossum

Fidget-Spinner

Awaiting requested review from Fidget-Spinner

JelleZijlstra

Awaiting requested review from JelleZijlstra

JelleZijlstra is a code owner

rhettinger

Awaiting requested review from rhettinger

rhettinger is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

AlexWaygood

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.