GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-102690: Use Edge as fallback in webbrowser instead of IE by DBJim · Pull Request #102691 · python/cpython

Conversation

DBJim commented Mar 14, 2023 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Issue: Update webbrowser to use Edge as fallback instead of IE #102690

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Update webbrowser.py to use Edge as fallback instead of IE

c33c859

bedevere-bot commented Mar 14, 2023

Copy link

Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot mentioned this pull request

Mar 14, 2023

Update webbrowser to use Edge as fallback instead of IE #102690

Closed

bedevere-bot added the awaiting review label

Mar 14, 2023

ghost commented Mar 14, 2023 •

edited by ghost

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

All commit authors signed the Contributor License Agreement.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Merge branch 'main' into main

f82848d

bedevere-bot commented Mar 14, 2023

Copy link

Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          📜🤖 Added by blurb_it.

3b4d8dd

merwok requested changes

Mar 14, 2023

View reviewed changes

Comment thread

Lib/webbrowser.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Misc/NEWS.d/next/Windows/2023-03-14-10-52-43.gh-issue-102690.sbXtqk.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot added awaiting changes and removed awaiting review labels

Mar 14, 2023

This comment was marked as resolved.

DBJim and others added 2 commits

March 15, 2023 01:38


          Update Lib/webbrowser.py

ecc53fb

Co-authored-by: Éric <[email protected]>


          Update Misc/NEWS.d/next/Windows/2023-03-14-10-52-43.gh-issue-102690.s…

8a00dec

…bXtqk.rst

Co-authored-by: Éric <[email protected]>

merwok requested a review from zooba

March 14, 2023 14:49

merwok added awaiting core review type-feature

A feature request or enhancement

3.12 only security fixes and removed awaiting changes labels

Mar 14, 2023

merwok changed the title ~~gh-102690: Update webbrowser.py to use Edge as fallback instead of IE~~ gh-102690: Update webbrowser to use Edge as fallback instead of IE

Mar 14, 2023

AlexWaygood added the OS-windows label

Mar 14, 2023

zooba reviewed

Mar 14, 2023

View reviewed changes

Comment thread

Lib/webbrowser.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

DBJim and others added 2 commits

March 15, 2023 17:11


          Merge branch 'python:main' into main

b91f873


          Update variable names, add descriptive comments

55ec113

DBJim requested a review from zooba

March 15, 2023 06:52

zooba approved these changes

Mar 15, 2023

View reviewed changes

zooba left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will let @merwok follow up (and/or hit the merge button)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-bot added awaiting merge and removed awaiting core review labels

Mar 15, 2023

merwok reviewed

Mar 15, 2023

View reviewed changes

Comment thread

Lib/webbrowser.py Resolved

Uh oh!

There was an error while loading. Please reload this page.


          style

3fd510f

DBJim requested a review from merwok

March 15, 2023 23:52

zooba reviewed

Mar 16, 2023

View reviewed changes

Comment thread

Lib/webbrowser.py Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Update Lib/webbrowser.py

3c42f6d

Co-authored-by: Steve Dower <[email protected]>

merwok changed the title ~~gh-102690: Update webbrowser to use Edge as fallback instead of IE~~ gh-102690: Use Edge as fallback in webbrowser instead of IE

Mar 16, 2023

merwok merged commit 1c9f339 into python:main

Mar 16, 2023

bedevere-bot removed the awaiting merge label

Mar 16, 2023

carljm added a commit to carljm/cpython that referenced this pull request

Mar 17, 2023


          Merge branch 'main' into inlinecomp2

1a8f4a0

* main: (34 commits)
  pythongh-102701: Fix overflow in dictobject.c (pythonGH-102750)
  pythonGH-78530: add support for generators in `asyncio.wait` (python#102761)
  Increase stack reserve size for Windows debug builds to avoid test crashes (pythonGH-102764)
  pythongh-102755: Add PyErr_DisplayException(exc) (python#102756)
  Fix outdated note about 'int' rounding or truncating (python#102736)
  pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (python#102760)
  pythongh-99726: Improves correctness of stat results for Windows, and uses faster API when available (pythonGH-102149)
  pythongh-102192: remove redundant exception fields from ssl module socket (python#102466)
  pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (python#102743)
  pythongh-102737: Un-ignore ceval.c in the CI globals check (pythongh-102745)
  pythonGH-102748: remove legacy support for generator based coroutines from `asyncio.iscoroutine` (python#102749)
  pythongh-102721: Improve coverage of `_collections_abc._CallableGenericAlias` (python#102722)
  pythonGH-102653: Make recipe docstring show the correct distribution (python#102742)
  Add comments to `{typing,_collections_abc}._type_repr` about each other (python#102752)
  pythongh-102594: PyErr_SetObject adds note to exception raised on normalization error (python#102675)
  pythongh-94440: Fix issue of ProcessPoolExecutor shutdown hanging (python#94468)
  pythonGH-100112:  avoid using iterable coroutines in asyncio internally (python#100128)
  pythongh-102690: Use Edge as fallback in webbrowser instead of IE (python#102691)
  pythongh-102660: Fix Refleaks in import.c (python#102744)
  pythongh-102738: remove from cases generator the code related to register instructions (python#102739)
  ...

Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this pull request

Mar 27, 2023


          pythongh-102690: Use Edge as fallback in webbrowser instead of IE (py…

b05f294

…thon#102691)

warsaw pushed a commit to warsaw/cpython that referenced this pull request

Apr 11, 2023


          pythongh-102690: Use Edge as fallback in webbrowser instead of IE (py…

ab8f1d8

…thon#102691)

Reviewers

zooba

zooba approved these changes

merwok

Awaiting requested review from merwok

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

3.12

only security fixes

OS-windows type-feature

A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

DBJim commented Mar 14, 2023 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedevere-bot commented Mar 14, 2023

Uh oh!

ghost commented Mar 14, 2023 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedevere-bot commented Mar 14, 2023

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

zooba left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

DBJim commented Mar 14, 2023 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

ghost commented Mar 14, 2023 •

edited by ghost

Loading

Uh oh!

There was an error while loading. Please reload this page.