GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix outdated note about 'int' rounding or truncating by mdickinson · Pull Request #102736 · python/cpython

Conversation

@mdickinson

@mdickinson mdickinson commented Mar 15, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This PR fixes an out-of-date note attached to int conversions in stdtypes.rst.

The "may round or truncate as in C" language dates from almost 30 years ago, when conversion from a Python float to a Python int involved at C level a (long) cast applied to a C double value. Prior to standard C, presumably the precise behaviour of that cast couldn't be relied upon. But since C89 standardised this behaviour and we can reasonably rely on all current C compilers adhering to that or later standards, the note is out of date. (Moreover, the current code for converting a Python 3 int to a C double is very different.)

Related discuss.python.org thread: https://discuss.python.org/t/built-in-types-int-round-or-truncate-please-elaborate/24840

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

m-aciek reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@mdickinson
Fix outdated note about 'int' rounding or truncating
56b47c0
@mdickinson mdickinson added skip issue skip news needs backport to 3.10 needs backport to 3.11 only security fixes labels Mar 15, 2023
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting core review labels Mar 15, 2023
furkanonder
furkanonder approved these changes Mar 16, 2023
View reviewed changes
@terryjreedy

terryjreedy commented Mar 16, 2023

Copy link
Copy Markdown
Member

Mark, tests are complete, so this is ready to merge and backport.

mdickinson reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mdickinson
mdickinson merged commit 405739f into python:main Mar 16, 2023
@miss-islington

miss-islington commented Mar 16, 2023

Copy link
Copy Markdown
Contributor

Thanks @mdickinson for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the awaiting core review label Mar 16, 2023
@bedevere-bot

bedevere-bot commented Mar 16, 2023

Copy link
Copy Markdown

GH-102766 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Mar 16, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 16, 2023
@mdickinson @miss-islington
Fix outdated note about 'int' rounding or truncating (pythonGH-102736)
6836408
(cherry picked from commit 405739f)

Co-authored-by: Mark Dickinson <[email protected]>
@bedevere-bot

bedevere-bot commented Mar 16, 2023

Copy link
Copy Markdown

GH-102767 is a backport of this pull request to the 3.10 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Mar 16, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 16, 2023
@mdickinson @miss-islington
Fix outdated note about 'int' rounding or truncating (pythonGH-102736)
dd08b6c
(cherry picked from commit 405739f)

Co-authored-by: Mark Dickinson <[email protected]>
@mdickinson
mdickinson deleted the fix-outdated-round-or-truncate-language branch March 16, 2023 20:35
mdickinson added a commit that referenced this pull request Mar 16, 2023
@miss-islington @mdickinson
[3.11] Fix outdated note about 'int' rounding or truncating (GH-102736)…
df399a3
… (#102766)

Fix outdated note about 'int' rounding or truncating (GH-102736)
(cherry picked from commit 405739f)

Co-authored-by: Mark Dickinson <[email protected]>
mdickinson added a commit that referenced this pull request Mar 16, 2023
@miss-islington @mdickinson
[3.10] Fix outdated note about 'int' rounding or truncating (GH-102736)…
99b38be
… (#102767)

Fix outdated note about 'int' rounding or truncating (GH-102736)
(cherry picked from commit 405739f)

Co-authored-by: Mark Dickinson <[email protected]>
carljm added a commit to carljm/cpython that referenced this pull request Mar 17, 2023
@carljm
Merge branch 'main' into inlinecomp2
1a8f4a0
* main: (34 commits)
  pythongh-102701: Fix overflow in dictobject.c (pythonGH-102750)
  pythonGH-78530: add support for generators in `asyncio.wait` (python#102761)
  Increase stack reserve size for Windows debug builds to avoid test crashes (pythonGH-102764)
  pythongh-102755: Add PyErr_DisplayException(exc) (python#102756)
  Fix outdated note about 'int' rounding or truncating (python#102736)
  pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (python#102760)
  pythongh-99726: Improves correctness of stat results for Windows, and uses faster API when available (pythonGH-102149)
  pythongh-102192: remove redundant exception fields from ssl module socket (python#102466)
  pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (python#102743)
  pythongh-102737: Un-ignore ceval.c in the CI globals check (pythongh-102745)
  pythonGH-102748: remove legacy support for generator based coroutines from `asyncio.iscoroutine` (python#102749)
  pythongh-102721: Improve coverage of `_collections_abc._CallableGenericAlias` (python#102722)
  pythonGH-102653: Make recipe docstring show the correct distribution (python#102742)
  Add comments to `{typing,_collections_abc}._type_repr` about each other (python#102752)
  pythongh-102594: PyErr_SetObject adds note to exception raised on normalization error (python#102675)
  pythongh-94440: Fix issue of ProcessPoolExecutor shutdown hanging (python#94468)
  pythonGH-100112:  avoid using iterable coroutines in asyncio internally (python#100128)
  pythongh-102690: Use Edge as fallback in webbrowser instead of IE (python#102691)
  pythongh-102660: Fix Refleaks in import.c (python#102744)
  pythongh-102738: remove from cases generator the code related to register instructions (python#102739)
  ...
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this pull request Mar 27, 2023
@mdickinson @Fidget-Spinner
Fix outdated note about 'int' rounding or truncating (python#102736)
2c96fc0
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@mdickinson @warsaw
Fix outdated note about 'int' rounding or truncating (python#102736)
eeb34e5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@furkanonder furkanonder furkanonder approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@mdickinson @terryjreedy @miss-islington @bedevere-bot @furkanonder
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.