GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-103596: [Enum] do not shadow mixed-in methods/attributes by ethanfurman · Pull Request #103600 · python/cpython

Conversation

@ethanfurman

@ethanfurman ethanfurman commented Apr 17, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

For example:

class Book(StrEnum):
    title = auto()
    author = auto()
    desc = auto()

Book.author.desc is Book.desc

but

Book.author.title() == 'Author'

Using upper-case member names avoids any possible confusion.

  • Issue: [Enum] attributes of mixed-in classes can be shadowed by other members #103596

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
samypr100 reacted with rocket emoji
All reactions
  • 🚀 1 reaction
@ethanfurman
do not shadow mixed-in methods/attributes
b1b5392 
For example:

    class Book(StrEnum):
        title = auto()
        author = auto()
        desc = auto()

    Book.author.desc is Book.desc

but

    Book.author.title() == 'Author'

Using upper-case member names means this isn't an issue in practice.
@ethanfurman ethanfurman added type-bug An unexpected behavior, bug, or error type-feature A feature request or enhancement stdlib Standard Library Python modules in the Lib/ directory 3.12 only security fixes labels Apr 17, 2023
@ethanfurman ethanfurman self-assigned this Apr 17, 2023
@bedevere-bot bedevere-bot mentioned this pull request Apr 17, 2023
[Enum] attributes of mixed-in classes can be shadowed by other members #103596
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Apr 17, 2023
@ethanfurman

ethanfurman commented Apr 17, 2023

Copy link
Copy Markdown
Member Author

Note that performance is only impacted when there is a name clash between member and existing attribute/method.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
samypr100
samypr100 reviewed Apr 18, 2023
View reviewed changes
Comment thread Doc/howto/enum.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ethanfurman @samypr100
fix typo
0d06493 
Co-authored-by: samypr100 <[email protected]>
@ethanfurman
ethanfurman merged commit 700ec65 into python:main Apr 18, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Apr 18, 2023
@ethanfurman
ethanfurman deleted the enum-no_shadow branch April 18, 2023 23:19
@samypr100 samypr100 mentioned this pull request Apr 19, 2023
Python 3.11 StrEnum error when member is named "title" python/mypy#14494
Closed
carljm added a commit to carljm/cpython that referenced this pull request Apr 20, 2023
@carljm
Merge branch 'main' into superopt
5c0a21c 
* main: (24 commits)
  pythongh-98040: Move the Single-Phase Init Tests Out of test_imp (pythongh-102561)
  pythongh-83861: Fix datetime.astimezone() method (pythonGH-101545)
  pythongh-102856: Clean some of the PEP 701 tokenizer implementation (python#103634)
  pythongh-102856: Skip test_mismatched_parens in WASI builds (python#103633)
  pythongh-102856: Initial implementation of PEP 701 (python#102855)
  pythongh-103583: Add ref. dependency between multibytecodec modules (python#103589)
  pythongh-83004: Harden msvcrt further (python#103420)
  pythonGH-88342: clarify that `asyncio.as_completed` accepts generators yielding tasks (python#103626)
  pythongh-102778: IDLE - make sys.last_exc available in Shell after traceback (python#103314)
  pythongh-103582: Remove last references to `argparse.REMAINDER` from docs (python#103586)
  pythongh-103583: Always pass multibyte codec structs as const (python#103588)
  pythongh-103617: Fix compiler warning in _iomodule.c (python#103618)
  pythongh-103596: [Enum] do not shadow mixed-in methods/attributes (pythonGH-103600)
  pythonGH-100530: Change the error message for non-class class patterns (pythonGH-103576)
  pythongh-95299: Remove lingering setuptools reference in installer scripts (pythonGH-103613)
  [Doc] Fix a typo in optparse.rst (python#103504)
  pythongh-101100: Fix broken reference `__format__` in `string.rst` (python#103531)
  pythongh-95299: Stop installing setuptools as a part of ensurepip and venv (python#101039)
  pythonGH-103484: Docs: add linkcheck allowed redirects entries for most cases (python#103569)
  pythongh-67230: update whatsnew note for csv changes (python#103598)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@samypr100 samypr100 samypr100 left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@ethanfurman ethanfurman

Labels

3.12 only security fixes stdlib Standard Library Python modules in the Lib/ directory type-bug An unexpected behavior, bug, or error type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ethanfurman @samypr100 @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.