GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add tests for empty ranges equality by Eclips4 · Pull Request #103751 · python/cpython

Conversation

@Eclips4

@Eclips4 Eclips4 commented Apr 24, 2023

Copy link
Copy Markdown
Member

As documentation says, empty ranges are equals.
Therefore, I decided to write a few tests for it

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Eclips4
Add tests for empty ranges equality
b91788d
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Apr 24, 2023
@arhadthedev arhadthedev added skip issue skip news labels Apr 24, 2023
@arhadthedev

arhadthedev commented Apr 24, 2023

Copy link
Copy Markdown
Member

For context, this PR is inspired by gh-103750.
Eclips4 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@terryjreedy terryjreedy added the needs backport to 3.11 only security fixes label Apr 24, 2023
@terryjreedy
terryjreedy merged commit dca27a6 into python:main Apr 24, 2023
@bedevere-bot bedevere-bot removed the awaiting review label Apr 24, 2023
@miss-islington

miss-islington commented Apr 24, 2023

Copy link
Copy Markdown
Contributor

Thanks @Eclips4 for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Apr 24, 2023

Copy link
Copy Markdown

GH-103760 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Apr 24, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 24, 2023
@Eclips4 @miss-islington
Add tests for empty range equality (pythonGH-103751)
8fa2f09 
(cherry picked from commit dca27a6)

Co-authored-by: Kirill <[email protected]>
terryjreedy pushed a commit that referenced this pull request Apr 24, 2023
@miss-islington @Eclips4
[3.11] Add tests for empty range equality (GH-103751) (#103760)
25406e5 
(cherry picked from commit dca27a6)

Co-authored-by: Kirill <[email protected]>
@pochmann

pochmann commented Apr 24, 2023

Copy link
Copy Markdown
Contributor

This looks redundant. Didn't that test function already test equality and hash equality of several empty ranges? Even inequality? I see three empty ranges among the test ranges defined at the top, and all pairs of them get tested:

https://github.com/Eclips4/cpython/blob/b91788d368e8441dfab3a84e1b5acfc03b743c23/Lib/test/test_range.py#L639-L660

If you want to test your particular two ranges, maybe instead just add them to all those test ranges?
Eclips4 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
terryjreedy added a commit to terryjreedy/cpython that referenced this pull request Apr 24, 2023
@terryjreedy
Revert "Add tests for empty range equality (python#103751)"
12fb140 
This reverts commit dca27a6.
Added tests are redundant with existing tests.
@terryjreedy

terryjreedy commented Apr 24, 2023

Copy link
Copy Markdown
Member

After looking harder this time, I agree. Revert in #103770.
Eclips4 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
terryjreedy added a commit that referenced this pull request Apr 24, 2023
@terryjreedy
Revert "Add tests for empty range equality (#103751)" (#103770)
ab25c7e 
This reverts commit dca27a6.
Added tests are redundant with existing tests.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 24, 2023
@terryjreedy @miss-islington
Revert "Add tests for empty range equality (pythonGH-103751)" (python…
43b0565 
…GH-103770)

This reverts commit dca27a6.
Added tests are redundant with existing tests.
(cherry picked from commit ab25c7e)

Co-authored-by: Terry Jan Reedy <[email protected]>
terryjreedy added a commit that referenced this pull request Apr 24, 2023
@miss-islington @terryjreedy
[3.11] Revert "Add tests for empty range equality (GH-103751)" (GH-10…
a8489f7 
…3770) (#103781)

Revert "Add tests for empty range equality (GH-103751)" (GH-103770)

This reverts commit dca27a6.
Added tests are redundant with existing tests.
(cherry picked from commit ab25c7e)

Co-authored-by: Terry Jan Reedy <[email protected]>
carljm added a commit to carljm/cpython that referenced this pull request Apr 24, 2023
@carljm
Merge branch 'main' into superopt
19b8025 
* main: (53 commits)
  pythongh-102498 Clean up unused variables and imports in the email module  (python#102482)
  pythongh-99184: Bypass instance attribute access in `repr` of `weakref.ref` (python#99244)
  pythongh-99032: datetime docs: Encoding is no longer relevant (python#93365)
  pythongh-94300: Update datetime.strptime documentation (python#95318)
  pythongh-103776: Remove explicit uses of $(SHELL) from Makefile (pythonGH-103778)
  pythongh-87092: fix a few cases of incorrect error handling in compiler (python#103456)
  pythonGH-103727: Avoid advancing tokenizer too far in f-string mode (pythonGH-103775)
  Revert "Add tests for empty range equality (python#103751)" (python#103770)
  pythongh-94518: Port 23-argument `_posixsubprocess.fork_exec` to Argument Clinic (python#94519)
  pythonGH-65022: Fix description of copyreg.pickle function (python#102656)
  pythongh-103323: Get the "Current" Thread State from a Thread-Local Variable (pythongh-103324)
  pythongh-91687: modernize dataclass example typing (python#103773)
  pythongh-103746: Test `types.UnionType` and `Literal` types together (python#103747)
  pythongh-103765: Fix 'Warning: py:class reference target not found: ModuleSpec' (pythonGH-103769)
  pythongh-87452: Improve the Popen.returncode docs
  Removed unnecessary escaping of asterisks (python#103714)
  pythonGH-102973: Slim down Fedora packages in the dev container (python#103283)
  pythongh-103091: Add PyUnstable_Type_AssignVersionTag (python#103095)
  Add tests for empty range equality (python#103751)
  pythongh-103712: Increase the length of the type name in AttributeError messages (python#103713)
  ...
carljm added a commit to carljm/cpython that referenced this pull request Apr 24, 2023
@carljm
Merge branch 'superopt' into superopt_spec
1972ca4 
* superopt: (82 commits)
  pythongh-101517: fix line number propagation in code generated for except* (python#103550)
  pythongh-103780: Use patch instead of mock in asyncio unix events test (python#103782)
  pythongh-102498 Clean up unused variables and imports in the email module  (python#102482)
  pythongh-99184: Bypass instance attribute access in `repr` of `weakref.ref` (python#99244)
  pythongh-99032: datetime docs: Encoding is no longer relevant (python#93365)
  pythongh-94300: Update datetime.strptime documentation (python#95318)
  pythongh-103776: Remove explicit uses of $(SHELL) from Makefile (pythonGH-103778)
  pythongh-87092: fix a few cases of incorrect error handling in compiler (python#103456)
  pythonGH-103727: Avoid advancing tokenizer too far in f-string mode (pythonGH-103775)
  Revert "Add tests for empty range equality (python#103751)" (python#103770)
  pythongh-94518: Port 23-argument `_posixsubprocess.fork_exec` to Argument Clinic (python#94519)
  pythonGH-65022: Fix description of copyreg.pickle function (python#102656)
  pythongh-103323: Get the "Current" Thread State from a Thread-Local Variable (pythongh-103324)
  pythongh-91687: modernize dataclass example typing (python#103773)
  pythongh-103746: Test `types.UnionType` and `Literal` types together (python#103747)
  pythongh-103765: Fix 'Warning: py:class reference target not found: ModuleSpec' (pythonGH-103769)
  pythongh-87452: Improve the Popen.returncode docs
  Removed unnecessary escaping of asterisks (python#103714)
  pythonGH-102973: Slim down Fedora packages in the dev container (python#103283)
  pythongh-103091: Add PyUnstable_Type_AssignVersionTag (python#103095)
  ...
@Eclips4

Eclips4 commented Apr 25, 2023

Copy link
Copy Markdown
Member Author

Yeah, I missed these tests above
Thanks @pochmann for the catch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Eclips4
Eclips4 deleted the empty_ranges branch April 25, 2023 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@Eclips4 @arhadthedev @miss-islington @bedevere-bot @pochmann @terryjreedy
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.